diff --git a/dmp-frontend/src/app/app-routing.module.ts b/dmp-frontend/src/app/app-routing.module.ts index c4e80203e..698390eec 100644 --- a/dmp-frontend/src/app/app-routing.module.ts +++ b/dmp-frontend/src/app/app-routing.module.ts @@ -14,6 +14,8 @@ import { ProjectListingComponent } from './projects/project-listing.component'; import { DataManagementPlanListingComponent } from './dmps/dmp-listing.component'; import { ProjectEditorComponent } from './projects/editor/project-editor.component'; import { DataManagementPlanEditorComponent } from './dmps/editor/dmp-editor.component'; +import { DatasetEditorComponent } from './datasets_new/editor/dataset-editor.component'; +import { DatasetListingComponent } from './datasets_new/dataset-listing.component'; const appRoutes: Routes = [ @@ -26,6 +28,9 @@ const appRoutes: Routes = [ { path: 'dmps', component: DataManagementPlanListingComponent, canActivate: [AuthGuard]}, { path: 'dmp/:id', component: DataManagementPlanEditorComponent, canActivate: [AuthGuard]}, { path: 'dmps/new', component: DataManagementPlanEditorComponent, canActivate: [AuthGuard]}, + { path: 'datasets', component: DatasetListingComponent, canActivate: [AuthGuard]}, + { path: 'dataset/:id', component: DatasetEditorComponent, canActivate: [AuthGuard]}, + { path: 'datasets/new', component: DatasetEditorComponent, canActivate: [AuthGuard]}, { path: 'login', component: MainSignInComponent}, { path: "unauthorized", loadChildren: './unauthorized/unauthorized.module#UnauthorizedModule' }, { path: 'welcome', component: HomepageComponent, canActivate: [AuthGuard]}, diff --git a/dmp-frontend/src/app/app.module.ts b/dmp-frontend/src/app/app.module.ts index 50d6f6571..6018c1f02 100644 --- a/dmp-frontend/src/app/app.module.ts +++ b/dmp-frontend/src/app/app.module.ts @@ -111,6 +111,7 @@ import { ProjectEditorComponent } from './projects/editor/project-editor.compone import { DataManagementPlanEditorComponent } from './dmps/editor/dmp-editor.component'; import { FigurecardComponent } from './shared/components/figurecard/figurecard.component'; +import { DatasetEditorComponent } from './datasets_new/editor/dataset-editor.component'; @@ -152,7 +153,8 @@ import { FigurecardComponent } from './shared/components/figurecard/figurecard.c BreadcrumbComponent, DmpDetailedComponent, ProjectDetailedComponent, ProjectEditorComponent, DataManagementPlanEditorComponent, - FigurecardComponent + FigurecardComponent, + DatasetEditorComponent ], imports: [ BrowserModule, diff --git a/dmp-frontend/src/app/datasets_new/dataset-listing.component.html b/dmp-frontend/src/app/datasets_new/dataset-listing.component.html index 495384bed..6490e3ec5 100644 --- a/dmp-frontend/src/app/datasets_new/dataset-listing.component.html +++ b/dmp-frontend/src/app/datasets_new/dataset-listing.component.html @@ -28,7 +28,8 @@ {{'DATASET-LISTING.COLUMNS.STATUS' | translate}} - {{row.status}} + {{row.status}} + @@ -53,13 +54,11 @@ - + - + \ No newline at end of file diff --git a/dmp-frontend/src/app/datasets_new/dataset-listing.component.ts b/dmp-frontend/src/app/datasets_new/dataset-listing.component.ts index c4e41dc1c..cb61b321a 100644 --- a/dmp-frontend/src/app/datasets_new/dataset-listing.component.ts +++ b/dmp-frontend/src/app/datasets_new/dataset-listing.component.ts @@ -20,7 +20,7 @@ import { DatasetListingModel } from "../models/datasets/DatasetListingModel"; styleUrls: ['./dataset-listing.component.css'], providers: [DatasetService] }) -export class DatasetListingComponent implements OnInit, AfterViewInit { +export class DatasetListingComponent implements OnInit { @ViewChild(MatPaginator) _paginator: MatPaginator; @ViewChild(MatSort) sort: MatSort; @@ -29,6 +29,11 @@ export class DatasetListingComponent implements OnInit, AfterViewInit { dataSource: DatasetDataSource | null; displayedColumns: String[] = ['label', 'reference', 'uri', 'status', 'description', 'created', 'actions']; + statuses = [ + {value: '0', viewValue: 'Active'}, + {value: '1', viewValue: 'Inactive'} + ]; + constructor( private datasetService: DatasetService, private router: Router, @@ -39,14 +44,9 @@ export class DatasetListingComponent implements OnInit, AfterViewInit { } ngOnInit() { - - } - - ngAfterViewInit() { - setTimeout(() => { - this.criteria.setRefreshCallback(() => this.refresh()); - this.criteria.setCriteria(this.getDefaultCriteria()); - }); + this.criteria.setCriteria(this.getDefaultCriteria()); + this.refresh(); + this.criteria.setRefreshCallback(() => this.refresh()); } refresh() { @@ -54,7 +54,7 @@ export class DatasetListingComponent implements OnInit, AfterViewInit { } rowClick(rowId: String) { - this.router.navigate(['/project/' + rowId]); + this.router.navigate(['/dataset/' + rowId]); } getDefaultCriteria(): DatasetCriteria { @@ -112,7 +112,7 @@ export class DatasetDataSource extends DataSource { setTimeout(() => { this.isLoadingResults = false; }); - return result.payload; + return result; }) .map(result => { if (!result) { return []; } diff --git a/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.html b/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.html index 177130ba3..5cdfd4d13 100644 --- a/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.html +++ b/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.html @@ -1,28 +1,28 @@
- {{'DMP-EDITOR.TITLE.NEW' | translate}} - {{'DMP-EDITOR.TITLE.EDIT' | translate}} {{project.label}} + {{'DATASET-EDITOR.TITLE.NEW' | translate}} + {{'DATASET-EDITOR.TITLE.EDIT' | translate}} {{dataset.label}} - + {{baseErrorModel.label}} {{'GENERAL.VALIDATION.REQUIRED' | translate}} - + - {{errorModel.description}} {{'GENERAL.VALIDATION.REQUIRED' | translate}} - +
{{chip.name.substring(0, 1).toUpperCase()}}
{{chip.name}} @@ -70,8 +70,8 @@
- +
{{chip.name.substring(0, 1).toUpperCase()}}
{{chip.name}} @@ -84,6 +84,20 @@
+ + +
{{chip.name.substring(0, 1).toUpperCase()}}
+ {{chip.name}} +
+ +
+ {{option.name}} +
+
+ +
+
diff --git a/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.ts b/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.ts index c4b90e9d8..e7101a5b8 100644 --- a/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.ts +++ b/dmp-frontend/src/app/datasets_new/editor/dataset-editor.component.ts @@ -19,14 +19,14 @@ import { ExternalSourcesItemModel } from "../../models/external-sources/External @Component({ selector: 'app-dataset-editor-component', templateUrl: 'dataset-editor.component.html', - styleUrls: ['./dataset-editor.component.scss'], + styleUrls: ['./dataset-editor.component.css'], providers: [DatasetService, ExternalSourcesService], encapsulation: ViewEncapsulation.None }) export class DatasetEditorComponent implements AfterViewInit { isNew = true; - dataManagementPlan: DatasetModel; + dataset: DatasetModel; formGroup: FormGroup = null; filteringOrganisationsAsync: boolean = false; @@ -53,13 +53,13 @@ export class DatasetEditorComponent implements AfterViewInit { this.isNew = false; this.datasetService.getSingle(itemId).map(data => data as DatasetModel) .subscribe(data => { - this.dataManagementPlan = new JsonSerializer().fromJSONObject(data, DatasetModel); - this.formGroup = this.dataManagementPlan.buildForm(); + this.dataset = new JsonSerializer().fromJSONObject(data, DatasetModel); + this.formGroup = this.dataset.buildForm(); }); } else { - this.dataManagementPlan = new DatasetModel(); + this.dataset = new DatasetModel(); setTimeout(() => { - this.formGroup = this.dataManagementPlan.buildForm(); + this.formGroup = this.dataset.buildForm(); }); } }); @@ -88,7 +88,7 @@ export class DatasetEditorComponent implements AfterViewInit { duration: 3000, extraClasses: ['snackbar-success'] }) - this.router.navigate(['/dataManagementPlans']); + this.router.navigate(['/datasets']); } onCallbackError(error: any) { @@ -98,12 +98,12 @@ export class DatasetEditorComponent implements AfterViewInit { public setErrorModel(errorModel: BaseErrorModel) { Object.keys(errorModel).forEach(item => { - (this.dataManagementPlan.errorModel)[item] = (errorModel)[item]; + (this.dataset.errorModel)[item] = (errorModel)[item]; }) } public cancel(): void { - this.router.navigate(['/dataManagementPlans']); + this.router.navigate(['/datasets']); } filterOrganisations(value: string): void { diff --git a/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteria.ts b/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteria.ts index 0e219a6c7..d5a1ef522 100644 --- a/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteria.ts +++ b/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteria.ts @@ -1,6 +1,5 @@ import { BaseCriteria } from "../BaseCriteria"; export class DatasetCriteria extends BaseCriteria { - public Name: String; - public Status: Number; + public status: Number; } diff --git a/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteriaErrorModel.ts b/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteriaErrorModel.ts index bfd401872..4c8c081a5 100644 --- a/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteriaErrorModel.ts +++ b/dmp-frontend/src/app/models/criteria/dataset/DatasetCriteriaErrorModel.ts @@ -1,6 +1,5 @@ import { BaseCriteriaErrorModel } from "../BaseCriteriaErrorModel"; export class DatasetCriteriaErrorModel extends BaseCriteriaErrorModel{ - public Name: String; - public Status: Number; + public status: Number; } diff --git a/dmp-frontend/src/app/services/dataset/dataset.service.ts b/dmp-frontend/src/app/services/dataset/dataset.service.ts index 808563f43..2f482292b 100644 --- a/dmp-frontend/src/app/services/dataset/dataset.service.ts +++ b/dmp-frontend/src/app/services/dataset/dataset.service.ts @@ -30,7 +30,7 @@ export class DatasetService { } getSingle(id: string): Observable { - return this.http.get(this.actionUrl + id, { headers: this.headers }); + return this.http.get(this.actionUrl +'getSingle/' + id, { headers: this.headers }); } createDataset(datasetModel: DatasetModel): Observable { diff --git a/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.html b/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.html index ed16bc2af..ba29fd80e 100644 --- a/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.html +++ b/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.html @@ -17,16 +17,20 @@
-->
- - {{baseErrorModel['Criteria.Name']}} + {{baseErrorModel['Criteria.like']}}
- - {{baseErrorModel['Criteria.Status']}} + + + {{status.viewValue}} + + + {{baseErrorModel['Criteria.status']}}
diff --git a/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.ts b/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.ts index 3461dbd30..04bbcfe40 100644 --- a/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.ts +++ b/dmp-frontend/src/app/shared/components/criteria/datasets/datasets-criteria.component.ts @@ -21,6 +21,11 @@ export class DatasetCriteriaComponent extends BaseCriteriaComponent implements O // public formStatus: ProjectStatus; public criteria: DatasetCriteria= new DatasetCriteria(); + statuses = [ + {value: '0', viewValue: 'Active'}, + {value: '1', viewValue: 'Inactive'} + ]; + constructor( public language: TranslateService, public formBuilder: FormBuilder diff --git a/dmp-frontend/src/assets/lang/en.json b/dmp-frontend/src/assets/lang/en.json index 2876089f3..ff00c2670 100644 --- a/dmp-frontend/src/assets/lang/en.json +++ b/dmp-frontend/src/assets/lang/en.json @@ -93,5 +93,25 @@ "PERIOD-TO": "End", "STATUS": "Status" } + }, + "DATASET-EDITOR": { + "TITLE": { + "NEW": "New Data Management Plan", + "EDIT": "Edit" + }, + "FIELDS": { + "NAME": "Name", + "DESCRIPTION": "Description", + "PROFILE": "Profile", + "URI": "Uri", + "DATAREPOSITORIES": "Data Repositories", + "REGISTRIES": "Registries", + "SERVICES": "Services" + }, + "ACTIONS": { + "SAVE": "Save", + "CANCEL": "Cancel", + "DELETE": "Delete" + } } } \ No newline at end of file