From b0cd53d74b03d67637365f58e202001d72f51cbb Mon Sep 17 00:00:00 2001 From: Sofia Papacharalampous Date: Fri, 22 Mar 2024 11:04:11 +0200 Subject: [PATCH 1/5] styling changes *dmp-user fields and semantics --- .../multiple-auto-complete.component.scss | 16 +--------------- .../dmp-user-field/dmp-user-field.component.html | 14 +++++++------- .../dmp-user-field/dmp-user-field.component.scss | 13 ------------- 3 files changed, 8 insertions(+), 35 deletions(-) diff --git a/dmp-frontend/src/app/library/auto-complete/multiple/multiple-auto-complete.component.scss b/dmp-frontend/src/app/library/auto-complete/multiple/multiple-auto-complete.component.scss index 633e9467d..0c67f1f8c 100644 --- a/dmp-frontend/src/app/library/auto-complete/multiple/multiple-auto-complete.component.scss +++ b/dmp-frontend/src/app/library/auto-complete/multiple/multiple-auto-complete.component.scss @@ -28,8 +28,7 @@ // text-overflow: ellipsis; // white-space: nowrap; // overflow: hidden; - // white-space: normal; - white-space: nowrap; + white-space: normal; word-break: break-word; } @@ -129,16 +128,3 @@ color: transparent; } } - -:host ::ng-deep .mdc-evolution-chip-set__chips { - max-width: 100%; - text-overflow: ellipsis; - flex-flow: nowrap; - overflow-x: scroll; -} - -:host ::ng-deep .mat-mdc-standard-chip .mdc-evolution-chip__cell--primary, -:host ::ng-deep .mat-mdc-standard-chip .mdc-evolution-chip__action--primary, -:host ::ng-deep .mat-mdc-standard-chip .mat-mdc-chip-action-label { - overflow: hidden; -} diff --git a/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.html b/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.html index aa648dd24..1b86486fd 100644 --- a/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.html +++ b/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.html @@ -30,18 +30,18 @@ -
+
{{userIndex + 1}} drag_indicator
-
+
{{enumUtils.toDmpUserTypeString(userType)}}
-
+
{{'DMP-EDITOR.FIELDS1.USER' | translate}}* @@ -49,7 +49,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-EDITOR.FIELDS1.EMAIL' | translate}}* @@ -57,7 +57,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-EDITOR.FIELDS1.USER-ROLE' | translate}} @@ -67,7 +67,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-EDITOR.FIELDS1.SECTION' | translate}} @@ -79,7 +79,7 @@ {{'GENERAL.VALIDATION.REQUIRED' |translate}}
-
+
diff --git a/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.scss b/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.scss index a4808a077..a47f72664 100644 --- a/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.scss +++ b/dmp-frontend/src/app/ui/dmp/dmp-user-field/dmp-user-field.component.scss @@ -13,16 +13,3 @@ cursor: auto; color: rgba(0, 0, 0, 0.38);; } - - -@media (max-width:1600px) { - - .user-fields { - flex-direction: column; - } - - .user-field { - align-self: flex-start; - width: 100%; - } -} \ No newline at end of file From ffb5d5ee7e3209847e99549298bb9df65aaee348 Mon Sep 17 00:00:00 2001 From: amentis Date: Fri, 22 Mar 2024 11:45:31 +0200 Subject: [PATCH 2/5] fix lock bug --- .../editor/dmp-blueprint-editor.component.html | 2 +- .../editor/description-editor.component.html | 12 ++++++------ dmp-frontend/src/common/base/base-editor.ts | 6 ++---- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html index 90bd7d6f8..a6524cf93 100644 --- a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html +++ b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html @@ -15,7 +15,7 @@
- diff --git a/dmp-frontend/src/app/ui/description/editor/description-editor.component.html b/dmp-frontend/src/app/ui/description/editor/description-editor.component.html index 6f721cb22..702dbe110 100644 --- a/dmp-frontend/src/app/ui/description/editor/description-editor.component.html +++ b/dmp-frontend/src/app/ui/description/editor/description-editor.component.html @@ -47,7 +47,7 @@
- +
- - - - + + +
@@ -116,7 +116,7 @@
{{'DESCRIPTION-EDITOR.TOC.NEXT' | translate}}
chevron_right
-
diff --git a/dmp-frontend/src/common/base/base-editor.ts b/dmp-frontend/src/common/base/base-editor.ts index af4b6d933..60ea6f7be 100644 --- a/dmp-frontend/src/common/base/base-editor.ts +++ b/dmp-frontend/src/common/base/base-editor.ts @@ -186,14 +186,12 @@ export abstract class BaseEditor { - this.isLocked = true; + this.isLockedByUser = true; interval(this.configurationService.lockInterval).pipe(takeUntil(this._destroyed)).subscribe(() => this.touchLock(itemId)); }); } @@ -211,6 +209,6 @@ export abstract class BaseEditor Date: Fri, 22 Mar 2024 11:48:54 +0200 Subject: [PATCH 3/5] styling changes *dmp-description --- .../dmp-blueprint-editor.component.html | 147 +++++++++++------- .../dmp-blueprint-editor.component.scss | 24 +-- 2 files changed, 90 insertions(+), 81 deletions(-) diff --git a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html index 90bd7d6f8..0b890f004 100644 --- a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html +++ b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html @@ -92,7 +92,7 @@
-
+
@@ -106,14 +106,14 @@
-
+
{{fieldIndex + 1}} drag_indicator
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.CATEGORY' | translate}} @@ -123,7 +123,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.SYSTEM-FIELD-TYPE' | translate}} @@ -133,7 +133,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.DATA-TYPE' | translate}} @@ -145,7 +145,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.REFERENCE-TYPE' | translate}} @@ -153,7 +153,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.FIELD-LABEL' | translate}} @@ -161,7 +161,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.FIELD-PLACEHOLDER' | translate}} @@ -169,7 +169,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.FIELD-DESCRIPTION' | translate}} @@ -177,7 +177,7 @@ {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.SEMANTICS' | translate}} @@ -188,14 +188,14 @@
-
+
{{'DMP-BLUEPRINT-EDITOR.FIELDS.FIELD-REQUIRED' | translate}} {{field.get('required').getError('backendError').message}} {{'GENERAL.VALIDATION.REQUIRED' | translate}}
-
+
@@ -225,62 +225,93 @@
-
-
-
-
+
+
+
+ + +
+
+
+ {{descriptionTemplateIndex + 1}} + drag_indicator +
+
+ +
+
-
- - {{'DMP-BLUEPRINT-EDITOR.FIELDS.DESCRIPTION-TEMPLATE-LABEL' | translate}} - - {{descriptionTemplate.get('label').getError('backendError').message}} - {{'GENERAL.VALIDATION.REQUIRED' | translate}} - -
-
- - {{'DMP-BLUEPRINT-EDITOR.FIELDS.DESCRIPTION-TEMPLATE-MIN-MULTIPLICITY' | translate}} - - {{descriptionTemplate.get('minMultiplicity').getError('backendError').message}} - {{'GENERAL.VALIDATION.REQUIRED' | translate}} - -
-
- - {{'DMP-BLUEPRINT-EDITOR.FIELDS.DESCRIPTION-TEMPLATE-MAX-MULTIPLICITY' | translate}} - - {{descriptionTemplate.get('maxMultiplicity').getError('backendError').message}} - {{'GENERAL.VALIDATION.REQUIRED' | translate}} - -
-
- +
+ {{descriptionTemplateIndex + 1}} + drag_indicator +
+ +
+
+
+ + {{'DMP-BLUEPRINT-EDITOR.FIELDS.DESCRIPTION-TEMPLATE' | translate}} + + {{descriptionTemplate.get('descriptionTemplateGroupId').getError('backendError').message}} + {{'GENERAL.VALIDATION.REQUIRED' | translate}} + +
+
+ + {{'DMP-BLUEPRINT-EDITOR.FIELDS.DESCRIPTION-TEMPLATE-LABEL' | translate}} + + {{descriptionTemplate.get('label').getError('backendError').message}} + {{'GENERAL.VALIDATION.REQUIRED' | translate}} + +
+
+ + {{'DMP-BLUEPRINT-EDITOR.FIELDS.DESCRIPTION-TEMPLATE-MIN-MULTIPLICITY' | translate}} + + {{descriptionTemplate.get('minMultiplicity').getError('backendError').message}} + {{'GENERAL.VALIDATION.REQUIRED' | translate}} + +
+
+ + {{'DMP-BLUEPRINT-EDITOR.FIELDS.DESCRIPTION-TEMPLATE-MAX-MULTIPLICITY' | translate}} + + {{descriptionTemplate.get('maxMultiplicity').getError('backendError').message}} + {{'GENERAL.VALIDATION.REQUIRED' | translate}} + +
+
+
+
+
+ +
+
+
+ {{section.get('descriptionTemplates').getError('backendError').message}}
- {{section.get('descriptionTemplates').getError('backendError').message}}
-
- - {{'DMP-BLUEPRINT-EDITOR.FIELDS.PREFILLING-SOURCES' | translate}} - - {{section.get('prefillingSourcesIds').getError('backendError').message}} - +
+
+ + {{'DMP-BLUEPRINT-EDITOR.FIELDS.PREFILLING-SOURCES' | translate}} + + {{section.get('prefillingSourcesIds').getError('backendError').message}} + +
+ diff --git a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.scss b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.scss index c3fcf299d..ebd157447 100644 --- a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.scss +++ b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.scss @@ -135,12 +135,9 @@ } } +.description-fields-wrapper, .section-fields-wrapper { width: 100%; - margin-top: 1.0rem; - display: flex; - flex-wrap: wrap; // ?? - align-items: center; .section-options-vertical { display: none; @@ -159,27 +156,8 @@ } .section-options-vertical { - width: 100%; display: initial; } - - .section-field { - width: 100%; - max-width: initial; - } - } -} - -.description-fields-wrapper { - width: 100%; - margin-top: 1.0rem; - display: flex; - flex-wrap: wrap; // ?? - align-items: center; - - @media (max-width: 1470px) { - flex-direction: column; - align-items: flex-start; } } From aed0f9de8eb740bba04239d3f8c423e7fd96b921 Mon Sep 17 00:00:00 2001 From: Sofia Papacharalampous Date: Fri, 22 Mar 2024 12:04:43 +0200 Subject: [PATCH 4/5] fixed sortable field *dmp-blueprint-editor>description-template --- .../editor/dmp-blueprint-editor.component.html | 16 +++++----------- .../editor/dmp-blueprint-editor.component.ts | 13 +++++++++++++ 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html index 3c2de4991..f6715e40b 100644 --- a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html +++ b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.html @@ -227,18 +227,13 @@
-
+
-
- {{descriptionTemplateIndex + 1}} - drag_indicator + {{descriptionTemplateIndex + 1}} + drag_indicator
- {{descriptionTemplateIndex + 1}} - drag_indicator + {{descriptionTemplateIndex + 1}} + drag_indicator
@@ -322,7 +317,6 @@
-
diff --git a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.ts b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.ts index 6e50e95b8..d9ee7ef17 100644 --- a/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.ts +++ b/dmp-frontend/src/app/ui/admin/dmp-blueprint/editor/dmp-blueprint-editor.component.ts @@ -64,6 +64,7 @@ export class DmpBlueprintEditorComponent extends BaseEditor Date: Fri, 22 Mar 2024 13:06:10 +0200 Subject: [PATCH 5/5] small ui fixes --- .../field-set-title/field-set-title.component.html | 4 ++-- .../form-field-set/form-field-set.component.html | 6 +++--- .../overview/description-overview.component.html | 2 +- .../dmp-editor-blueprint/dmp-editor.component.html | 2 +- dmp-frontend/src/assets/i18n/en.json | 12 +++++++++--- 5 files changed, 16 insertions(+), 10 deletions(-) diff --git a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/field-set-title/field-set-title.component.html b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/field-set-title/field-set-title.component.html index bd01cfe40..912cd2d99 100644 --- a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/field-set-title/field-set-title.component.html +++ b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/field-set-title/field-set-title.component.html @@ -13,12 +13,12 @@
- {{'DATASET-EDITOR.QUESTION.EXTENDED-DESCRIPTION.VIEW-MORE' | translate}} + {{'DESCRIPTION-EDITOR.ACTIONS.VIEW-MORE' | translate}}
- {{'DATASET-EDITOR.QUESTION.EXTENDED-DESCRIPTION.VIEW-LESS' | translate}} + {{'DESCRIPTION-EDITOR.ACTIONS.VIEW-LESS' | translate}}
\ No newline at end of file diff --git a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/form-field-set.component.html b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/form-field-set.component.html index a81d198b5..e8f96ed06 100644 --- a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/form-field-set.component.html +++ b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field-set/form-field-set.component.html @@ -37,7 +37,7 @@ add_circle {{fieldSet.multiplicity.placeholder}} - {{('DATASET-PROFILE-EDITOR.STEPS.FORM.COMPOSITE-FIELD.FIELDS.MULTIPLICITY-ADD-ONE-FIELD' + (fieldSet.multiplicity.tableView?'-TABLEVIEW':'')) | translate}} + {{('DESCRIPTION-EDITOR.ACTIONS.MULTIPLICITY-ADD-ONE-FIELD' + (fieldSet.multiplicity.tableView?'-TABLEVIEW':'')) | translate}}
@@ -65,7 +65,7 @@ add_circle {{fieldSet.multiplicity.placeholder}} - {{('DATASET-PROFILE-EDITOR.STEPS.FORM.COMPOSITE-FIELD.FIELDS.MULTIPLICITY-ADD-ONE-FIELD' + (fieldSet.multiplicity.tableView?'-TABLEVIEW':'')) | translate}} + {{('DESCRIPTION-EDITOR.ACTIONS.MULTIPLICITY-ADD-ONE-FIELD' + (fieldSet.multiplicity.tableView?'-TABLEVIEW':'')) | translate}} @@ -75,6 +75,6 @@
- +
\ No newline at end of file diff --git a/dmp-frontend/src/app/ui/description/overview/description-overview.component.html b/dmp-frontend/src/app/ui/description/overview/description-overview.component.html index 7be667a40..a0cd183bc 100644 --- a/dmp-frontend/src/app/ui/description/overview/description-overview.component.html +++ b/dmp-frontend/src/app/ui/description/overview/description-overview.component.html @@ -12,7 +12,7 @@

{{ description.label }}

-
+

{{ enumUtils.toDmpUserRolesString(dmpService.getCurrentUserRolesInDmp(description?.dmp?.dmpUsers)) }}

diff --git a/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html b/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html index 05862add9..fb0859a81 100644 --- a/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html +++ b/dmp-frontend/src/app/ui/dmp/dmp-editor-blueprint/dmp-editor.component.html @@ -90,7 +90,7 @@
  • {{'DMP-EDITOR.DESCRIPTION' | translate}}: {{ description.label }}
    - close + close check
  • diff --git a/dmp-frontend/src/assets/i18n/en.json b/dmp-frontend/src/assets/i18n/en.json index 168636ec9..05c32f3af 100644 --- a/dmp-frontend/src/assets/i18n/en.json +++ b/dmp-frontend/src/assets/i18n/en.json @@ -383,7 +383,6 @@ "MULTIPLICITY-ADD-ONE-FIELD": "Add more", "MULTIPLICITY-ADD-ONE-FIELD-TABLEVIEW": "Add row", "ORDER": "Order", - "COMMENT-PLACEHOLDER": "Please Specify", "COMMENT-HINT": "Provide additional information or justification about your selection", "SEMANTICS": "Semantics", "EXPORT": "Include in Export" @@ -859,6 +858,9 @@ "DESCRIPTION-TEMPLATE-VERSION": "Version" } }, + "FIELDS": { + "COMMENT-PLACEHOLDER": "Please Specify" + }, "ACTIONS": { "BACK-TO": "Back to", "EXPORT": "Export", @@ -871,9 +873,13 @@ "REVERSE": "Undo Finalization", "UNDO-FINALIZATION-QUESTION": "Undo finalization?", "CONFIRM": "Yes", - "REJECT": "No" + "REJECT": "No", + "MULTIPLICITY-ADD-ONE-FIELD": "Add more", + "MULTIPLICITY-ADD-ONE-FIELD-TABLEVIEW": "Add row", + "VIEW-MORE": "View more", + "VIEW-LESS": "View less" }, - "MESSAGES":{ + "MESSAGES": { "MISSING-FIELDS": "There are some required fields left unfilled. Please check the Plan and make sure that all required questions are answered and URLs are provided with valid input. (Missing fields are marked in red color)" }, "LOCKED-DIALOG": {