From b676bafdab488eec724e2f8110b9c13277f9df19 Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 09:50:16 +0300 Subject: [PATCH 01/10] try more fixes --- dmp-backend/core/pom.xml | 12 +++++++----- dmp-backend/web/pom.xml | 4 ++-- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/dmp-backend/core/pom.xml b/dmp-backend/core/pom.xml index 9536dcc03..fce7f5b87 100644 --- a/dmp-backend/core/pom.xml +++ b/dmp-backend/core/pom.xml @@ -3,6 +3,11 @@ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 + + core + ${revision} + ${packaging.type} + eu.eudat dmp-backend @@ -10,17 +15,14 @@ ../pom.xml - eu.eudat - core - ${revision} - ${packaging.type} - 21 + 21 21 21 UTF-8 1.0.0-SNAPSHOT + jar diff --git a/dmp-backend/web/pom.xml b/dmp-backend/web/pom.xml index 79bf497ad..0bb04e4d9 100644 --- a/dmp-backend/web/pom.xml +++ b/dmp-backend/web/pom.xml @@ -4,7 +4,6 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - dmp-backend web ${revision} ${packaging.type} @@ -22,11 +21,12 @@ 21 21 1.0.0-SNAPSHOT + jar - eu.eudat + core ${revision} From 565e8a3b1efc0abcd91fecb3a6d2e204d1fa9ae1 Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 09:52:49 +0300 Subject: [PATCH 02/10] uncomment the groupID --- dmp-backend/web/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dmp-backend/web/pom.xml b/dmp-backend/web/pom.xml index 0bb04e4d9..505adb18a 100644 --- a/dmp-backend/web/pom.xml +++ b/dmp-backend/web/pom.xml @@ -26,7 +26,7 @@ - + eu.eudat core ${revision} From 8833905325aff799569d8b343f9e6f9e395162e9 Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 10:09:19 +0300 Subject: [PATCH 03/10] Dockerfile updates --- dmp-backend/Dockerfile | 4 +--- dmp-backend/core/pom.xml | 2 +- dmp-backend/pom.xml | 14 ++++++++++++++ 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/dmp-backend/Dockerfile b/dmp-backend/Dockerfile index 0377f3cf3..87a74372d 100644 --- a/dmp-backend/Dockerfile +++ b/dmp-backend/Dockerfile @@ -26,8 +26,6 @@ RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} c ######################################## Run Stage ######################################## FROM eclipse-temurin:21-jre-alpine -WORKDIR /app - ARG PROFILE ARG REVISION ENV SERVER_PORT=8080 @@ -35,4 +33,4 @@ EXPOSE ${SERVER_PORT} COPY --from=build-stage /build/web/target/web-${REVISION}.jar /app.jar -ENTRYPOINT ["java", "-Djava.security.egd=file:/dev/./urandom", "-Dspring.profiles.active=${PROFILE}", "-Dspring.config.additional-location=/files/config/", "-cp", "/app/app.jar", "-Dloader.path=/files/repo-jars", "org.springframework.boot.loader.PropertiesLauncher"] \ No newline at end of file +ENTRYPOINT ["java", "-Djava.security.egd=file:/dev/./urandom", "-Dspring.profiles.active=${PROFILE}", "-Dspring.config.additional-location=file:/config/", "-jar", "/app/app.jar"] \ No newline at end of file diff --git a/dmp-backend/core/pom.xml b/dmp-backend/core/pom.xml index fce7f5b87..2aa4c67ac 100644 --- a/dmp-backend/core/pom.xml +++ b/dmp-backend/core/pom.xml @@ -3,7 +3,7 @@ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - + core ${revision} ${packaging.type} diff --git a/dmp-backend/pom.xml b/dmp-backend/pom.xml index 4aa20dc3b..f8044b48d 100644 --- a/dmp-backend/pom.xml +++ b/dmp-backend/pom.xml @@ -4,6 +4,7 @@ 4.0.0 eu.eudat dmp-backend + OpenDMP Backend Parent ${revision} pom @@ -293,6 +294,19 @@ + + cite-dev + + + cite-maven + CITE Maven Repository + https://crepo.cite.gr/repository/cite-maven/ + + + + true + + \ No newline at end of file From ef5125bb0424590a34e4319f1f2be637c10d148d Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 10:21:56 +0300 Subject: [PATCH 04/10] rm -devel configs --- annotation-service/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/annotation-service/Dockerfile b/annotation-service/Dockerfile index 1e0a28fda..b5c4d6f33 100644 --- a/annotation-service/Dockerfile +++ b/annotation-service/Dockerfile @@ -14,7 +14,7 @@ COPY annotation /build/annotation/ COPY annotation-web /build/annotation-web/ COPY settings.xml /root/.m2/settings.xml RUN rm -f /build/annotation-web/src/main/resources/config/app.env -RUN rm -f /build/annotation-web/src/main/resources/config/*-dev.yml +RUN rm -f /build/annotation-web/src/main/resources/config/*-devel.yml RUN rm -f /build/annotation-web/src/main/resources/logging/*.xml RUN rm -f /build/annotation-web/src/main/resources/certificates/*.crt From c0ac0bb72874a97fb545b7c4575de6221544d667 Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 10:29:05 +0300 Subject: [PATCH 05/10] correct path --- dmp-backend/Dockerfile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dmp-backend/Dockerfile b/dmp-backend/Dockerfile index 87a74372d..6f0795f2d 100644 --- a/dmp-backend/Dockerfile +++ b/dmp-backend/Dockerfile @@ -26,11 +26,13 @@ RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} c ######################################## Run Stage ######################################## FROM eclipse-temurin:21-jre-alpine +WORKDIR /app + ARG PROFILE ARG REVISION ENV SERVER_PORT=8080 EXPOSE ${SERVER_PORT} -COPY --from=build-stage /build/web/target/web-${REVISION}.jar /app.jar +COPY --from=build-stage /build/web/target/web-${REVISION}.jar /app/app.jar ENTRYPOINT ["java", "-Djava.security.egd=file:/dev/./urandom", "-Dspring.profiles.active=${PROFILE}", "-Dspring.config.additional-location=file:/config/", "-jar", "/app/app.jar"] \ No newline at end of file From c1a241e4a81d2e4af978902e73d13d7f359e5549 Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 10:34:21 +0300 Subject: [PATCH 06/10] try not use revision variable --- dmp-backend/core/pom.xml | 2 +- dmp-backend/web/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dmp-backend/core/pom.xml b/dmp-backend/core/pom.xml index 2aa4c67ac..542d63b2e 100644 --- a/dmp-backend/core/pom.xml +++ b/dmp-backend/core/pom.xml @@ -5,7 +5,7 @@ 4.0.0 core - ${revision} + 1.0-SNAPSHOT ${packaging.type} diff --git a/dmp-backend/web/pom.xml b/dmp-backend/web/pom.xml index 505adb18a..9259a9eb0 100644 --- a/dmp-backend/web/pom.xml +++ b/dmp-backend/web/pom.xml @@ -28,7 +28,7 @@ eu.eudat core - ${revision} + 1.0-SNAPSHOT From e89bfdf0f4947a04c8e223f0abc65206bd7b465a Mon Sep 17 00:00:00 2001 From: amentis Date: Mon, 8 Apr 2024 10:45:32 +0300 Subject: [PATCH 07/10] remove description template section multiplicity property --- .../types/descriptiontemplate/SectionEntity.java | 10 ---------- .../SectionCommonModelBuilder.java | 1 - .../SectionBuilder.java | 1 - .../descriptiontemplatedefinition/Section.java | 11 ----------- .../DescriptionSectionToDatasetSectionMapper.java | 1 - .../eu/eudat/model/persist/ReferencePersist.java | 8 -------- .../SectionPersist.java | 14 -------------- .../description/DescriptionServiceImpl.java | 1 + .../DescriptionTemplateServiceImpl.java | 7 +++---- .../PublicDatasetsDescriptionDocumentation.java | 1 - .../core/services/reference/reference.service.ts | 3 ++- 11 files changed, 6 insertions(+), 52 deletions(-) diff --git a/dmp-backend/core/src/main/java/eu/eudat/commons/types/descriptiontemplate/SectionEntity.java b/dmp-backend/core/src/main/java/eu/eudat/commons/types/descriptiontemplate/SectionEntity.java index 8b4dc2036..b54eb3453 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/commons/types/descriptiontemplate/SectionEntity.java +++ b/dmp-backend/core/src/main/java/eu/eudat/commons/types/descriptiontemplate/SectionEntity.java @@ -28,8 +28,6 @@ public class SectionEntity{ @XmlElementWrapper(name = "fieldSets") @XmlElement(name = "fieldSet") private List fieldSets; - @XmlAttribute(name="multiplicity") - private Boolean multiplicity; public String getId() { return id; @@ -103,14 +101,6 @@ public class SectionEntity{ this.numbering = numbering; } - public Boolean getMultiplicity() { - return multiplicity; - } - - public void setMultiplicity(Boolean multiplicity) { - this.multiplicity = multiplicity; - } - public List getAllField(){ List fieldEntities = new ArrayList<>(); if (this.getFieldSets() != null){ diff --git a/dmp-backend/core/src/main/java/eu/eudat/model/builder/commonmodels/descriptiontemplate/SectionCommonModelBuilder.java b/dmp-backend/core/src/main/java/eu/eudat/model/builder/commonmodels/descriptiontemplate/SectionCommonModelBuilder.java index cc42614d7..5956ad0ef 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/model/builder/commonmodels/descriptiontemplate/SectionCommonModelBuilder.java +++ b/dmp-backend/core/src/main/java/eu/eudat/model/builder/commonmodels/descriptiontemplate/SectionCommonModelBuilder.java @@ -53,7 +53,6 @@ public class SectionCommonModelBuilder extends BaseCommonModelBuilder { if (fields.hasField(this.asIndexer(Section._description))) m.setDescription(d.getDescription()); if (fields.hasField(this.asIndexer(Section._ordinal))) m.setOrdinal(d.getOrdinal()); if (fields.hasField(this.asIndexer(Section._defaultVisibility))) m.setDefaultVisibility(d.isDefaultVisibility()); - if (fields.hasField(this.asIndexer(Section._multiplicity))) m.setMultiplicity(d.getMultiplicity()); if (fields.hasField(this.asIndexer(Section._numbering))) m.setNumbering(d.getNumbering()); if (fields.hasField(this.asIndexer(Section._title))) m.setTitle(d.getTitle()); if (fields.hasField(this.asIndexer(Section._extendedDescription))) m.setExtendedDescription(d.getExtendedDescription()); diff --git a/dmp-backend/core/src/main/java/eu/eudat/model/descriptiontemplatedefinition/Section.java b/dmp-backend/core/src/main/java/eu/eudat/model/descriptiontemplatedefinition/Section.java index a4222ce96..c83753c4f 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/model/descriptiontemplatedefinition/Section.java +++ b/dmp-backend/core/src/main/java/eu/eudat/model/descriptiontemplatedefinition/Section.java @@ -14,9 +14,6 @@ public class Section { public final static String _defaultVisibility = "defaultVisibility"; private Boolean defaultVisibility; - public final static String _multiplicity = "multiplicity"; - private Boolean multiplicity; - public final static String _numbering = "numbering"; private String numbering; //TODO maybe remove @@ -59,14 +56,6 @@ public class Section { this.defaultVisibility = defaultVisibility; } - public Boolean getMultiplicity() { - return multiplicity; - } - - public void setMultiplicity(Boolean multiplicity) { - this.multiplicity = multiplicity; - } - public String getNumbering() { return numbering; } diff --git a/dmp-backend/core/src/main/java/eu/eudat/model/mapper/publicapi/DescriptionSectionToDatasetSectionMapper.java b/dmp-backend/core/src/main/java/eu/eudat/model/mapper/publicapi/DescriptionSectionToDatasetSectionMapper.java index d698d16b2..723cccb3e 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/model/mapper/publicapi/DescriptionSectionToDatasetSectionMapper.java +++ b/dmp-backend/core/src/main/java/eu/eudat/model/mapper/publicapi/DescriptionSectionToDatasetSectionMapper.java @@ -19,7 +19,6 @@ public class DescriptionSectionToDatasetSectionMapper { model.setOrdinal(section.getOrdinal()); model.setTitle(section.getTitle()); model.setSections(section.getSections().stream().map(x-> this.toPublicModel(x, page)).toList()); - model.setMultiplicity(section.getMultiplicity()); model.setDefaultVisibility(section.getDefaultVisibility()); model.setNumbering(section.getNumbering()); model.setPage("page_" + page); diff --git a/dmp-backend/core/src/main/java/eu/eudat/model/persist/ReferencePersist.java b/dmp-backend/core/src/main/java/eu/eudat/model/persist/ReferencePersist.java index 5591bf73c..4b742f4a6 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/model/persist/ReferencePersist.java +++ b/dmp-backend/core/src/main/java/eu/eudat/model/persist/ReferencePersist.java @@ -232,14 +232,6 @@ public class ReferencePersist { @Override protected List specifications(ReferencePersist item) { return Arrays.asList( - this.spec() - .iff(() -> this.isValidGuid(item.getId())) - .must(() -> this.isValidHash(item.getHash())) - .failOn(ReferencePersist._hash).failWith(messageSource.getMessage("Validation_Required", new Object[]{ReferencePersist._hash}, LocaleContextHolder.getLocale())), - this.spec() - .iff(() -> !this.isValidGuid(item.getId())) - .must(() -> !this.isValidHash(item.getHash())) - .failOn(ReferencePersist._hash).failWith(messageSource.getMessage("Validation_OverPosting", new Object[]{}, LocaleContextHolder.getLocale())), this.spec() .must(() -> !this.isEmpty(item.getLabel())) .failOn(ReferencePersist._label).failWith(messageSource.getMessage("Validation_Required", new Object[]{ReferencePersist._label}, LocaleContextHolder.getLocale())), diff --git a/dmp-backend/core/src/main/java/eu/eudat/model/persist/descriptiontemplatedefinition/SectionPersist.java b/dmp-backend/core/src/main/java/eu/eudat/model/persist/descriptiontemplatedefinition/SectionPersist.java index e56da9699..826f71fb1 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/model/persist/descriptiontemplatedefinition/SectionPersist.java +++ b/dmp-backend/core/src/main/java/eu/eudat/model/persist/descriptiontemplatedefinition/SectionPersist.java @@ -28,10 +28,6 @@ public class SectionPersist { public static final String _defaultVisibility = "defaultVisibility"; - private Boolean multiplicity = null; - - public static final String _multiplicity = "multiplicity"; - private String title = null; public static final String _title = "title"; @@ -72,13 +68,6 @@ public class SectionPersist { this.defaultVisibility = defaultVisibility; } - public Boolean getMultiplicity() { - return multiplicity; - } - - public void setMultiplicity(Boolean multiplicity) { - this.multiplicity = multiplicity; - } public String getTitle() { return title; @@ -145,9 +134,6 @@ public class SectionPersist { this.spec() .must(() -> !this.isNull(item.getDefaultVisibility())) .failOn(SectionPersist._defaultVisibility).failWith(messageSource.getMessage("Validation_Required", new Object[]{SectionPersist._defaultVisibility}, LocaleContextHolder.getLocale())), - this.spec() - .must(() -> !this.isNull(item.getMultiplicity())) - .failOn(SectionPersist._multiplicity).failWith(messageSource.getMessage("Validation_Required", new Object[]{SectionPersist._multiplicity}, LocaleContextHolder.getLocale())), this.spec() .must(() -> !this.isEmpty(item.getTitle())) .failOn(SectionPersist._title).failWith(messageSource.getMessage("Validation_Required", new Object[]{SectionPersist._title}, LocaleContextHolder.getLocale())), diff --git a/dmp-backend/core/src/main/java/eu/eudat/service/description/DescriptionServiceImpl.java b/dmp-backend/core/src/main/java/eu/eudat/service/description/DescriptionServiceImpl.java index c319fdab5..d35f4c5f7 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/service/description/DescriptionServiceImpl.java +++ b/dmp-backend/core/src/main/java/eu/eudat/service/description/DescriptionServiceImpl.java @@ -560,6 +560,7 @@ public class DescriptionServiceImpl implements DescriptionService { if (referenceEntity == null){ referenceEntity = new ReferenceEntity(); referenceEntity.setId(UUID.randomUUID()); + referenceEntity.setLabel(referencePersist.getLabel()); referenceEntity.setIsActive(IsActive.Active); referenceEntity.setCreatedAt(Instant.now()); referenceEntity.setTypeId(fieldEntity.getReferenceTypeId()); diff --git a/dmp-backend/core/src/main/java/eu/eudat/service/descriptiontemplate/DescriptionTemplateServiceImpl.java b/dmp-backend/core/src/main/java/eu/eudat/service/descriptiontemplate/DescriptionTemplateServiceImpl.java index df4232960..642ee889e 100644 --- a/dmp-backend/core/src/main/java/eu/eudat/service/descriptiontemplate/DescriptionTemplateServiceImpl.java +++ b/dmp-backend/core/src/main/java/eu/eudat/service/descriptiontemplate/DescriptionTemplateServiceImpl.java @@ -316,7 +316,6 @@ public class DescriptionTemplateServiceImpl implements DescriptionTemplateServic data.setDescription(persist.getDescription()); data.setOrdinal(persist.getOrdinal()); data.setDefaultVisibility(persist.getDefaultVisibility()); - data.setMultiplicity(persist.getMultiplicity()); data.setTitle(persist.getTitle()); if (!this.conventionService.isListNullOrEmpty(persist.getSections())) { @@ -329,14 +328,14 @@ public class DescriptionTemplateServiceImpl implements DescriptionTemplateServic if (!this.conventionService.isListNullOrEmpty(persist.getFieldSets())) { data.setFieldSets(new ArrayList<>()); for (FieldSetPersist fieldSetPersist : persist.getFieldSets()) { - data.getFieldSets().add(this.buildFieldSetEntity(fieldSetPersist, persist.getMultiplicity())); + data.getFieldSets().add(this.buildFieldSetEntity(fieldSetPersist)); } } return data; } - private @NotNull FieldSetEntity buildFieldSetEntity(FieldSetPersist persist, Boolean multiplicity) throws InvalidApplicationException { + private @NotNull FieldSetEntity buildFieldSetEntity(FieldSetPersist persist) throws InvalidApplicationException { FieldSetEntity data = new FieldSetEntity(); if (persist == null) return data; @@ -348,7 +347,7 @@ public class DescriptionTemplateServiceImpl implements DescriptionTemplateServic data.setNumbering(persist.getNumbering()); data.setAdditionalInformation(persist.getAdditionalInformation()); data.setExtendedDescription(persist.getExtendedDescription()); - if (persist.getMultiplicity() != null && multiplicity) + if (persist.getMultiplicity() != null) data.setMultiplicity(this.buildMultiplicityEntity(persist.getMultiplicity())); data.setHasCommentField(persist.getHasCommentField()); diff --git a/dmp-backend/web/src/main/java/eu/eudat/controllers/publicapi/PublicDatasetsDescriptionDocumentation.java b/dmp-backend/web/src/main/java/eu/eudat/controllers/publicapi/PublicDatasetsDescriptionDocumentation.java index 2e3cbed4d..d7df96fc9 100644 --- a/dmp-backend/web/src/main/java/eu/eudat/controllers/publicapi/PublicDatasetsDescriptionDocumentation.java +++ b/dmp-backend/web/src/main/java/eu/eudat/controllers/publicapi/PublicDatasetsDescriptionDocumentation.java @@ -166,7 +166,6 @@ public class PublicDatasetsDescriptionDocumentation { String.join(".", Description._descriptionTemplate, DescriptionTemplate._definition, Definition._pages, Page._sections, Section._description), String.join(".", Description._descriptionTemplate, DescriptionTemplate._definition, Definition._pages, Page._sections, Section._extendedDescription), String.join(".", Description._descriptionTemplate, DescriptionTemplate._definition, Definition._pages, Page._sections, Section._title), - String.join(".", Description._descriptionTemplate, DescriptionTemplate._definition, Definition._pages, Page._sections, Section._multiplicity), String.join(".", Description._descriptionTemplate, DescriptionTemplate._definition, Definition._pages, Page._sections, Section._numbering), String.join(".", Description._descriptionTemplate, DescriptionTemplate._definition, Definition._pages, Page._sections, Section._ordinal), String.join(".", Description._descriptionTemplate, DescriptionTemplate._definition, Definition._pages, Page._sections, Section._sections), diff --git a/dmp-frontend/src/app/core/services/reference/reference.service.ts b/dmp-frontend/src/app/core/services/reference/reference.service.ts index 2cc3b9735..fdca0d1ea 100644 --- a/dmp-frontend/src/app/core/services/reference/reference.service.ts +++ b/dmp-frontend/src/app/core/services/reference/reference.service.ts @@ -124,8 +124,9 @@ export class ReferenceService { filterFn: (searchQuery: string, data?: any) => this.searchWithDefinition(this.buildAutocompleteSearchLookup(typeId, searchQuery)).pipe(map(x => x)), getSelectedItem: (selectedItem: any) => this.query(this.buildAutocompleteSearchSelectedItemsLookup([typeId], null, null, null, [selectedItem])).pipe(map(x => x.items[0])), displayFn: (item: Reference) => item.label, + subtitleFn: (item: Reference) => item?.sourceType === ReferenceSourceType.External ? this.language.instant('REFERENCE-FIELD-COMPONENT.EXTERNAL-SOURCE') + ': ' + item.source : this.language.instant('REFERENCE-FIELD-COMPONENT.INTERNAL-SOURCE'), titleFn: (item: Reference) => item.label, - valueAssign: (item: Reference) => item.id, + valueAssign: (item: Reference) => item, }; }; From 9ce9632c37e6c2d7e65a3a7c483be93d4523d0f4 Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 10:47:48 +0300 Subject: [PATCH 08/10] remove devProfileURL from dockerfile --- dmp-backend/Dockerfile | 4 ++-- dmp-backend/core/pom.xml | 2 +- dmp-backend/web/pom.xml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dmp-backend/Dockerfile b/dmp-backend/Dockerfile index 6f0795f2d..29fc0c375 100644 --- a/dmp-backend/Dockerfile +++ b/dmp-backend/Dockerfile @@ -19,9 +19,9 @@ RUN rm -f /build/annotation-web/src/main/resources/logging/*.xml WORKDIR /build/ #RUN mvn package -q -RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} dependency:go-offline +RUN mvn -Drevision=${REVISION} -P${PROFILE} dependency:go-offline # Build project -RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} clean package +RUN mvn -Drevision=${REVISION} -P${PROFILE} clean package ######################################## Run Stage ######################################## FROM eclipse-temurin:21-jre-alpine diff --git a/dmp-backend/core/pom.xml b/dmp-backend/core/pom.xml index 542d63b2e..2aa4c67ac 100644 --- a/dmp-backend/core/pom.xml +++ b/dmp-backend/core/pom.xml @@ -5,7 +5,7 @@ 4.0.0 core - 1.0-SNAPSHOT + ${revision} ${packaging.type} diff --git a/dmp-backend/web/pom.xml b/dmp-backend/web/pom.xml index 9259a9eb0..505adb18a 100644 --- a/dmp-backend/web/pom.xml +++ b/dmp-backend/web/pom.xml @@ -28,7 +28,7 @@ eu.eudat core - 1.0-SNAPSHOT + ${revision} From 79431f086509ad424822945c4263adb364f38673 Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 10:52:22 +0300 Subject: [PATCH 09/10] revert devProfulURL change --- dmp-backend/Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dmp-backend/Dockerfile b/dmp-backend/Dockerfile index 29fc0c375..6f0795f2d 100644 --- a/dmp-backend/Dockerfile +++ b/dmp-backend/Dockerfile @@ -19,9 +19,9 @@ RUN rm -f /build/annotation-web/src/main/resources/logging/*.xml WORKDIR /build/ #RUN mvn package -q -RUN mvn -Drevision=${REVISION} -P${PROFILE} dependency:go-offline +RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} dependency:go-offline # Build project -RUN mvn -Drevision=${REVISION} -P${PROFILE} clean package +RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} clean package ######################################## Run Stage ######################################## FROM eclipse-temurin:21-jre-alpine From bdfcb8cdf68afa7f825484a8e93176a24b21e96a Mon Sep 17 00:00:00 2001 From: amandilaras Date: Mon, 8 Apr 2024 10:59:10 +0300 Subject: [PATCH 10/10] update Dockerfiles --- dmp-backend/Dockerfile | 2 +- dmp-backend/Dockerfile.CI | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/dmp-backend/Dockerfile b/dmp-backend/Dockerfile index 6f0795f2d..982b41242 100644 --- a/dmp-backend/Dockerfile +++ b/dmp-backend/Dockerfile @@ -14,7 +14,7 @@ COPY core /build/core/ COPY web /build/web/ COPY settings.xml /root/.m2/settings.xml RUN rm -f /build/web/src/main/resources/config/*-devel.yml -RUN rm -f /build/annotation-web/src/main/resources/logging/*.xml +RUN rm -f /build/web/src/main/resources/logging/*.xml WORKDIR /build/ diff --git a/dmp-backend/Dockerfile.CI b/dmp-backend/Dockerfile.CI index e95d54371..982b41242 100644 --- a/dmp-backend/Dockerfile.CI +++ b/dmp-backend/Dockerfile.CI @@ -10,14 +10,15 @@ ENV server_username=$MAVEN_ACCOUNT_USR ENV server_password=$MAVEN_ACCOUNT_PSW COPY pom.xml /build/ -COPY core /build/core -#COPY elastic /build/elastic/ +COPY core /build/core/ COPY web /build/web/ COPY settings.xml /root/.m2/settings.xml -RUN rm -f /build/web/src/main/resources/config/*-dev.yml +RUN rm -f /build/web/src/main/resources/config/*-devel.yml +RUN rm -f /build/web/src/main/resources/logging/*.xml WORKDIR /build/ +#RUN mvn package -q RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} dependency:go-offline # Build project RUN mvn -Drevision=${REVISION} -DdevProfileUrl=${DEV_PROFILE_URL} -P${PROFILE} clean package @@ -29,6 +30,9 @@ WORKDIR /app ARG PROFILE ARG REVISION +ENV SERVER_PORT=8080 +EXPOSE ${SERVER_PORT} COPY --from=build-stage /build/web/target/web-${REVISION}.jar /app/app.jar -ENTRYPOINT ["java", "-Djava.security.egd=file:/dev/./urandom", "-Dspring.profiles.active=${PROFILE}", "-Dspring.config.additional-location=/files/config/", "-cp", "/app/app.jar", "-Dloader.path=/files/repo-jars", "org.springframework.boot.loader.PropertiesLauncher"] \ No newline at end of file + +ENTRYPOINT ["java", "-Djava.security.egd=file:/dev/./urandom", "-Dspring.profiles.active=${PROFILE}", "-Dspring.config.additional-location=file:/config/", "-jar", "/app/app.jar"] \ No newline at end of file