From 5c608c11e86d341633c3b639d991affb6a6b63ba Mon Sep 17 00:00:00 2001 From: dtziotzios Date: Thu, 7 Mar 2019 12:04:54 +0200 Subject: [PATCH] ADDITIONAL-INFORMATION On CompositeFields Fix Import Dataset Profiles Desc Extendet And Additional --- .../ExportXmlBuilderDatasetProfile.java | 5 +++ .../datasetProfileModel/FieldSet.java | 39 ++++++++++++++++--- .../components/datasetprofile/FieldSet.java | 12 ++++++ .../datasetprofiledefinition/FieldSet.java | 16 ++++++++ .../components/datasetprofile/FieldSet.java | 11 ++++++ .../admin/dataset-profile/dataset-profile.ts | 1 + .../composite-field.ts | 1 + .../model/dataset-profile-definition/field.ts | 1 + .../admin/field-set-editor-model.ts | 3 ++ ...file-editor-composite-field.component.html | 4 ++ .../ui/dmp/listing/dmp-listing.component.html | 32 +++++++++++---- .../form-composite-field.component.html | 31 ++++++++++----- .../form-field/form-field.component.html | 2 +- .../dataset-description-form.model.ts | 9 ++++- dmp-frontend/src/assets/i18n/en.json | 1 + 15 files changed, 143 insertions(+), 25 deletions(-) diff --git a/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/ExportXmlBuilderDatasetProfile.java b/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/ExportXmlBuilderDatasetProfile.java index cbb18494c..6a53063d5 100644 --- a/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/ExportXmlBuilderDatasetProfile.java +++ b/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/ExportXmlBuilderDatasetProfile.java @@ -132,6 +132,11 @@ public class ExportXmlBuilderDatasetProfile { extendedDescription.setTextContent(field.getExtendedDescription()); composite.appendChild(extendedDescription); } + if (field.getAdditionalInformation() != null && !field.getAdditionalInformation().isEmpty()) { + Element additionalInformation = element.createElement("additionalInformation"); + additionalInformation.setTextContent(field.getAdditionalInformation()); + composite.appendChild(additionalInformation); + } elementFieldSets.appendChild(composite); diff --git a/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/datasetProfileModel/FieldSet.java b/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/datasetProfileModel/FieldSet.java index b1af01832..50af153e8 100644 --- a/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/datasetProfileModel/FieldSet.java +++ b/dmp-backend/web/src/main/java/eu/eudat/logic/utilities/documents/xml/datasetProfileXml/datasetProfileModel/FieldSet.java @@ -15,6 +15,9 @@ public class FieldSet { private String numbering; private Boolean commentField; private Multiplicity multiplicity; + private String description; + private String extendedDescription; + private String additionalInformation; private String title; @XmlAttribute(name = "id") @@ -76,6 +79,33 @@ public class FieldSet { return title; } + @XmlElement(name = "description") + public String getDescription() { + return description; + } + + public void setDescription(String description) { + this.description = description; + } + + @XmlElement(name = "extendedDescription") + public String getExtendedDescription() { + return extendedDescription; + } + + public void setExtendedDescription(String extendedDescription) { + this.extendedDescription = extendedDescription; + } + + @XmlElement(name = "additionalInformation") + public String getAdditionalInformation() { + return additionalInformation; + } + + public void setAdditionalInformation(String additionalInformation) { + this.additionalInformation = additionalInformation; + } + public void setTitle(String title) { this.title = title; } @@ -87,11 +117,10 @@ public class FieldSet { fieldSet1Entity.setHasCommentField(this.commentField != null ? this.commentField : false); fieldSet1Entity.setMultiplicity(this.multiplicity != null ? this.multiplicity.toAdminCompositeModelSection() : null); fieldSet1Entity.setTitle(this.title); -// List fieldsEntity = new LinkedList<>(); -// -// for (Fields xmlField:this.fields) { -// fieldsEntity.add(xmlField.toAdminCompositeModelSection()); -// } + fieldSet1Entity.setDescription(this.description); + fieldSet1Entity.setExtendedDescription(this.extendedDescription); + fieldSet1Entity.setAdditionalInformation(this.additionalInformation); + fieldSet1Entity.setFields(this.fields.toAdminCompositeModelSection()); return fieldSet1Entity; } diff --git a/dmp-backend/web/src/main/java/eu/eudat/models/data/admin/components/datasetprofile/FieldSet.java b/dmp-backend/web/src/main/java/eu/eudat/models/data/admin/components/datasetprofile/FieldSet.java index ab27ff641..de1623765 100644 --- a/dmp-backend/web/src/main/java/eu/eudat/models/data/admin/components/datasetprofile/FieldSet.java +++ b/dmp-backend/web/src/main/java/eu/eudat/models/data/admin/components/datasetprofile/FieldSet.java @@ -15,6 +15,7 @@ public class FieldSet implements Comparable, ViewStyleDefinition fields; @@ -86,6 +87,14 @@ public class FieldSet implements Comparable, ViewStyleDefinition fieldToShort = this.fields; diff --git a/dmp-backend/web/src/main/java/eu/eudat/models/data/entities/xmlmodels/datasetprofiledefinition/FieldSet.java b/dmp-backend/web/src/main/java/eu/eudat/models/data/entities/xmlmodels/datasetprofiledefinition/FieldSet.java index 23be8632f..86f7728a3 100644 --- a/dmp-backend/web/src/main/java/eu/eudat/models/data/entities/xmlmodels/datasetprofiledefinition/FieldSet.java +++ b/dmp-backend/web/src/main/java/eu/eudat/models/data/entities/xmlmodels/datasetprofiledefinition/FieldSet.java @@ -19,6 +19,7 @@ public class FieldSet implements DatabaseViewStyleDefinition, XmlSerializable fields; private List
multiplicityItems; @@ -118,6 +119,14 @@ public class FieldSet implements Comparable, PropertiesModelBuilder, ViewStyleDe this.commentFieldValue = commentFieldValue; } + public String getAdditionalInformation() { + return additionalInformation; + } + + public void setAdditionalInformation(String additionalInformation) { + this.additionalInformation = additionalInformation; + } + @Override public eu.eudat.models.data.entities.xmlmodels.datasetprofiledefinition.FieldSet toDatabaseDefinition(eu.eudat.models.data.entities.xmlmodels.datasetprofiledefinition.FieldSet item) { List viewStylefields = new ModelBuilder().toViewStyleDefinition(this.fields, eu.eudat.models.data.entities.xmlmodels.datasetprofiledefinition.Field.class); @@ -137,6 +146,7 @@ public class FieldSet implements Comparable, PropertiesModelBuilder, ViewStyleDe this.ordinal = item.getOrdinal(); this.title = item.getTitle(); this.description = item.getDescription(); + this.additionalInformation=item.getAdditionalInformation(); this.numbering = item.getNumbering(); this.extendedDescription = item.getExtendedDescription(); this.hasCommentField = item.getHasCommentField(); @@ -167,6 +177,7 @@ public class FieldSet implements Comparable, PropertiesModelBuilder, ViewStyleDe newFieldSet.id = ids[0]+"_"+ids[1]+"_"+ids[2]; newFieldSet.description = this.description; newFieldSet.extendedDescription = this.extendedDescription; + newFieldSet.additionalInformation=this.additionalInformation; newFieldSet.title = this.title; newFieldSet.ordinal = this.ordinal; newFieldSet.fields = new LinkedList(); diff --git a/dmp-frontend/src/app/core/model/admin/dataset-profile/dataset-profile.ts b/dmp-frontend/src/app/core/model/admin/dataset-profile/dataset-profile.ts index 81c2ebd31..b8c5444e0 100644 --- a/dmp-frontend/src/app/core/model/admin/dataset-profile/dataset-profile.ts +++ b/dmp-frontend/src/app/core/model/admin/dataset-profile/dataset-profile.ts @@ -31,6 +31,7 @@ export interface FieldSet { title: string; description: string; extendedDescription: string; + additionalInformation:string; hasCommentField: boolean; fields: Field[]; } diff --git a/dmp-frontend/src/app/core/model/dataset-profile-definition/composite-field.ts b/dmp-frontend/src/app/core/model/dataset-profile-definition/composite-field.ts index 91e0b2a72..019d1818b 100644 --- a/dmp-frontend/src/app/core/model/dataset-profile-definition/composite-field.ts +++ b/dmp-frontend/src/app/core/model/dataset-profile-definition/composite-field.ts @@ -11,6 +11,7 @@ export interface CompositeField { title: string; description: string; extendedDescription: string; + additionalInformation:string; hasCommentField: boolean; commentFieldValue: string; } \ No newline at end of file diff --git a/dmp-frontend/src/app/core/model/dataset-profile-definition/field.ts b/dmp-frontend/src/app/core/model/dataset-profile-definition/field.ts index b37e6fd94..dc8cd80cd 100644 --- a/dmp-frontend/src/app/core/model/dataset-profile-definition/field.ts +++ b/dmp-frontend/src/app/core/model/dataset-profile-definition/field.ts @@ -12,6 +12,7 @@ export interface Field { description: string; numbering: string; extendedDescription: string; + additionalInformation:string; viewStyle: ViewStyle; defaultVisibility: boolean; page: number; diff --git a/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-set-editor-model.ts b/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-set-editor-model.ts index f103114bb..5f3791e8b 100644 --- a/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-set-editor-model.ts +++ b/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-set-editor-model.ts @@ -14,6 +14,7 @@ export class FieldSetEditorModel extends BaseFormModel { public title: string; public description: string; public extendedDescription: string; + public additionalInformation:string; public hasCommentField: boolean; fromModel(item: FieldSet): FieldSetEditorModel { @@ -25,6 +26,7 @@ export class FieldSetEditorModel extends BaseFormModel { this.title = item.title; this.description = item.description; this.extendedDescription = item.extendedDescription; + this.additionalInformation=item.additionalInformation; this.hasCommentField = item.hasCommentField; return this; } @@ -36,6 +38,7 @@ export class FieldSetEditorModel extends BaseFormModel { title: [this.title], description: [this.description], extendedDescription: [this.extendedDescription], + additionalInformation:[this.additionalInformation], hasCommentField: [this.hasCommentField] }); const fieldsFormArray = new Array(); diff --git a/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/composite-field/dataset-profile-editor-composite-field.component.html b/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/composite-field/dataset-profile-editor-composite-field.component.html index da3c28de1..e7a01e8f9 100644 --- a/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/composite-field/dataset-profile-editor-composite-field.component.html +++ b/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/composite-field/dataset-profile-editor-composite-field.component.html @@ -50,6 +50,10 @@ + + + diff --git a/dmp-frontend/src/app/ui/dmp/listing/dmp-listing.component.html b/dmp-frontend/src/app/ui/dmp/listing/dmp-listing.component.html index 04cb880c2..7df8f5706 100644 --- a/dmp-frontend/src/app/ui/dmp/listing/dmp-listing.component.html +++ b/dmp-frontend/src/app/ui/dmp/listing/dmp-listing.component.html @@ -8,7 +8,8 @@ - {{'DMP-LISTING.COLUMNS.NAME' | translate}} + {{'DMP-LISTING.COLUMNS.NAME' | translate}} + {{row.label}} @@ -27,7 +28,8 @@ - {{'DMP-LISTING.COLUMNS.CREATION-TIME' | translate}} + + {{'DMP-LISTING.COLUMNS.CREATION-TIME' | translate}} {{row.creationTime | date:'shortDate'}} @@ -39,15 +41,28 @@ - {{'DMP-LISTING.COLUMNS.LATEST_VERSION' | translate}} - {{row.version}} + + {{'DMP-LISTING.COLUMNS.LATEST_VERSION' | translate}} + + + + {{row.version}} + + + - {{'DMP-LISTING.COLUMNS.DATASETS' | translate}} + + {{'DMP-LISTING.COLUMNS.DATASETS' | translate}} - + + @@ -85,7 +100,8 @@ - - + \ No newline at end of file diff --git a/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-composite-field/form-composite-field.component.html b/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-composite-field/form-composite-field.component.html index 657d775e2..9b53c153a 100644 --- a/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-composite-field/form-composite-field.component.html +++ b/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-composite-field/form-composite-field.component.html @@ -1,21 +1,26 @@ -
+
+ class="col-12">
-
{{form.get('numbering').value}} +
+ {{form.get('numbering').value}} {{form.get('title').value}}
+ info +
{{form.get('description').value}}
{{form.get('extendedDescription').value}}
- + + - -