From 5be674d07e88210c734059c69b3cd5498dcc65a5 Mon Sep 17 00:00:00 2001
From: George Kalampokis <gkalampokis@cite.gr>
Date: Thu, 10 Sep 2020 18:04:14 +0300
Subject: [PATCH] Allow wordlist combobox type to have multiple values

---
 .../commons/datafield/WordListData.java       | 14 +++++++--
 .../field-data/field-data.ts                  |  1 +
 .../word-list-field-data-editor-model.ts      |  5 +++-
 ...file-editor-word-list-field.component.html |  5 +++-
 .../form-field/form-field.component.html      |  2 +-
 .../form-field/form-field.component.ts        | 30 +++++++++++++------
 dmp-frontend/src/assets/i18n/de.json          |  3 +-
 dmp-frontend/src/assets/i18n/en.json          |  3 +-
 dmp-frontend/src/assets/i18n/es.json          |  3 +-
 dmp-frontend/src/assets/i18n/gr.json          |  3 +-
 dmp-frontend/src/assets/i18n/tr.json          |  3 +-
 11 files changed, 53 insertions(+), 19 deletions(-)

diff --git a/dmp-backend/web/src/main/java/eu/eudat/models/data/components/commons/datafield/WordListData.java b/dmp-backend/web/src/main/java/eu/eudat/models/data/components/commons/datafield/WordListData.java
index 69b4ca4b1..1a2bc455f 100644
--- a/dmp-backend/web/src/main/java/eu/eudat/models/data/components/commons/datafield/WordListData.java
+++ b/dmp-backend/web/src/main/java/eu/eudat/models/data/components/commons/datafield/WordListData.java
@@ -12,6 +12,7 @@ import java.util.Map;
 
 public class WordListData extends ComboBoxData<WordListData> {
     private List<Option> options;
+    private Boolean multiList;
 
     public List<Option> getOptions() {
         return options;
@@ -21,10 +22,18 @@ public class WordListData extends ComboBoxData<WordListData> {
         this.options = options;
     }
 
+    public Boolean getMultiList() {
+        return multiList;
+    }
+
+    public void setMultiList(Boolean multiList) {
+        this.multiList = multiList;
+    }
 
     @Override
     public Element toXml(Document doc) {
         Element root = super.toXml(doc);
+        root.setAttribute("multiList", this.multiList.toString());
         Element element = doc.createElement("options");
         if (this.options != null) {
             for (Option option : this.options) {
@@ -50,6 +59,8 @@ public class WordListData extends ComboBoxData<WordListData> {
                 }
             }
         }
+        Boolean temp = Boolean.parseBoolean(item.getAttribute("multiList"));
+        this.multiList = temp != null ? temp : false;
         return this;
     }
 
@@ -57,7 +68,6 @@ public class WordListData extends ComboBoxData<WordListData> {
     public WordListData fromData(Object data) {
         super.fromData(data);
         this.options = new LinkedList();
-
         if (data != null) {
             List<Map<String, String>> options = ((Map<String, List<Map<String, String>>>) data).get("options");
             if (options != null) {
@@ -68,8 +78,8 @@ public class WordListData extends ComboBoxData<WordListData> {
                     this.options.add(newOption);
                 }
             }
+            this.multiList = (Boolean) ((Map<String, Object>) data).get("multiList");
         }
-
         return this;
     }
 
diff --git a/dmp-frontend/src/app/core/model/dataset-profile-definition/field-data/field-data.ts b/dmp-frontend/src/app/core/model/dataset-profile-definition/field-data/field-data.ts
index 6a953e120..8923345f1 100644
--- a/dmp-frontend/src/app/core/model/dataset-profile-definition/field-data/field-data.ts
+++ b/dmp-frontend/src/app/core/model/dataset-profile-definition/field-data/field-data.ts
@@ -41,6 +41,7 @@ export interface TextAreaFieldData extends FieldData {
 export interface WordListFieldData extends FieldData {
 	type: DatasetProfileComboBoxType;
 	options: Array<FieldDataOption>;
+	multiList: boolean;
 }
 
 export interface FieldDataOption extends FieldData {
diff --git a/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-data/word-list-field-data-editor-model.ts b/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-data/word-list-field-data-editor-model.ts
index 7308ee1af..2022da566 100644
--- a/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-data/word-list-field-data-editor-model.ts
+++ b/dmp-frontend/src/app/ui/admin/dataset-profile/admin/field-data/word-list-field-data-editor-model.ts
@@ -7,11 +7,13 @@ import { FieldDataOptionEditorModel } from './field-data-option-editor-model';
 export class WordListFieldDataEditorModel extends FieldDataEditorModel<WordListFieldDataEditorModel> {
 	public type: DatasetProfileComboBoxType = DatasetProfileComboBoxType.WordList;
 	public options: Array<FieldDataOptionEditorModel>;
+	public multipleList: boolean;
 
 	buildForm(disabled: boolean = false, skipDisable: Array<String> = []): FormGroup {
 		const formGroup = this.formBuilder.group({
 			type: [{ value: this.type, disabled: (disabled && !skipDisable.includes('WordListFieldDataEditorModel.type')) }],
-			label: [{ value: this.label, disabled: (disabled && !skipDisable.includes('WordListFieldDataEditorModel.label')) }]
+			label: [{ value: this.label, disabled: (disabled && !skipDisable.includes('WordListFieldDataEditorModel.label')) }],
+			multiList: [{ value: this.multipleList, disabled: (disabled && !skipDisable.includes('WordListFieldDataEditorModel.multipleList'))}]
 		});
 		const optionsFormArray = new Array<FormGroup>();
 		if (this.options) {
@@ -29,6 +31,7 @@ export class WordListFieldDataEditorModel extends FieldDataEditorModel<WordListF
 		this.type = item.type;
 		if (item.options) { this.options = item.options.map(x => new FieldDataOptionEditorModel().fromModel(x)); }
 		this.label = item.label;
+		this.multipleList = item.multiList;
 		return this;
 	}
 }
diff --git a/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/field-type/word-list/dataset-profile-editor-word-list-field.component.html b/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/field-type/word-list/dataset-profile-editor-word-list-field.component.html
index 1236a10f8..493b890b6 100644
--- a/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/field-type/word-list/dataset-profile-editor-word-list-field.component.html
+++ b/dmp-frontend/src/app/ui/admin/dataset-profile/editor/components/field-type/word-list/dataset-profile-editor-word-list-field.component.html
@@ -2,6 +2,9 @@
 
 	<h5 style="font-weight: bold" class="col-12">{{'DATASET-PROFILE-EDITOR.STEPS.FORM.FIELD.FIELDS.FIELD-WORD-LIST-TITLE'
 		| translate}}</h5>
+		<mat-checkbox class="col-auto" [formControl]="this.form.get('data').get('multiList')">
+			{{'DATASET-PROFILE-EDITOR.STEPS.FORM.FIELD.FIELDS.FIELD-MULTIPLE-WORDLIST' | translate}}
+			</mat-checkbox>
 
 	<mat-form-field class="col-12">
 		<input matInput type="string"
@@ -30,4 +33,4 @@
 	<div class="col-auto"><button mat-icon-button (click)="addNewRow()">
 			<mat-icon>add</mat-icon>
 		</button></div>
-</div>
\ No newline at end of file
+</div>
diff --git a/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.html b/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.html
index fc090d9dd..bb7741581 100644
--- a/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.html
+++ b/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.html
@@ -32,7 +32,7 @@
 				<mat-hint>{{ "TYPES.DATASET-PROFILE-COMBO-BOX-TYPE.EXTERNAL-SOURCE-HINT" | translate }}</mat-hint>
 			</mat-form-field>
 			<mat-form-field *ngIf="form.get('data').value.type === datasetProfileComboBoxTypeEnum.WordList" class="col-md-12">
-				<mat-select [formControl]="form.get('value')" placeholder="{{ form.get('data').value.label | translate }}" [required]="form.get('validationRequired').value">
+				<mat-select [formControl]="form.get('value')" placeholder="{{ form.get('data').value.label | translate }}" [required]="form.get('validationRequired').value" [multiple]="form.get('data').value.multiList">
 					<mat-option *ngFor="let opt of form.get('data').value.options" [value]="opt.value">{{opt.label}}
 					</mat-option>
 				</mat-select>
diff --git a/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.ts b/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.ts
index 1327691d5..e35c8026b 100644
--- a/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.ts
+++ b/dmp-frontend/src/app/ui/misc/dataset-description-form/components/form-field/form-field.component.ts
@@ -93,6 +93,18 @@ export class FormFieldComponent extends BaseComponent implements OnInit {
 			this.visibilityRulesService.updateValueAndVisibility(this.form.get('id').value, this.form.get('value').value);
 		}
 
+		if (this.form.get('viewStyle').value.renderStyle === DatasetProfileFieldViewStyle.ComboBox && this.form.get('data').value.type === DatasetProfileComboBoxType.WordList) {
+			if (this.form.get('data').value.multiList) {
+				const originalValue = <string>this.form.get('value').value;
+				let values = (<string>this.form.get('value').value).slice(1, -1).split(', ');
+				if (!originalValue.startsWith('[') && !originalValue.endsWith(']')) {
+					values = undefined;
+					values = [originalValue];
+				}
+				this.form.patchValue({ 'value': values });
+			}
+		}
+
 		// Setup autocomplete configuration if needed
 		if (this.form.get('viewStyle').value.renderStyle === DatasetProfileFieldViewStyle.ComboBox && this.form.get('data').value.type === DatasetProfileComboBoxType.Autocomplete) {
 			if (!(this.form.controls['data'].value.multiAutoComplete)) {
@@ -134,7 +146,7 @@ export class FormFieldComponent extends BaseComponent implements OnInit {
 					initialItems: () => this.searchDatasetExternalDataRepositories(''),
 					displayFn: (item) => typeof (item) == 'string' ? JSON.parse(item)['name'] : item.name,
 					titleFn: (item) => typeof (item) == 'string' ? JSON.parse(item)['name'] : item.name,
-					subtitleFn: (item) => item.source ? this.language.instant('TYPES.EXTERNAL-DATASET-TYPE.SOURCE:') + item.source : item.tag ? this.language.instant('TYPES.EXTERNAL-DATASET-TYPE.SOURCE:') + item.tag :  this.language.instant('TYPES.EXTERNAL-DATASET-TYPE.NO-SOURCE'),
+					subtitleFn: (item) => item.source ? this.language.instant('TYPES.EXTERNAL-DATASET-TYPE.SOURCE:') + item.source : item.tag ? this.language.instant('TYPES.EXTERNAL-DATASET-TYPE.SOURCE:') + item.tag : this.language.instant('TYPES.EXTERNAL-DATASET-TYPE.NO-SOURCE'),
 					valueAssign: (item) => typeof (item) == 'string' ? item : JSON.stringify(item)
 				};
 				break;
@@ -188,14 +200,14 @@ export class FormFieldComponent extends BaseComponent implements OnInit {
 				this.datasetIdInitialized = true;
 				break;
 			case DatasetProfileFieldViewStyle.Currency:
-			this.currencyAutoCompleteConfiguration = {
-				filterFn: this.searchCurrency.bind(this),
-				initialItems: () => this.searchCurrency(''),
-				displayFn: (item) => typeof (item) == 'string' ? JSON.parse(item)['name'] : item.name,
-				titleFn: (item) => typeof (item) == 'string' ? JSON.parse(item)['name'] : item.name,
-				valueAssign: (item) => typeof (item) == 'string' ? item : JSON.stringify(item)
-			};
-			break;
+				this.currencyAutoCompleteConfiguration = {
+					filterFn: this.searchCurrency.bind(this),
+					initialItems: () => this.searchCurrency(''),
+					displayFn: (item) => typeof (item) == 'string' ? JSON.parse(item)['name'] : item.name,
+					titleFn: (item) => typeof (item) == 'string' ? JSON.parse(item)['name'] : item.name,
+					valueAssign: (item) => typeof (item) == 'string' ? item : JSON.stringify(item)
+				};
+				break;
 		}
 
 		if (this.form.get('viewStyle').value.renderStyle === DatasetProfileFieldViewStyle.InternalDmpEntities) {
diff --git a/dmp-frontend/src/assets/i18n/de.json b/dmp-frontend/src/assets/i18n/de.json
index 5c4c57a9c..7e6a0c4e5 100644
--- a/dmp-frontend/src/assets/i18n/de.json
+++ b/dmp-frontend/src/assets/i18n/de.json
@@ -334,7 +334,8 @@
 						"FIELD-DATE-PICKER-PLACEHOLDER": "Input Placeholder",
 						"FIELD-DATE-PICKER-LABEL": "Label",
 						"FIELD-DATE-PICKER-VALUE": "Value",
-						"FIELD-MULTIPLE-AUTOCOMPLETE": "Multiple Autocomplete"
+						"FIELD-MULTIPLE-AUTOCOMPLETE": "Multiple Autocomplete",
+						"FIELD-MULTIPLE-WORDLIST": "Multiple Selection"
 					},
 					"DEFAULT-VALUES": {
 						"NONE": "Keine",
diff --git a/dmp-frontend/src/assets/i18n/en.json b/dmp-frontend/src/assets/i18n/en.json
index cbe090e2d..1609c414e 100644
--- a/dmp-frontend/src/assets/i18n/en.json
+++ b/dmp-frontend/src/assets/i18n/en.json
@@ -354,7 +354,8 @@
 						"FIELD-DATE-PICKER-PLACEHOLDER": "Input Placeholder",
 						"FIELD-DATE-PICKER-LABEL": "Label",
 						"FIELD-DATE-PICKER-VALUE": "Value",
-						"FIELD-MULTIPLE-AUTOCOMPLETE": "Multiple Autocomplete"
+						"FIELD-MULTIPLE-AUTOCOMPLETE": "Multiple Autocomplete",
+						"FIELD-MULTIPLE-WORDLIST": "Multiple Selection"
 					},
 					"DEFAULT-VALUES": {
 						"NONE": "None",
diff --git a/dmp-frontend/src/assets/i18n/es.json b/dmp-frontend/src/assets/i18n/es.json
index aa2754232..bd589666c 100644
--- a/dmp-frontend/src/assets/i18n/es.json
+++ b/dmp-frontend/src/assets/i18n/es.json
@@ -354,7 +354,8 @@
 						"FIELD-DATE-PICKER-PLACEHOLDER": "Marcador de entrada",
 						"FIELD-DATE-PICKER-LABEL": "Etiqueta",
 						"FIELD-DATE-PICKER-VALUE": "Valor",
-						"FIELD-MULTIPLE-AUTOCOMPLETE": "Autocompeltado múltiple"
+						"FIELD-MULTIPLE-AUTOCOMPLETE": "Autocompeltado múltiple",
+						"FIELD-MULTIPLE-WORDLIST": "Multiple Selection"
 					},
 					"DEFAULT-VALUES": {
 						"NONE": "Ninguno",
diff --git a/dmp-frontend/src/assets/i18n/gr.json b/dmp-frontend/src/assets/i18n/gr.json
index 687714158..ee678ec31 100644
--- a/dmp-frontend/src/assets/i18n/gr.json
+++ b/dmp-frontend/src/assets/i18n/gr.json
@@ -351,7 +351,8 @@
 						"FIELD-DATE-PICKER-PLACEHOLDER": "Τοποθέτηση placeholder",
 						"FIELD-DATE-PICKER-LABEL": "Ετικέτα",
 						"FIELD-DATE-PICKER-VALUE": "Τιμή",
-						"FIELD-MULTIPLE-AUTOCOMPLETE": "Πολλαπλή Αυτόματη Συμπλήρωση"
+						"FIELD-MULTIPLE-AUTOCOMPLETE": "Πολλαπλή Αυτόματη Συμπλήρωση",
+						"FIELD-MULTIPLE-WORDLIST": "Multiple Selection"
 					},
 					"DEFAULT-VALUES": {
 						"NONE": "Κανένα",
diff --git a/dmp-frontend/src/assets/i18n/tr.json b/dmp-frontend/src/assets/i18n/tr.json
index 68222507f..5a426bcd2 100644
--- a/dmp-frontend/src/assets/i18n/tr.json
+++ b/dmp-frontend/src/assets/i18n/tr.json
@@ -351,7 +351,8 @@
 						"FIELD-DATE-PICKER-PLACEHOLDER": "Girdi Yer tutucu",
 						"FIELD-DATE-PICKER-LABEL": "Etiket",
 						"FIELD-DATE-PICKER-VALUE": "Değer",
-						"FIELD-MULTIPLE-AUTOCOMPLETE": "Çoklu Otomatik Tamamlama"
+						"FIELD-MULTIPLE-AUTOCOMPLETE": "Çoklu Otomatik Tamamlama",
+						"FIELD-MULTIPLE-WORDLIST": "Multiple Selection"
 					},
 					"DEFAULT-VALUES": {
 						"NONE": "Hiç",