From b8a391752296d443eb3f63193d91b4c5d9a6b406 Mon Sep 17 00:00:00 2001
From: annabakouli <annabakouli@gmail.com>
Date: Thu, 7 Dec 2017 15:36:12 +0200
Subject: [PATCH 1/2] no message

---
 dmp-frontend/src/app/app.component.ts         | 37 ------------------
 .../googgle-sign-in.component.html            |  2 +-
 .../googgle-sign-in.component.ts              | 38 +++++++++++++++++--
 .../main-sign-in/main-sign-in.component.ts    |  1 +
 4 files changed, 36 insertions(+), 42 deletions(-)

diff --git a/dmp-frontend/src/app/app.component.ts b/dmp-frontend/src/app/app.component.ts
index a18742d99..fb0b02d02 100644
--- a/dmp-frontend/src/app/app.component.ts
+++ b/dmp-frontend/src/app/app.component.ts
@@ -35,45 +35,8 @@ export class AppComponent implements OnInit {
   }
 
   ngOnInit() {
-    //this.initiateExternalProviders();
   }
 
-  initiateExternalProviders(){
-
-
-    //initiate google
-    var clientId = '1010962018903-glegmqudqtl1lub0150vacopbu06lgsg.apps.googleusercontent.com';
-    var scope = [
-      'profile',
-      'email'
-    ].join(' ');
-    
-    if(gapi.auth2 == undefined){
-    
-        gapi.load('auth2', () => {
-          
-          gapi.auth2.init({
-            client_id: clientId,
-            cookiepolicy: 'single_host_origin',
-            scope: scope
-          });
-          
-          
-    
-          //RE-Render the button (due to known issues of google-button with angular's lifecycle)
-          gapi.signin2.render('googleBtn');
-    
-          //var buttonElement = this.element.nativeElement.querySelector('#googleBtn'); 
-          //this.attachSignin(buttonElement);
-          
-        });
-    
-    }
-
-  }
-
-
-
   slideNav(){
 
     $("#appSidebar").toggleClass("expanded");
diff --git a/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.html b/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.html
index e84f17f92..b7e7cd8f9 100644
--- a/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.html
+++ b/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.html
@@ -2,7 +2,7 @@
 <table class="table">
     <tbody>
         <tr align="center">
-            <div class="g-signin2" id="googleBtn"></div>
+            <div  class="g-signin2" id="googleBtn"></div>
         </tr>
     </tbody>
 </table>
diff --git a/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.ts b/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.ts
index d0f2dca38..7b0f37c58 100644
--- a/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.ts
+++ b/dmp-frontend/src/app/login/googgle-sign-in/googgle-sign-in.component.ts
@@ -14,7 +14,7 @@ declare function simple_notifier(type: string, title: string, message:string): a
   templateUrl: './googgle-sign-in.component.html',
   styleUrls: ['./googgle-sign-in.component.css']
 })
-export class GooggleSignInComponent implements OnInit, AfterViewInit, Injectable {
+export class GooggleSignInComponent implements OnInit, Injectable {
 
   
 
@@ -22,17 +22,47 @@ export class GooggleSignInComponent implements OnInit, AfterViewInit, Injectable
     
   }
 
+  
   ngOnInit() {
+    this.initiateExternalProviders();
+  }
+
+  initiateExternalProviders(){
+
+    var clientId = '1010962018903-glegmqudqtl1lub0150vacopbu06lgsg.apps.googleusercontent.com';
+    var scope = [
+      'profile',
+      'email'
+    ].join(' ');
+    
+    if(gapi.auth2 == undefined){
+    
+        gapi.load('auth2', () => {
+          
+          gapi.auth2.init({
+            client_id: clientId,
+            cookiepolicy: 'single_host_origin',
+            scope: scope
+          }).then(()=>this.renderButton());
+          
+        });
+    
+    }else{
+      gapi.auth2.init({
+        client_id: clientId,
+        cookiepolicy: 'single_host_origin',
+        scope: scope
+      }).then(()=>this.renderButton());
+    }
 
   }
 
-  ngAfterViewInit() {
 
+  renderButton() {
 
-    //RE-Render the button (due to known issues of google-button with angular's lifecycle)
     gapi.signin2.render('googleBtn');
     var buttonElement = this.element.nativeElement.querySelector('#googleBtn'); 
-    this.attachSignin(buttonElement);
+    if(buttonElement)this.attachSignin(buttonElement);
     
   }
   
diff --git a/dmp-frontend/src/app/login/main-sign-in/main-sign-in.component.ts b/dmp-frontend/src/app/login/main-sign-in/main-sign-in.component.ts
index 31290388e..e1b5702cd 100644
--- a/dmp-frontend/src/app/login/main-sign-in/main-sign-in.component.ts
+++ b/dmp-frontend/src/app/login/main-sign-in/main-sign-in.component.ts
@@ -4,6 +4,7 @@ import { NativeLoginService } from '../../services/login/native-login.service';
 import { TokenService, TokenProvider } from '../../services/login/token.service';
 import {Router} from '@angular/router';
 import {MenuItem} from 'primeng/primeng';
+declare const gapi: any;
 
 import '../../../assets/custom.js';
 declare function simple_notifier(type: string, title: string, message:string): any;

From e04c90dd2bc60da19da8ffbbfec1084052a4d745 Mon Sep 17 00:00:00 2001
From: annampak <annampak@hotmail.com>
Date: Thu, 7 Dec 2017 15:44:17 +0200
Subject: [PATCH 2/2] minor fixes

---
 .../src/app/field-form/field-form.component.html      |  2 +-
 dmp-admin/src/app/field-form/field-form.component.ts  |  5 ++---
 dmp-admin/src/app/form/form.component.ts              | 11 +++++++----
 dmp-admin/src/app/models/Field.ts                     |  4 +++-
 dmp-admin/src/app/models/FieldGroup.ts                |  2 ++
 dmp-admin/src/app/models/Section.ts                   |  5 ++++-
 dmp-admin/src/app/rule-component/rule.component.ts    |  1 -
 7 files changed, 19 insertions(+), 11 deletions(-)

diff --git a/dmp-admin/src/app/field-form/field-form.component.html b/dmp-admin/src/app/field-form/field-form.component.html
index fefbca431..68d14ab9b 100644
--- a/dmp-admin/src/app/field-form/field-form.component.html
+++ b/dmp-admin/src/app/field-form/field-form.component.html
@@ -15,7 +15,7 @@
                         <label>View style</label>
                         <select class="form-control" formControlName="renderStyle">
                             <option value="textarea">textarea</option>
-                            <option value="booleanDesicion">booleanDesicion</option>
+                            <option value="booleanDecision">booleanDecision</option>
                             <option value='combobox'>combobox</option>
                             <option value="checkBox">checkBox</option>
                             <option value="freetext">freetext</option>
diff --git a/dmp-admin/src/app/field-form/field-form.component.ts b/dmp-admin/src/app/field-form/field-form.component.ts
index de0733025..a3f284556 100644
--- a/dmp-admin/src/app/field-form/field-form.component.ts
+++ b/dmp-admin/src/app/field-form/field-form.component.ts
@@ -16,10 +16,9 @@ export class FieldFormComponent {
 @Input() form: FormGroup;
 @Input() dataModel: Field;
 
-constructon(){}
+constructor(){}
 
-ngOnInit(){
-  console.log("init field")
+ngOnInit(){ 
  // this.addNewRule();
 }
 
diff --git a/dmp-admin/src/app/form/form.component.ts b/dmp-admin/src/app/form/form.component.ts
index 8b388d545..baafc21f8 100644
--- a/dmp-admin/src/app/form/form.component.ts
+++ b/dmp-admin/src/app/form/form.component.ts
@@ -59,14 +59,17 @@ export class FormComponent {
     (<FormArray>this.form.get("sections")).removeAt(index)
   }
 
-  updateForm(data) {
+  createForm(data) {
     return this.restBase.post("/admin/addDmp", data);
   }
-
+  updateForm(id,data) {
+    return this.restBase.post("/admin/addDmp/"+id, data);
+  }
   onSubmit() {
-    debugger;
     let data = this.form.value;
-    this.updateForm(data).subscribe();
+    
+    if(this.profileID) this.updateForm(this.profileID, data).subscribe();
+    else this.createForm(data).subscribe();
   }
 
 }
\ No newline at end of file
diff --git a/dmp-admin/src/app/models/Field.ts b/dmp-admin/src/app/models/Field.ts
index 9cd9767ed..4bc4eb2a6 100644
--- a/dmp-admin/src/app/models/Field.ts
+++ b/dmp-admin/src/app/models/Field.ts
@@ -34,7 +34,7 @@ export class Field extends BaseModel implements Serializable<Field>,FormGenerato
         this.defaultValue = new JsonSerializer<DefaultValue>().fromJSONObject(item.defaultValue, DefaultValue);
         this.description = item.description;
         this.extendedDescription = item.extendedDescription;
-        this.defaultVisibility = item.defaultVisibility;
+        this.defaultVisibility = item.defaultVisibility ? item.defaultVisibility : true;
         this.page = item.page;
         this.multiplicity =  new JsonSerializer<Multiplicity>().fromJSONObject(item.multiplicity, Multiplicity);
         this.ordinal = item.ordinal;
@@ -70,6 +70,8 @@ export class Field extends BaseModel implements Serializable<Field>,FormGenerato
         //formGroup.addControl("data",this.data? this.data.buildForm():this.formBuilder.group({}));
         if(this.data)formGroup.addControl("data",this.data.buildForm());
         
+        if( !formGroup.controls["defaultVisibility"].value) formGroup.controls["defaultVisibility"].setValue(true);
+
         return formGroup;
     }
 }
\ No newline at end of file
diff --git a/dmp-admin/src/app/models/FieldGroup.ts b/dmp-admin/src/app/models/FieldGroup.ts
index 2f7acac08..3ec538c2d 100644
--- a/dmp-admin/src/app/models/FieldGroup.ts
+++ b/dmp-admin/src/app/models/FieldGroup.ts
@@ -52,6 +52,8 @@ export class FieldGroup extends BaseModel implements Serializable<FieldGroup>, F
             })
         }
         formGroup.addControl('compositeFields', this.formBuilder.array(compositeFieldsFormArray));
+        
+        if( !formGroup.controls["defaultVisibility"].value) formGroup.controls["defaultVisibility"].setValue(true);
 
         return formGroup;
     }
diff --git a/dmp-admin/src/app/models/Section.ts b/dmp-admin/src/app/models/Section.ts
index 789e9f63d..96313363f 100644
--- a/dmp-admin/src/app/models/Section.ts
+++ b/dmp-admin/src/app/models/Section.ts
@@ -49,7 +49,10 @@ export class Section extends BaseModel implements Serializable<Section>, FormGen
         formGroup.addControl('id', new FormControl(this.id));
         formGroup.addControl('title', new FormControl(this.title));
         formGroup.addControl('description', new FormControl(this.description));      
-        formGroup.addControl('ordinal', new FormControl(this.ordinal));        
+        formGroup.addControl('ordinal', new FormControl(this.ordinal));       
+        
+        if( !formGroup.controls["defaultVisibility"].value) formGroup.controls["defaultVisibility"].setValue(true);
+        
         return formGroup;
     }
 }
\ No newline at end of file
diff --git a/dmp-admin/src/app/rule-component/rule.component.ts b/dmp-admin/src/app/rule-component/rule.component.ts
index b6c746321..251371c34 100644
--- a/dmp-admin/src/app/rule-component/rule.component.ts
+++ b/dmp-admin/src/app/rule-component/rule.component.ts
@@ -13,7 +13,6 @@ export class RuleFormComponent {
 @Input() dataModel: FormGroup;
 
 TargetValidation(){
-  debugger;
 }
 
 }
\ No newline at end of file