From 33c7676464b52d806c4fda89950c5c2f23c5796a Mon Sep 17 00:00:00 2001
From: Diamantis Tziotzios <tziotzios.diamantis@nbg.gr>
Date: Thu, 9 May 2024 10:47:34 +0300
Subject: [PATCH] small fixes

---
 .../components/form-field/form-field.component.ts   | 13 +++----------
 .../form-section/form-section.component.html        |  2 +-
 .../form-section/form-section.component.ts          |  2 +-
 3 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field/form-field.component.ts b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field/form-field.component.ts
index a904605f7..a4eed8824 100644
--- a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field/form-field.component.ts
+++ b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-field/form-field.component.ts
@@ -87,7 +87,8 @@ export class DescriptionFormFieldComponent extends BaseComponent implements OnIn
 		public dialog: MatDialog,
 		private fileUtils: FileUtils,
 		private referenceService: ReferenceService,
-		private storageFileService: StorageFileService
+		private storageFileService: StorageFileService,
+        private changeDetectorRef: ChangeDetectorRef
 	) {
 		super();
 	}
@@ -117,15 +118,6 @@ export class DescriptionFormFieldComponent extends BaseComponent implements OnIn
 		}
 	}
 
-	checkBoxChanged(event: MatCheckboxChange){
-		if (event.checked){
-			this.propertiesFormGroup?.get(this.field.id).get('textValue').setValue("true");
-		} else{
-			this.propertiesFormGroup?.get(this.field.id).get('textValue').setValue("false");
-		}
-		this.visibilityRulesService.reloadVisibility();
-	}
-
 	private applyFieldType(){
 		this.isRequired = this.field.validations?.includes(DescriptionTemplateFieldValidationType.Required);
 
@@ -287,6 +279,7 @@ export class DescriptionFormFieldComponent extends BaseComponent implements OnIn
 	private createFileNameDisplay(name: string, extension: string){
 		if (extension.startsWith('.')) this.fileNameDisplay = name + extension;
 		else this.fileNameDisplay = name + '.' + extension;
+		this.changeDetectorRef.markForCheck();
 	}
 
 
diff --git a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.html b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.html
index 11d7a32fe..f8b89731b 100644
--- a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.html
+++ b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.html
@@ -33,7 +33,7 @@
 			<div *ngIf="section?.sections?.length > 0" class="col-12">
 				<ng-container *ngFor="let innerSection of section.sections; let j = index;">
 					<div class="row" *ngIf="visibilityRulesService.isVisibleMap[innerSection.id]">
-						<app-description-form-section class="col-12" [section]="innerSection" [canReview]="canReview" [path]="path+'.'+(j+1)" [pathName]="pathName+'.sections.'+j" (askedToScroll)="onAskedToScroll($event)" [propertiesFormGroup]="propertiesFormGroup" [descriptionId]="descriptionId" [visibilityRulesService]="visibilityRulesService" [linkToScroll]="subsectionLinkToScroll"></app-description-form-section>
+						<app-description-form-section class="col-12" [section]="innerSection" [canReview]="canReview" [path]="path+'.'+(j+1)" [pathName]="pathName+'.sections.'+j" (askedToScroll)="onAskedToScroll(null, $event)" [propertiesFormGroup]="propertiesFormGroup" [descriptionId]="descriptionId" [visibilityRulesService]="visibilityRulesService" [linkToScroll]="subsectionLinkToScroll"></app-description-form-section>
 					</div>
 				</ng-container>
 			</div>
diff --git a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.ts b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.ts
index 135098f79..72ae9989c 100644
--- a/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.ts
+++ b/dmp-frontend/src/app/ui/description/editor/description-form/components/form-section/form-section.component.ts
@@ -70,7 +70,7 @@ export class DescriptionFormSectionComponent extends BaseComponent implements On
 	}
 
 	onAskedToScroll(event:MouseEvent, id: string) {
-		event.stopPropagation();
+		event?.stopPropagation();
 		this.panelExpanded = true;
 		this.askedToScroll.emit(id);
 	}