From 2146c564b7c3e3ea157011e911a6bc2cae06c483 Mon Sep 17 00:00:00 2001
From: mchouliara <mchouliara@cite.gr>
Date: Wed, 18 Sep 2024 09:45:31 +0300
Subject: [PATCH] add titles to iframes, keep one h1 in app and switch headings
 to similarly styled divs

---
 frontend/src/app/ui/about/about.component.html     |  2 +-
 .../user-invite-to-tenant-dialog.component.html    |  2 +-
 .../contact-content/contact-content.component.html |  2 +-
 .../contact-content/contact-content.component.scss |  3 ++-
 .../ui/faq/faq-content/faq-content.component.html  |  2 +-
 .../glossary-content.component.html                |  2 +-
 frontend/src/app/ui/navbar/navbar.component.html   | 14 ++++++++------
 .../dialog/plan-invitation-dialog.component.html   |  2 +-
 .../start-new-plan-dialog.component.html           |  2 +-
 .../cookies-policy/cookies-policy.component.html   |  2 +-
 .../opensource-licences.component.html             |  2 +-
 .../opensource-licences.component.scss             |  3 ++-
 .../sidebar-footer/privacy/privacy.component.html  |  2 +-
 .../sidebar-footer/privacy/privacy.component.scss  |  3 ++-
 .../sidebar-footer/terms/terms.component.html      |  2 +-
 .../user-guide-content.component.html              |  4 ++--
 .../user-guide-content.component.scss              |  3 ++-
 17 files changed, 29 insertions(+), 23 deletions(-)

diff --git a/frontend/src/app/ui/about/about.component.html b/frontend/src/app/ui/about/about.component.html
index f51042fc1..0ecc1e083 100644
--- a/frontend/src/app/ui/about/about.component.html
+++ b/frontend/src/app/ui/about/about.component.html
@@ -1,5 +1,5 @@
 <div class="container-fluid">
 	<div class="row">
-		<iframe *ngIf="aboutHTMLUrl" class="iframe" [src]="aboutHTMLUrl"></iframe>
+		<iframe *ngIf="aboutHTMLUrl" title="about" class="iframe" [src]="aboutHTMLUrl"></iframe>
 	</div>
 </div>
\ No newline at end of file
diff --git a/frontend/src/app/ui/admin/user/listing/user-invite-to-tenant-dialog/user-invite-to-tenant-dialog.component.html b/frontend/src/app/ui/admin/user/listing/user-invite-to-tenant-dialog/user-invite-to-tenant-dialog.component.html
index 56f7eb069..ba7699a1d 100644
--- a/frontend/src/app/ui/admin/user/listing/user-invite-to-tenant-dialog/user-invite-to-tenant-dialog.component.html
+++ b/frontend/src/app/ui/admin/user/listing/user-invite-to-tenant-dialog/user-invite-to-tenant-dialog.component.html
@@ -1,7 +1,7 @@
 <div class="user-invite-to-tenant-dialog container-fluid" *ngIf="formGroup">
 	<div class="row align-items-center">
 		<div class="col">
-			<h1 class="title">{{'USER-INVITE-TO-TENANT-DIALOG.TITLE' | translate}}</h1>
+			<div class="title">{{'USER-INVITE-TO-TENANT-DIALOG.TITLE' | translate}}</div>
 		</div>
 		<div class="col-auto">
 			<button mat-icon-button (click)="closeDialog()"><mat-icon>close</mat-icon></button>
diff --git a/frontend/src/app/ui/contact/contact-content/contact-content.component.html b/frontend/src/app/ui/contact/contact-content/contact-content.component.html
index 7089021b2..0d3c4b00b 100644
--- a/frontend/src/app/ui/contact/contact-content/contact-content.component.html
+++ b/frontend/src/app/ui/contact/contact-content/contact-content.component.html
@@ -2,7 +2,7 @@
 	<div [ngClass]="{'container contact-component': !isDialog}">
 		<div *ngIf="!isDialog" class="row">
 			<div class="col-md-12">
-				<h1>{{ 'CONTACT.SUPPORT.TITLE' | translate}}</h1>
+				<div class="title">{{ 'CONTACT.SUPPORT.TITLE' | translate}}</div>
 			</div>
 		</div>
 		<div [ngClass]="{'contact-container': !isDialog}" class="row">
diff --git a/frontend/src/app/ui/contact/contact-content/contact-content.component.scss b/frontend/src/app/ui/contact/contact-content/contact-content.component.scss
index c696eb3ec..e99210458 100644
--- a/frontend/src/app/ui/contact/contact-content/contact-content.component.scss
+++ b/frontend/src/app/ui/contact/contact-content/contact-content.component.scss
@@ -1,6 +1,7 @@
-h1 {
+.title {
   text-align: center;
   margin: 2rem 0 1rem 0;
+  font-size: 3.3125rem;
 }
 
 img {
diff --git a/frontend/src/app/ui/faq/faq-content/faq-content.component.html b/frontend/src/app/ui/faq/faq-content/faq-content.component.html
index 30a3fd8fe..959704525 100644
--- a/frontend/src/app/ui/faq/faq-content/faq-content.component.html
+++ b/frontend/src/app/ui/faq/faq-content/faq-content.component.html
@@ -1,7 +1,7 @@
 <div class="container-fluid">
 	<div class="row">
 		<div class="col-12 pr-0">
-			<iframe *ngIf="faqHTMLUrl" class="iframe" [src]="faqHTMLUrl"></iframe>
+			<iframe *ngIf="faqHTMLUrl" title="FAQ content" class="iframe" [src]="faqHTMLUrl"></iframe>
 		</div>
 	</div>
 </div>
\ No newline at end of file
diff --git a/frontend/src/app/ui/glossary/glossary-content/glossary-content.component.html b/frontend/src/app/ui/glossary/glossary-content/glossary-content.component.html
index 0d965191d..80f8d7da8 100644
--- a/frontend/src/app/ui/glossary/glossary-content/glossary-content.component.html
+++ b/frontend/src/app/ui/glossary/glossary-content/glossary-content.component.html
@@ -1,5 +1,5 @@
 <div class="container-fluid">
 	<div class="row">
-		<iframe *ngIf="glossaryHTMLUrl" class="iframe" [src]="glossaryHTMLUrl"></iframe>
+		<iframe *ngIf="glossaryHTMLUrl" class="iframe" title="glossary content" [src]="glossaryHTMLUrl"></iframe>
 	</div>
 </div>
\ No newline at end of file
diff --git a/frontend/src/app/ui/navbar/navbar.component.html b/frontend/src/app/ui/navbar/navbar.component.html
index 0ba841c5e..90707c0c0 100644
--- a/frontend/src/app/ui/navbar/navbar.component.html
+++ b/frontend/src/app/ui/navbar/navbar.component.html
@@ -1,14 +1,16 @@
 <ng-container>
 	<nav class="navbar navbar-expand-lg fixed-navbar">
 		<div class="container-fluid h-100">
-            <button class="hamburger change" id="hamburger" (click)="toggleMyNav($event)" title="hide or show navigation sidebar">
+            <button class="hamburger change" id="hamburger" (click)="toggleMyNav($event)" aria-label="hide or show navigation sidebar">
                 <div class="icon-bar1"></div>
                 <div class="icon-bar2"></div>
                 <div class="icon-bar3"></div>
             </button>
-            <a class="logo mr-auto" [routerLink]="routerUtils.generateUrl(['home'])">
-                <img class="logo-image" alt="go to homepage" [src]="'../../../assets/images/nav-logo' + configurationService.navLogoExtension">
-            </a>
+            <h1 class="logo mr-auto" >
+                <a [routerLink]="routerUtils.generateUrl(['home'])">
+                    <img class="logo-image" alt="go to homepage" [src]="'../../../assets/images/nav-logo' + configurationService.navLogoExtension">
+                </a>
+            </h1>
             @if(extraImageURL){
                 <a class="extra-logo" [routerLink]="routerUtils.generateUrl(['home'])" aria-label="home">
                     <img alt="logo image" class="extra-logo-image" [src]="extraImageURL">
@@ -40,7 +42,7 @@
 				<li class="navbar-item-lg" *ngIf="isAuthenticated()">
 					<button mat-button [matMenuTriggerFor]="tenantMenu" class="p-0 lang" aria-label="tenants">
 						<mat-icon class="m-0 material-symbols-outlined">tenancy</mat-icon>
-						<mat-icon class="m-0">arrow_drop_down</mat-icon>
+						<mat-icon class="m-0" aria-hidden>arrow_drop_down</mat-icon>
 					</button>
 					<mat-menu #tenantMenu="matMenu" class="nav-mat-menu">
 						<app-tenant-switch class="d-lg-block d-none"></app-tenant-switch>
@@ -51,7 +53,7 @@
 						<app-language (languageChange)="getLanguage($event)"></app-language>
 					</mat-menu>
 					<button mat-icon-button matTooltip="{{'NAV-BAR.INAPP-NOTIFICATIONS' | translate}}" (click)="toggleInAppNotifications()" aria-label="notifications">
-						<mat-icon aria-hidden="true" [matBadge]="inAppNotificationCount" [matBadgeHidden]="inAppNotificationCount <= 0" matBadgeColor="warn">mail</mat-icon>
+						<mat-icon aria-hidden [matBadge]="inAppNotificationCount" [matBadgeHidden]="inAppNotificationCount <= 0" matBadgeColor="warn">mail</mat-icon>
 					</button>
 				</li>
 
diff --git a/frontend/src/app/ui/plan/invitation/dialog/plan-invitation-dialog.component.html b/frontend/src/app/ui/plan/invitation/dialog/plan-invitation-dialog.component.html
index d81741f97..0112e1404 100644
--- a/frontend/src/app/ui/plan/invitation/dialog/plan-invitation-dialog.component.html
+++ b/frontend/src/app/ui/plan/invitation/dialog/plan-invitation-dialog.component.html
@@ -1,7 +1,7 @@
 <div class="plan-invitation-dialog container-fluid" *ngIf="formGroup">
 	<div class="row align-items-center">
 		<div class="col">
-			<h1 class="title">{{'PLAN-USER-INVITATION-DIALOG.TITLE' | translate}}</h1>
+			<div class="title">{{'PLAN-USER-INVITATION-DIALOG.TITLE' | translate}}</div>
 		</div>
 		<div class="col-auto">
 			<button mat-icon-button (click)="closeDialog()"><mat-icon>close</mat-icon></button>
diff --git a/frontend/src/app/ui/plan/new/start-new-plan-dialogue/start-new-plan-dialog.component.html b/frontend/src/app/ui/plan/new/start-new-plan-dialogue/start-new-plan-dialog.component.html
index 0b20d774d..46e1dd79a 100644
--- a/frontend/src/app/ui/plan/new/start-new-plan-dialogue/start-new-plan-dialog.component.html
+++ b/frontend/src/app/ui/plan/new/start-new-plan-dialogue/start-new-plan-dialog.component.html
@@ -8,7 +8,7 @@
 
 	<div class="content">
 		<div class="col-12 p-0">
-			<h1 class="title p-0">{{'START-NEW-PLAN-DIALOG.TITLE' | translate}}</h1>
+			<div class="title p-0">{{'START-NEW-PLAN-DIALOG.TITLE' | translate}}</div>
 		</div>
 		<div class="col-12 p-0">
 			<p class="text">{{'START-NEW-PLAN-DIALOG.MESSAGE' | translate}}</p>
diff --git a/frontend/src/app/ui/sidebar/sidebar-footer/cookies-policy/cookies-policy.component.html b/frontend/src/app/ui/sidebar/sidebar-footer/cookies-policy/cookies-policy.component.html
index a07814c46..e09aab5cf 100644
--- a/frontend/src/app/ui/sidebar/sidebar-footer/cookies-policy/cookies-policy.component.html
+++ b/frontend/src/app/ui/sidebar/sidebar-footer/cookies-policy/cookies-policy.component.html
@@ -1,5 +1,5 @@
 <div class="container-fluid">
 	<div class="row">
-		<iframe *ngIf="cookiePolicyHTMLUrl" class="iframe" [src]="cookiePolicyHTMLUrl"></iframe>
+		<iframe *ngIf="cookiePolicyHTMLUrl" class="iframe" title="cookie policy" [src]="cookiePolicyHTMLUrl"></iframe>
 	</div>
 </div>
\ No newline at end of file
diff --git a/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.html b/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.html
index 3ee148b85..9f6cfedd4 100644
--- a/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.html
+++ b/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.html
@@ -1,7 +1,7 @@
 <div class="container terms-component">
 	<div class="row">
 		<div class="col-md-12">
-			<h1>{{ 'OPENSOURCE-LICENCES.TITLE' | translate}}</h1>
+			<div class="title">{{ 'OPENSOURCE-LICENCES.TITLE' | translate}}</div>
 		</div>
 	</div>
 	<div class="row">
diff --git a/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.scss b/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.scss
index 8ceabd898..2af95927e 100644
--- a/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.scss
+++ b/frontend/src/app/ui/sidebar/sidebar-footer/opensource-licences/opensource-licences.component.scss
@@ -1,6 +1,7 @@
-h1 {
+.title {
 	text-align: center;
 	margin: 2rem 0 1rem 0;
+    font-size: 3.3125rem;
 }
 
 h4 {
diff --git a/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.html b/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.html
index 89e52c053..2d5bf3f31 100644
--- a/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.html
+++ b/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.html
@@ -1,7 +1,7 @@
 <div class="container privacy-component">
 	<div class="row">
 		<div class="col-md-12">
-			<h1>{{ 'PRIVACY-POLICY.TITLE' | translate}}</h1>
+			<div class="title">{{ 'PRIVACY-POLICY.TITLE' | translate}}</div>
 		</div>
 	</div>
 	<div class="row">
diff --git a/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.scss b/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.scss
index 9b960ac31..b1e70a10e 100644
--- a/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.scss
+++ b/frontend/src/app/ui/sidebar/sidebar-footer/privacy/privacy.component.scss
@@ -1,5 +1,6 @@
-h1 {
+.title {
 	text-align: center;
+    font-size: 3.3125rem;
 }
 
 img {
diff --git a/frontend/src/app/ui/sidebar/sidebar-footer/terms/terms.component.html b/frontend/src/app/ui/sidebar/sidebar-footer/terms/terms.component.html
index 45cef287f..eeeaddee7 100644
--- a/frontend/src/app/ui/sidebar/sidebar-footer/terms/terms.component.html
+++ b/frontend/src/app/ui/sidebar/sidebar-footer/terms/terms.component.html
@@ -1,5 +1,5 @@
 <div class="container-fluid">
 	<div class="row">
-		<iframe *ngIf="termsHTMLUrl" class="iframe" [src]="termsHTMLUrl"></iframe>
+		<iframe *ngIf="termsHTMLUrl" class="iframe" title="terms of service" [src]="termsHTMLUrl"></iframe>
 	</div>
 </div>
\ No newline at end of file
diff --git a/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.html b/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.html
index b0cd50905..f2314f085 100644
--- a/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.html
+++ b/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.html
@@ -1,11 +1,11 @@
 <div class="container-fluid">
     <div *ngIf="!isDialog" class="row">
         <div class="col-md-12">
-            <h1>{{ 'GUIDE.TITLE' | translate}}</h1>
+            <div class="title">{{ 'GUIDE.TITLE' | translate}}</div>
         </div>
     </div>
 	<div class="row">
-		<iframe *ngIf="!useInnerHTML && guideHTMLUrl" class="iframe" id='userguide' [src]="guideHTMLUrl" (load)="onIFrameLoad(iframe)" #iframe></iframe>
+		<iframe *ngIf="!useInnerHTML && guideHTMLUrl" class="iframe" id='userguide' [src]="guideHTMLUrl" title="user guide" (load)="onIFrameLoad(iframe)" #iframe></iframe>
 		<span #guide *ngIf="useInnerHTML" id='userguide' [innerHTML]="guideHTML"></span>
 	</div>
 </div>
diff --git a/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.scss b/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.scss
index d556cc369..c7b2071bb 100644
--- a/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.scss
+++ b/frontend/src/app/ui/user-guide/user-guide-content/user-guide-content.component.scss
@@ -17,7 +17,8 @@
 	cursor: pointer !important;
 }
 
-h1 {
+.title {
     text-align: center;
     margin: 2rem 0 0 0;
+    font-size: 3.3125rem;
 }
\ No newline at end of file