From 0d0e23d2405200a482a3d703a3f7d7fc36445e15 Mon Sep 17 00:00:00 2001
From: Sofia Papacharalampous <spapacharalampous@cite.gr>
Date: Wed, 1 May 2024 17:22:57 +0300
Subject: [PATCH] fixed description template type editor on finalized status

---
 .../description-template-type-editor.component.ts      | 10 ++++++++--
 .../description-template-type-listing.component.html   |  2 +-
 .../description-template-type-listing.component.ts     |  5 +++++
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/dmp-frontend/src/app/ui/admin/description-types/editor/description-template-type-editor.component.ts b/dmp-frontend/src/app/ui/admin/description-types/editor/description-template-type-editor.component.ts
index 997893d75..71ca5adbe 100644
--- a/dmp-frontend/src/app/ui/admin/description-types/editor/description-template-type-editor.component.ts
+++ b/dmp-frontend/src/app/ui/admin/description-types/editor/description-template-type-editor.component.ts
@@ -37,6 +37,7 @@ export class DescriptionTemplateTypeEditorComponent extends BaseEditor<Descripti
 
 	isNew = true;
 	isDeleted = false;
+	isFinalized = false;
 	formGroup: UntypedFormGroup = null;
 	showInactiveDetails = false;
 
@@ -46,11 +47,11 @@ export class DescriptionTemplateTypeEditorComponent extends BaseEditor<Descripti
 	}
 
 	protected get canSave(): boolean {
-		return !this.isDeleted && this.hasPermission(this.authService.permissionEnum.EditDescriptionTemplateType) && this.editorModel.belongsToCurrentTenant != false;
+		return !this.isDeleted && !this.isFinalized && this.hasPermission(this.authService.permissionEnum.EditDescriptionTemplateType) && this.editorModel.belongsToCurrentTenant != false;
 	}
 
 	protected get canFinalize(): boolean {
-		return !this.isDeleted && this.hasPermission(this.authService.permissionEnum.EditDescriptionTemplateType) && this.editorModel.belongsToCurrentTenant != false;
+		return !this.isDeleted && !this.isFinalized && this.hasPermission(this.authService.permissionEnum.EditDescriptionTemplateType) && this.editorModel.belongsToCurrentTenant != false;
 	}
 
 
@@ -99,6 +100,7 @@ export class DescriptionTemplateTypeEditorComponent extends BaseEditor<Descripti
 		try {
 			this.editorModel = data ? new DescriptionTemplateTypeEditorModel().fromModel(data) : new DescriptionTemplateTypeEditorModel();
 			this.isDeleted = data ? data.isActive === IsActive.Inactive : false;
+			this.isFinalized = data ? data.status === DescriptionTemplateTypeStatus.Finalized : false;
 			this.buildForm();
 		} catch (error) {
 			this.logger.error('Could not parse descriptionTemplateType item: ' + data + error);
@@ -109,6 +111,10 @@ export class DescriptionTemplateTypeEditorComponent extends BaseEditor<Descripti
 	buildForm() {
 		this.formGroup = this.editorModel.buildForm(null, this.isDeleted || !this.authService.hasPermission(AppPermission.EditDescriptionTemplateType));
 		this.descriptionTemplateTypeEditorService.setValidationErrorModel(this.editorModel.validationErrorModel);
+
+		if (this.isFinalized) {
+			this.formGroup.disable();
+		}
 	}
 
 	refreshData(): void {
diff --git a/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.html b/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.html
index 6ab99b102..7bc8cb476 100644
--- a/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.html
+++ b/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.html
@@ -95,7 +95,7 @@
 				<mat-icon>more_horiz</mat-icon>
 			</button>
 			<mat-menu #actionsMenu="matMenu">
-				<button mat-menu-item [routerLink]="['/description-template-type/' + row.id]">
+				<button *ngIf="!isFinalized(row)" mat-menu-item [routerLink]="['/description-template-type/' + row.id]">
 					<mat-icon>edit</mat-icon>{{'DESCRIPTION-TEMPLATE-TYPE-LISTING.ACTIONS.EDIT' | translate}}
 				</button>
 				<button  *ngIf="row.belongsToCurrentTenant != false"  mat-menu-item (click)="deleteType(row.id)">
diff --git a/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.ts b/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.ts
index 198818fa2..ad5207428 100644
--- a/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.ts
+++ b/dmp-frontend/src/app/ui/admin/description-types/listing/description-template-type-listing.component.ts
@@ -130,6 +130,11 @@ export class DescriptionTemplateTypeListingComponent extends BaseListingComponen
 	//
 	// Listing Component functions
 	//
+
+	isFinalized(item: DescriptionTemplateType): boolean {
+		return item.status === DescriptionTemplateTypeStatus.Finalized
+	}
+
 	onColumnsChanged(event: ColumnsChangedEvent) {
 		super.onColumnsChanged(event);
 		this.onColumnsChangedInternal(event.properties.map(x => x.toString()));