From 3e8ed4f50429dad8a3426512709ae5b586b7ef02 Mon Sep 17 00:00:00 2001
From: Alex Martzios <alexandros.martzios@gmail.com>
Date: Thu, 29 Feb 2024 11:33:17 +0200
Subject: [PATCH] [develop | DONE | CHANGED] remove tooltips from search page,
 add labels for entity metadata

---
 .../landing-utils/availableOn.component.ts    |  2 +-
 .../entity-metadata.component.ts              | 29 ++++++++++---------
 .../landing-utils/showPublisher.component.ts  |  6 ++--
 .../entity-actions.component.ts               | 13 ++++-----
 .../result-preview.component.html             |  6 ++--
 5 files changed, 30 insertions(+), 26 deletions(-)

diff --git a/landingPages/landing-utils/availableOn.component.ts b/landingPages/landing-utils/availableOn.component.ts
index 1ea5740d..85fef1ea 100644
--- a/landingPages/landing-utils/availableOn.component.ts
+++ b/landingPages/landing-utils/availableOn.component.ts
@@ -40,7 +40,7 @@ import {RouterHelper} from "../../utils/routerHelper.class";
                 <icon [name]="availableOn[0].accessRightIcon" [flex]="true" [ratio]="(isMobile && usedBy == 'landing') ? 1 : 0.8"></icon>
               </span>
               <ng-container *ngIf="!isMobile">
-                <a uk-tooltip="Source" target="_blank"
+                <a target="_blank"
                   class="uk-flex uk-flex-middle uk-flex-center uk-button-link uk-text-bolder">
                   <span>{{sliceString(availableOn[0].downloadNames.join("; "), 20)}}</span>
                   <span>
diff --git a/landingPages/landing-utils/entity-metadata.component.ts b/landingPages/landing-utils/entity-metadata.component.ts
index d9e0cf98..0378f127 100644
--- a/landingPages/landing-utils/entity-metadata.component.ts
+++ b/landingPages/landing-utils/entity-metadata.component.ts
@@ -118,8 +118,9 @@ import {RouterHelper} from "../../utils/routerHelper.class";
       <showPublisher *ngIf="publisher || journal" [publisher]="publisher" [journal]="journal"
                      [properties]="properties"></showPublisher>
       <!-- data provider labels -->
-      <ng-container *ngIf="compatibility && !(compatibility.info == 'not available' && type == 'service')">
-        <span uk-tooltip title="Compatibility">
+      <span *ngIf="compatibility && !(compatibility.info == 'not available' && type == 'service')">
+        <span class="uk-text-meta uk-margin-xsmall-right">Compatibility:</span>
+        <span>
           <a *ngIf="compatibility.id"
              [queryParams]="addEoscPrevInParams({datasourceId: compatibility.id})" routerLinkActive="router-link-active"
              [routerLink]="properties.searchLinkToDataProvider.split('?')[0]">
@@ -137,10 +138,11 @@ import {RouterHelper} from "../../utils/routerHelper.class";
             {{compatibility.name}}
           </span>
         </span>
-      </ng-container>
-      <ng-container *ngIf="compatibilityString">
-        <span uk-tooltip title="Compatibility">{{compatibilityString}}</span>
-      </ng-container>
+      </span>
+      <span *ngIf="compatibilityString">
+        <span class="uk-text-meta uk-margin-xsmall-right">Compatibility:</span>
+        <span>{{compatibilityString}}</span>
+      </span>
       <ng-container
           *ngIf="aggregationStatus && aggregationStatus.fulltexts && aggregationStatus.fulltexts > 0">
         <span>OpenAIRE Text Mining</span>
@@ -152,9 +154,9 @@ import {RouterHelper} from "../../utils/routerHelper.class";
         <span>Publicly funded</span>
       </ng-container>
       <!-- Projects -->
-      <span *ngIf="projects && projects.length > 0"
-        [attr.uk-tooltip]="projects.length > projectsLimit ? 'cls: uk-invisible' : 'pos: top; cls: uk-active'" title="Funded by">
-        {{showInline ? projectNames.join(', ') : projectNames.slice(0, projectsLimit).join(', ')}}
+      <span *ngIf="projects && projects.length > 0">
+        <span class="uk-text-meta uk-margin-xsmall-right">Funded by:</span>
+        <span>{{showInline ? projectNames.join(', ') : projectNames.slice(0, projectsLimit).join(', ')}}</span>
         <span *ngIf="projects.length > projectsLimit">
           <a *ngIf="!showInline" (click)="viewAllProjectsClick();" class="uk-background-muted custom-extra-entities">
             +{{projects.length - projectsLimit | number}} projects
@@ -166,9 +168,9 @@ import {RouterHelper} from "../../utils/routerHelper.class";
         </span>
       </span>
       <!-- Organizations -->
-      <span *ngIf="organizations && organizations.length > 0"
-        [attr.uk-tooltip]="organizations.length > organizationsLimit ? 'cls: uk-invisible' : 'pos: top; cls: uk-active'" title="Partners">
-        {{showInline ? organizationNames.join(', ') : organizationNames.slice(0, organizationsLimit).join(', ')}}
+      <span *ngIf="organizations && organizations.length > 0">
+        <span class="uk-text-meta uk-margin-xsmall-right">Partners:</span>
+        <span>{{showInline ? organizationNames.join(', ') : organizationNames.slice(0, organizationsLimit).join(', ')}}</span>
         <span *ngIf="organizations.length > organizationsLimit">
           <a *ngIf="!showInline" (click)="viewAllPartnersClick();" class="uk-background-muted custom-extra-entities">
             +{{organizations.length - organizationsLimit | number}} partners
@@ -180,9 +182,10 @@ import {RouterHelper} from "../../utils/routerHelper.class";
         </span>
       </span>
       <!-- Subjects -->
-      <span uk-tooltip="Subjects" *ngIf="subjects && subjects.length > 0" [class.truncated]="subjects.length > 3">
+      <span *ngIf="subjects && subjects.length > 0" [class.truncated]="subjects.length > 3">
         {{subjects.slice(0, 3).join(', ')}}
       </span>
+      <!-- For tabs in landing -->
       <ng-container *ngIf="provenanceAction">
         <span>{{provenanceAction}}</span>
       </ng-container>
diff --git a/landingPages/landing-utils/showPublisher.component.ts b/landingPages/landing-utils/showPublisher.component.ts
index 37c0838b..bbb8c177 100644
--- a/landingPages/landing-utils/showPublisher.component.ts
+++ b/landingPages/landing-utils/showPublisher.component.ts
@@ -5,7 +5,8 @@ import {EnvProperties} from "../../utils/properties/env-properties";
   selector: 'showPublisher, [showPublisher]',
   template: `
     <ng-container *ngIf="publisher">
-      <span [attr.uk-tooltip]="'cls: uk-active'" [title]="'Publisher'">{{publisher}}</span>
+      <span class="uk-text-meta uk-margin-xsmall-right">Publisher:</span>
+      <span>{{publisher}}</span>
       <span *ngIf="journal && (journal['journal'] || journal['issn'] || journal['lissn']
         || journal['volume'] || journal['eissn'] || journal['issue'])" 
         class="uk-margin-xsmall-left uk-margin-xsmall-right bullet"></span>
@@ -14,7 +15,8 @@ import {EnvProperties} from "../../utils/properties/env-properties";
 			|| journal['volume'] || journal['eissn'] || journal['issue'])">
 			<ng-container *ngIf="journal && (journal['journal'] || journal['issn'] || journal['lissn']
 				|| journal['volume'] || journal['eissn'] || journal['issue'])">
-				<span [attr.uk-tooltip]="'cls: uk-active'" [title]="'Journal'">
+				<span>
+          <span class="uk-text-meta uk-margin-xsmall-right">Journal:</span>
 					<span *ngIf="journal['journal']">{{journal['journal']}}</span>
 					<span *ngIf="journal['journal'] && (journal['volume'] || journal['issue'])">, </span>
 					<ng-container *ngIf="journal['volume']">
diff --git a/utils/entity-actions/entity-actions.component.ts b/utils/entity-actions/entity-actions.component.ts
index f2e07c77..bf2c628a 100644
--- a/utils/entity-actions/entity-actions.component.ts
+++ b/utils/entity-actions/entity-actions.component.ts
@@ -14,8 +14,7 @@ import {EnvProperties} from "../properties/env-properties";
       <div *ngIf="linking && isRouteAvailable('participate/direct-claim')">
         <a [queryParams]="routerHelper.createQueryParams(['id','type','linkTo'], [id,type,linkTo])"
           routerLinkActive="router-link-active" routerLink="/participate/direct-claim"
-          [title]="'Link '+openaireEntities.RESULTS+' with a '+openaireEntities.PROJECT+', a '+openaireEntities.COMMUNITY+' or other '+openaireEntities.RESULTS+' and make the new information available in OpenAIRE information space.'"
-          [attr.uk-tooltip]="'pos: bottom; cls: uk-active  uk-text-small uk-padding-small uk-width-medium'"
+          [attr.uk-tooltip]="showTooltip ? 'title: Link '+openaireEntities.RESULTS+' with a '+openaireEntities.PROJECT+', a '+openaireEntities.COMMUNITY+' or other '+openaireEntities.RESULTS+' and make the new information available in OpenAIRE information space.; pos: bottom; cls: uk-active uk-text-small uk-padding-small uk-width-medium' : 'cls: uk-invisible'"
           class="uk-flex uk-flex-middle uk-button-link" [ngClass]="isMobile ? 'uk-margin-left uk-margin-xsmall-bottom' : 'uk-text-bolder uk-flex-center'">
           <icon [flex]="true" [ratio]="0.7" name="link_to" visuallyHidden="link"></icon>
           <span class="uk-margin-xsmall-left">Link to</span>
@@ -23,8 +22,7 @@ import {EnvProperties} from "../properties/env-properties";
       </div>
       <div *ngIf="share">
         <a (click)="openAddThisModal()"
-           [title]="'Share this '+getTypeName() + ' in your social networks'"
-           [attr.uk-tooltip]="'pos: right; cls: uk-active  uk-text-small uk-padding-small'"
+          [attr.uk-tooltip]="showTooltip ? 'title: Share this '+getTypeName()+' in your social networks; pos: bottom; cls: uk-active  uk-text-small uk-padding-small' : 'cls: uk-invisible'"
           class="uk-flex uk-flex-middle uk-button-link" [ngClass]="isMobile ? 'uk-margin-left uk-margin-xsmall-bottom' : 'uk-text-bolder uk-flex-center'">
           <icon class="uk-text-bolder" [flex]="true" [ratio]="0.8" name="share" visuallyHidden="share"></icon>
           <span class="uk-margin-xsmall-left">Share</span>
@@ -39,8 +37,7 @@ import {EnvProperties} from "../properties/env-properties";
       </div>
       <div *ngIf="deposit && isRouteAvailable('participate/deposit/learn-how')">
         <a routerLinkActive="router-link-active" routerLink="/participate/deposit/learn-how"
-          [title]="'Find a repository to deposit or publish your research in Open Access'"
-          [attr.uk-tooltip]="'pos: bottom; cls: uk-active  uk-text-small uk-padding-small uk-width-medium'"
+          [attr.uk-tooltip]="showTooltip ? 'title: Find a repository to deposit or publish your research in Open Access; pos: bottom; cls: uk-active  uk-text-small uk-padding-small uk-width-medium' : 'cls: uk-invisible'"
           class="uk-flex uk-flex-middle uk-button-link" [ngClass]="isMobile ? 'uk-margin-left uk-margin-xsmall-bottom' : 'uk-text-bolder uk-flex-center'">
           <icon flex="true" ratio="0.7" name="upload" visuallyHidden="upload"></icon>
           <span class="uk-margin-xsmall-left">Deposit</span>
@@ -48,8 +45,7 @@ import {EnvProperties} from "../properties/env-properties";
       </div>
       <div *ngIf="embed" >
         <a (click)="openEmbedResultsModal()"
-          [title]="'Embed the related '+openaireEntities.RESULTS+' of this '+getTypeName()+' in your website'"
-          [attr.uk-tooltip]="'pos: bottom; cls: uk-active  uk-text-small uk-padding-small uk-width-medium'"
+          [attr.uk-tooltip]="showTooltip ? 'title: Embed the related '+openaireEntities.RESULTS+' of this '+getTypeName()+' in your website; pos: bottom; cls: uk-active  uk-text-small uk-padding-small uk-width-medium' : 'cls: uk-invisible'"
           class="uk-flex uk-flex-middle uk-button-link" [ngClass]="isMobile ? 'uk-margin-left uk-margin-xsmall-bottom' : 'uk-text-bolder uk-flex-center'">
           <icon flex="true" ratio="0.8" name="code" visuallyHidden="code"></icon>
           <span class="uk-margin-xsmall-left">Embed</span>
@@ -99,6 +95,7 @@ export class EntityActionsComponent implements OnInit {
   @Input() embed: boolean = false;
   @Input() url: string;
   @Input() isMobile: boolean = false;
+  @Input() showTooltip: boolean = true;
   public citeThisClicked: boolean;
   public routerHelper: RouterHelper = new RouterHelper();
   @ViewChild('citeModal') citeModal;
diff --git a/utils/result-preview/result-preview.component.html b/utils/result-preview/result-preview.component.html
index b920a1ea..7e1c1d56 100644
--- a/utils/result-preview/result-preview.component.html
+++ b/utils/result-preview/result-preview.component.html
@@ -187,7 +187,8 @@
                             [deposit]="deposit" [embed]="embed"
                             [type]="result.resultType"
                             [result]="result" [id]="result.objId?result.objId:result.id"
-                            [url]="properties.domain + properties.baseLink + url + '?' + urlParam + '=' + result.id">
+                            [url]="properties.domain + properties.baseLink + url + '?' + urlParam + '=' + result.id"
+                            [showTooltip]="false">
               <span *ngIf="orcid">
                 <orcid-work *ngIf="showOrcid && result.identifiers && result.identifiers.size > 0"
                             [resultId]="result.relcanId" [resultTitle]="result.title"
@@ -331,7 +332,8 @@
                                     [type]="result.resultType"
                                     [result]="result" [id]="result.objId?result.objId:result.id"
                                     [url]="properties.domain + properties.baseLink + url + '?' + urlParam + '=' + result.id"
-                                    [isMobile]="isMobile">
+                                    [isMobile]="isMobile"
+                                    [showTooltip]="false">
                       <span *ngIf="orcid">
                         <orcid-work *ngIf="showOrcid && result.identifiers && result.identifiers.size > 0"
                                     [resultId]="result.relcanId" [resultTitle]="result.title"