From 322ee51e261a61861a085dc3ca01d1d456f6338f Mon Sep 17 00:00:00 2001
From: "konstantina.galouni" <kgalouni@di.uoa.gr>
Date: Tue, 12 Apr 2022 16:52:49 +0300
Subject: [PATCH] [Library & common-assets| new-theme]: Fixes in
 custom-external. 1. resultLanding.component.html: [Bug fix] In EGI Notebook,
 uk-text-uppercase should be in text (custom-external icon could not be
 loaded). 2. resultLanding.component.ts: Removed unnecessary log. 3.
 result-preview.component.html: Added properly "custom-external" class. 4.
 utils.css: In class "custom-external", set verical-align: super.

---
 landingPages/result/resultLanding.component.html |  4 ++--
 landingPages/result/resultLanding.component.ts   |  1 -
 .../result-preview/result-preview.component.html | 16 ++++++----------
 3 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/landingPages/result/resultLanding.component.html b/landingPages/result/resultLanding.component.html
index 565cc612..8a2ad3dd 100644
--- a/landingPages/result/resultLanding.component.html
+++ b/landingPages/result/resultLanding.component.html
@@ -367,13 +367,13 @@
             <!-- EGI Notebook-->
               <div *ngIf="resultLandingInfo.showEgiNotebookButton && properties.adminToolsPortalType == 'explore'
                             && (properties.environment == 'beta' || properties.environment == 'development') && (!viewAll || viewAll=='egiNotebook')">
-                <a class="uk-link-text uk-text-bold uk-text-uppercase"
+                <a class="uk-link-text uk-text-bold custom-external"
                    target="_blank" [href]="properties.egiNotebookLink">
 <!--                    <span class="uk-icon-button uk-icon">-->
                       <img src="assets/common-assets/eosc-logo.png"
                            loading="lazy" alt="eosc_logo" style="width:27px; height:27px">
 <!--                    </span>-->
-                  <span class="uk-margin-small-left custom-external"><u>EOSC SERVICE: EGI NOTEBOOK</u></span>
+                  <span class="uk-margin-small-left uk-text-uppercase"><u>EOSC SERVICE: EGI NOTEBOOK</u></span>
                 </a>
               </div>
 <!--              <hr *ngIf="resultLandingInfo.showEgiNotebookButton && properties.adminToolsPortalType == 'explore'-->
diff --git a/landingPages/result/resultLanding.component.ts b/landingPages/result/resultLanding.component.ts
index a6b623ef..db26e4de 100644
--- a/landingPages/result/resultLanding.component.ts
+++ b/landingPages/result/resultLanding.component.ts
@@ -207,7 +207,6 @@ export class ResultLandingComponent {
     }));
 
       this.offset = Number.parseInt(getComputedStyle(document.documentElement).getPropertyValue('--navbar-height'));
-      console.log(this.offset);
   }
 
   private initMetaAndLinks(type: string) {
diff --git a/utils/result-preview/result-preview.component.html b/utils/result-preview/result-preview.component.html
index 023bd5f1..60a2b247 100644
--- a/utils/result-preview/result-preview.component.html
+++ b/utils/result-preview/result-preview.component.html
@@ -7,9 +7,9 @@
             alt="Enermaps tool preview" loading="lazy">
       <div class="uk-overlay uk-margin-medium-left uk-overlay-default uk-position-bottom uk-hidden-hover uk-padding-small">
         <p>Visit <a
-          class=" uk-margin-right uk-margin-small-top"
+          class="custom-external uk-margin-right uk-margin-small-top"
           [href]="properties.enermapsURL + '/?shared_id=' + result.enermapsId" target="_blank" >
-          Enermaps tool <span class="custom-external custom-icon space"></span>
+          Enermaps tool
         </a></p>
       </div>
 
@@ -55,7 +55,7 @@
 
         <a *ngIf="externalUrl && result.id && !(result.resultType == 'dataprovider' && result.compatibilityUNKNOWN) "
            (click)="onClick()"
-           target="_blank" [href]="externalUrl+result.id" class="uk-link uk-width-expand">
+           target="_blank" [href]="externalUrl+result.id" class="custom-external uk-link uk-width-expand">
           <span *ngIf="(result.title) || result.acronym">
             <span *ngIf="result.acronym">
               {{result.acronym}}
@@ -67,7 +67,6 @@
           <span *ngIf="!result.title && !result.acronym">
             [no title available]
           </span>
-          <span class="custom-external custom-icon space"></span>
         </a>
 
         <div *ngIf="!result.id ||  (result.resultType == 'dataprovider' && result.compatibilityUNKNOWN)"
@@ -224,8 +223,7 @@
     <div *ngIf="result.websiteURL && result.websiteURL != '' && !promoteWebsiteURL" class="uk-margin-small-bottom">
       <span class="uk-text-meta">Website URL: </span>
       <span>
-            <a href="{{result.websiteURL}}" target="_blank">
-              <span class="custom-external custom-icon"></span>
+            <a href="{{result.websiteURL}}" target="_blank" class="custom-external">
               {{result.websiteURL}}
             </a>
         </span>
@@ -234,8 +232,7 @@
     <div *ngIf="result.OAIPMHURL && result.OAIPMHURL != ''" class="uk-margin-small-bottom">
       <span class="uk-text-meta">OAI-PMH URL: </span>
       <span>
-        <a href="{{result.OAIPMHURL}}" target="_blank">
-          <span class="custom-external custom-icon"></span>
+        <a href="{{result.OAIPMHURL}}" target="_blank" class="custom-external">
           {{result.OAIPMHURL}}
         </a>
       </span>
@@ -271,8 +268,7 @@
         <span class="uk-text-meta">Download from: </span>
         <a *ngIf="from.downloadUrl"
            [href]="from.downloadUrl" target="_blank" class="title">
-          <span>{{from.downloadNames.join("; ")}}</span>
-          <span class="custom-external space"></span>
+          <span class="custom-external">{{from.downloadNames.join("; ")}}</span>
         </a>
         <span *ngIf="!from.downloadUrl || from.downloadUrl.length === 0" class="title">
           <span>{{from.downloadNames.join(", ")}}</span>