D-Net
/
openaire-graph-docs
6
1
Fork 5
Code Issues 5 Pull Requests 2 Packages Projects Releases 47 Wiki Activity

Add sitemap.xml generation during build #21

Merged
schatz merged 4 commits from Add_sitemap_generation into main 2022-12-02 12:27:52 +01:00
Conversation 2 Commits 4 Files Changed 1 +6
schatz commented 2022-11-29 12:19:50 +01:00
Member
Copy Link

Adds plugin for generating sitemap.xml during build for better SEO.

Adds plugin for generating sitemap.xml during build for better SEO.
claudio.atzori was assigned by schatz 2022-11-29 12:19:50 +01:00
schatz added 1 commit 2022-11-29 12:19:50 +01:00
claudio.atzori commented 2022-11-30 09:23:17 +01:00
Owner
Copy Link

Looks fine to me, just a few questions:

  1. wouldn't a monthly change frequency be enough?
  2. I tried building and running the branch and I see the sitemap.xml file under the build directory. However, I could not find a way to access it through the web browser. Shouldn't it be exposed under the root? e.g. when running the site using npm run start, shouldnt' it be exposed under http://localhost:3000/sitemap.xml ?
Looks fine to me, just a few questions: 1. wouldn't a monthly change frequency be enough? 2. I tried building and running the branch and I see the `sitemap.xml` file under the build directory. However, I could not find a way to access it through the web browser. Shouldn't it be exposed under the root? e.g. when running the site using `npm run start`, shouldnt' it be exposed under `http://localhost:3000/sitemap.xml` ?
schatz commented 2022-11-30 10:56:56 +01:00
Author
Member
Copy Link
  1. wouldn't a monthly change frequency be enough?

Agree

  1. I tried building and running the branch and I see the sitemap.xml file under the build directory. However, I could not find a way to access it through the web browser. Shouldn't it be exposed under the root? e.g. when running the site using npm run start, shouldnt' it be exposed under http://localhost:3000/sitemap.xml ?

From the docs of the plugin here, the sitemap.xml is generated in the build output as you've said. So, you can see it when serving the build folder with a web server and not with npm run start which is intended for development.
You can see the generated sitemap.xml here: http://snf-23385.ok-kno.grnetcloud.net/sitemap.xml

> 1. wouldn't a monthly change frequency be enough? Agree > 2. I tried building and running the branch and I see the `sitemap.xml` file under the build directory. However, I could not find a way to access it through the web browser. Shouldn't it be exposed under the root? e.g. when running the site using `npm run start`, shouldnt' it be exposed under `http://localhost:3000/sitemap.xml` ? > From the docs of the plugin [here](https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-sitemap), the sitemap.xml is generated in the build output as you've said. So, you can see it when serving the build folder with a web server and not with `npm run start` which is intended for development. You can see the generated sitemap.xml here: http://snf-23385.ok-kno.grnetcloud.net/sitemap.xml
schatz added 1 commit 2022-11-30 13:15:56 +01:00
schatz added 1 commit 2022-11-30 13:18:32 +01:00
schatz added 1 commit 2022-12-02 11:29:48 +01:00
schatz merged commit 9c45c0533e into main 2022-12-02 12:27:52 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/openaire-graph-docs#21
No description provided.
Delete Branch "Add_sitemap_generation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?