D-Net
/
dnet-hadoop
14
5
Fork 11
Code Issues 14 Pull Requests 13 Projects 2 Releases 2 Wiki Activity

orcid-no-doi #43

Merged
claudio.atzori merged 45 commits from enrico.ottonello/dnet-hadoop:orcid-no-doi into master 2020-12-02 10:55:12 +01:00
Conversation 5 Commits 45 Files Changed 68 +2 -5
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ab083f9946 - Show all commits

7
dhp-workflows/dhp-doiboost/src/main/java/eu/dnetlib/doiboost/orcidnodoi/ActivitiesDumpReader.java
View File

@ -128,10 +128,7 @@ public class ActivitiesDumpReader {
} }
} }
} catch (Exception e) { } catch (Exception e) {
Log throw new Exception(filename, e);
claudio.atzori commented 2020-09-16 10:02:31 +02:00
Outdated
Review
Copy Link

What is the reason for not handling nor let propagate this exception? I imagine that a malformed entry in the tar file could cause it, but in that case we should interrupt the procedure and deepen the analysis to spot the error. In this way the error would likely be unnoticed, but causing a drop in the number of output records.

What is the reason for not handling nor let propagate this exception? I imagine that a malformed entry in the tar file could cause it, but in that case we should interrupt the procedure and deepen the analysis to spot the error. In this way the error would likely be unnoticed, but causing a drop in the number of output records.
.warn(
"Parsing work from tar archive and xml work: " + filename + " " + e.getMessage());
// Log.warn(e);
} }
if ((counter % XML_WORKS_PARSED_COUNTER_LOG_INTERVAL) == 0) { if ((counter % XML_WORKS_PARSED_COUNTER_LOG_INTERVAL) == 0) {
@ -143,7 +140,7 @@ public class ActivitiesDumpReader {
} }
} }
} }
} catch (IOException e) { } catch (Exception e) {
Log.warn("Parsing work from gzip archive: " + e.getMessage()); Log.warn("Parsing work from gzip archive: " + e.getMessage());
Log.warn(e); Log.warn(e);
throw new RuntimeException(e); throw new RuntimeException(e);