[Dedup] swap expected and actual in tests #83

New Issue

claudio.atzori · 2020-12-23T12:30:47+01:00

claudio.atzori commented

2020-12-23 12:30:47 +01:00

I see many misuses of the assertEquals function in the dedup worfklow module, e.g.

https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-workflows/dhp-dedup-openaire/src/test/java/eu/dnetlib/dhp/oa/dedup/EntityMergerTest.java

The assertion signature assumes the 1st parameter represents the expected value, to be checked against the actual value, passed as 2nd parameter:

org.junit.jupiter.api.Assertions#assertEquals(java.lang.Object expected, java.lang.Object actual)

Please fix the tests and look for other misuses within the dedup module scope.

I see many misuses of the `assertEquals` function in the dedup worfklow module, e.g. https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-workflows/dhp-dedup-openaire/src/test/java/eu/dnetlib/dhp/oa/dedup/EntityMergerTest.java The assertion signature assumes the 1st parameter represents the expected value, to be checked against the actual value, passed as 2nd parameter: ```org.junit.jupiter.api.Assertions#assertEquals(java.lang.Object expected, java.lang.Object actual)``` Please fix the tests and look for other misuses within the dedup module scope.

claudio.atzori added the

bug

label 2020-12-23 12:30:47 +01:00

michele.debonis was assigned by claudio.atzori

2020-12-23 12:30:47 +01:00

Sign in to join this conversation.