[Dedup] swap expected and actual in tests #83

Open
opened 3 years ago by claudio.atzori · 0 comments
Owner

I see many misuses of the assertEquals function in the dedup worfklow module, e.g.

https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-workflows/dhp-dedup-openaire/src/test/java/eu/dnetlib/dhp/oa/dedup/EntityMergerTest.java

The assertion signature assumes the 1st parameter represents the expected value, to be checked against the actual value, passed as 2nd parameter:

org.junit.jupiter.api.Assertions#assertEquals(java.lang.Object expected, java.lang.Object actual)

Please fix the tests and look for other misuses within the dedup module scope.

I see many misuses of the `assertEquals` function in the dedup worfklow module, e.g. https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-workflows/dhp-dedup-openaire/src/test/java/eu/dnetlib/dhp/oa/dedup/EntityMergerTest.java The assertion signature assumes the 1st parameter represents the expected value, to be checked against the actual value, passed as 2nd parameter: ```org.junit.jupiter.api.Assertions#assertEquals(java.lang.Object expected, java.lang.Object actual)``` Please fix the tests and look for other misuses within the dedup module scope.
claudio.atzori added the
bug
label 3 years ago
michele.debonis was assigned by claudio.atzori 3 years ago
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#83
Loading…
There is no content yet.