D-Net
/
dnet-hadoop
14
5
Fork 11
Code Issues 14 Pull Requests 13 Projects 2 Releases 2 Wiki Activity

added extension for new author pid (orcid_pending) #63

Merged
claudio.atzori merged 4 commits from miriam.baglioni/dnet-hadoop:master into master 2020-12-02 11:15:01 +01:00
Conversation 2 Commits 4 Files Changed 5 +14 -5
miriam.baglioni commented 2020-12-01 20:13:37 +01:00
Member
Copy Link

This PR contains the extention of the propagation of orcid throgh semrel by adding the new authro pid type orcid_pending. For propagation both orcid and orcid_pending will be considered, only orcid_pending will be propagated. No orcid will be transferred to the receiving result if the author already has associated one orcid or one orcid_pending pid

This PR contains the extention of the propagation of orcid throgh semrel by adding the new authro pid type orcid_pending. For propagation both orcid and orcid_pending will be considered, only orcid_pending will be propagated. No orcid will be transferred to the receiving result if the author already has associated one orcid or one orcid_pending pid
miriam.baglioni added the
enhancement
 label 2020-12-01 20:13:37 +01:00
claudio.atzori was assigned by miriam.baglioni 2020-12-01 20:13:37 +01:00
miriam.baglioni commented 2020-12-01 20:14:47 +01:00
Author
Member
Copy Link

when writing only orcid_pending will be propagated I meant that the propagation action will mark the added pid as orcid_pending

when writing only orcid_pending will be propagated I meant that the propagation action will mark the added pid as orcid_pending
claudio.atzori reviewed 2020-12-02 10:56:49 +01:00
dhp-workflows/dhp-enrichment/src/main/java/eu/dnetlib/dhp/PropagationConstant.java Outdated
@ -45,3 +45,3 @@
public static final String PROPAGATION_ORCID_TO_RESULT_FROM_SEM_REL_CLASS_NAME = "Propagation of authors pid to result through semantic relations";
public static final String PROPAGATION_AUTHOR_PID = "ORCID";
public static final String PROPAGATION_AUTHOR_PID_CLASSID = "orcid_pending";
claudio.atzori commented 2020-12-02 10:56:49 +01:00
Owner
Copy Link

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L11

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L11
claudio.atzori reviewed 2020-12-02 10:57:11 +01:00
dhp-workflows/dhp-enrichment/src/main/java/eu/dnetlib/dhp/PropagationConstant.java
@ -46,2 +46,3 @@
public static final String PROPAGATION_AUTHOR_PID = "ORCID";
public static final String PROPAGATION_AUTHOR_PID_CLASSID = "orcid_pending";
public static final String ORCID = "orcid";
claudio.atzori commented 2020-12-02 10:57:11 +01:00
Owner
Copy Link

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L10

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L10
claudio.atzori reviewed 2020-12-02 10:57:56 +01:00
dhp-workflows/dhp-enrichment/src/main/java/eu/dnetlib/dhp/PropagationConstant.java Outdated
@ -47,1 +47,3 @@
public static final String PROPAGATION_AUTHOR_PID = "ORCID";
public static final String PROPAGATION_AUTHOR_PID_CLASSID = "orcid_pending";
public static final String ORCID = "orcid";
public static final String PROPAGATION_AUTHOR_PID_CLASSNAME = "Open Researcher and Contributor ID";
claudio.atzori commented 2020-12-02 10:57:56 +01:00
Owner
Copy Link

Please move this definition in the common https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java

Please move this definition in the common https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java
claudio.atzori requested changes 2020-12-02 10:58:49 +01:00
claudio.atzori left a comment
Owner
Copy Link

Minor changes: move a few constants in the common class ModelConstants.java

Minor changes: move a few constants in the common class `ModelConstants.java`
miriam.baglioni commented 2020-12-02 11:13:58 +01:00
Author
Member
Copy Link

done and pushed

done and pushed
claudio.atzori changed title from WIP:added extention for new author pid (orcid_pending) to added extension for new author pid (orcid_pending) 2020-12-02 11:14:51 +01:00
claudio.atzori closed this pull request 2020-12-02 11:15:01 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#63
No description provided.
Delete Branch "miriam.baglioni/dnet-hadoop:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?