D-Net
/
dnet-hadoop
15
4
Fork 10
Code Issues 14 Pull Requests 8 Projects 2 Releases 1 Wiki Activity

Labels Milestones

added extension for new author pid (orcid_pending) #63

Merged
claudio.atzori merged 4 commits from miriam.baglioni/dnet-hadoop:master into master 3 years ago
Conversation 2 Commits 4 Files Changed 5
miriam.baglioni commented 3 years ago
Collaborator

This PR contains the extention of the propagation of orcid throgh semrel by adding the new authro pid type orcid_pending. For propagation both orcid and orcid_pending will be considered, only orcid_pending will be propagated. No orcid will be transferred to the receiving result if the author already has associated one orcid or one orcid_pending pid

This PR contains the extention of the propagation of orcid throgh semrel by adding the new authro pid type orcid_pending. For propagation both orcid and orcid_pending will be considered, only orcid_pending will be propagated. No orcid will be transferred to the receiving result if the author already has associated one orcid or one orcid_pending pid
miriam.baglioni added the
enhancement
 label 3 years ago
claudio.atzori was assigned by miriam.baglioni 3 years ago
miriam.baglioni commented 3 years ago
Poster
Collaborator

when writing only orcid_pending will be propagated I meant that the propagation action will mark the added pid as orcid_pending

when writing only orcid_pending will be propagated I meant that the propagation action will mark the added pid as orcid_pending
claudio.atzori reviewed 3 years ago
dhp-workflows/dhp-enrichment/src/main/java/eu/dnetlib/dhp/PropagationConstant.java Outdated
@ -45,3 +45,3 @@
public static final String PROPAGATION_ORCID_TO_RESULT_FROM_SEM_REL_CLASS_NAME = "Propagation of authors pid to result through semantic relations";
public static final String PROPAGATION_AUTHOR_PID = "ORCID";
public static final String PROPAGATION_AUTHOR_PID_CLASSID = "orcid_pending";
claudio.atzori commented 3 years ago
Owner

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L11

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L11
claudio.atzori reviewed 3 years ago
dhp-workflows/dhp-enrichment/src/main/java/eu/dnetlib/dhp/PropagationConstant.java
@ -46,2 +46,3 @@
public static final String PROPAGATION_AUTHOR_PID = "ORCID";
public static final String PROPAGATION_AUTHOR_PID_CLASSID = "orcid_pending";
public static final String ORCID = "orcid";
claudio.atzori commented 3 years ago
Owner

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L10

Please remove this and refer to https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java#L10
claudio.atzori reviewed 3 years ago
dhp-workflows/dhp-enrichment/src/main/java/eu/dnetlib/dhp/PropagationConstant.java Outdated
@ -47,1 +47,3 @@
public static final String PROPAGATION_AUTHOR_PID = "ORCID";
public static final String PROPAGATION_AUTHOR_PID_CLASSID = "orcid_pending";
public static final String ORCID = "orcid";
public static final String PROPAGATION_AUTHOR_PID_CLASSNAME = "Open Researcher and Contributor ID";
claudio.atzori commented 3 years ago
Owner

Please move this definition in the common https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java

Please move this definition in the common https://code-repo.d4science.org/D-Net/dnet-hadoop/src/branch/master/dhp-schemas/src/main/java/eu/dnetlib/dhp/schema/common/ModelConstants.java
claudio.atzori requested changes 3 years ago
claudio.atzori left a comment
Owner

Minor changes: move a few constants in the common class ModelConstants.java

Minor changes: move a few constants in the common class `ModelConstants.java`
miriam.baglioni commented 3 years ago
Poster
Collaborator

done and pushed

done and pushed
claudio.atzori changed title from WIP:added extention for new author pid (orcid_pending) to added extension for new author pid (orcid_pending) 3 years ago
claudio.atzori closed this pull request 3 years ago
The pull request has been merged as 873c358d1d.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b miriam.baglioni-master master
git pull master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff miriam.baglioni-master
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
bug

Something is not working   
duplicate

This issue or pull request already exists   
enhancement

New feature / refactoring   
help wanted

Need some help   
invalid

Something is wrong   
question

More information is needed   
RDGraph

EOSC Research Discovery Graph   
RSAC

EOSC Research Software APIs and Connectors   
wontfix

This won't be fixed
No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
claudio.atzori
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#63
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'miriam.baglioni/dnet-hadoop:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes