D-Net
/
dnet-hadoop
15
4
Fork 10
Code Issues 14 Pull Requests 10 Projects 2 Releases 1 Wiki Activity

Merging different bestacccessrights #45

New Issue
Closed
opened 2020-09-30 15:56:33 +02:00 by claudio.atzori · 3 comments
claudio.atzori commented 2020-09-30 15:56:33 +02:00
Owner
Copy Link

I just noticed that the result merge procedure considers only the trust to merge the field bestaccessright, while instead it should make use of

eu.dnetlib.dhp.schema.common.LicenseComparator

to make the most open values emerge in representative records.

Please adjust the Result merge functionality accordingly.

I just noticed that the result merge procedure considers only the trust to merge the field `bestaccessright`, while instead it should make use of ```eu.dnetlib.dhp.schema.common.LicenseComparator``` to make the most _open_ values emerge in representative records. Please adjust the Result merge functionality accordingly.
claudio.atzori added the
bug
 label 2020-09-30 15:56:33 +02:00
michele.debonis was assigned by claudio.atzori 2020-09-30 15:56:33 +02:00
alessia.bardi commented 2020-10-01 10:43:58 +02:00
Owner
Copy Link

This is very very urgent!

This is very very urgent!
michele.debonis commented 2020-10-06 15:30:29 +02:00
Member
Copy Link

Fixed both the tests and the merge function.
Now the most open value of the bestaccessright emerges in the representative records.

Fixed both the tests and the merge function. Now the most open value of the bestaccessright emerges in the representative records.
👍 1
claudio.atzori commented 2020-10-06 17:34:41 +02:00
Author
Owner
Copy Link

Thanks Michele, the changes looks good.

Thanks Michele, the changes looks good.
Sign in to join this conversation.
master
Branches Tags
Clear current reference
master
beta
spark34-integration
dependency-revision
beta-release-1.2.5
rest-collector-plugin-with-retry
misc_fixes_merge_entities
WebCrowlBeta
WebCrowl
provision_memoryOverhead
stats_step16_fix
doidoost_dismiss
CrossrefFundersMap
taggingProjects
9647_datacite_affiliations
UsageStatsRecordDS
mergeutils
oaf_country_beta
index_records
ocnew
FOSNew
bulkTaggingPathMapExtention
transformativeagreement
new_orcid_enhancement
9559_DBLP_data
base_stats_job_deprecated
SWH_issue_377
import_orps_fix
spark_join_param_tuning
crossref_mapping_vocabularies
promote_actions_join_type_master
promote_actions_join_type
provision_community_api
enrichmentSingleStepFixed
fosPreparationBeta
resource_types
enrichmentSingleStep
oldPropagationOrganizationCommunity
beta_to_master_dicember2023
orcid_import
9078_xml_records_irish_tender
clean_license_publisher
bulkTag
SWH_integration
importpoci
8172_impact_indicators_workflow
dedup-with-dataframe-spark34
8876
master_july23
distinct_pids_from_openorgs_beta
propagationProjectThroughParentChils
fulltext_url_validation
removeTaggingCondition
ticket_8369
tweaking_spark_params
fc4e-rsac
doiboost_authormerger
beta_dedup_configuration
apc_affiliation
bulkTagRefactor
organizationToRepresentative
graph_cleaning_refactoring
scholix_flat_indexing
scholix_data_type_openaire
advConstraintsInBeta
doiboostMappingExtention
mag_citation_relation
h2020classification
doiboostFunderExtention
citations_monodirectional
compatibility_order
8232-mdstore-synch-improve
subjectPropagation
pubmed_to_production
cleanCountryOnMaster
graph_cleaning
deduptesting
horizontalConstraints
enrichment
scholix_to_solr
transformation_wf
discard-non-wellformed
removeDump
eosc_context_tagging
pubmed_update
doiboost_refactor
clean_context_master
monitoring
dump_new_funded_products
dump_delta_projects
dump
7096-fileGZip-collector-plugin
oaf_relation_mapping
validation
native_records_migration
instance_group_by_url
hostedByMap_update
hostedByMap_oastartdate
sygma_indexing
Clear current reference
september-2023
dhp-1.2.4
archive/master_pre_stable_ids
archive/bipFinder_master_test
archive/islookup_timeout
dhp-1.2.3
dhp-1.2.2
dhp-1.2.1
dhp-1.2.0
dhp-1.1.7
dhp-1.1.6
archive/junit5
archive/dedupTest
dhp-1.1.5
dhp-1.0.4
dhp-1.0.3
dhp-1.0.2
1.0.1
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature / refactoring

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
RDGraph

EOSC Research Discovery Graph

  
RSAC

EOSC Research Software APIs and Connectors

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
RDGraph
RSAC
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
michele.debonis
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: D-Net/dnet-hadoop#45
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?