Added unit test to verify the generation in the OriginalID the old openaire Identifier generated by OAI

- move the business logic from the model class to  dhp-common

.gitignore

@@ -26,4 +26,3 @@ spark-warehouse
 /**/*.log
 /**/.factorypath
 /**/.scalafmt.conf
-/.java-version

CODE_OF_CONDUCT.md

@@ -1,43 +0,0 @@
-# Contributor Code of Conduct
-
-Openness, transparency and our community-driven participatory approach guide us in our day-to-day interactions and decision-making. Our open source projects are no exception. Trust, respect, collaboration and transparency are core values we believe should live and breathe within our projects. Our community welcomes participants from around the world with different experiences, unique perspectives, and great ideas to share.
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment include:
-
-- Using welcoming and inclusive language
-- Being respectful of differing viewpoints and experiences
-- Gracefully accepting constructive criticism
-- Attempting collaboration before conflict
-- Focusing on what is best for the community
-- Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-- Violence, threats of violence, or inciting others to commit self-harm
-- The use of sexualized language or imagery and unwelcome sexual attention or advances
-- Trolling, intentionally spreading misinformation, insulting/derogatory comments, and personal or political attacks
-- Public or private harassment
-- Publishing others' private information, such as a physical or electronic address, without explicit permission
-- Abuse of the reporting process to intentionally harass or exclude others
-- Advocating for, or encouraging, any of the above behavior
-- Other conduct which could reasonably be considered inappropriate in a professional setting
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org/), [version 1.4](https://www.contributor-covenant.org/version/1/4/code-of-conduct.html).

CONTRIBUTING.md

@@ -1,10 +0,0 @@
-# Contributing to D-Net Hadoop
-
-:+1::tada: First off, thanks for taking the time to contribute! :tada::+1:
-
-This project and everyone participating in it is governed by our [Code of Conduct](CODE_OF_CONDUCT.md). By participating, you are expected to uphold this code. Please report unacceptable behavior to [dnet-team@isti.cnr.it](mailto:dnet-team@isti.cnr.it).
-
-The following is a set of guidelines for contributing to this project and its packages. These are mostly guidelines, not rules, which applies to this project as a while, including all its sub-modules. 
-Use your best judgment, and feel free to propose changes to this document in a pull request.
-
-All contributions are welcome, all contributions will be considered to be contributed under the [project license](LICENSE.md).

README.md

@@ -1,133 +1,2 @@
 # dnet-hadoop
-
-Dnet-hadoop is the project that defined all the [OOZIE workflows](https://oozie.apache.org/) for the OpenAIRE Graph construction, processing, provisioning.
-
-This project adheres to the Contributor Covenant [code of conduct](CODE_OF_CONDUCT.md).
-By participating, you are expected to uphold this code. Please report unacceptable behavior to [dnet-team@isti.cnr.it](mailto:dnet-team@isti.cnr.it).
-
-This project is licensed under the [AGPL v3 or later version](#LICENSE.md).
-
-How to build, package and run oozie workflows
-====================
-
-Oozie-installer is a utility allowing building, uploading and running oozie workflows. In practice, it creates a `*.tar.gz` 
-package that contains resources that define a workflow and some helper scripts.
-
-This module is automatically executed when running:
-
-`mvn package -Poozie-package -Dworkflow.source.dir=classpath/to/parent/directory/of/oozie_app`
-
-on module having set:
-
-```
-<parent>
-    <groupId>eu.dnetlib.dhp</groupId>
-    <artifactId>dhp-workflows</artifactId>
-</parent>
-```
-
-in `pom.xml` file. `oozie-package` profile initializes oozie workflow packaging, `workflow.source.dir` property points to 
-a workflow (notice: this is not a relative path but a classpath to directory usually holding `oozie_app` subdirectory).
-
-The outcome of this packaging is `oozie-package.tar.gz` file containing inside all the resources required to run Oozie workflow:
-
-- jar packages
-- workflow definitions
-- job properties
-- maintenance scripts
-
-Required properties
-====================
-
-In order to include proper workflow within package, `workflow.source.dir` property has to be set. It could be provided 
-by setting `-Dworkflow.source.dir=some/job/dir` maven parameter.
-
-In oder to define full set of cluster environment properties one should create `~/.dhp/application.properties` file with 
-the following properties:
-
-- `dhp.hadoop.frontend.user.name` - your user name on hadoop cluster and frontend machine
-- `dhp.hadoop.frontend.host.name` - frontend host name
-- `dhp.hadoop.frontend.temp.dir` - frontend directory for temporary files
-- `dhp.hadoop.frontend.port.ssh` - frontend machine ssh port
-- `oozieServiceLoc` - oozie service location required by run_workflow.sh script executing oozie job
-- `nameNode` - name node address
-- `jobTracker` - job tracker address
-- `oozie.execution.log.file.location` - location of file that will be created when executing oozie job, it contains output 
-produced by `run_workflow.sh` script (needed to obtain oozie job id)
-- `maven.executable` - mvn command location, requires parameterization due to a different setup of CI cluster
-- `sparkDriverMemory` - amount of memory assigned to spark jobs driver
-- `sparkExecutorMemory` - amount of memory assigned to spark jobs executors
-- `sparkExecutorCores` - number of cores assigned to spark jobs executors
-
-All values will be overriden with the ones from `job.properties` and eventually `job-override.properties` stored in module's 
-main folder.
-
-When overriding properties from `job.properties`, `job-override.properties` file can be created in main module directory 
-(the one containing `pom.xml` file) and define all new properties which will override existing properties. 
-One can provide those properties one by one as command line `-D` arguments.
-
-Properties overriding order is the following:
-
-1. `pom.xml` defined properties (located in the project root dir)
-2. `~/.dhp/application.properties` defined properties
-3. `${workflow.source.dir}/job.properties`
-4. `job-override.properties` (located in the project root dir)
-5. `maven -Dparam=value`
-
-where the maven `-Dparam` property is overriding all the other ones.
-
-Workflow definition requirements
-====================
-
-`workflow.source.dir` property should point to the following directory structure:
-
-	[${workflow.source.dir}]
-		|
-		|-job.properties (optional)
-		|
-		\-[oozie_app]
-			|
-			\-workflow.xml
-
-This property can be set using maven `-D` switch.
-
-`[oozie_app]` is the default directory name however it can be set to any value as soon as `oozieAppDir` property is 
-provided with directory name as value.
-
-Sub-workflows are supported as well and sub-workflow directories should be nested within `[oozie_app]` directory.
-
-Creating oozie installer step-by-step
-=====================================
-
-Automated oozie-installer steps are the following:
-
-1. creating jar packages:  `*.jar` and `*tests.jar` along with copying all dependencies in `target/dependencies`
-2. reading properties from maven, `~/.dhp/application.properties`, `job.properties`, `job-override.properties`
-3. invoking priming mechanism linking resources from import.txt file (currently resolving subworkflow resources)
-4. assembling shell scripts for preparing Hadoop filesystem, uploading Oozie application and starting workflow
-5. copying whole `${workflow.source.dir}` content to `target/${oozie.package.file.name}`
-6. generating updated `job.properties` file in `target/${oozie.package.file.name}` based on maven, 
-`~/.dhp/application.properties`, `job.properties` and `job-override.properties`
-7. creating `lib` directory (or multiple directories for sub-workflows for each nested directory) and copying jar packages 
-created at step (1) to each one of them
-8. bundling whole `${oozie.package.file.name}` directory into single tar.gz package
-
-Uploading oozie package and running workflow on cluster
-=======================================================
-
-In order to simplify deployment and execution process two dedicated profiles were introduced:
-
-- `deploy`
-- `run`
-
-to be used along with `oozie-package` profile e.g. by providing `-Poozie-package,deploy,run` maven parameters.
-
-The `deploy` profile supplements packaging process with:
-1) uploading oozie-package via scp to `/home/${user.name}/oozie-packages` directory on `${dhp.hadoop.frontend.host.name}` machine
-2) extracting uploaded package
-3) uploading oozie content to hadoop cluster HDFS location defined in `oozie.wf.application.path` property (generated dynamically by maven build process, based on `${dhp.hadoop.frontend.user.name}` and `workflow.source.dir` properties)
-
-The `run` profile introduces:
-1) executing oozie application uploaded to HDFS cluster using `deploy` command. Triggers `run_workflow.sh` script providing runtime properties defined in `job.properties` file.
-
-Notice: ssh access to frontend machine has to be configured on system level and it is preferable to set key-based authentication in order to simplify remote operations.
+Dnet-hadoop is the project that defined all the OOZIE workflows for the OpenAIRE Graph construction, processing, provisioning.

dhp-common/pom.xml

@@ -52,8 +52,6 @@
 					</execution>
 				</executions>
 				<configuration>
-					<failOnMultipleScalaVersions>true</failOnMultipleScalaVersions>
-					<scalaCompatVersion>${scala.binary.version}</scalaCompatVersion>
 					<scalaVersion>${scala.version}</scalaVersion>
 				</configuration>
 			</plugin>
@@ -62,11 +60,6 @@
 	</build>
 
 	<dependencies>
-		<dependency>
-			<groupId>eu.dnetlib.dhp</groupId>
-			<artifactId>dhp-pace-core</artifactId>
-			<version>${project.version}</version>
-		</dependency>
 
 		<dependency>
 			<groupId>org.apache.hadoop</groupId>
@@ -83,11 +76,11 @@
 
 		<dependency>
 			<groupId>org.apache.spark</groupId>
-			<artifactId>spark-core_${scala.binary.version}</artifactId>
+			<artifactId>spark-core_2.11</artifactId>
 		</dependency>
 		<dependency>
 			<groupId>org.apache.spark</groupId>
-			<artifactId>spark-sql_${scala.binary.version}</artifactId>
+			<artifactId>spark-sql_2.11</artifactId>
 		</dependency>
 
 		<dependency>
@@ -149,6 +142,11 @@
 			<artifactId>okhttp</artifactId>
 		</dependency>
 
+		<dependency>
+			<groupId>eu.dnetlib</groupId>
+			<artifactId>dnet-pace-core</artifactId>
+		</dependency>
+
 		<dependency>
 			<groupId>org.apache.httpcomponents</groupId>
 			<artifactId>httpclient</artifactId>
@@ -161,7 +159,7 @@
 
 		<dependency>
 			<groupId>eu.dnetlib.dhp</groupId>
-			<artifactId>${dhp-schemas.artifact}</artifactId>
+			<artifactId>dhp-schemas</artifactId>
 		</dependency>
 
 		<dependency>

dhp-common/src/main/java/eu/dnetlib/dhp/common/Constants.java

@@ -10,12 +10,6 @@ public class Constants {
 	public static final Map<String, String> accessRightsCoarMap = Maps.newHashMap();
 	public static final Map<String, String> coarCodeLabelMap = Maps.newHashMap();
 
-	public static final String ROR_NS_PREFIX = "ror_________";
-
-	public static final String ROR_OPENAIRE_ID = "10|openaire____::993a7ae7a863813cf95028b50708e222";
-
-	public static final String ROR_DATASOURCE_NAME = "Research Organization Registry (ROR)";
-
 	public static String COAR_ACCESS_RIGHT_SCHEMA = "http://vocabularies.coar-repositories.org/documentation/access_rights/";
 
 	private Constants() {
@@ -51,7 +45,6 @@ public class Constants {
 	public static final String RETRY_DELAY = "retryDelay";
 	public static final String CONNECT_TIMEOUT = "connectTimeOut";
 	public static final String READ_TIMEOUT = "readTimeOut";
-	public static final String REQUEST_METHOD = "requestMethod";
 	public static final String FROM_DATE_OVERRIDE = "fromDateOverride";
 	public static final String UNTIL_DATE_OVERRIDE = "untilDateOverride";
 

dhp-common/src/main/java/eu/dnetlib/dhp/common/MDStoreInfo.java

@@ -1,100 +0,0 @@
-
-package eu.dnetlib.dhp.common;
-
-/**
- * This utility represent the Metadata Store information
- * needed during the migration from mongo to HDFS to store
-  */
-public class MDStoreInfo {
-	private String mdstore;
-	private String currentId;
-	private Long latestTimestamp;
-
-	/**
-	 * Instantiates a new Md store info.
-	 */
-	public MDStoreInfo() {
-	}
-
-	/**
-	 * Instantiates a new Md store info.
-	 *
-	 * @param mdstore         the mdstore
-	 * @param currentId       the current id
-	 * @param latestTimestamp the latest timestamp
-	 */
-	public MDStoreInfo(String mdstore, String currentId, Long latestTimestamp) {
-		this.mdstore = mdstore;
-		this.currentId = currentId;
-		this.latestTimestamp = latestTimestamp;
-	}
-
-	/**
-	 * Gets mdstore.
-	 *
-	 * @return the mdstore
-	 */
-	public String getMdstore() {
-		return mdstore;
-	}
-
-	/**
-	 * Sets mdstore.
-	 *
-	 * @param mdstore the mdstore
-	 * @return the mdstore
-	 */
-	public MDStoreInfo setMdstore(String mdstore) {
-		this.mdstore = mdstore;
-		return this;
-	}
-
-	/**
-	 * Gets current id.
-	 *
-	 * @return the current id
-	 */
-	public String getCurrentId() {
-		return currentId;
-	}
-
-	/**
-	 * Sets current id.
-	 *
-	 * @param currentId the current id
-	 * @return the current id
-	 */
-	public MDStoreInfo setCurrentId(String currentId) {
-		this.currentId = currentId;
-		return this;
-	}
-
-	/**
-	 * Gets latest timestamp.
-	 *
-	 * @return the latest timestamp
-	 */
-	public Long getLatestTimestamp() {
-		return latestTimestamp;
-	}
-
-	/**
-	 * Sets latest timestamp.
-	 *
-	 * @param latestTimestamp the latest timestamp
-	 * @return the latest timestamp
-	 */
-	public MDStoreInfo setLatestTimestamp(Long latestTimestamp) {
-		this.latestTimestamp = latestTimestamp;
-		return this;
-	}
-
-	@Override
-	public String toString() {
-		return "MDStoreInfo{" +
-			"mdstore='" + mdstore + '\'' +
-			", currentId='" + currentId + '\'' +
-			", latestTimestamp=" + latestTimestamp +
-			'}';
-	}
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/MakeTarArchive.java

@@ -5,71 +5,13 @@ import java.io.BufferedInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.Serializable;
-import java.util.Optional;
 
 import org.apache.commons.compress.archivers.tar.TarArchiveEntry;
 import org.apache.commons.compress.archivers.tar.TarArchiveOutputStream;
-import org.apache.commons.io.IOUtils;
-import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.*;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import eu.dnetlib.dhp.application.ArgumentApplicationParser;
 
 public class MakeTarArchive implements Serializable {
 
-	private static final Logger log = LoggerFactory.getLogger(MakeTarArchive.class);
-
-	public static void main(String[] args) throws Exception {
-		String jsonConfiguration = IOUtils
-			.toString(
-				MakeTarArchive.class
-					.getResourceAsStream(
-						"/eu/dnetlib/dhp/common/input_maketar_parameters.json"));
-
-		final ArgumentApplicationParser parser = new ArgumentApplicationParser(jsonConfiguration);
-		parser.parseArgument(args);
-
-		final String outputPath = parser.get("hdfsPath");
-		log.info("hdfsPath: {}", outputPath);
-
-		final String hdfsNameNode = parser.get("nameNode");
-		log.info("nameNode: {}", hdfsNameNode);
-
-		final String inputPath = parser.get("sourcePath");
-		log.info("input path : {}", inputPath);
-
-		final int gBperSplit = Optional
-			.ofNullable(parser.get("splitSize"))
-			.map(Integer::valueOf)
-			.orElse(10);
-
-		Configuration conf = new Configuration();
-		conf.set("fs.defaultFS", hdfsNameNode);
-
-		FileSystem fileSystem = FileSystem.get(conf);
-
-		makeTArArchive(fileSystem, inputPath, outputPath, gBperSplit);
-
-	}
-
-	public static void makeTArArchive(FileSystem fileSystem, String inputPath, String outputPath, int gBperSplit)
-		throws IOException {
-
-		RemoteIterator<LocatedFileStatus> dirIterator = fileSystem.listLocatedStatus(new Path(inputPath));
-
-		while (dirIterator.hasNext()) {
-			LocatedFileStatus fileStatus = dirIterator.next();
-
-			Path p = fileStatus.getPath();
-			String pathString = p.toString();
-			String entity = pathString.substring(pathString.lastIndexOf("/") + 1);
-
-			MakeTarArchive.tarMaxSize(fileSystem, pathString, outputPath + "/" + entity, entity, gBperSplit);
-		}
-	}
-
 	private static TarArchiveOutputStream getTar(FileSystem fileSystem, String outputPath) throws IOException {
 		Path hdfsWritePath = new Path(outputPath);
 		if (fileSystem.exists(hdfsWritePath)) {
@@ -79,7 +21,7 @@ public class MakeTarArchive implements Serializable {
 		return new TarArchiveOutputStream(fileSystem.create(hdfsWritePath).getWrappedStream());
 	}
 
-	private static void write(FileSystem fileSystem, String inputPath, String outputPath, String dirName)
+	private static void write(FileSystem fileSystem, String inputPath, String outputPath, String dir_name)
 		throws IOException {
 
 		Path hdfsWritePath = new Path(outputPath);
@@ -95,7 +37,7 @@ public class MakeTarArchive implements Serializable {
 					new Path(inputPath), true);
 
 			while (iterator.hasNext()) {
-				writeCurrentFile(fileSystem, dirName, iterator, ar, 0);
+				writeCurrentFile(fileSystem, dir_name, iterator, ar, 0);
 			}
 
 		}
@@ -117,30 +59,32 @@ public class MakeTarArchive implements Serializable {
 					new Path(inputPath), true);
 			boolean next = fileStatusListIterator.hasNext();
 			while (next) {
-				try (TarArchiveOutputStream ar = getTar(fileSystem, outputPath + "_" + (partNum + 1) + ".tar")) {
+				TarArchiveOutputStream ar = getTar(fileSystem, outputPath + "_" + (partNum + 1) + ".tar");
 
-					long currentSize = 0;
-					while (next && currentSize < bytesPerSplit) {
-						currentSize = writeCurrentFile(fileSystem, dir_name, fileStatusListIterator, ar, currentSize);
-						next = fileStatusListIterator.hasNext();
+				long current_size = 0;
+				while (next && current_size < bytesPerSplit) {
+					current_size = writeCurrentFile(fileSystem, dir_name, fileStatusListIterator, ar, current_size);
+					next = fileStatusListIterator.hasNext();
 
-					}
-
-					partNum += 1;
 				}
+
+				partNum += 1;
+				ar.close();
 			}
+
 		}
+
 	}
 
-	private static long writeCurrentFile(FileSystem fileSystem, String dirName,
+	private static long writeCurrentFile(FileSystem fileSystem, String dir_name,
 		RemoteIterator<LocatedFileStatus> fileStatusListIterator,
-		TarArchiveOutputStream ar, long currentSize) throws IOException {
+		TarArchiveOutputStream ar, long current_size) throws IOException {
 		LocatedFileStatus fileStatus = fileStatusListIterator.next();
 
 		Path p = fileStatus.getPath();
-		String pString = p.toString();
-		if (!pString.endsWith("_SUCCESS")) {
-			String name = pString.substring(pString.lastIndexOf("/") + 1);
+		String p_string = p.toString();
+		if (!p_string.endsWith("_SUCCESS")) {
+			String name = p_string.substring(p_string.lastIndexOf("/") + 1);
 			if (name.startsWith("part-") & name.length() > 10) {
 				String tmp = name.substring(0, 10);
 				if (name.contains(".")) {
@@ -148,9 +92,9 @@ public class MakeTarArchive implements Serializable {
 				}
 				name = tmp;
 			}
-			TarArchiveEntry entry = new TarArchiveEntry(dirName + "/" + name);
+			TarArchiveEntry entry = new TarArchiveEntry(dir_name + "/" + name);
 			entry.setSize(fileStatus.getLen());
-			currentSize += fileStatus.getLen();
+			current_size += fileStatus.getLen();
 			ar.putArchiveEntry(entry);
 
 			InputStream is = fileSystem.open(fileStatus.getPath());
@@ -166,7 +110,7 @@ public class MakeTarArchive implements Serializable {
 			ar.closeArchiveEntry();
 
 		}
-		return currentSize;
+		return current_size;
 	}
 
 }

dhp-common/src/main/java/eu/dnetlib/dhp/common/MdstoreClient.java

@@ -1,12 +1,12 @@
 
 package eu.dnetlib.dhp.common;
 
-import static com.mongodb.client.model.Sorts.descending;
-
 import java.io.Closeable;
 import java.io.IOException;
-import java.util.*;
-import java.util.stream.Collectors;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
 import java.util.stream.StreamSupport;
 
 import org.apache.commons.lang3.StringUtils;
@@ -38,26 +38,6 @@ public class MdstoreClient implements Closeable {
 		this.db = getDb(client, dbName);
 	}
 
-	private Long parseTimestamp(Document f) {
-		if (f == null || !f.containsKey("timestamp"))
-			return null;
-
-		Object ts = f.get("timestamp");
-
-		return Long.parseLong(ts.toString());
-	}
-
-	public Long getLatestTimestamp(final String collectionId) {
-		MongoCollection<Document> collection = db.getCollection(collectionId);
-		FindIterable<Document> result = collection.find().sort(descending("timestamp")).limit(1);
-		if (result == null) {
-			return null;
-		}
-
-		Document f = result.first();
-		return parseTimestamp(f);
-	}
-
 	public MongoCollection<Document> mdStore(final String mdId) {
 		BasicDBObject query = (BasicDBObject) QueryBuilder.start("mdId").is(mdId).get();
 
@@ -74,16 +54,6 @@ public class MdstoreClient implements Closeable {
 		return getColl(db, currentId, true);
 	}
 
-	public List<MDStoreInfo> mdStoreWithTimestamp(final String mdFormat, final String mdLayout,
-		final String mdInterpretation) {
-		Map<String, String> res = validCollections(mdFormat, mdLayout, mdInterpretation);
-		return res
-			.entrySet()
-			.stream()
-			.map(e -> new MDStoreInfo(e.getKey(), e.getValue(), getLatestTimestamp(e.getValue())))
-			.collect(Collectors.toList());
-	}
-
 	public Map<String, String> validCollections(
 		final String mdFormat, final String mdLayout, final String mdInterpretation) {
 

dhp-common/src/main/java/eu/dnetlib/dhp/common/action/ReadDatasourceMasterDuplicateFromDB.java

@@ -1,81 +0,0 @@
-
-package eu.dnetlib.dhp.common.action;
-
-import java.io.BufferedWriter;
-import java.io.IOException;
-import java.io.OutputStreamWriter;
-import java.nio.charset.StandardCharsets;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-
-import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.fs.FSDataOutputStream;
-import org.apache.hadoop.fs.FileSystem;
-import org.apache.hadoop.fs.Path;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import com.fasterxml.jackson.databind.ObjectMapper;
-
-import eu.dnetlib.dhp.common.DbClient;
-import eu.dnetlib.dhp.common.action.model.MasterDuplicate;
-import eu.dnetlib.dhp.schema.oaf.utils.OafMapperUtils;
-
-public class ReadDatasourceMasterDuplicateFromDB {
-
-	private static final Logger log = LoggerFactory.getLogger(ReadDatasourceMasterDuplicateFromDB.class);
-
-	private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
-
-	private static final String QUERY = "SELECT distinct dd.id as masterId, d.officialname as masterName, dd.duplicate as duplicateId "
-		+
-		"FROM dsm_dedup_services dd join dsm_services d on (dd.id = d.id);";
-
-	public static int execute(String dbUrl, String dbUser, String dbPassword, String hdfsPath, String hdfsNameNode)
-		throws IOException {
-		int count = 0;
-		try (DbClient dbClient = new DbClient(dbUrl, dbUser, dbPassword)) {
-			Configuration conf = new Configuration();
-			conf.set("fs.defaultFS", hdfsNameNode);
-			FileSystem fileSystem = FileSystem.get(conf);
-			FSDataOutputStream fos = fileSystem.create(new Path(hdfsPath));
-
-			log.info("running query: {}", QUERY);
-			log.info("storing results in: {}", hdfsPath);
-
-			try (BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(fos, StandardCharsets.UTF_8))) {
-				dbClient.processResults(QUERY, rs -> writeMap(datasourceMasterMap(rs), writer));
-				count++;
-			}
-		}
-		return count;
-	}
-
-	private static MasterDuplicate datasourceMasterMap(ResultSet rs) {
-		try {
-			final MasterDuplicate md = new MasterDuplicate();
-
-			final String duplicateId = rs.getString("duplicateId");
-			final String masterId = rs.getString("masterId");
-			final String masterName = rs.getString("masterName");
-
-			md.setDuplicateId(OafMapperUtils.createOpenaireId(10, duplicateId, true));
-			md.setMasterId(OafMapperUtils.createOpenaireId(10, masterId, true));
-			md.setMasterName(masterName);
-
-			return md;
-		} catch (final SQLException e) {
-			throw new RuntimeException(e);
-		}
-	}
-
-	private static void writeMap(final MasterDuplicate dm, final BufferedWriter writer) {
-		try {
-			writer.write(OBJECT_MAPPER.writeValueAsString(dm));
-			writer.newLine();
-		} catch (final IOException e) {
-			throw new RuntimeException(e);
-		}
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/action/model/MasterDuplicate.java

@@ -1,38 +0,0 @@
-
-package eu.dnetlib.dhp.common.action.model;
-
-import java.io.Serializable;
-
-/**
- * @author miriam.baglioni
- * @Date 21/07/22
- */
-public class MasterDuplicate implements Serializable {
-	private String duplicateId;
-	private String masterId;
-	private String masterName;
-
-	public String getDuplicateId() {
-		return duplicateId;
-	}
-
-	public void setDuplicateId(String duplicateId) {
-		this.duplicateId = duplicateId;
-	}
-
-	public String getMasterId() {
-		return masterId;
-	}
-
-	public void setMasterId(String masterId) {
-		this.masterId = masterId;
-	}
-
-	public String getMasterName() {
-		return masterName;
-	}
-
-	public void setMasterName(String masterName) {
-		this.masterName = masterName;
-	}
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/InputStreamRequestBody.java

@@ -0,0 +1,53 @@
+
+package eu.dnetlib.dhp.common.api;
+
+import java.io.IOException;
+import java.io.InputStream;
+
+import okhttp3.MediaType;
+import okhttp3.RequestBody;
+import okhttp3.internal.Util;
+import okio.BufferedSink;
+import okio.Okio;
+import okio.Source;
+
+public class InputStreamRequestBody extends RequestBody {
+
+	private final InputStream inputStream;
+	private final MediaType mediaType;
+	private final long lenght;
+
+	public static RequestBody create(final MediaType mediaType, final InputStream inputStream, final long len) {
+
+		return new InputStreamRequestBody(inputStream, mediaType, len);
+	}
+
+	private InputStreamRequestBody(InputStream inputStream, MediaType mediaType, long len) {
+		this.inputStream = inputStream;
+		this.mediaType = mediaType;
+		this.lenght = len;
+	}
+
+	@Override
+	public MediaType contentType() {
+		return mediaType;
+	}
+
+	@Override
+	public long contentLength() {
+
+		return lenght;
+
+	}
+
+	@Override
+	public void writeTo(BufferedSink sink) throws IOException {
+		Source source = null;
+		try {
+			source = Okio.source(inputStream);
+			sink.writeAll(source);
+		} finally {
+			Util.closeQuietly(source);
+		}
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/MissingConceptDoiException.java

@@ -0,0 +1,8 @@
+
+package eu.dnetlib.dhp.common.api;
+
+public class MissingConceptDoiException extends Throwable {
+	public MissingConceptDoiException(String message) {
+		super(message);
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/ZenodoAPIClient.java

@@ -0,0 +1,318 @@
+
+package eu.dnetlib.dhp.common.api;
+
+import java.io.*;
+import java.io.IOException;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.http.HttpHeaders;
+import org.apache.http.entity.ContentType;
+
+import com.google.gson.Gson;
+
+import eu.dnetlib.dhp.common.api.zenodo.ZenodoModel;
+import eu.dnetlib.dhp.common.api.zenodo.ZenodoModelList;
+import okhttp3.*;
+
+public class ZenodoAPIClient implements Serializable {
+
+	String urlString;
+	String bucket;
+
+	String deposition_id;
+	String access_token;
+
+	public static final MediaType MEDIA_TYPE_JSON = MediaType.parse("application/json; charset=utf-8");
+
+	private static final MediaType MEDIA_TYPE_ZIP = MediaType.parse("application/zip");
+
+	public String getUrlString() {
+		return urlString;
+	}
+
+	public void setUrlString(String urlString) {
+		this.urlString = urlString;
+	}
+
+	public String getBucket() {
+		return bucket;
+	}
+
+	public void setBucket(String bucket) {
+		this.bucket = bucket;
+	}
+
+	public void setDeposition_id(String deposition_id) {
+		this.deposition_id = deposition_id;
+	}
+
+	public ZenodoAPIClient(String urlString, String access_token) {
+
+		this.urlString = urlString;
+		this.access_token = access_token;
+	}
+
+	/**
+	 * Brand new deposition in Zenodo. It sets the deposition_id and the bucket where to store the files to upload
+	 *
+	 * @return response code
+	 * @throws IOException
+	 */
+	public int newDeposition() throws IOException {
+		String json = "{}";
+		OkHttpClient httpClient = new OkHttpClient.Builder().connectTimeout(600, TimeUnit.SECONDS).build();
+
+		RequestBody body = RequestBody.create(json, MEDIA_TYPE_JSON);
+
+		Request request = new Request.Builder()
+			.url(urlString)
+			.addHeader(HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.toString()) // add request headers
+			.addHeader(HttpHeaders.AUTHORIZATION, "Bearer " + access_token)
+			.post(body)
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+
+			// Get response body
+			json = response.body().string();
+
+			ZenodoModel newSubmission = new Gson().fromJson(json, ZenodoModel.class);
+			this.bucket = newSubmission.getLinks().getBucket();
+			this.deposition_id = newSubmission.getId();
+
+			return response.code();
+
+		}
+
+	}
+
+	/**
+	 * Upload files in Zenodo.
+	 *
+	 * @param is the inputStream for the file to upload
+	 * @param file_name the name of the file as it will appear on Zenodo
+	 * @param len the size of the file
+	 * @return the response code
+	 */
+	public int uploadIS(InputStream is, String file_name, long len) throws IOException {
+		OkHttpClient httpClient = new OkHttpClient.Builder()
+			.writeTimeout(600, TimeUnit.SECONDS)
+			.readTimeout(600, TimeUnit.SECONDS)
+			.connectTimeout(600, TimeUnit.SECONDS)
+			.build();
+
+		Request request = new Request.Builder()
+			.url(bucket + "/" + file_name)
+			.addHeader(HttpHeaders.CONTENT_TYPE, "application/zip") // add request headers
+			.addHeader(HttpHeaders.AUTHORIZATION, "Bearer " + access_token)
+			.put(InputStreamRequestBody.create(MEDIA_TYPE_ZIP, is, len))
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+			return response.code();
+		}
+	}
+
+	/**
+	 * Associates metadata information to the current deposition
+	 *
+	 * @param metadata the metadata
+	 * @return response code
+	 * @throws IOException
+	 */
+	public int sendMretadata(String metadata) throws IOException {
+
+		OkHttpClient httpClient = new OkHttpClient.Builder().connectTimeout(600, TimeUnit.SECONDS).build();
+
+		RequestBody body = RequestBody.create(metadata, MEDIA_TYPE_JSON);
+
+		Request request = new Request.Builder()
+			.url(urlString + "/" + deposition_id)
+			.addHeader(HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.toString()) // add request headers
+			.addHeader(HttpHeaders.AUTHORIZATION, "Bearer " + access_token)
+			.put(body)
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+
+			return response.code();
+
+		}
+
+	}
+
+	/**
+	 * To publish the current deposition. It works for both new deposition or new version of an old deposition
+	 *
+	 * @return response code
+	 * @throws IOException
+	 */
+	public int publish() throws IOException {
+
+		String json = "{}";
+
+		OkHttpClient httpClient = new OkHttpClient.Builder().connectTimeout(600, TimeUnit.SECONDS).build();
+
+		RequestBody body = RequestBody.create(json, MEDIA_TYPE_JSON);
+
+		Request request = new Request.Builder()
+			.url(urlString + "/" + deposition_id + "/actions/publish")
+			.addHeader("Authorization", "Bearer " + access_token)
+			.post(body)
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+
+			return response.code();
+
+		}
+	}
+
+	/**
+	 * To create a new version of an already published deposition. It sets the deposition_id and the bucket to be used
+	 * for the new version.
+	 *
+	 * @param concept_rec_id the concept record id of the deposition for which to create a new version. It is the last
+	 *            part of the url for the DOI Zenodo suggests to use to cite all versions: DOI: 10.xxx/zenodo.656930
+	 *            concept_rec_id = 656930
+	 * @return response code
+	 * @throws IOException
+	 * @throws MissingConceptDoiException
+	 */
+	public int newVersion(String concept_rec_id) throws IOException, MissingConceptDoiException {
+		setDepositionId(concept_rec_id);
+		String json = "{}";
+
+		OkHttpClient httpClient = new OkHttpClient.Builder().connectTimeout(600, TimeUnit.SECONDS).build();
+
+		RequestBody body = RequestBody.create(json, MEDIA_TYPE_JSON);
+
+		Request request = new Request.Builder()
+			.url(urlString + "/" + deposition_id + "/actions/newversion")
+			.addHeader(HttpHeaders.AUTHORIZATION, "Bearer " + access_token)
+			.post(body)
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+
+			ZenodoModel zenodoModel = new Gson().fromJson(response.body().string(), ZenodoModel.class);
+			String latest_draft = zenodoModel.getLinks().getLatest_draft();
+			deposition_id = latest_draft.substring(latest_draft.lastIndexOf("/") + 1);
+			bucket = getBucket(latest_draft);
+			return response.code();
+
+		}
+	}
+
+	/**
+	 * To finish uploading a version or new deposition not published
+	 * It sets the deposition_id and the bucket to be used
+	 *
+	 *
+	 * @param deposition_id the deposition id of the not yet published upload
+	 *            concept_rec_id = 656930
+	 * @return response code
+	 * @throws IOException
+	 * @throws MissingConceptDoiException
+	 */
+	public int uploadOpenDeposition(String deposition_id) throws IOException, MissingConceptDoiException {
+
+		this.deposition_id = deposition_id;
+
+		OkHttpClient httpClient = new OkHttpClient.Builder().connectTimeout(600, TimeUnit.SECONDS).build();
+
+		Request request = new Request.Builder()
+			.url(urlString + "/" + deposition_id)
+			.addHeader("Authorization", "Bearer " + access_token)
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+
+			ZenodoModel zenodoModel = new Gson().fromJson(response.body().string(), ZenodoModel.class);
+			bucket = zenodoModel.getLinks().getBucket();
+			return response.code();
+
+		}
+
+	}
+
+	private void setDepositionId(String concept_rec_id) throws IOException, MissingConceptDoiException {
+
+		ZenodoModelList zenodoModelList = new Gson().fromJson(getPrevDepositions(), ZenodoModelList.class);
+
+		for (ZenodoModel zm : zenodoModelList) {
+			if (zm.getConceptrecid().equals(concept_rec_id)) {
+				deposition_id = zm.getId();
+				return;
+			}
+		}
+
+		throw new MissingConceptDoiException("The concept record id specified was missing in the list of depositions");
+
+	}
+
+	private String getPrevDepositions() throws IOException {
+		OkHttpClient httpClient = new OkHttpClient.Builder().connectTimeout(600, TimeUnit.SECONDS).build();
+
+		Request request = new Request.Builder()
+			.url(urlString)
+			.addHeader(HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.toString()) // add request headers
+			.addHeader(HttpHeaders.AUTHORIZATION, "Bearer " + access_token)
+			.get()
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+
+			return response.body().string();
+
+		}
+
+	}
+
+	private String getBucket(String url) throws IOException {
+		OkHttpClient httpClient = new OkHttpClient.Builder()
+			.connectTimeout(600, TimeUnit.SECONDS)
+			.build();
+
+		Request request = new Request.Builder()
+			.url(url)
+			.addHeader(HttpHeaders.CONTENT_TYPE, ContentType.APPLICATION_JSON.toString()) // add request headers
+			.addHeader(HttpHeaders.AUTHORIZATION, "Bearer " + access_token)
+			.get()
+			.build();
+
+		try (Response response = httpClient.newCall(request).execute()) {
+
+			if (!response.isSuccessful())
+				throw new IOException("Unexpected code " + response + response.body().string());
+
+			// Get response body
+			ZenodoModel zenodoModel = new Gson().fromJson(response.body().string(), ZenodoModel.class);
+
+			return zenodoModel.getLinks().getBucket();
+
+		}
+
+	}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/context/CategorySummary.java

@@ -1,39 +0,0 @@
-
-package eu.dnetlib.dhp.common.api.context;
-
-public class CategorySummary {
-
-	private String id;
-
-	private String label;
-
-	private boolean hasConcept;
-
-	public String getId() {
-		return id;
-	}
-
-	public String getLabel() {
-		return label;
-	}
-
-	public boolean isHasConcept() {
-		return hasConcept;
-	}
-
-	public CategorySummary setId(final String id) {
-		this.id = id;
-		return this;
-	}
-
-	public CategorySummary setLabel(final String label) {
-		this.label = label;
-		return this;
-	}
-
-	public CategorySummary setHasConcept(final boolean hasConcept) {
-		this.hasConcept = hasConcept;
-		return this;
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/context/CategorySummaryList.java

@@ -1,7 +0,0 @@
-
-package eu.dnetlib.dhp.common.api.context;
-
-import java.util.ArrayList;
-
-public class CategorySummaryList extends ArrayList<CategorySummary> {
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/context/ConceptSummary.java

@@ -1,52 +0,0 @@
-
-package eu.dnetlib.dhp.common.api.context;
-
-import java.util.List;
-
-public class ConceptSummary {
-
-	private String id;
-
-	private String label;
-
-	public boolean hasSubConcept;
-
-	private List<ConceptSummary> concepts;
-
-	public String getId() {
-		return id;
-	}
-
-	public String getLabel() {
-		return label;
-	}
-
-	public List<ConceptSummary> getConcepts() {
-		return concepts;
-	}
-
-	public ConceptSummary setId(final String id) {
-		this.id = id;
-		return this;
-	}
-
-	public ConceptSummary setLabel(final String label) {
-		this.label = label;
-		return this;
-	}
-
-	public boolean isHasSubConcept() {
-		return hasSubConcept;
-	}
-
-	public ConceptSummary setHasSubConcept(final boolean hasSubConcept) {
-		this.hasSubConcept = hasSubConcept;
-		return this;
-	}
-
-	public ConceptSummary setConcept(final List<ConceptSummary> concepts) {
-		this.concepts = concepts;
-		return this;
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/context/ConceptSummaryList.java

@@ -1,7 +0,0 @@
-
-package eu.dnetlib.dhp.common.api.context;
-
-import java.util.ArrayList;
-
-public class ConceptSummaryList extends ArrayList<ConceptSummary> {
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/context/ContextSummary.java

@@ -1,50 +0,0 @@
-
-package eu.dnetlib.dhp.common.api.context;
-
-public class ContextSummary {
-
-	private String id;
-
-	private String label;
-
-	private String type;
-
-	private String status;
-
-	public String getId() {
-		return id;
-	}
-
-	public String getLabel() {
-		return label;
-	}
-
-	public String getType() {
-		return type;
-	}
-
-	public String getStatus() {
-		return status;
-	}
-
-	public ContextSummary setId(final String id) {
-		this.id = id;
-		return this;
-	}
-
-	public ContextSummary setLabel(final String label) {
-		this.label = label;
-		return this;
-	}
-
-	public ContextSummary setType(final String type) {
-		this.type = type;
-		return this;
-	}
-
-	public ContextSummary setStatus(final String status) {
-		this.status = status;
-		return this;
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/context/ContextSummaryList.java

@@ -1,7 +0,0 @@
-
-package eu.dnetlib.dhp.common.api.context;
-
-import java.util.ArrayList;
-
-public class ContextSummaryList extends ArrayList<ContextSummary> {
-}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/Community.java

@@ -0,0 +1,14 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+public class Community {
+	private String identifier;
+
+	public String getIdentifier() {
+		return identifier;
+	}
+
+	public void setIdentifier(String identifier) {
+		this.identifier = identifier;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/Creator.java

@@ -0,0 +1,47 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+public class Creator {
+	private String affiliation;
+	private String name;
+	private String orcid;
+
+	public String getAffiliation() {
+		return affiliation;
+	}
+
+	public void setAffiliation(String affiliation) {
+		this.affiliation = affiliation;
+	}
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+	public String getOrcid() {
+		return orcid;
+	}
+
+	public void setOrcid(String orcid) {
+		this.orcid = orcid;
+	}
+
+	public static Creator newInstance(String name, String affiliation, String orcid) {
+		Creator c = new Creator();
+		if (name != null) {
+			c.name = name;
+		}
+		if (affiliation != null) {
+			c.affiliation = affiliation;
+		}
+		if (orcid != null) {
+			c.orcid = orcid;
+		}
+
+		return c;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/File.java

@@ -0,0 +1,44 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.io.Serializable;
+
+public class File implements Serializable {
+	private String checksum;
+	private String filename;
+	private long filesize;
+	private String id;
+
+	public String getChecksum() {
+		return checksum;
+	}
+
+	public void setChecksum(String checksum) {
+		this.checksum = checksum;
+	}
+
+	public String getFilename() {
+		return filename;
+	}
+
+	public void setFilename(String filename) {
+		this.filename = filename;
+	}
+
+	public long getFilesize() {
+		return filesize;
+	}
+
+	public void setFilesize(long filesize) {
+		this.filesize = filesize;
+	}
+
+	public String getId() {
+		return id;
+	}
+
+	public void setId(String id) {
+		this.id = id;
+	}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/Grant.java

@@ -0,0 +1,23 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.io.Serializable;
+
+public class Grant implements Serializable {
+	private String id;
+
+	public String getId() {
+		return id;
+	}
+
+	public void setId(String id) {
+		this.id = id;
+	}
+
+	public static Grant newInstance(String id) {
+		Grant g = new Grant();
+		g.id = id;
+
+		return g;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/Links.java

@@ -0,0 +1,92 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.io.Serializable;
+
+public class Links implements Serializable {
+
+	private String bucket;
+
+	private String discard;
+
+	private String edit;
+	private String files;
+	private String html;
+	private String latest_draft;
+	private String latest_draft_html;
+	private String publish;
+
+	private String self;
+
+	public String getBucket() {
+		return bucket;
+	}
+
+	public void setBucket(String bucket) {
+		this.bucket = bucket;
+	}
+
+	public String getDiscard() {
+		return discard;
+	}
+
+	public void setDiscard(String discard) {
+		this.discard = discard;
+	}
+
+	public String getEdit() {
+		return edit;
+	}
+
+	public void setEdit(String edit) {
+		this.edit = edit;
+	}
+
+	public String getFiles() {
+		return files;
+	}
+
+	public void setFiles(String files) {
+		this.files = files;
+	}
+
+	public String getHtml() {
+		return html;
+	}
+
+	public void setHtml(String html) {
+		this.html = html;
+	}
+
+	public String getLatest_draft() {
+		return latest_draft;
+	}
+
+	public void setLatest_draft(String latest_draft) {
+		this.latest_draft = latest_draft;
+	}
+
+	public String getLatest_draft_html() {
+		return latest_draft_html;
+	}
+
+	public void setLatest_draft_html(String latest_draft_html) {
+		this.latest_draft_html = latest_draft_html;
+	}
+
+	public String getPublish() {
+		return publish;
+	}
+
+	public void setPublish(String publish) {
+		this.publish = publish;
+	}
+
+	public String getSelf() {
+		return self;
+	}
+
+	public void setSelf(String self) {
+		this.self = self;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/Metadata.java

@@ -0,0 +1,153 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.io.Serializable;
+import java.util.List;
+
+public class Metadata implements Serializable {
+
+	private String access_right;
+	private List<Community> communities;
+	private List<Creator> creators;
+	private String description;
+	private String doi;
+	private List<Grant> grants;
+	private List<String> keywords;
+	private String language;
+	private String license;
+	private PrereserveDoi prereserve_doi;
+	private String publication_date;
+	private List<String> references;
+	private List<RelatedIdentifier> related_identifiers;
+	private String title;
+	private String upload_type;
+	private String version;
+
+	public String getUpload_type() {
+		return upload_type;
+	}
+
+	public void setUpload_type(String upload_type) {
+		this.upload_type = upload_type;
+	}
+
+	public String getVersion() {
+		return version;
+	}
+
+	public void setVersion(String version) {
+		this.version = version;
+	}
+
+	public String getAccess_right() {
+		return access_right;
+	}
+
+	public void setAccess_right(String access_right) {
+		this.access_right = access_right;
+	}
+
+	public List<Community> getCommunities() {
+		return communities;
+	}
+
+	public void setCommunities(List<Community> communities) {
+		this.communities = communities;
+	}
+
+	public List<Creator> getCreators() {
+		return creators;
+	}
+
+	public void setCreators(List<Creator> creators) {
+		this.creators = creators;
+	}
+
+	public String getDescription() {
+		return description;
+	}
+
+	public void setDescription(String description) {
+		this.description = description;
+	}
+
+	public String getDoi() {
+		return doi;
+	}
+
+	public void setDoi(String doi) {
+		this.doi = doi;
+	}
+
+	public List<Grant> getGrants() {
+		return grants;
+	}
+
+	public void setGrants(List<Grant> grants) {
+		this.grants = grants;
+	}
+
+	public List<String> getKeywords() {
+		return keywords;
+	}
+
+	public void setKeywords(List<String> keywords) {
+		this.keywords = keywords;
+	}
+
+	public String getLanguage() {
+		return language;
+	}
+
+	public void setLanguage(String language) {
+		this.language = language;
+	}
+
+	public String getLicense() {
+		return license;
+	}
+
+	public void setLicense(String license) {
+		this.license = license;
+	}
+
+	public PrereserveDoi getPrereserve_doi() {
+		return prereserve_doi;
+	}
+
+	public void setPrereserve_doi(PrereserveDoi prereserve_doi) {
+		this.prereserve_doi = prereserve_doi;
+	}
+
+	public String getPublication_date() {
+		return publication_date;
+	}
+
+	public void setPublication_date(String publication_date) {
+		this.publication_date = publication_date;
+	}
+
+	public List<String> getReferences() {
+		return references;
+	}
+
+	public void setReferences(List<String> references) {
+		this.references = references;
+	}
+
+	public List<RelatedIdentifier> getRelated_identifiers() {
+		return related_identifiers;
+	}
+
+	public void setRelated_identifiers(List<RelatedIdentifier> related_identifiers) {
+		this.related_identifiers = related_identifiers;
+	}
+
+	public String getTitle() {
+		return title;
+	}
+
+	public void setTitle(String title) {
+		this.title = title;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/PrereserveDoi.java

@@ -0,0 +1,25 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.io.Serializable;
+
+public class PrereserveDoi implements Serializable {
+	private String doi;
+	private String recid;
+
+	public String getDoi() {
+		return doi;
+	}
+
+	public void setDoi(String doi) {
+		this.doi = doi;
+	}
+
+	public String getRecid() {
+		return recid;
+	}
+
+	public void setRecid(String recid) {
+		this.recid = recid;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/RelatedIdentifier.java

@@ -0,0 +1,43 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.io.Serializable;
+
+public class RelatedIdentifier implements Serializable {
+	private String identifier;
+	private String relation;
+	private String resource_type;
+	private String scheme;
+
+	public String getIdentifier() {
+		return identifier;
+	}
+
+	public void setIdentifier(String identifier) {
+		this.identifier = identifier;
+	}
+
+	public String getRelation() {
+		return relation;
+	}
+
+	public void setRelation(String relation) {
+		this.relation = relation;
+	}
+
+	public String getResource_type() {
+		return resource_type;
+	}
+
+	public void setResource_type(String resource_type) {
+		this.resource_type = resource_type;
+	}
+
+	public String getScheme() {
+		return scheme;
+	}
+
+	public void setScheme(String scheme) {
+		this.scheme = scheme;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/ZenodoModel.java

@@ -0,0 +1,118 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.io.Serializable;
+import java.util.List;
+
+public class ZenodoModel implements Serializable {
+
+	private String conceptrecid;
+	private String created;
+
+	private List<File> files;
+	private String id;
+	private Links links;
+	private Metadata metadata;
+	private String modified;
+	private String owner;
+	private String record_id;
+	private String state;
+	private boolean submitted;
+	private String title;
+
+	public String getConceptrecid() {
+		return conceptrecid;
+	}
+
+	public void setConceptrecid(String conceptrecid) {
+		this.conceptrecid = conceptrecid;
+	}
+
+	public String getCreated() {
+		return created;
+	}
+
+	public void setCreated(String created) {
+		this.created = created;
+	}
+
+	public List<File> getFiles() {
+		return files;
+	}
+
+	public void setFiles(List<File> files) {
+		this.files = files;
+	}
+
+	public String getId() {
+		return id;
+	}
+
+	public void setId(String id) {
+		this.id = id;
+	}
+
+	public Links getLinks() {
+		return links;
+	}
+
+	public void setLinks(Links links) {
+		this.links = links;
+	}
+
+	public Metadata getMetadata() {
+		return metadata;
+	}
+
+	public void setMetadata(Metadata metadata) {
+		this.metadata = metadata;
+	}
+
+	public String getModified() {
+		return modified;
+	}
+
+	public void setModified(String modified) {
+		this.modified = modified;
+	}
+
+	public String getOwner() {
+		return owner;
+	}
+
+	public void setOwner(String owner) {
+		this.owner = owner;
+	}
+
+	public String getRecord_id() {
+		return record_id;
+	}
+
+	public void setRecord_id(String record_id) {
+		this.record_id = record_id;
+	}
+
+	public String getState() {
+		return state;
+	}
+
+	public void setState(String state) {
+		this.state = state;
+	}
+
+	public boolean isSubmitted() {
+		return submitted;
+	}
+
+	public void setSubmitted(boolean submitted) {
+		this.submitted = submitted;
+	}
+
+	public String getTitle() {
+		return title;
+	}
+
+	public void setTitle(String title) {
+		this.title = title;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/api/zenodo/ZenodoModelList.java

@@ -0,0 +1,7 @@
+
+package eu.dnetlib.dhp.common.api.zenodo;
+
+import java.util.ArrayList;
+
+public class ZenodoModelList extends ArrayList<ZenodoModel> {
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/collection/HttpClientParams.java

@@ -1,9 +1,6 @@
 
 package eu.dnetlib.dhp.common.collection;
 
-import java.util.HashMap;
-import java.util.Map;
-
 /**
  * Bundles the http connection parameters driving the client behaviour.
  */
@@ -16,8 +13,6 @@ public class HttpClientParams {
 	public static int _connectTimeOut = 10; // seconds
 	public static int _readTimeOut = 30; // seconds
 
-	public static String _requestMethod = "GET";
-
 	/**
 	 * Maximum number of allowed retires before failing
 	 */
@@ -43,30 +38,17 @@ public class HttpClientParams {
 	 */
 	private int readTimeOut;
 
-	/**
-	 * Custom http headers
-	 */
-	private Map<String, String> headers;
-
-	/**
-	 * Request method (i.e., GET, POST etc)
-	 */
-	private String requestMethod;
-
 	public HttpClientParams() {
-		this(_maxNumberOfRetry, _requestDelay, _retryDelay, _connectTimeOut, _readTimeOut, new HashMap<>(),
-			_requestMethod);
+		this(_maxNumberOfRetry, _requestDelay, _retryDelay, _connectTimeOut, _readTimeOut);
 	}
 
 	public HttpClientParams(int maxNumberOfRetry, int requestDelay, int retryDelay, int connectTimeOut,
-		int readTimeOut, Map<String, String> headers, String requestMethod) {
+		int readTimeOut) {
 		this.maxNumberOfRetry = maxNumberOfRetry;
 		this.requestDelay = requestDelay;
 		this.retryDelay = retryDelay;
 		this.connectTimeOut = connectTimeOut;
 		this.readTimeOut = readTimeOut;
-		this.headers = headers;
-		this.requestMethod = requestMethod;
 	}
 
 	public int getMaxNumberOfRetry() {
@@ -109,19 +91,4 @@ public class HttpClientParams {
 		this.readTimeOut = readTimeOut;
 	}
 
-	public Map<String, String> getHeaders() {
-		return headers;
-	}
-
-	public void setHeaders(Map<String, String> headers) {
-		this.headers = headers;
-	}
-
-	public String getRequestMethod() {
-		return requestMethod;
-	}
-
-	public void setRequestMethod(String requestMethod) {
-		this.requestMethod = requestMethod;
-	}
 }

dhp-common/src/main/java/eu/dnetlib/dhp/common/collection/HttpConnector2.java

@@ -8,13 +8,10 @@ import java.io.InputStream;
 import java.net.*;
 import java.util.List;
 import java.util.Map;
-import java.util.concurrent.TimeUnit;
 
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.math.NumberUtils;
-import org.apache.commons.lang3.time.DateUtils;
 import org.apache.http.HttpHeaders;
-import org.joda.time.Instant;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -97,32 +94,24 @@ public class HttpConnector2 {
 			throw new CollectorException(msg);
 		}
 
+		log.info("Request attempt {} [{}]", retryNumber, requestUrl);
+
 		InputStream input = null;
 
-		long start = System.currentTimeMillis();
 		try {
 			if (getClientParams().getRequestDelay() > 0) {
 				backoffAndSleep(getClientParams().getRequestDelay());
 			}
-
-			log.info("Request attempt {} [{}]", retryNumber, requestUrl);
-
 			final HttpURLConnection urlConn = (HttpURLConnection) new URL(requestUrl).openConnection();
 			urlConn.setInstanceFollowRedirects(false);
 			urlConn.setReadTimeout(getClientParams().getReadTimeOut() * 1000);
 			urlConn.setConnectTimeout(getClientParams().getConnectTimeOut() * 1000);
 			urlConn.addRequestProperty(HttpHeaders.USER_AGENT, userAgent);
-			urlConn.setRequestMethod(getClientParams().getRequestMethod());
 
-			// if provided, add custom headers
-			if (!getClientParams().getHeaders().isEmpty()) {
-				for (Map.Entry<String, String> headerEntry : getClientParams().getHeaders().entrySet()) {
-					urlConn.addRequestProperty(headerEntry.getKey(), headerEntry.getValue());
-				}
+			if (log.isDebugEnabled()) {
+				logHeaderFields(urlConn);
 			}
 
-			logHeaderFields(urlConn);
-
 			int retryAfter = obtainRetryAfter(urlConn.getHeaderFields());
 			String rateLimit = urlConn.getHeaderField(Constants.HTTPHEADER_IETF_DRAFT_RATELIMIT_LIMIT);
 			String rateRemaining = urlConn.getHeaderField(Constants.HTTPHEADER_IETF_DRAFT_RATELIMIT_REMAINING);
@@ -136,7 +125,9 @@ public class HttpConnector2 {
 			}
 
 			if (is2xx(urlConn.getResponseCode())) {
-				return getInputStream(urlConn, start);
+				input = urlConn.getInputStream();
+				responseType = urlConn.getContentType();
+				return input;
 			}
 			if (is3xx(urlConn.getResponseCode())) {
 				// REDIRECTS
@@ -146,7 +137,6 @@ public class HttpConnector2 {
 					.put(
 						REPORT_PREFIX + urlConn.getResponseCode(),
 						String.format("Moved to: %s", newUrl));
-				logRequestTime(start);
 				urlConn.disconnect();
 				if (retryAfter > 0) {
 					backoffAndSleep(retryAfter);
@@ -162,50 +152,26 @@ public class HttpConnector2 {
 						if (retryAfter > 0) {
 							log
 								.warn(
-									"waiting and repeating request after suggested retry-after {} sec for URL {}",
-									retryAfter, requestUrl);
+									"{} - waiting and repeating request after suggested retry-after {} sec.",
+									requestUrl, retryAfter);
 							backoffAndSleep(retryAfter * 1000);
 						} else {
 							log
 								.warn(
-									"waiting and repeating request after default delay of {} sec for URL {}",
-									getClientParams().getRetryDelay(), requestUrl);
-							backoffAndSleep(retryNumber * getClientParams().getRetryDelay());
+									"{} - waiting and repeating request after default delay of {} sec.",
+									requestUrl, getClientParams().getRetryDelay());
+							backoffAndSleep(retryNumber * getClientParams().getRetryDelay() * 1000);
 						}
 						report.put(REPORT_PREFIX + urlConn.getResponseCode(), requestUrl);
-
-						logRequestTime(start);
-
 						urlConn.disconnect();
-
 						return attemptDownload(requestUrl, retryNumber + 1, report);
-					case 422: // UNPROCESSABLE ENTITY
-						report.put(REPORT_PREFIX + urlConn.getResponseCode(), requestUrl);
-						log.warn("waiting and repeating request after 10 sec for URL {}", requestUrl);
-						backoffAndSleep(10000);
-						urlConn.disconnect();
-						logRequestTime(start);
-						try {
-							return getInputStream(urlConn, start);
-						} catch (IOException e) {
-							log
-								.error(
-									"server returned 422 and got IOException accessing the response body from URL {}",
-									requestUrl);
-							log.error("IOException:", e);
-							return attemptDownload(requestUrl, retryNumber + 1, report);
-						}
 					default:
-						log.error("gor error {} from URL: {}", urlConn.getResponseCode(), urlConn.getURL());
-						log.error("response message: {}", urlConn.getResponseMessage());
 						report
 							.put(
 								REPORT_PREFIX + urlConn.getResponseCode(),
 								String
 									.format(
 										"%s Error: %s", requestUrl, urlConn.getResponseMessage()));
-						logRequestTime(start);
-						urlConn.disconnect();
 						throw new CollectorException(urlConn.getResponseCode() + " error " + report);
 				}
 			}
@@ -226,27 +192,13 @@ public class HttpConnector2 {
 		}
 	}
 
-	private InputStream getInputStream(HttpURLConnection urlConn, long start) throws IOException {
-		InputStream input = urlConn.getInputStream();
-		responseType = urlConn.getContentType();
-		logRequestTime(start);
-		return input;
-	}
-
-	private static void logRequestTime(long start) {
-		log
-			.info(
-				"request time elapsed: {}sec",
-				TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis() - start));
-	}
-
 	private void logHeaderFields(final HttpURLConnection urlConn) throws IOException {
-		log.info("Response: {} - {}", urlConn.getResponseCode(), urlConn.getResponseMessage());
+		log.debug("StatusCode: {}", urlConn.getResponseMessage());
 
 		for (Map.Entry<String, List<String>> e : urlConn.getHeaderFields().entrySet()) {
 			if (e.getKey() != null) {
 				for (String v : e.getValue()) {
-					log.info("  key: {} - value: {}", e.getKey(), v);
+					log.debug("  key: {} - value: {}", e.getKey(), v);
 				}
 			}
 		}
@@ -266,7 +218,7 @@ public class HttpConnector2 {
 		for (String key : headerMap.keySet()) {
 			if ((key != null) && key.equalsIgnoreCase(HttpHeaders.RETRY_AFTER) && (!headerMap.get(key).isEmpty())
 				&& NumberUtils.isCreatable(headerMap.get(key).get(0))) {
-				return Integer.parseInt(headerMap.get(key).get(0));
+				return Integer.parseInt(headerMap.get(key).get(0)) + 10;
 			}
 		}
 		return -1;

dhp-common/src/main/java/eu/dnetlib/dhp/common/test/TestUtils.java

@@ -0,0 +1,27 @@
+package eu.dnetlib.dhp.common.test;
+
+import org.apache.commons.io.IOUtils;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.Objects;
+
+public class TestUtils {
+
+    public static List<String> getVocabulariesMock() throws IOException {
+        return IOUtils
+                .readLines(
+                        Objects
+                                .requireNonNull(
+                                        TestUtils.class.getResourceAsStream("/eu/dnetlib/dhp/vocabulary/terms.txt")));
+    }
+
+    public static List<String> getSynonymsMock() throws IOException {
+        return IOUtils
+                .readLines(
+                        Objects
+                                .requireNonNull(
+                                        TestUtils.class.getResourceAsStream("/eu/dnetlib/dhp/vocabulary/synonyms.txt")));
+    }
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/common/vocabulary/Vocabulary.java

@@ -4,7 +4,6 @@ package eu.dnetlib.dhp.common.vocabulary;
 import java.io.Serializable;
 import java.util.HashMap;
 import java.util.Map;
-import java.util.Objects;
 import java.util.Optional;
 
 import org.apache.commons.lang3.StringUtils;
@@ -63,46 +62,25 @@ public class Vocabulary implements Serializable {
 	}
 
 	public VocabularyTerm getTermBySynonym(final String syn) {
-		return Optional
-			.ofNullable(syn)
-			.map(s -> getTerm(synonyms.get(s.toLowerCase())))
-			.orElse(null);
+		return getTerm(synonyms.get(syn.toLowerCase()));
 	}
 
 	public Qualifier getTermAsQualifier(final String termId) {
-		return getTermAsQualifier(termId, false);
-	}
-
-	public Qualifier getTermAsQualifier(final String termId, boolean strict) {
-		final VocabularyTerm term = getTerm(termId);
-		if (Objects.nonNull(term)) {
-			return OafMapperUtils.qualifier(term.getId(), term.getName(), getId(), getName());
-		} else if (Objects.isNull(term) && strict) {
+		if (StringUtils.isBlank(termId)) {
 			return OafMapperUtils.unknown(getId(), getName());
+		} else if (termExists(termId)) {
+			final VocabularyTerm t = getTerm(termId);
+			return OafMapperUtils.qualifier(t.getId(), t.getName(), getId(), getName());
 		} else {
 			return OafMapperUtils.qualifier(termId, termId, getId(), getName());
 		}
 	}
 
 	public Qualifier getSynonymAsQualifier(final String syn) {
-		return getSynonymAsQualifier(syn, false);
-	}
-
-	public Qualifier getSynonymAsQualifier(final String syn, boolean strict) {
 		return Optional
 			.ofNullable(getTermBySynonym(syn))
-			.map(term -> getTermAsQualifier(term.getId(), strict))
+			.map(term -> getTermAsQualifier(term.getId()))
 			.orElse(null);
 	}
 
-	public Qualifier lookup(String id) {
-		return lookup(id, false);
-	}
-
-	public Qualifier lookup(String id, boolean strict) {
-		return Optional
-			.ofNullable(getSynonymAsQualifier(id, strict))
-			.orElse(getTermAsQualifier(id, strict));
-	}
-
 }

dhp-common/src/main/java/eu/dnetlib/dhp/common/vocabulary/VocabularyGroup.java

@@ -81,13 +81,6 @@ public class VocabularyGroup implements Serializable {
 		vocs.put(id.toLowerCase(), new Vocabulary(id, name));
 	}
 
-	public Optional<Vocabulary> find(final String vocId) {
-		return Optional
-			.ofNullable(vocId)
-			.map(String::toLowerCase)
-			.map(vocs::get);
-	}
-
 	public void addTerm(final String vocId, final String id, final String name) {
 		if (vocabularyExists(vocId)) {
 			vocs.get(vocId.toLowerCase()).addTerm(id, name);
@@ -135,24 +128,6 @@ public class VocabularyGroup implements Serializable {
 		return vocs.get(vocId.toLowerCase()).getSynonymAsQualifier(syn);
 	}
 
-	public Qualifier lookupTermBySynonym(final String vocId, final String syn) {
-		return find(vocId)
-			.map(
-				vocabulary -> Optional
-					.ofNullable(vocabulary.getTerm(syn))
-					.map(
-						term -> OafMapperUtils
-							.qualifier(term.getId(), term.getName(), vocabulary.getId(), vocabulary.getName()))
-					.orElse(
-						Optional
-							.ofNullable(vocabulary.getTermBySynonym(syn))
-							.map(
-								term -> OafMapperUtils
-									.qualifier(term.getId(), term.getName(), vocabulary.getId(), vocabulary.getName()))
-							.orElse(null)))
-			.orElse(null);
-	}
-
 	/**
 	 * getSynonymAsQualifierCaseSensitive
 	 *

dhp-common/src/main/java/eu/dnetlib/dhp/oa/merge/AuthorMerger.java

@@ -119,131 +119,6 @@ public class AuthorMerger {
 				});
 	}
 
-	public static String normalizeFullName(final String fullname) {
-		return nfd(fullname)
-			.toLowerCase()
-			// do not compact the regexes in a single expression, would cause StackOverflowError
-			// in case
-			// of large input strings
-			.replaceAll("(\\W)+", " ")
-			.replaceAll("(\\p{InCombiningDiacriticalMarks})+", " ")
-			.replaceAll("(\\p{Punct})+", " ")
-			.replaceAll("(\\d)+", " ")
-			.replaceAll("(\\n)+", " ")
-
-			.trim();
-	}
-
-	private static String authorFieldToBeCompared(Author author) {
-		if (StringUtils.isNotBlank(author.getSurname())) {
-			return author.getSurname();
-
-		}
-		if (StringUtils.isNotBlank(author.getFullname())) {
-			return author.getFullname();
-		}
-		return null;
-	}
-
-	/**
-	 * This method tries to figure out when two author are the same in the contest
-	 * of ORCID enrichment
-	 *
-	 * @param left  Author in the OAF entity
-	 * @param right Author ORCID
-	 * @return based on a heuristic on the names of the authors if they are the same.
-	 */
-	public static boolean checkORCIDSimilarity(final Author left, final Author right) {
-		final Person pl = parse(left);
-		final Person pr = parse(right);
-
-		// If one of them didn't have a surname we verify if they have the fullName not empty
-		// and verify if the normalized version is equal
-		if (!(pl.getSurname() != null && pl.getSurname().stream().anyMatch(StringUtils::isNotBlank) &&
-			pr.getSurname() != null && pr.getSurname().stream().anyMatch(StringUtils::isNotBlank))) {
-
-			if (pl.getFullname() != null && !pl.getFullname().isEmpty() && pr.getFullname() != null
-				&& !pr.getFullname().isEmpty()) {
-				return pl
-					.getFullname()
-					.stream()
-					.anyMatch(
-						fl -> pr.getFullname().stream().anyMatch(fr -> normalize(fl).equalsIgnoreCase(normalize(fr))));
-			} else {
-				return false;
-			}
-		}
-		// The Authors have one surname in common
-		if (pl.getSurname().stream().anyMatch(sl -> pr.getSurname().stream().anyMatch(sr -> sr.equalsIgnoreCase(sl)))) {
-
-			// If one of them has only a surname and is the same we can say that they are the same author
-			if ((pl.getName() == null || pl.getName().stream().allMatch(StringUtils::isBlank)) ||
-				(pr.getName() == null || pr.getName().stream().allMatch(StringUtils::isBlank)))
-				return true;
-			// The authors have the same initials of Name in common
-			if (pl
-				.getName()
-				.stream()
-				.anyMatch(
-					nl -> pr
-						.getName()
-						.stream()
-						.anyMatch(nr -> nr.equalsIgnoreCase(nl))))
-				return true;
-		}
-
-		// Sometimes we noticed that publication have author wrote in inverse order Surname, Name
-		// We verify if we have an exact match between name and surname
-		if (pl.getSurname().stream().anyMatch(sl -> pr.getName().stream().anyMatch(nr -> nr.equalsIgnoreCase(sl))) &&
-			pl.getName().stream().anyMatch(nl -> pr.getSurname().stream().anyMatch(sr -> sr.equalsIgnoreCase(nl))))
-			return true;
-		else
-			return false;
-	}
-	//
-
-	/**
-	 * Method to enrich ORCID information in one list of authors based on another list
-	 *
-	 * @param baseAuthor  the Author List in the OAF Entity
-	 * @param orcidAuthor The list of ORCID Author intersected
-	 * @return The Author List of the OAF Entity enriched with the orcid Author
-	 */
-	public static List<Author> enrichOrcid(List<Author> baseAuthor, List<Author> orcidAuthor) {
-
-		if (baseAuthor == null || baseAuthor.isEmpty())
-			return orcidAuthor;
-
-		if (orcidAuthor == null || orcidAuthor.isEmpty())
-			return baseAuthor;
-
-		if (baseAuthor.size() == 1 && orcidAuthor.size() > 10)
-			return baseAuthor;
-
-		final List<Author> oAuthor = new ArrayList<>();
-		oAuthor.addAll(orcidAuthor);
-
-		baseAuthor.forEach(ba -> {
-			Optional<Author> aMatch = oAuthor.stream().filter(oa -> checkORCIDSimilarity(ba, oa)).findFirst();
-			if (aMatch.isPresent()) {
-				final Author sameAuthor = aMatch.get();
-				addPid(ba, sameAuthor.getPid());
-				oAuthor.remove(sameAuthor);
-			}
-		});
-		return baseAuthor;
-	}
-
-	private static void addPid(final Author a, final List<StructuredProperty> pids) {
-
-		if (a.getPid() == null) {
-			a.setPid(new ArrayList<>());
-		}
-
-		a.getPid().addAll(pids);
-
-	}
-
 	public static String pidToComparableString(StructuredProperty pid) {
 		final String classid = pid.getQualifier().getClassid() != null ? pid.getQualifier().getClassid().toLowerCase()
 			: "";
@@ -296,7 +171,7 @@ public class AuthorMerger {
 		}
 	}
 
-	public static String normalize(final String s) {
+	private static String normalize(final String s) {
 		String[] normalized = nfd(s)
 			.toLowerCase()
 			// do not compact the regexes in a single expression, would cause StackOverflowError

dhp-common/src/main/java/eu/dnetlib/dhp/oa/merge/DispatchEntitiesSparkJob.java

@@ -0,0 +1,97 @@
+
+package eu.dnetlib.dhp.oa.merge;
+
+import static eu.dnetlib.dhp.common.SparkSessionSupport.runWithSparkSession;
+
+import java.util.Objects;
+import java.util.Optional;
+
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.function.FilterFunction;
+import org.apache.spark.api.java.function.MapFunction;
+import org.apache.spark.sql.Encoders;
+import org.apache.spark.sql.SaveMode;
+import org.apache.spark.sql.SparkSession;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import eu.dnetlib.dhp.application.ArgumentApplicationParser;
+import eu.dnetlib.dhp.common.HdfsSupport;
+import eu.dnetlib.dhp.schema.oaf.Oaf;
+import eu.dnetlib.dhp.schema.oaf.OafEntity;
+
+public class DispatchEntitiesSparkJob {
+
+	private static final Logger log = LoggerFactory.getLogger(DispatchEntitiesSparkJob.class);
+
+	private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+
+	public static void main(String[] args) throws Exception {
+
+		String jsonConfiguration = IOUtils
+			.toString(
+				Objects
+					.requireNonNull(
+						DispatchEntitiesSparkJob.class
+							.getResourceAsStream(
+								"/eu/dnetlib/dhp/oa/merge/dispatch_entities_parameters.json")));
+		final ArgumentApplicationParser parser = new ArgumentApplicationParser(jsonConfiguration);
+		parser.parseArgument(args);
+
+		Boolean isSparkSessionManaged = Optional
+			.ofNullable(parser.get("isSparkSessionManaged"))
+			.map(Boolean::valueOf)
+			.orElse(Boolean.TRUE);
+		log.info("isSparkSessionManaged: {}", isSparkSessionManaged);
+
+		String inputPath = parser.get("inputPath");
+		log.info("inputPath: {}", inputPath);
+
+		String outputPath = parser.get("outputPath");
+		log.info("outputPath: {}", outputPath);
+
+		String graphTableClassName = parser.get("graphTableClassName");
+		log.info("graphTableClassName: {}", graphTableClassName);
+
+		@SuppressWarnings("unchecked")
+		Class<? extends OafEntity> entityClazz = (Class<? extends OafEntity>) Class.forName(graphTableClassName);
+
+		SparkConf conf = new SparkConf();
+		runWithSparkSession(
+			conf,
+			isSparkSessionManaged,
+			spark -> {
+				HdfsSupport.remove(outputPath, spark.sparkContext().hadoopConfiguration());
+				dispatchEntities(spark, inputPath, entityClazz, outputPath);
+			});
+	}
+
+	private static <T extends Oaf> void dispatchEntities(
+		SparkSession spark,
+		String inputPath,
+		Class<T> clazz,
+		String outputPath) {
+
+		spark
+			.read()
+			.textFile(inputPath)
+			.filter((FilterFunction<String>) s -> isEntityType(s, clazz))
+			.map((MapFunction<String, String>) s -> StringUtils.substringAfter(s, "|"), Encoders.STRING())
+			.map(
+				(MapFunction<String, T>) value -> OBJECT_MAPPER.readValue(value, clazz),
+				Encoders.bean(clazz))
+			.write()
+			.mode(SaveMode.Overwrite)
+			.option("compression", "gzip")
+			.json(outputPath);
+	}
+
+	private static <T extends Oaf> boolean isEntityType(final String s, final Class<T> clazz) {
+		return StringUtils.substringBefore(s, "|").equals(clazz.getName());
+	}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/oa/merge/GroupEntitiesSparkJob.java

@@ -2,49 +2,50 @@
 package eu.dnetlib.dhp.oa.merge;
 
 import static eu.dnetlib.dhp.common.SparkSessionSupport.runWithSparkSession;
-import static org.apache.spark.sql.functions.col;
-import static org.apache.spark.sql.functions.when;
+import static eu.dnetlib.dhp.utils.DHPUtils.toSeq;
 
-import java.util.Map;
+import java.io.IOException;
+import java.util.List;
+import java.util.Objects;
 import java.util.Optional;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ForkJoinPool;
 import java.util.stream.Collectors;
 
 import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.spark.SparkConf;
+import org.apache.spark.api.java.JavaSparkContext;
+import org.apache.spark.api.java.function.FilterFunction;
 import org.apache.spark.api.java.function.MapFunction;
-import org.apache.spark.api.java.function.ReduceFunction;
 import org.apache.spark.sql.*;
+import org.apache.spark.sql.expressions.Aggregator;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.jayway.jsonpath.Configuration;
+import com.jayway.jsonpath.DocumentContext;
+import com.jayway.jsonpath.JsonPath;
+import com.jayway.jsonpath.Option;
+
 import eu.dnetlib.dhp.application.ArgumentApplicationParser;
 import eu.dnetlib.dhp.common.HdfsSupport;
-import eu.dnetlib.dhp.common.vocabulary.VocabularyGroup;
-import eu.dnetlib.dhp.schema.common.EntityType;
 import eu.dnetlib.dhp.schema.common.ModelSupport;
-import eu.dnetlib.dhp.schema.oaf.OafEntity;
-import eu.dnetlib.dhp.schema.oaf.utils.GraphCleaningFunctions;
+import eu.dnetlib.dhp.schema.oaf.*;
 import eu.dnetlib.dhp.schema.oaf.utils.OafMapperUtils;
-import eu.dnetlib.dhp.utils.ISLookupClientFactory;
-import eu.dnetlib.enabling.is.lookup.rmi.ISLookUpException;
-import eu.dnetlib.enabling.is.lookup.rmi.ISLookUpService;
 import scala.Tuple2;
 
 /**
  * Groups the graph content by entity identifier to ensure ID uniqueness
  */
 public class GroupEntitiesSparkJob {
+
 	private static final Logger log = LoggerFactory.getLogger(GroupEntitiesSparkJob.class);
 
-	private static final Encoder<OafEntity> OAFENTITY_KRYO_ENC = Encoders.kryo(OafEntity.class);
+	private static final String ID_JPATH = "$.id";
 
-	private ArgumentApplicationParser parser;
-
-	public GroupEntitiesSparkJob(ArgumentApplicationParser parser) {
-		this.parser = parser;
-	}
+	private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper()
+		.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
 
 	public static void main(String[] args) throws Exception {
 
@@ -62,133 +63,141 @@ public class GroupEntitiesSparkJob {
 			.orElse(Boolean.TRUE);
 		log.info("isSparkSessionManaged: {}", isSparkSessionManaged);
 
-		final String isLookupUrl = parser.get("isLookupUrl");
-		log.info("isLookupUrl: {}", isLookupUrl);
-
-		final ISLookUpService isLookupService = ISLookupClientFactory.getLookUpService(isLookupUrl);
-
-		new GroupEntitiesSparkJob(parser).run(isSparkSessionManaged, isLookupService);
-	}
-
-	public void run(Boolean isSparkSessionManaged, ISLookUpService isLookUpService)
-		throws ISLookUpException {
-
 		String graphInputPath = parser.get("graphInputPath");
 		log.info("graphInputPath: {}", graphInputPath);
 
-		String checkpointPath = parser.get("checkpointPath");
-		log.info("checkpointPath: {}", checkpointPath);
-
 		String outputPath = parser.get("outputPath");
 		log.info("outputPath: {}", outputPath);
 
-		boolean filterInvisible = Boolean.parseBoolean(parser.get("filterInvisible"));
-		log.info("filterInvisible: {}", filterInvisible);
-
 		SparkConf conf = new SparkConf();
 		conf.set("spark.serializer", "org.apache.spark.serializer.KryoSerializer");
 		conf.registerKryoClasses(ModelSupport.getOafModelClasses());
 
-		final VocabularyGroup vocs = VocabularyGroup.loadVocsFromIS(isLookUpService);
-
 		runWithSparkSession(
 			conf,
 			isSparkSessionManaged,
 			spark -> {
-				HdfsSupport.remove(checkpointPath, spark.sparkContext().hadoopConfiguration());
-				groupEntities(spark, graphInputPath, checkpointPath, outputPath, filterInvisible, vocs);
+				HdfsSupport.remove(outputPath, spark.sparkContext().hadoopConfiguration());
+				groupEntities(spark, graphInputPath, outputPath);
 			});
 	}
 
 	private static void groupEntities(
 		SparkSession spark,
 		String inputPath,
-		String checkpointPath,
-		String outputPath,
-		boolean filterInvisible, VocabularyGroup vocs) {
+		String outputPath) {
 
-		Dataset<OafEntity> allEntities = spark.emptyDataset(OAFENTITY_KRYO_ENC);
-
-		for (Map.Entry<EntityType, Class> e : ModelSupport.entityTypes.entrySet()) {
-			String entity = e.getKey().name();
-			Class<? extends OafEntity> entityClass = e.getValue();
-			String entityInputPath = inputPath + "/" + entity;
-
-			if (!HdfsSupport.exists(entityInputPath, spark.sparkContext().hadoopConfiguration())) {
-				continue;
-			}
-
-			allEntities = allEntities
-				.union(
-					((Dataset<OafEntity>) spark
-						.read()
-						.schema(Encoders.bean(entityClass).schema())
-						.json(entityInputPath)
-						.filter("length(id) > 0")
-						.as(Encoders.bean(entityClass)))
-							.map((MapFunction<OafEntity, OafEntity>) r -> r, OAFENTITY_KRYO_ENC));
-		}
-
-		Dataset<?> groupedEntities = allEntities
+		final TypedColumn<OafEntity, OafEntity> aggregator = new GroupingAggregator().toColumn();
+		final JavaSparkContext sc = JavaSparkContext.fromSparkContext(spark.sparkContext());
+		spark
+			.read()
+			.textFile(toSeq(listEntityPaths(inputPath, sc)))
+			.map((MapFunction<String, OafEntity>) GroupEntitiesSparkJob::parseOaf, Encoders.kryo(OafEntity.class))
+			.filter((FilterFunction<OafEntity>) e -> StringUtils.isNotBlank(ModelSupport.idFn().apply(e)))
+			.groupByKey((MapFunction<OafEntity, String>) oaf -> ModelSupport.idFn().apply(oaf), Encoders.STRING())
+			.agg(aggregator)
 			.map(
-				(MapFunction<OafEntity, OafEntity>) entity -> GraphCleaningFunctions
-					.applyCoarVocabularies(entity, vocs),
-				OAFENTITY_KRYO_ENC)
-			.groupByKey((MapFunction<OafEntity, String>) OafEntity::getId, Encoders.STRING())
-			.reduceGroups((ReduceFunction<OafEntity>) OafMapperUtils::mergeEntities)
-			.map(
-				(MapFunction<Tuple2<String, OafEntity>, Tuple2<String, OafEntity>>) t -> new Tuple2<>(
-					t._2().getClass().getName(), t._2()),
-				Encoders.tuple(Encoders.STRING(), OAFENTITY_KRYO_ENC));
-
-		// pivot on "_1" (classname of the entity)
-		// created columns containing only entities of the same class
-		for (Map.Entry<EntityType, Class> e : ModelSupport.entityTypes.entrySet()) {
-			String entity = e.getKey().name();
-			Class<? extends OafEntity> entityClass = e.getValue();
-
-			groupedEntities = groupedEntities
-				.withColumn(
-					entity,
-					when(col("_1").equalTo(entityClass.getName()), col("_2")));
-		}
-
-		groupedEntities
-			.drop("_1", "_2")
+				(MapFunction<Tuple2<String, OafEntity>, String>) t -> t._2().getClass().getName() +
+					"|" + OBJECT_MAPPER.writeValueAsString(t._2()),
+				Encoders.STRING())
 			.write()
-			.mode(SaveMode.Overwrite)
 			.option("compression", "gzip")
-			.save(checkpointPath);
-
-		ForkJoinPool parPool = new ForkJoinPool(ModelSupport.entityTypes.size());
-
-		ModelSupport.entityTypes
-			.entrySet()
-			.stream()
-			.map(e -> parPool.submit(() -> {
-				String entity = e.getKey().name();
-				Class<? extends OafEntity> entityClass = e.getValue();
-
-				spark
-					.read()
-					.load(checkpointPath)
-					.select(col(entity).as("value"))
-					.filter("value IS NOT NULL")
-					.as(OAFENTITY_KRYO_ENC)
-					.map((MapFunction<OafEntity, OafEntity>) r -> r, (Encoder<OafEntity>) Encoders.bean(entityClass))
-					.filter(filterInvisible ? "dataInfo.invisible != TRUE" : "TRUE")
-					.write()
-					.mode(SaveMode.Overwrite)
-					.option("compression", "gzip")
-					.json(outputPath + "/" + entity);
-			}))
-			.collect(Collectors.toList())
-			.forEach(t -> {
-				try {
-					t.get();
-				} catch (InterruptedException | ExecutionException e) {
-					throw new RuntimeException(e);
-				}
-			});
+			.mode(SaveMode.Overwrite)
+			.text(outputPath);
 	}
+
+	public static class GroupingAggregator extends Aggregator<OafEntity, OafEntity, OafEntity> {
+
+		@Override
+		public OafEntity zero() {
+			return null;
+		}
+
+		@Override
+		public OafEntity reduce(OafEntity b, OafEntity a) {
+			return mergeAndGet(b, a);
+		}
+
+		private OafEntity mergeAndGet(OafEntity b, OafEntity a) {
+			if (Objects.nonNull(a) && Objects.nonNull(b)) {
+				return OafMapperUtils.mergeEntities(b, a);
+			}
+			return Objects.isNull(a) ? b : a;
+		}
+
+		@Override
+		public OafEntity merge(OafEntity b, OafEntity a) {
+			return mergeAndGet(b, a);
+		}
+
+		@Override
+		public OafEntity finish(OafEntity j) {
+			return j;
+		}
+
+		@Override
+		public Encoder<OafEntity> bufferEncoder() {
+			return Encoders.kryo(OafEntity.class);
+		}
+
+		@Override
+		public Encoder<OafEntity> outputEncoder() {
+			return Encoders.kryo(OafEntity.class);
+		}
+
+	}
+
+	private static OafEntity parseOaf(String s) {
+
+		DocumentContext dc = JsonPath
+			.parse(s, Configuration.defaultConfiguration().addOptions(Option.SUPPRESS_EXCEPTIONS));
+		final String id = dc.read(ID_JPATH);
+		if (StringUtils.isNotBlank(id)) {
+
+			String prefix = StringUtils.substringBefore(id, "|");
+			switch (prefix) {
+				case "10":
+					return parse(s, Datasource.class);
+				case "20":
+					return parse(s, Organization.class);
+				case "40":
+					return parse(s, Project.class);
+				case "50":
+					String resultType = dc.read("$.resulttype.classid");
+					switch (resultType) {
+						case "publication":
+							return parse(s, Publication.class);
+						case "dataset":
+							return parse(s, eu.dnetlib.dhp.schema.oaf.Dataset.class);
+						case "software":
+							return parse(s, Software.class);
+						case "other":
+							return parse(s, OtherResearchProduct.class);
+						default:
+							throw new IllegalArgumentException(String.format("invalid resultType: '%s'", resultType));
+					}
+				default:
+					throw new IllegalArgumentException(String.format("invalid id prefix: '%s'", prefix));
+			}
+		} else {
+			throw new IllegalArgumentException(String.format("invalid oaf: '%s'", s));
+		}
+	}
+
+	private static <T extends OafEntity> OafEntity parse(String s, Class<T> clazz) {
+		try {
+			return OBJECT_MAPPER.readValue(s, clazz);
+		} catch (IOException e) {
+			throw new IllegalArgumentException(e);
+		}
+	}
+
+	private static List<String> listEntityPaths(String inputPath, JavaSparkContext sc) {
+		return HdfsSupport
+			.listFiles(inputPath, sc.hadoopConfiguration())
+			.stream()
+			.filter(f -> !f.toLowerCase().contains("relation"))
+			.collect(Collectors.toList());
+	}
+
 }

dhp-common/src/main/java/eu/dnetlib/dhp/oozie/RunSQLSparkJob.java

@@ -1,77 +0,0 @@
-
-package eu.dnetlib.dhp.oozie;
-
-import static eu.dnetlib.dhp.common.SparkSessionSupport.runWithSparkHiveSession;
-
-import java.net.URL;
-import java.nio.charset.StandardCharsets;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Optional;
-
-import org.apache.commons.lang3.time.DurationFormatUtils;
-import org.apache.commons.text.StringSubstitutor;
-import org.apache.spark.SparkConf;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import com.google.common.io.Resources;
-
-import eu.dnetlib.dhp.application.ArgumentApplicationParser;
-
-public class RunSQLSparkJob {
-	private static final Logger log = LoggerFactory.getLogger(RunSQLSparkJob.class);
-
-	private final ArgumentApplicationParser parser;
-
-	public RunSQLSparkJob(ArgumentApplicationParser parser) {
-		this.parser = parser;
-	}
-
-	public static void main(String[] args) throws Exception {
-
-		Map<String, String> params = new HashMap<>();
-		for (int i = 0; i < args.length - 1; i++) {
-			if (args[i].startsWith("--")) {
-				params.put(args[i].substring(2), args[++i]);
-			}
-		}
-
-		/*
-		 * String jsonConfiguration = IOUtils .toString( Objects .requireNonNull( RunSQLSparkJob.class
-		 * .getResourceAsStream( "/eu/dnetlib/dhp/oozie/run_sql_parameters.json"))); final ArgumentApplicationParser
-		 * parser = new ArgumentApplicationParser(jsonConfiguration); parser.parseArgument(args);
-		 */
-
-		Boolean isSparkSessionManaged = Optional
-			.ofNullable(params.get("isSparkSessionManaged"))
-			.map(Boolean::valueOf)
-			.orElse(Boolean.TRUE);
-		log.info("isSparkSessionManaged: {}", isSparkSessionManaged);
-
-		URL url = com.google.common.io.Resources.getResource(params.get("sql"));
-		String raw_sql = Resources.toString(url, StandardCharsets.UTF_8);
-
-		String sql = StringSubstitutor.replace(raw_sql, params);
-		log.info("sql: {}", sql);
-
-		SparkConf conf = new SparkConf();
-		conf.set("hive.metastore.uris", params.get("hiveMetastoreUris"));
-
-		runWithSparkHiveSession(
-			conf,
-			isSparkSessionManaged,
-			spark -> {
-				for (String statement : sql.split(";\\s*/\\*\\s*EOS\\s*\\*/\\s*")) {
-					log.info("executing: {}", statement);
-					long startTime = System.currentTimeMillis();
-					spark.sql(statement).show();
-					log
-						.info(
-							"executed in {}",
-							DurationFormatUtils.formatDuration(System.currentTimeMillis() - startTime, "HH:mm:ss.S"));
-				}
-			});
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/CleaningFunctions.java

@@ -0,0 +1,74 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Set;
+
+import org.apache.commons.lang3.StringUtils;
+
+import eu.dnetlib.dhp.schema.oaf.StructuredProperty;
+
+public class CleaningFunctions {
+
+	public static final String DOI_PREFIX_REGEX = "(^10\\.|\\/10\\.)";
+	public static final String DOI_PREFIX = "10.";
+
+	public static final Set<String> PID_BLACKLIST = new HashSet<>();
+
+	static {
+		PID_BLACKLIST.add("none");
+		PID_BLACKLIST.add("na");
+	}
+
+	public CleaningFunctions() {}
+
+	/**
+	 * Utility method that filter PID values on a per-type basis.
+	 * @param s the PID whose value will be checked.
+	 * @return false if the pid matches the filter criteria, true otherwise.
+	 */
+	public static boolean pidFilter(StructuredProperty s) {
+		final String pidValue = s.getValue();
+		if (Objects.isNull(s.getQualifier()) ||
+			StringUtils.isBlank(pidValue) ||
+			StringUtils.isBlank(pidValue.replaceAll("(?:\\n|\\r|\\t|\\s)", ""))) {
+			return false;
+		}
+		if (CleaningFunctions.PID_BLACKLIST.contains(pidValue)) {
+			return false;
+		}
+		return !PidBlacklistProvider.getBlacklist(s.getQualifier().getClassid()).contains(pidValue);
+	}
+
+	/**
+	 * Utility method that normalises PID values on a per-type basis.
+	 * @param pid the PID whose value will be normalised.
+	 * @return the PID containing the normalised value.
+	 */
+	public static StructuredProperty normalizePidValue(StructuredProperty pid) {
+		pid.setValue(
+				normalizePidValue(
+					pid.getQualifier().getClassid(),
+					pid.getValue()));
+
+		return pid;
+	}
+
+	public static String normalizePidValue(String pidType, String pidValue) {
+		String value = Optional
+				.ofNullable(pidValue)
+				.map(String::trim)
+				.orElseThrow(() -> new IllegalArgumentException("PID value cannot be empty"));
+
+		switch (pidType) {
+
+			// TODO add cleaning for more PID types as needed
+			case "doi":
+				return value.toLowerCase().replaceFirst(DOI_PREFIX_REGEX, DOI_PREFIX);
+		}
+		return value;
+	}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/DoiCleaningRule.java

@@ -1,14 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-public class DoiCleaningRule {
-
-	public static String clean(final String doi) {
-		return doi
-			.toLowerCase()
-			.replaceAll("\\s", "")
-			.replaceAll("^doi:", "")
-			.replaceFirst(CleaningFunctions.DOI_PREFIX_REGEX, CleaningFunctions.DOI_PREFIX);
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/FundRefCleaningRule.java

@@ -1,25 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-public class FundRefCleaningRule {
-
-	public static final Pattern PATTERN = Pattern.compile("\\d+");
-
-	public static String clean(final String fundRefId) {
-
-		String s = fundRefId
-			.toLowerCase()
-			.replaceAll("\\s", "");
-
-		Matcher m = PATTERN.matcher(s);
-		if (m.find()) {
-			return m.group();
-		} else {
-			return "";
-		}
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/GridCleaningRule.java

@@ -1,24 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-public class GridCleaningRule {
-
-	public static final Pattern PATTERN = Pattern.compile("(?<grid>\\d{4,6}\\.[0-9a-z]{1,2})");
-
-	public static String clean(String grid) {
-		String s = grid
-			.replaceAll("\\s", "")
-			.toLowerCase();
-
-		Matcher m = PATTERN.matcher(s);
-		if (m.find()) {
-			return "grid." + m.group("grid");
-		}
-
-		return "";
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/ISNICleaningRule.java

@@ -1,21 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-// https://www.wikidata.org/wiki/Property:P213
-public class ISNICleaningRule {
-
-	public static final Pattern PATTERN = Pattern.compile("([0]{4}) ?([0-9]{4}) ?([0-9]{4}) ?([0-9]{3}[0-9X])");
-
-	public static String clean(final String isni) {
-
-		Matcher m = PATTERN.matcher(isni);
-		if (m.find()) {
-			return String.join("", m.group(1), m.group(2), m.group(3), m.group(4));
-		} else {
-			return "";
-		}
-	}
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/IdentifierFactory.java

@@ -0,0 +1,283 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static eu.dnetlib.dhp.schema.common.ModelConstants.*;
+
+import java.io.Serializable;
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
+import java.util.*;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import org.apache.commons.codec.binary.Hex;
+import org.apache.commons.lang3.StringUtils;
+
+import com.google.common.collect.HashBiMap;
+import com.google.common.collect.Maps;
+
+import eu.dnetlib.dhp.schema.common.ModelSupport;
+import eu.dnetlib.dhp.schema.oaf.*;
+
+/**
+ * Factory class for OpenAIRE identifiers in the Graph
+ */
+public class IdentifierFactory implements Serializable {
+
+	public static final String ID_SEPARATOR = "::";
+	public static final String ID_PREFIX_SEPARATOR = "|";
+
+	public static final int ID_PREFIX_LEN = 12;
+
+	/**
+	 * Declares the associations PID_TYPE -> [DATASOURCE ID, NAME] considered authoritative for that PID_TYPE
+	 */
+	public static final Map<PidType, HashBiMap<String, String>> PID_AUTHORITY = Maps.newHashMap();
+
+	static {
+		PID_AUTHORITY.put(PidType.doi, HashBiMap.create());
+		PID_AUTHORITY.get(PidType.doi).put(CROSSREF_ID, "Crossref");
+		PID_AUTHORITY.get(PidType.doi).put(DATACITE_ID, "Datacite");
+		PID_AUTHORITY.get(PidType.doi).put(ZENODO_OD_ID, "ZENODO");
+		PID_AUTHORITY.get(PidType.doi).put(ZENODO_R3_ID, "Zenodo");
+
+		PID_AUTHORITY.put(PidType.pmc, HashBiMap.create());
+		PID_AUTHORITY.get(PidType.pmc).put(EUROPE_PUBMED_CENTRAL_ID, "Europe PubMed Central");
+		PID_AUTHORITY.get(PidType.pmc).put(PUBMED_CENTRAL_ID, "PubMed Central");
+
+		PID_AUTHORITY.put(PidType.pmid, HashBiMap.create());
+		PID_AUTHORITY.get(PidType.pmid).put(EUROPE_PUBMED_CENTRAL_ID, "Europe PubMed Central");
+		PID_AUTHORITY.get(PidType.pmid).put(PUBMED_CENTRAL_ID, "PubMed Central");
+
+		PID_AUTHORITY.put(PidType.arXiv, HashBiMap.create());
+		PID_AUTHORITY.get(PidType.arXiv).put(ARXIV_ID, "arXiv.org e-Print Archive");
+	}
+
+	/**
+	 * Declares the associations PID_TYPE -> [DATASOURCE ID, PID SUBSTRING] considered as delegated authority for that
+	 * PID_TYPE. Example, Zenodo is delegated to forge DOIs that contain the 'zenodo' word.
+	 */
+	public static final Map<PidType, Map<String, String>> DELEGATED_PID_AUTHORITY = Maps.newHashMap();
+
+	static {
+		DELEGATED_PID_AUTHORITY.put(PidType.doi, new HashMap<>());
+		DELEGATED_PID_AUTHORITY.get(PidType.doi).put(ZENODO_OD_ID, "zenodo");
+		DELEGATED_PID_AUTHORITY.get(PidType.doi).put(ZENODO_R3_ID, "zenodo");
+	}
+
+	/**
+	 * Declares the associations PID_TYPE -> [DATASOURCE ID, NAME] whose records are considered enrichment for the graph.
+	 * Their OpenAIRE ID is built from the declared PID type. Are merged with their corresponding record, identified by
+	 * the same OpenAIRE id.
+	 */
+	public static final Map<PidType, HashBiMap<String, String>> ENRICHMENT_PROVIDER = Maps.newHashMap();
+
+	static {
+		ENRICHMENT_PROVIDER.put(PidType.doi, HashBiMap.create());
+		ENRICHMENT_PROVIDER.get(PidType.doi).put(OPEN_APC_ID, OPEN_APC_NAME);
+	}
+
+	public static Set<String> delegatedAuthorityDatasourceIds() {
+		return DELEGATED_PID_AUTHORITY.values()
+				.stream()
+				.flatMap(m -> m.keySet().stream())
+				.collect(Collectors.toCollection(HashSet::new));
+	}
+
+	public static List<StructuredProperty> getPids(List<StructuredProperty> pid, KeyValue collectedFrom) {
+		return pidFromInstance(pid, collectedFrom, true).distinct().collect(Collectors.toList());
+	}
+
+	public static <T extends Result> String createDOIBoostIdentifier(T entity) {
+		if (entity == null)
+			return null;
+
+		StructuredProperty pid = null;
+		if (entity.getPid() != null) {
+			pid = entity
+				.getPid()
+				.stream()
+				.filter(Objects::nonNull)
+				.filter(s -> s.getQualifier() != null && "doi".equalsIgnoreCase(s.getQualifier().getClassid()))
+				.filter(CleaningFunctions::pidFilter)
+				.findAny()
+				.orElse(null);
+		} else {
+			if (entity.getInstance() != null) {
+				pid = entity
+					.getInstance()
+					.stream()
+					.filter(i -> i.getPid() != null)
+					.flatMap(i -> i.getPid().stream())
+					.filter(CleaningFunctions::pidFilter)
+					.findAny()
+					.orElse(null);
+			}
+		}
+		if (pid != null)
+			return idFromPid(entity, pid, true);
+		return null;
+	}
+
+	/**
+	 * Creates an identifier from the most relevant PID (if available) provided by a known PID authority in the given
+	 * entity T. Returns entity.id when none of the PIDs meet the selection criteria is available.
+	 *
+	 * @param entity the entity providing PIDs and a default ID.
+	 * @param <T> the specific entity type. Currently Organization and Result subclasses are supported.
+	 * @param md5 indicates whether should hash the PID value or not.
+	 * @return an identifier from the most relevant PID, entity.id otherwise
+	 */
+	public static <T extends OafEntity> String createIdentifier(T entity, boolean md5) {
+
+		checkArgument(StringUtils.isNoneBlank(entity.getId()), "missing entity identifier");
+
+		final Map<String, Set<StructuredProperty>> pids = extractPids(entity);
+
+		return pids
+			.values()
+			.stream()
+			.flatMap(Set::stream)
+			.min(new PidComparator<>(entity))
+			.map(
+				min -> Optional
+					.ofNullable(pids.get(min.getQualifier().getClassid()))
+					.map(
+						p -> p
+							.stream()
+							.sorted(new PidValueComparator())
+							.findFirst()
+							.map(s -> idFromPid(entity, s, md5))
+							.orElseGet(entity::getId))
+					.orElseGet(entity::getId))
+			.orElseGet(entity::getId);
+	}
+
+	private static <T extends OafEntity> Map<String, Set<StructuredProperty>> extractPids(T entity) {
+		if (entity instanceof Result) {
+			return Optional
+				.ofNullable(((Result) entity).getInstance())
+				.map(IdentifierFactory::mapPids)
+				.orElse(new HashMap<>());
+		} else {
+			return entity
+				.getPid()
+				.stream()
+				.map(CleaningFunctions::normalizePidValue)
+				.filter(CleaningFunctions::pidFilter)
+				.collect(
+					Collectors
+						.groupingBy(
+							p -> p.getQualifier().getClassid(),
+							Collectors.mapping(p -> p, Collectors.toCollection(HashSet::new))));
+		}
+	}
+
+	private static Map<String, Set<StructuredProperty>> mapPids(List<Instance> instance) {
+		return instance
+			.stream()
+			.map(i -> pidFromInstance(i.getPid(), i.getCollectedfrom(), false))
+			.flatMap(Function.identity())
+			.collect(
+				Collectors
+					.groupingBy(
+						p -> p.getQualifier().getClassid(),
+						Collectors.mapping(p -> p, Collectors.toCollection(HashSet::new))));
+	}
+
+	private static Stream<StructuredProperty> pidFromInstance(List<StructuredProperty> pid, KeyValue collectedFrom,
+		boolean mapHandles) {
+		return Optional
+			.ofNullable(pid)
+			.map(
+				pp -> pp
+					.stream()
+					// filter away PIDs provided by a DS that is not considered an authority for the
+					// given PID Type
+					.filter(p -> shouldFilterPidByCriteria(collectedFrom, p, mapHandles))
+					.map(CleaningFunctions::normalizePidValue)
+					.filter(p -> isNotFromDelegatedAuthority(collectedFrom, p))
+					.filter(CleaningFunctions::pidFilter))
+			.orElse(Stream.empty());
+	}
+
+
+	private static boolean shouldFilterPidByCriteria(KeyValue collectedFrom, StructuredProperty p, boolean mapHandles) {
+		final PidType pType = PidType.tryValueOf(p.getQualifier().getClassid());
+
+		if (Objects.isNull(collectedFrom)) {
+			return false;
+		}
+
+		boolean isEnrich = Optional
+				.ofNullable(ENRICHMENT_PROVIDER.get(pType))
+				.map(enrich -> enrich.containsKey(collectedFrom.getKey())
+						|| enrich.containsValue(collectedFrom.getValue()))
+				.orElse(false);
+
+		boolean isAuthority = Optional
+				.ofNullable(PID_AUTHORITY.get(pType))
+				.map(authorities -> authorities.containsKey(collectedFrom.getKey())
+						|| authorities.containsValue(collectedFrom.getValue()))
+				.orElse(false);
+
+		return (mapHandles && pType.equals(PidType.handle)) || isEnrich || isAuthority;
+	}
+
+	private static boolean isNotFromDelegatedAuthority(KeyValue collectedFrom, StructuredProperty p) {
+		final PidType pType = PidType.tryValueOf(p.getQualifier().getClassid());
+
+		final Map<String, String> da = DELEGATED_PID_AUTHORITY.get(pType);
+		if (Objects.isNull(da)) {
+			return true;
+		}
+		if (!da.containsKey(collectedFrom.getKey())) {
+			return true;
+		}
+		return StringUtils.contains(p.getValue(), da.get(collectedFrom.getKey()));
+	}
+
+	/**
+	 * @see {@link IdentifierFactory#createIdentifier(OafEntity, boolean)}
+	 */
+	public static <T extends OafEntity> String createIdentifier(T entity) {
+
+		return createIdentifier(entity, true);
+	}
+
+	private static <T extends OafEntity> String idFromPid(T entity, StructuredProperty s, boolean md5) {
+		return idFromPid(ModelSupport.getIdPrefix(entity.getClass()), s.getQualifier().getClassid(), s.getValue(), md5);
+	}
+
+	public static String idFromPid(String numericPrefix, String pidType, String pidValue, boolean md5) {
+		return new StringBuilder()
+				.append(numericPrefix)
+				.append(ID_PREFIX_SEPARATOR)
+				.append(createPrefix(pidType))
+				.append(ID_SEPARATOR)
+				.append(md5 ? md5(pidValue) : pidValue)
+				.toString();
+	}
+
+	// create the prefix (length = 12)
+	private static String createPrefix(String pidType) {
+		StringBuilder prefix = new StringBuilder(StringUtils.left(pidType, ID_PREFIX_LEN));
+		while (prefix.length() < ID_PREFIX_LEN) {
+			prefix.append("_");
+		}
+		return prefix.substring(0, ID_PREFIX_LEN);
+	}
+
+	public static String md5(final String s) {
+		try {
+			final MessageDigest md = MessageDigest.getInstance("MD5");
+			md.update(s.getBytes(StandardCharsets.UTF_8));
+			return new String(Hex.encodeHex(md.digest()));
+		} catch (final Exception e) {
+			return null;
+		}
+	}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/ModelHardLimits.java

@@ -0,0 +1,24 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+public class ModelHardLimits {
+
+	private ModelHardLimits() {}
+
+	public static final String LAYOUT = "index";
+	public static final String INTERPRETATION = "openaire";
+	public static final String SEPARATOR = "-";
+
+	public static final int MAX_EXTERNAL_ENTITIES = 50;
+	public static final int MAX_AUTHORS = 200;
+	public static final int MAX_AUTHOR_FULLNAME_LENGTH = 1000;
+	public static final int MAX_TITLE_LENGTH = 5000;
+	public static final int MAX_TITLES = 10;
+	public static final int MAX_ABSTRACT_LENGTH = 150000;
+	public static final int MAX_INSTANCES = 10;
+
+	public static String getCollectionName(String format) {
+		return format + SEPARATOR + LAYOUT + SEPARATOR + INTERPRETATION;
+	}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/OafMapperUtils.java

@@ -26,26 +26,21 @@ public class OafMapperUtils {
 		if (ModelSupport.isSubClass(left, OafEntity.class)) {
 			return mergeEntities((OafEntity) left, (OafEntity) right);
 		} else if (ModelSupport.isSubClass(left, Relation.class)) {
-			((Relation) left).mergeFrom((Relation) right);
+			return OafUtils.mergeOAF(left, right);
 		} else {
 			throw new IllegalArgumentException("invalid Oaf type:" + left.getClass().getCanonicalName());
 		}
-		return left;
 	}
 
 	public static OafEntity mergeEntities(OafEntity left, OafEntity right) {
 		if (ModelSupport.isSubClass(left, Result.class)) {
 			return mergeResults((Result) left, (Result) right);
-		} else if (ModelSupport.isSubClass(left, Datasource.class)) {
-			left.mergeFrom(right);
-		} else if (ModelSupport.isSubClass(left, Organization.class)) {
-			left.mergeFrom(right);
-		} else if (ModelSupport.isSubClass(left, Project.class)) {
-			left.mergeFrom(right);
+		} else if (ModelSupport.isSubClass(left, Datasource.class) || ModelSupport.isSubClass(left, Organization.class) || ModelSupport.isSubClass(left, Project.class))
+		{
+			return OafUtils.mergeOAF(left, right);
 		} else {
 			throw new IllegalArgumentException("invalid OafEntity subtype:" + left.getClass().getCanonicalName());
 		}
-		return left;
 	}
 
 	public static Result mergeResults(Result left, Result right) {
@@ -59,13 +54,11 @@ public class OafMapperUtils {
 		if (!leftFromDelegatedAuthority && rightFromDelegatedAuthority) {
 			return right;
 		}
-
 		if (new ResultTypeComparator().compare(left, right) < 0) {
-			left.mergeFrom(right);
-			return left;
+			return OafUtils.mergeOAF(left, right);
 		} else {
-			right.mergeFrom(left);
-			return right;
+			return OafUtils.mergeOAF(right, left);
+
 		}
 	}
 
@@ -140,30 +133,8 @@ public class OafMapperUtils {
 			.collect(Collectors.toList());
 	}
 
-	public static InstanceTypeMapping instanceTypeMapping(String originalType, String code, String label,
-		String vocabularyName) {
-		final InstanceTypeMapping m = new InstanceTypeMapping();
-		m.setVocabularyName(vocabularyName);
-		m.setOriginalType(originalType);
-		m.setTypeCode(code);
-		m.setTypeLabel(label);
-		return m;
-	}
-
-	public static InstanceTypeMapping instanceTypeMapping(String originalType, Qualifier term) {
-		return instanceTypeMapping(originalType, term.getClassid(), term.getClassname(), term.getSchemeid());
-	}
-
-	public static InstanceTypeMapping instanceTypeMapping(String originalType) {
-		return instanceTypeMapping(originalType, null, null, null);
-	}
-
-	public static InstanceTypeMapping instanceTypeMapping(String originalType, String vocabularyName) {
-		return instanceTypeMapping(originalType, null, null, vocabularyName);
-	}
-
 	public static Qualifier unknown(final String schemeid, final String schemename) {
-		return qualifier(UNKNOWN, "Unknown", schemeid, schemename);
+		return qualifier("UNKNOWN", "Unknown", schemeid, schemename);
 	}
 
 	public static AccessRight accessRight(
@@ -211,17 +182,6 @@ public class OafMapperUtils {
 		return q;
 	}
 
-	public static Subject subject(
-		final String value,
-		final String classid,
-		final String classname,
-		final String schemeid,
-		final String schemename,
-		final DataInfo dataInfo) {
-
-		return subject(value, qualifier(classid, classname, schemeid, schemename), dataInfo);
-	}
-
 	public static StructuredProperty structuredProperty(
 		final String value,
 		final String classid,
@@ -233,20 +193,6 @@ public class OafMapperUtils {
 		return structuredProperty(value, qualifier(classid, classname, schemeid, schemename), dataInfo);
 	}
 
-	public static Subject subject(
-		final String value,
-		final Qualifier qualifier,
-		final DataInfo dataInfo) {
-		if (value == null) {
-			return null;
-		}
-		final Subject s = new Subject();
-		s.setValue(value);
-		s.setQualifier(qualifier);
-		s.setDataInfo(dataInfo);
-		return s;
-	}
-
 	public static StructuredProperty structuredProperty(
 		final String value,
 		final Qualifier qualifier,
@@ -298,6 +244,9 @@ public class OafMapperUtils {
 		return p;
 	}
 
+
+
+
 	public static Journal journal(
 		final String name,
 		final String issnPrinted,
@@ -463,76 +412,7 @@ public class OafMapperUtils {
 	public static Measure newMeasureInstance(String id, String value, String key, DataInfo dataInfo) {
 		Measure m = new Measure();
 		m.setId(id);
-		m.setUnit(Arrays.asList(newKeyValueInstance(key, value, dataInfo)));
+		m.setUnit(Collections.singletonList(newKeyValueInstance(key, value, dataInfo)));
 		return m;
 	}
-
-	public static Relation getRelation(final String source,
-		final String target,
-		final String relType,
-		final String subRelType,
-		final String relClass,
-		final OafEntity entity) {
-		return getRelation(source, target, relType, subRelType, relClass, entity, null);
-	}
-
-	public static Relation getRelation(final String source,
-		final String target,
-		final String relType,
-		final String subRelType,
-		final String relClass,
-		final OafEntity entity,
-		final String validationDate) {
-		return getRelation(
-			source, target, relType, subRelType, relClass, entity.getCollectedfrom(), entity.getDataInfo(),
-			entity.getLastupdatetimestamp(), validationDate, null);
-	}
-
-	public static Relation getRelation(final String source,
-		final String target,
-		final String relType,
-		final String subRelType,
-		final String relClass,
-		final List<KeyValue> collectedfrom,
-		final DataInfo dataInfo,
-		final Long lastupdatetimestamp) {
-		return getRelation(
-			source, target, relType, subRelType, relClass, collectedfrom, dataInfo, lastupdatetimestamp, null, null);
-	}
-
-	public static Relation getRelation(final String source,
-		final String target,
-		final String relType,
-		final String subRelType,
-		final String relClass,
-		final List<KeyValue> collectedfrom,
-		final DataInfo dataInfo,
-		final Long lastupdatetimestamp,
-		final String validationDate,
-		final List<KeyValue> properties) {
-		final Relation rel = new Relation();
-		rel.setRelType(relType);
-		rel.setSubRelType(subRelType);
-		rel.setRelClass(relClass);
-		rel.setSource(source);
-		rel.setTarget(target);
-		rel.setCollectedfrom(collectedfrom);
-		rel.setDataInfo(dataInfo);
-		rel.setLastupdatetimestamp(lastupdatetimestamp);
-		rel.setValidated(StringUtils.isNotBlank(validationDate));
-		rel.setValidationDate(StringUtils.isNotBlank(validationDate) ? validationDate : null);
-		rel.setProperties(properties);
-		return rel;
-	}
-
-	public static String getProvenance(DataInfo dataInfo) {
-		return Optional
-			.ofNullable(dataInfo)
-			.map(
-				d -> Optional
-					.ofNullable(d.getProvenanceaction())
-					.map(Qualifier::getClassid)
-					.orElse(""))
-			.orElse("");
-	}
 }

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/OafUtils.java

@@ -0,0 +1,761 @@
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import com.google.common.base.Preconditions;
+import eu.dnetlib.dhp.common.api.zenodo.File;
+import eu.dnetlib.dhp.schema.common.AccessRightComparator;
+import eu.dnetlib.dhp.schema.common.ModelConstants;
+import eu.dnetlib.dhp.schema.common.ModelSupport;
+import eu.dnetlib.dhp.schema.oaf.*;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.tuple.ImmutablePair;
+import org.apache.commons.lang3.tuple.Pair;
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.ibm.icu.text.PluralRules.Operand.e;
+
+import java.text.ParseException;
+import java.util.*;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+/**
+ * The type Oaf utils class groups all
+ * the utilities method used for OAF Generation
+ */
+public class OafUtils {
+
+    /**
+     * Normalize pid string.
+     *
+     * @param pid the pid
+     * @return the string
+     */
+    public static String extractKeyFromPid(final StructuredProperty pid) {
+        if (pid == null)
+            return null;
+        final  StructuredProperty normalizedPid = CleaningFunctions.normalizePidValue(pid);
+
+        return String.format("%s::%s", normalizedPid.getQualifier().getClassid(), normalizedPid.getValue());
+    }
+
+
+    /**
+     * This method converts the list of instance enrichments
+     * into a Map where the key is the normalized identifier
+     * and the value is the instance itself
+     *
+     * @param ri the list of enrichment instances
+     * @return the result map
+     */
+    public static Map<String, Instance> toInstanceMap(final List<Instance> ri) {
+
+
+        return ri
+                .stream()
+                .filter(i -> i.getPid() != null || i.getAlternateIdentifier() != null)
+                .flatMap(i -> {
+                    final List<Pair<String, Instance>> result = new ArrayList<>();
+                    if (i.getPid() != null)
+                        i.getPid().stream().filter(OafUtils::validPid).forEach(p -> result.add(new ImmutablePair<>(extractKeyFromPid(p), i)));
+                    if (i.getAlternateIdentifier() != null)
+                        i.getAlternateIdentifier().stream().filter(OafUtils::validPid).forEach(p -> result.add(new ImmutablePair<>(extractKeyFromPid(p), i)));
+                    return result.stream();
+                }).collect(Collectors.toMap(
+                        Pair::getLeft,
+                        Pair::getRight,
+                        (a, b) -> a
+                ));
+    }
+
+    /**
+     * Valid pid boolean.
+     *
+     * @param p the p
+     * @return the boolean
+     */
+    private static boolean validPid(final StructuredProperty p) {
+        return p.getValue()!= null && p.getQualifier()!= null && p.getQualifier().getClassid()!=null;
+    }
+
+
+
+    /**
+     * This utility method finds the list of enrichment instances
+     * that match one or more PIDs in the input list
+     *
+     * @param pids        the list of PIDs
+     * @param enrichments the List of enrichment instances having the same pid
+     * @return the list
+     */
+    private static List<Instance> findEnrichmentsByPID(final List<StructuredProperty> pids, final Map<String,Instance> enrichments) {
+        if (pids == null || enrichments == null)
+            return null;
+        return pids
+                .stream()
+                .map(OafUtils::extractKeyFromPid)
+                .map(enrichments::get)
+                .filter(Objects::nonNull)
+                .collect(Collectors.toList());
+    }
+
+    /**
+     * Is an enrichment boolean.
+     *
+     * @param e the e
+     * @return the boolean
+     */
+    public static boolean isAnEnrichment(OafEntity e) {
+        return e.getDataInfo()!= null &&
+                e.getDataInfo().getProvenanceaction()!= null
+                && ModelConstants.PROVENANCE_ENRICH.equalsIgnoreCase(e.getDataInfo().getProvenanceaction().getClassid());
+    }
+
+
+    /**
+     * This method apply enrichment on a single instance
+     * The enrichment consists of replacing values on
+     * single attribute only if in the current instance is missing
+     * The only repeatable field enriched is measures
+     *
+     * @param currentInstance the current instance
+     * @param enrichment      the enrichment instance
+     */
+    private static void applyEnrichment(final Instance currentInstance, final Instance enrichment) {
+        if (currentInstance == null || enrichment == null)
+            return;
+
+        //ENRICH accessright
+        if (enrichment.getAccessright()!=null && currentInstance.getAccessright() == null)
+            currentInstance.setAccessright(enrichment.getAccessright());
+
+        //ENRICH license
+        if (enrichment.getLicense()!=null && currentInstance.getLicense() == null)
+            currentInstance.setLicense(enrichment.getLicense());
+
+        //ENRICH instanceType
+        if (enrichment.getInstancetype()!=null && currentInstance.getInstancetype() == null)
+            currentInstance.setInstancetype(enrichment.getInstancetype());
+
+        //ENRICH hostedby
+        if (enrichment.getHostedby()!=null && currentInstance.getHostedby() == null)
+            currentInstance.setHostedby(enrichment.getHostedby());
+
+        //ENRICH distributionlocation
+        if (enrichment.getDistributionlocation()!=null && currentInstance.getDistributionlocation() == null)
+            currentInstance.setDistributionlocation(enrichment.getDistributionlocation());
+
+        //ENRICH collectedfrom
+        if (enrichment.getCollectedfrom()!=null && currentInstance.getCollectedfrom() == null)
+            currentInstance.setCollectedfrom(enrichment.getCollectedfrom());
+
+        //ENRICH dateofacceptance
+        if (enrichment.getDateofacceptance()!=null && currentInstance.getDateofacceptance() == null)
+            currentInstance.setDateofacceptance(enrichment.getDateofacceptance());
+
+        //ENRICH processingchargeamount
+        if (enrichment.getProcessingchargeamount()!=null && currentInstance.getProcessingchargeamount() == null)
+            currentInstance.setProcessingchargeamount(enrichment.getProcessingchargeamount());
+
+        //ENRICH refereed
+        if (enrichment.getRefereed()!=null && currentInstance.getRefereed() == null)
+            currentInstance.setRefereed(enrichment.getRefereed());
+
+        //ENRICH measures
+        if (enrichment.getMeasures()!=null)
+            if (currentInstance.getMeasures() == null)
+                currentInstance.setMeasures(enrichment.getMeasures());
+            else
+                enrichment.getMeasures().forEach(currentInstance.getMeasures()::add);
+
+    }
+
+
+    /**
+     * This main method apply the enrichment of the instances
+     *
+     * @param toEnrichInstances   the instances that could be enriched
+     * @param enrichmentInstances the enrichment instances
+     * @return list of instances possibly enriched
+     */
+    private static List<Instance> enrichInstances(final List<Instance> toEnrichInstances,final List<Instance> enrichmentInstances) {
+        final List<Instance> enrichmentResult = new ArrayList<>();
+
+        if (toEnrichInstances == null) {
+            return enrichmentResult;
+        }
+        if (enrichmentInstances == null) {
+            return enrichmentResult;
+        }
+        Map<String, Instance> ri = toInstanceMap(enrichmentInstances);
+
+        toEnrichInstances.forEach(i -> {
+            final List<Instance> e = findEnrichmentsByPID(i.getPid(), ri);
+            if (e!= null && e.size()> 0) {
+                e.forEach(enr -> applyEnrichment(i, enr));
+            } else {
+                final List<Instance> a = findEnrichmentsByPID(i.getAlternateIdentifier(), ri);
+                if (a!= null && a.size()> 0) {
+                    a.forEach(enr -> applyEnrichment(i, enr));
+                }
+            }
+            enrichmentResult.add(i);
+        });
+        return enrichmentResult;
+    }
+
+    /**
+     * Longest lists list.
+     *
+     * @param a the a
+     * @param b the b
+     * @return the list
+     */
+    public static List<Field<String>> longestLists(List<Field<String>> a, List<Field<String>> b) {
+        if (a == null || b == null)
+            return a == null ? b : a;
+        if (a.size() == b.size()) {
+            int msa = a
+                    .stream()
+                    .filter(i -> i != null && i.getValue() != null)
+                    .map(i -> i.getValue().length())
+                    .max(Comparator.naturalOrder())
+                    .orElse(0);
+            int msb = b
+                    .stream()
+                    .filter(i -> i != null && i.getValue() != null)
+                    .map(i -> i.getValue().length())
+                    .max(Comparator.naturalOrder())
+                    .orElse(0);
+            return msa > msb ? a : b;
+        }
+        return a.size() > b.size() ? a : b;
+    }
+
+
+    /**
+     * This method merge two oaf object of the same type
+     * It should replace the mergeFrom utility inside the oaf
+     * class.
+     *
+     * @param original First object
+     * @param enrich   second object
+     * @return the merged object
+     */
+    public static <T extends Oaf> T mergeOAF(T original, T enrich) {
+        if (original == null)
+            return enrich;
+        if (enrich == null)
+            return original;
+
+        if (original.getClass() != enrich.getClass())
+            throw new RuntimeException(String.format("Trying to merge different types of object %s, and %s",
+                    original.getClass().getCanonicalName(),
+                    enrich.getClass().getCanonicalName()));
+
+        Oaf result ;
+
+        switch (original.getClass().getSimpleName().toLowerCase()) {
+            case "relation":
+                result = mergeOAFRelation((Relation) original, (Relation) enrich);
+                break;
+            case "publication":
+                result = mergeOAFPublication((Publication) original, (Publication) enrich);
+                break;
+            case "dataset":
+                result = mergeOAFDataset((Dataset) original, (Dataset) enrich);
+                break;
+            case "software":
+                result = mergeOAFSoftware((Software) original, (Software) enrich);
+                break;
+            case "otherresearchproduct":
+                result = mergeOAFOtherResearchProduct((OtherResearchProduct) original, (OtherResearchProduct) enrich);
+                break;
+            case "project":
+                result = mergeOAFProject((Project) original, (Project)enrich);
+                break;
+            case "organization":
+                result = mergeOAFOrganization((Organization) original, (Organization)enrich);
+                break;
+            default:
+                throw new RuntimeException("Trying to merge an unsupported class");
+
+
+        }
+        result.setCollectedfrom(
+                Stream
+                        .concat(
+                                Optional
+                                        .ofNullable(original.getCollectedfrom())
+                                        .map(Collection::stream)
+                                        .orElse(Stream.empty()),
+                                Optional
+                                        .ofNullable(enrich.getCollectedfrom())
+                                        .map(Collection::stream)
+                                        .orElse(Stream.empty()))
+                        .distinct() // relies on KeyValue.equals
+                        .collect(Collectors.toList()));
+
+        result.setLastupdatetimestamp(
+                Math
+                        .max(
+                                Optional.ofNullable(original.getLastupdatetimestamp()).orElse(0L),
+                                Optional.ofNullable(enrich.getLastupdatetimestamp()).orElse(0L)));
+
+        return (T) result;
+
+    }
+
+
+    @SafeVarargs
+    public static  <T> List<T> mergeLists(final List<T>... lists) {
+
+        return Arrays
+                .stream(lists)
+                .filter(Objects::nonNull)
+                .flatMap(List::stream)
+                .filter(Objects::nonNull)
+                .distinct()
+                .collect(Collectors.toList());
+    }
+
+
+    private static int compareTrust(Oaf a, Oaf b) {
+        return extractTrust(a).compareTo(extractTrust(b));
+    }
+
+    private static String extractTrust(Oaf e) {
+        if (e == null || e.getDataInfo() == null || e.getDataInfo().getTrust() == null)
+            return "0.0";
+        return e.getDataInfo().getTrust();
+    }
+
+
+    private static void mergeOAFDataInfo(Oaf from, Oaf to) {
+        Optional.ofNullable(to)
+                .ifPresent(other -> Optional.ofNullable(other.getDataInfo())
+                        .ifPresent(otherDataInfo -> Optional.ofNullable(from.getDataInfo())
+                                .ifPresent(thisDataInfo -> {
+                                    if (compareTrust(from, other) < 0 || thisDataInfo.getInvisible()) {
+                                        from.setDataInfo(otherDataInfo);
+                                    }
+                                })));
+    }
+
+
+    /**
+     * Gets main title.
+     *
+     * @param titles the titles
+     * @return the main title
+     */
+    private static StructuredProperty getMainTitle(final List<StructuredProperty> titles) {
+        // need to check if the list of titles contains more than 1 main title? (in that case, we should chose which
+        // main title select in the list)
+        for (StructuredProperty t : titles) {
+            if (t.getQualifier() != null && t.getQualifier().getClassid() != null)
+                if (t.getQualifier().getClassid().equals("main title"))
+                    return t;
+        }
+        return null;
+    }
+
+
+    private static OafEntity mergeEntity(final OafEntity original,final  OafEntity enrich) {
+
+        final OafEntity mergedEntity = original;
+
+
+        mergedEntity.setOriginalId(mergeLists(mergedEntity.getOriginalId(), enrich.getOriginalId()));
+
+        mergedEntity.setPid(mergeLists(mergedEntity.getPid(), enrich.getPid()));
+
+
+        if (enrich.getDateofcollection() != null && compareTrust(mergedEntity, enrich) < 0)
+            mergedEntity.setDateofcollection(enrich.getDateofcollection());
+
+        if (enrich.getDateoftransformation() != null && compareTrust(mergedEntity, enrich) < 0)
+            mergedEntity.setDateoftransformation(enrich.getDateoftransformation());
+
+        mergedEntity.setExtraInfo(mergeLists(mergedEntity.getExtraInfo(), enrich.getExtraInfo()));
+
+        if (enrich.getOaiprovenance() != null && compareTrust(mergedEntity, enrich) < 0)
+            mergedEntity.setOaiprovenance(enrich.getOaiprovenance());
+
+        return mergedEntity;
+
+
+    }
+
+    private static Result mergeOAFResult(final Result original,final  Result enrich) {
+
+
+        final Result mergedResult = (Result) mergeEntity(original, enrich);
+
+        if(mergedResult.getProcessingchargeamount() == null || StringUtils.isBlank(mergedResult.getProcessingchargeamount().getValue() )){
+            mergedResult.setProcessingchargeamount(enrich.getProcessingchargeamount());
+            mergedResult.setProcessingchargecurrency(enrich.getProcessingchargecurrency());
+        }
+
+        mergedResult.setMeasures(mergeLists(mergedResult.getMeasures(), enrich.getMeasures()));
+
+        if( !isAnEnrichment(mergedResult) && !isAnEnrichment(enrich))
+            mergedResult.setInstance(mergeLists(mergedResult.getInstance(), enrich.getInstance()));
+        else {
+            final List<Instance> enrichmentInstances = isAnEnrichment(mergedResult) ? mergedResult.getInstance() : enrich.getInstance();
+            final List<Instance> enrichedInstances= isAnEnrichment(mergedResult) ?  enrich.getInstance(): mergedResult.getInstance();
+            if (isAnEnrichment(mergedResult))
+                mergedResult.setDataInfo(enrich.getDataInfo());
+            mergedResult.setInstance(enrichInstances(enrichedInstances,enrichmentInstances));
+        }
+
+        if (enrich.getBestaccessright() != null
+                && new AccessRightComparator().compare(enrich.getBestaccessright(), mergedResult.getBestaccessright()) < 0)
+            mergedResult.setBestaccessright(enrich.getBestaccessright());
+
+        if (enrich.getResulttype() != null && compareTrust(mergedResult, enrich) < 0)
+            mergedResult.setResulttype(enrich.getResulttype());
+
+        if (enrich.getLanguage() != null && compareTrust(mergedResult, enrich) < 0)
+            mergedResult.setLanguage(enrich.getLanguage());
+
+        if (Objects.nonNull(enrich.getDateofacceptance())) {
+            if (Objects.isNull(mergedResult.getDateofacceptance())) {
+                mergedResult.setDateofacceptance(enrich.getDateofacceptance());
+            } else if (compareTrust(mergedResult, enrich) < 0) {
+                mergedResult.setDateofacceptance(enrich.getDateofacceptance());
+            }
+        }
+
+        mergedResult.setCountry(mergeLists(mergedResult.getCountry(), enrich.getCountry()));
+
+        mergedResult.setSubject(mergeLists(mergedResult.getSubject(), enrich.getSubject()));
+
+        // merge title lists: main title with higher trust and distinct between the others
+        StructuredProperty baseMainTitle = null;
+        if (mergedResult.getTitle() != null) {
+            baseMainTitle = getMainTitle(mergedResult.getTitle());
+            if (baseMainTitle != null) {
+                final StructuredProperty p = baseMainTitle;
+                mergedResult.setTitle(mergedResult.getTitle().stream().filter(t -> t != p).collect(Collectors.toList()));
+            }
+        }
+
+        StructuredProperty newMainTitle = null;
+        if (enrich.getTitle() != null) {
+            newMainTitle = getMainTitle(enrich.getTitle());
+            if (newMainTitle != null) {
+                final StructuredProperty p = newMainTitle;
+                enrich.setTitle(enrich.getTitle().stream().filter(t -> t != p).collect(Collectors.toList()));
+            }
+        }
+
+        if (newMainTitle != null && compareTrust(mergedResult, enrich) < 0) {
+            baseMainTitle = newMainTitle;
+        }
+
+        mergedResult.setTitle(mergeLists(mergedResult.getTitle(), enrich.getTitle()));
+        if (mergedResult.getTitle() != null && baseMainTitle != null) {
+            mergedResult.getTitle().add(baseMainTitle);
+        }
+
+        mergedResult.setRelevantdate (mergeLists(mergedResult.getRelevantdate(), enrich.getRelevantdate()));
+
+        mergedResult.setDescription( longestLists(mergedResult.getDescription(), enrich.getDescription()));
+
+        if (enrich.getPublisher() != null && compareTrust(mergedResult, enrich) < 0)
+            mergedResult.setPublisher(enrich.getPublisher());
+
+        if (enrich.getEmbargoenddate() != null && compareTrust(mergedResult, enrich) < 0)
+            mergedResult.setEmbargoenddate(enrich.getEmbargoenddate());
+
+        mergedResult.setSource(mergeLists(mergedResult.getSource(), enrich.getSource()));
+
+        mergedResult.setFulltext(mergeLists(mergedResult.getFulltext(), enrich.getFulltext()));
+
+        mergedResult.setFormat(mergeLists(mergedResult.getFormat(), enrich.getFormat()));
+
+        mergedResult.setContributor(mergeLists(mergedResult.getContributor(), enrich.getContributor()));
+
+        if (enrich.getResourcetype() != null)
+            mergedResult.setResourcetype(enrich.getResourcetype());
+
+        mergedResult.setCoverage(mergeLists(mergedResult.getCoverage(), enrich.getCoverage()));
+
+        mergedResult.setContext(mergeLists(mergedResult.getContext(), enrich.getContext()));
+
+        mergedResult.setExternalReference(mergeLists(mergedResult.getExternalReference(), enrich.getExternalReference()));
+
+        return mergedResult;
+    }
+
+    private static OtherResearchProduct mergeOAFOtherResearchProduct(final OtherResearchProduct original,final  OtherResearchProduct enrich) {
+        final OtherResearchProduct mergedORP = (OtherResearchProduct) mergeOAFResult(original, enrich);
+
+
+        mergedORP.setContactperson(mergeLists(mergedORP.getContactperson(), enrich.getContactperson()));
+        mergedORP.setContactgroup(mergeLists(mergedORP.getContactgroup(), enrich.getContactgroup()));
+        mergedORP.setTool(mergeLists(mergedORP.getTool(), enrich.getTool()));
+        mergeOAFDataInfo(mergedORP, enrich);
+
+        return mergedORP;
+    }
+
+    private static Software mergeOAFSoftware(final Software original, final Software enrich) {
+        final Software mergedSoftware = (Software) mergeOAFResult(original, enrich);
+
+        mergedSoftware.setDocumentationUrl(mergeLists(mergedSoftware.getDocumentationUrl(), enrich.getDocumentationUrl()));
+
+        mergedSoftware.setLicense(mergeLists(mergedSoftware.getLicense(), enrich.getLicense()));
+
+        mergedSoftware.setCodeRepositoryUrl(enrich.getCodeRepositoryUrl() != null && compareTrust(mergedSoftware,enrich) < 0
+                ? enrich.getCodeRepositoryUrl()
+                : mergedSoftware.getCodeRepositoryUrl());
+
+        mergedSoftware.setProgrammingLanguage(enrich.getProgrammingLanguage() != null && compareTrust(mergedSoftware, enrich) < 0
+                ? enrich.getProgrammingLanguage()
+                : mergedSoftware.getProgrammingLanguage());
+
+        mergeOAFDataInfo(mergedSoftware, enrich);
+        return mergedSoftware;
+    }
+
+    private static Dataset mergeOAFDataset(Dataset original, Dataset enrich) {
+
+        final Dataset mergedDataset = (Dataset) mergeOAFResult(original, enrich);
+
+        mergedDataset.setStoragedate(enrich.getStoragedate() != null && compareTrust(mergedDataset, enrich) < 0 ? enrich.getStoragedate() : mergedDataset.getStoragedate());
+
+        mergedDataset.setDevice(enrich.getDevice() != null && compareTrust(mergedDataset, enrich) < 0 ? enrich.getDevice() : mergedDataset.getDevice());
+
+        mergedDataset.setSize(enrich.getSize() != null && compareTrust(mergedDataset, enrich) < 0 ? enrich.getSize() : mergedDataset.getSize());
+
+        mergedDataset.setVersion(enrich.getVersion() != null && compareTrust(mergedDataset, enrich) < 0 ? enrich.getVersion() : mergedDataset.getVersion());
+
+        mergedDataset.setLastmetadataupdate(
+                enrich.getLastmetadataupdate() != null && compareTrust(mergedDataset,enrich) < 0
+                ? enrich.getLastmetadataupdate()
+                : mergedDataset.getLastmetadataupdate());
+
+        mergedDataset.setMetadataversionnumber(
+                enrich.getMetadataversionnumber() != null && compareTrust(mergedDataset, enrich) < 0
+                ? enrich.getMetadataversionnumber()
+                : mergedDataset.getMetadataversionnumber());
+
+        mergedDataset.setGeolocation(mergeLists(mergedDataset.getGeolocation(), enrich.getGeolocation()));
+
+        mergeOAFDataInfo(mergedDataset, enrich);
+
+        return mergedDataset;
+    }
+
+    private static Publication mergeOAFPublication(Publication original, Publication enrich) {
+
+        final Publication mergedPublication = (Publication) mergeOAFResult(original, enrich);
+
+        if (enrich.getJournal() != null && compareTrust(mergedPublication, enrich) < 0)
+            mergedPublication.setJournal(enrich.getJournal());
+        mergeOAFDataInfo(mergedPublication, enrich);
+        return mergedPublication;
+    }
+
+
+    private static Relation mergeOAFRelation(Relation from, Relation to) {
+
+            checkArgument(Objects.equals(from.getSource(), to.getSource()), "source ids must be equal");
+            checkArgument(Objects.equals(from.getTarget(), to.getTarget()), "target ids must be equal");
+            checkArgument(Objects.equals(from.getRelType(), to.getRelType()), "relType(s) must be equal");
+            checkArgument(
+                    Objects.equals(from.getSubRelType(), to.getSubRelType()), "subRelType(s) must be equal");
+            checkArgument(Objects.equals(from.getRelClass(), to.getRelClass()), "relClass(es) must be equal");
+
+            from.setValidated(from.getValidated() || to.getValidated());
+            try {
+                from.setValidationDate(ModelSupport.oldest(from.getValidationDate(), to.getValidationDate()));
+            } catch (ParseException e) {
+                throw new IllegalArgumentException(String
+                        .format(
+                                "invalid validation date format in relation [s:%s, t:%s]: %s", from.getSource(), from.getTarget(),
+                                from.getValidationDate()));
+            }
+
+            return from;
+    }
+
+
+    private static Oaf mergeOAFOrganization(Organization original, Organization enrich) {
+
+        final Organization mergedOrganization = (Organization) mergeEntity(original, enrich);
+
+        int ct = compareTrust(mergedOrganization, enrich);
+        mergedOrganization.setLegalshortname(enrich.getLegalshortname() != null && ct < 0
+                ? enrich.getLegalshortname()
+                : mergedOrganization.getLegalname());
+
+
+        mergedOrganization.setLegalname(enrich.getLegalname() != null && ct < 0 ?
+                enrich.getLegalname()
+                : mergedOrganization.getLegalname());
+
+        mergedOrganization.setAlternativeNames(mergeLists(enrich.getAlternativeNames(), mergedOrganization.getAlternativeNames()));
+
+
+        mergedOrganization.setWebsiteurl(enrich.getWebsiteurl() != null && ct < 0
+                ? enrich.getWebsiteurl()
+                : mergedOrganization.getWebsiteurl());
+
+        mergedOrganization.setLogourl(enrich.getLogourl() != null && ct < 0
+                ? enrich.getLogourl()
+                : mergedOrganization.getLogourl());
+
+        mergedOrganization.setEclegalbody(enrich.getEclegalbody() != null && ct < 0
+                ? enrich.getEclegalbody()
+                : mergedOrganization.getEclegalbody());
+
+        mergedOrganization.setEclegalperson(enrich.getEclegalperson() != null && ct < 0
+                        ? enrich.getEclegalperson()
+                        : mergedOrganization.getEclegalperson());
+
+        mergedOrganization.setEcnonprofit (enrich.getEcnonprofit() != null && ct< 0
+                ? enrich.getEcnonprofit()
+                : mergedOrganization.getEcnonprofit());
+
+        mergedOrganization.setEcresearchorganization (enrich.getEcresearchorganization() != null && ct < 0
+                ? enrich.getEcresearchorganization()
+                : mergedOrganization.getEcresearchorganization());
+
+        mergedOrganization.setEchighereducation (enrich.getEchighereducation() != null && ct < 0
+                ? enrich.getEchighereducation()
+                : mergedOrganization.getEchighereducation());
+
+        mergedOrganization.setEcinternationalorganizationeurinterests (enrich.getEcinternationalorganizationeurinterests() != null && ct< 0
+                ? enrich.getEcinternationalorganizationeurinterests()
+                : mergedOrganization.getEcinternationalorganizationeurinterests());
+
+        mergedOrganization.setEcinternationalorganization (enrich.getEcinternationalorganization() != null && ct < 0
+                ? enrich.getEcinternationalorganization()
+                : mergedOrganization.getEcinternationalorganization());
+
+        mergedOrganization.setEcenterprise (enrich.getEcenterprise() != null && ct < 0
+                ? enrich.getEcenterprise()
+                : mergedOrganization.getEcenterprise());
+
+        mergedOrganization.setEcsmevalidated (enrich.getEcsmevalidated() != null && ct < 0
+                ? enrich.getEcsmevalidated()
+                : mergedOrganization.getEcsmevalidated());
+        mergedOrganization.setEcnutscode( enrich.getEcnutscode() != null && ct < 0
+                ? enrich.getEcnutscode()
+                : mergedOrganization.getEcnutscode());
+
+        mergedOrganization.setCountry (enrich.getCountry() != null && ct < 0 ?
+                enrich.getCountry()
+                :mergedOrganization.getCountry());
+
+        mergeOAFDataInfo(mergedOrganization, enrich);
+
+        return mergedOrganization;
+    }
+
+    private static Oaf mergeOAFProject(Project original, Project enrich) {
+
+        final Project mergedProject = (Project) mergeEntity(original, enrich);
+
+        int ct = compareTrust(mergedProject, enrich);
+
+
+        mergedProject.setWebsiteurl (enrich.getWebsiteurl() != null && ct < 0
+                ? enrich.getWebsiteurl()
+                : mergedProject.getWebsiteurl());
+
+        mergedProject.setCode(enrich.getCode() != null && ct < 0 ?
+                enrich.getCode() :
+                mergedProject.getCode());
+
+        mergedProject.setAcronym(enrich.getAcronym() != null && ct < 0
+                ? enrich.getAcronym()
+                : mergedProject.getAcronym());
+
+        mergedProject.setTitle (enrich.getTitle() != null && ct < 0
+                ? enrich.getTitle()
+                : mergedProject.getTitle());
+        mergedProject.setStartdate (enrich.getStartdate() != null && ct < 0
+                ? enrich.getStartdate()
+                : mergedProject.getStartdate());
+        mergedProject.setEnddate (enrich.getEnddate() != null && ct < 0
+                ? enrich.getEnddate()
+                : mergedProject.getEnddate());
+        mergedProject.setCallidentifier ( enrich.getCallidentifier() != null && ct < 0
+                ? enrich.getCallidentifier()
+                : mergedProject.getCallidentifier());
+        mergedProject.setKeywords  ( enrich.getKeywords() != null && ct < 0
+                ? enrich.getKeywords()
+                : mergedProject.getKeywords());
+
+        mergedProject.setDuration ( enrich.getDuration() != null && ct < 0
+                ? enrich.getDuration()
+                : mergedProject.getDuration());
+        mergedProject.setEcsc39 ( enrich.getEcsc39() != null && ct < 0
+                ? enrich.getEcsc39() :
+                mergedProject.getEcsc39());
+        mergedProject.setOamandatepublications ( enrich.getOamandatepublications() != null && ct < 0
+                ? enrich.getOamandatepublications()
+                : mergedProject.getOamandatepublications());
+        mergedProject.setEcarticle29_3 (enrich.getEcarticle29_3() != null && ct < 0
+                ? enrich.getEcarticle29_3()
+                : mergedProject.getEcarticle29_3());
+
+        mergedProject.setSubjects (mergeLists(mergedProject.getSubjects(), enrich.getSubjects()));
+        mergedProject.setFundingtree (mergeLists(mergedProject.getFundingtree(), enrich.getFundingtree()));
+        mergedProject.setContracttype (enrich.getContracttype() != null && ct < 0
+                ? enrich.getContracttype()
+                : mergedProject.getContracttype());
+        mergedProject.setOptional1 ( enrich.getOptional1() != null && ct < 0
+                ? enrich.getOptional1()
+                : mergedProject.getOptional1());
+        mergedProject.setOptional2 (enrich.getOptional2() != null && ct < 0
+                ? enrich.getOptional2()
+                : mergedProject.getOptional2());
+
+        mergedProject.setJsonextrainfo ( enrich.getJsonextrainfo() != null && ct < 0
+                ? enrich.getJsonextrainfo()
+                : mergedProject.getJsonextrainfo());
+
+        mergedProject.setContactfullname ( enrich.getContactfullname() != null && ct < 0
+                ? enrich.getContactfullname()
+                : mergedProject.getContactfullname());
+
+        mergedProject.setContactfax ( enrich.getContactfax() != null && ct < 0
+                ? enrich.getContactfax()
+                : mergedProject.getContactfax());
+
+        mergedProject.setContactphone (enrich.getContactphone() != null && ct < 0
+                ? enrich.getContactphone()
+                : mergedProject.getContactphone());
+
+        mergedProject.setContactemail ( enrich.getContactemail() != null && ct < 0
+                ? enrich.getContactemail()
+                : mergedProject.getContactemail());
+
+        mergedProject.setSummary ( enrich.getSummary() != null && ct < 0
+                ? enrich.getSummary()
+                : mergedProject.getSummary());
+
+        mergedProject.setCurrency( enrich.getCurrency() != null && ct < 0
+                ? enrich.getCurrency()
+                : mergedProject.getCurrency());
+
+        if (enrich.getH2020topiccode() != null && StringUtils.isEmpty(mergedProject.getH2020topiccode())){
+            mergedProject.setH2020topiccode(enrich.getH2020topiccode());
+            mergedProject.setH2020topicdescription(enrich.getH2020topicdescription());
+        }
+
+        mergedProject.setH2020classification (mergeLists(mergedProject.getH2020classification(), enrich.getH2020classification()));
+
+        mergeOAFDataInfo(mergedProject, enrich);
+
+        return mergedProject;
+
+
+
+    }
+
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/OrganizationPidComparator.java

@@ -0,0 +1,38 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import java.util.Comparator;
+
+import eu.dnetlib.dhp.schema.oaf.StructuredProperty;
+
+public class OrganizationPidComparator implements Comparator<StructuredProperty> {
+
+	@Override
+	public int compare(StructuredProperty left, StructuredProperty right) {
+
+		PidType lClass = PidType.tryValueOf(left.getQualifier().getClassid());
+		PidType rClass = PidType.tryValueOf(right.getQualifier().getClassid());
+
+		if (lClass.equals(PidType.openorgs))
+			return -1;
+		if (rClass.equals(PidType.openorgs))
+			return 1;
+
+		if (lClass.equals(PidType.GRID))
+			return -1;
+		if (rClass.equals(PidType.GRID))
+			return 1;
+
+		if (lClass.equals(PidType.mag_id))
+			return -1;
+		if (rClass.equals(PidType.mag_id))
+			return 1;
+
+		if (lClass.equals(PidType.urn))
+			return -1;
+		if (rClass.equals(PidType.urn))
+			return 1;
+
+		return 0;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PICCleaningRule.java

@@ -1,21 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-public class PICCleaningRule {
-
-	public static final Pattern PATTERN = Pattern.compile("\\d{9}");
-
-	public static String clean(final String pic) {
-
-		Matcher m = PATTERN.matcher(pic);
-		if (m.find()) {
-			return m.group();
-		} else {
-			return "";
-		}
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PidBlacklist.java

@@ -0,0 +1,8 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import java.util.HashMap;
+import java.util.HashSet;
+
+public class PidBlacklist extends HashMap<String, HashSet<String>> {
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PidBlacklistProvider.java

@@ -0,0 +1,39 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import java.io.IOException;
+import java.util.HashSet;
+import java.util.Optional;
+import java.util.Set;
+
+import org.apache.commons.io.IOUtils;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+public class PidBlacklistProvider {
+
+	private static final PidBlacklist blacklist;
+
+	static {
+		try {
+			String json = IOUtils.toString(IdentifierFactory.class.getResourceAsStream("pid_blacklist.json"));
+			blacklist = new ObjectMapper().readValue(json, PidBlacklist.class);
+
+		} catch (IOException e) {
+			throw new RuntimeException(e);
+		}
+	}
+
+	public static PidBlacklist getBlacklist() {
+		return blacklist;
+	}
+
+	public static Set<String> getBlacklist(String pidType) {
+		return Optional
+			.ofNullable(getBlacklist().get(pidType))
+			.orElse(new HashSet<>());
+	}
+
+	private PidBlacklistProvider() {}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PidCleaner.java

@@ -1,62 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.Optional;
-
-import eu.dnetlib.dhp.schema.oaf.StructuredProperty;
-
-public class PidCleaner {
-
-	/**
-	 * Utility method that normalises PID values on a per-type basis.
-	 * @param pid the PID whose value will be normalised.
-	 * @return the PID containing the normalised value.
-	 */
-	public static StructuredProperty normalizePidValue(StructuredProperty pid) {
-		pid
-			.setValue(
-				normalizePidValue(
-					pid.getQualifier().getClassid(),
-					pid.getValue()));
-
-		return pid;
-	}
-
-	public static String normalizePidValue(String pidType, String pidValue) {
-		String value = Optional
-			.ofNullable(pidValue)
-			.map(String::trim)
-			.orElseThrow(() -> new IllegalArgumentException("PID value cannot be empty"));
-
-		switch (pidType) {
-
-			// TODO add cleaning for more PID types as needed
-
-			// Result
-			case "doi":
-				return DoiCleaningRule.clean(value);
-			case "pmid":
-				return PmidCleaningRule.clean(value);
-			case "pmc":
-				return PmcCleaningRule.clean(value);
-			case "handle":
-			case "arXiv":
-				return value;
-
-			// Organization
-			case "GRID":
-				return GridCleaningRule.clean(value);
-			case "ISNI":
-				return ISNICleaningRule.clean(value);
-			case "ROR":
-				return RorCleaningRule.clean(value);
-			case "PIC":
-				return PICCleaningRule.clean(value);
-			case "FundRef":
-				return FundRefCleaningRule.clean(value);
-			default:
-				return value;
-		}
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PidComparator.java

@@ -0,0 +1,48 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import java.util.Comparator;
+
+import eu.dnetlib.dhp.schema.common.ModelSupport;
+import eu.dnetlib.dhp.schema.oaf.OafEntity;
+import eu.dnetlib.dhp.schema.oaf.Organization;
+import eu.dnetlib.dhp.schema.oaf.Result;
+import eu.dnetlib.dhp.schema.oaf.StructuredProperty;
+
+public class PidComparator<T extends OafEntity> implements Comparator<StructuredProperty> {
+
+	private final T entity;
+
+	public PidComparator(T entity) {
+		this.entity = entity;
+	}
+
+	@Override
+	public int compare(StructuredProperty left, StructuredProperty right) {
+
+		if (left == null && right == null)
+			return 0;
+		if (left == null)
+			return 1;
+		if (right == null)
+			return -1;
+
+		if (ModelSupport.isSubClass(entity, Result.class)) {
+			return compareResultPids(left, right);
+		}
+		if (ModelSupport.isSubClass(entity, Organization.class)) {
+			return compareOrganizationtPids(left, right);
+		}
+
+		// Else (but unlikely), lexicographical ordering will do.
+		return left.getQualifier().getClassid().compareTo(right.getQualifier().getClassid());
+	}
+
+	private int compareResultPids(StructuredProperty left, StructuredProperty right) {
+		return new ResultPidComparator().compare(left, right);
+	}
+
+	private int compareOrganizationtPids(StructuredProperty left, StructuredProperty right) {
+		return new OrganizationPidComparator().compare(left, right);
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PidType.java

@@ -0,0 +1,79 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import org.apache.commons.lang3.EnumUtils;
+
+public enum PidType {
+
+	/**
+	 * The DOI syntax shall be made up of a DOI prefix and a DOI suffix separated by a forward slash.
+	 *
+	 * There is no defined limit on the length of the DOI name, or of the DOI prefix or DOI suffix.
+	 *
+	 * The DOI name is case-insensitive and can incorporate any printable characters from the legal graphic characters
+	 * of Unicode. Further constraints on character use (e.g. use of language-specific alphanumeric characters) can be
+	 * defined for an application by the ISO 26324 Registration Authority.
+	 *
+	 *
+	 * DOI prefix: The DOI prefix shall be composed of a directory indicator followed by a registrant code.
+	 * These two components shall be separated by a full stop (period). The directory indicator shall be "10" and
+	 * distinguishes the entire set of character strings (prefix and suffix) as digital object identifiers within the
+	 * resolution system.
+	 *
+	 * Registrant code: The second element of the DOI prefix shall be the registrant code. The registrant code is a
+	 * unique string assigned to a registrant.
+	 *
+	 * DOI suffix: The DOI suffix shall consist of a character string of any length chosen by the registrant.
+	 * Each suffix shall be unique to the prefix element that precedes it. The unique suffix can be a sequential number,
+	 * or it might incorporate an identifier generated from or based on another system used by the registrant
+	 * (e.g. ISAN, ISBN, ISRC, ISSN, ISTC, ISNI; in such cases, a preferred construction for such a suffix can be
+	 * specified, as in Example 1).
+	 *
+	 * Source: https://www.doi.org/doi_handbook/2_Numbering.html#2.2
+	 */
+	doi,
+
+	/**
+	 * PubMed Unique Identifier (PMID)
+	 *
+	 * This field is a 1-to-8 digit accession number with no leading zeros. It is present on all records and is the
+	 * accession number for managing and disseminating records. PMIDs are not reused after records are deleted.
+	 *
+	 * Beginning in February 2012 PMIDs include extensions following a decimal point to account for article versions
+	 * (e.g., 21804956.2). All citations are considered version 1 until replaced.  The extended PMID is not displayed
+	 * on the MEDLINE format.
+	 *
+	 * View the citation in abstract format in PubMed to access additional versions when available (see the article in
+	 * the Jan-Feb 2012 NLM Technical Bulletin).
+	 *
+	 * Source: https://www.nlm.nih.gov/bsd/mms/medlineelements.html#pmid
+	 */
+	pmid,
+
+	/**
+	 * This field contains the unique identifier for the cited article in PubMed Central. The identifier begins with the
+	 * prefix PMC.
+	 *
+	 * Source: https://www.nlm.nih.gov/bsd/mms/medlineelements.html#pmc
+	 */
+	pmc, handle, arXiv, nct, pdb,
+
+	// Organization
+	openorgs, corda, corda_h2020, GRID, mag_id, urn,
+
+	// Used by dedup
+	undefined, original;
+
+	public static boolean isValid(String type) {
+		return EnumUtils.isValidEnum(PidType.class, type);
+	}
+
+	public static PidType tryValueOf(String s) {
+		try {
+			return PidType.valueOf(s);
+		} catch (Exception e) {
+			return PidType.original;
+		}
+	}
+
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PidValueComparator.java

@@ -0,0 +1,33 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import java.util.Comparator;
+import java.util.Optional;
+
+import eu.dnetlib.dhp.schema.oaf.StructuredProperty;
+
+public class PidValueComparator implements Comparator<StructuredProperty> {
+
+	@Override
+	public int compare(StructuredProperty left, StructuredProperty right) {
+
+		if (left == null && right == null)
+			return 0;
+		if (left == null)
+			return 1;
+		if (right == null)
+			return -1;
+
+		StructuredProperty l = CleaningFunctions.normalizePidValue(left);
+		StructuredProperty r = CleaningFunctions.normalizePidValue(right);
+
+		return Optional
+			.ofNullable(l.getValue())
+			.map(
+				lv -> Optional
+					.ofNullable(r.getValue())
+					.map(rv -> lv.compareTo(rv))
+					.orElse(-1))
+			.orElse(1);
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PmcCleaningRule.java

@@ -1,24 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-public class PmcCleaningRule {
-
-	public static final Pattern PATTERN = Pattern.compile("PMC\\d{1,8}");
-
-	public static String clean(String pmc) {
-		String s = pmc
-			.replaceAll("\\s", "")
-			.toUpperCase();
-
-		final Matcher m = PATTERN.matcher(s);
-
-		if (m.find()) {
-			return m.group();
-		}
-		return "";
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/PmidCleaningRule.java

@@ -1,25 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-// https://researchguides.stevens.edu/c.php?g=442331&p=6577176
-public class PmidCleaningRule {
-
-	public static final Pattern PATTERN = Pattern.compile("0*(\\d{1,8})");
-
-	public static String clean(String pmid) {
-		String s = pmid
-			.toLowerCase()
-			.replaceAll("\\s", "");
-
-		final Matcher m = PATTERN.matcher(s);
-
-		if (m.find()) {
-			return m.group(1);
-		}
-		return "";
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/ResultPidComparator.java

@@ -0,0 +1,53 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import java.util.Comparator;
+
+import eu.dnetlib.dhp.schema.oaf.StructuredProperty;
+
+public class ResultPidComparator implements Comparator<StructuredProperty> {
+
+	@Override
+	public int compare(StructuredProperty left, StructuredProperty right) {
+
+		PidType lClass = PidType.tryValueOf(left.getQualifier().getClassid());
+		PidType rClass = PidType.tryValueOf(right.getQualifier().getClassid());
+
+		if (lClass.equals(PidType.doi))
+			return -1;
+		if (rClass.equals(PidType.doi))
+			return 1;
+
+		if (lClass.equals(PidType.pmid))
+			return -1;
+		if (rClass.equals(PidType.pmid))
+			return 1;
+
+		if (lClass.equals(PidType.pmc))
+			return -1;
+		if (rClass.equals(PidType.pmc))
+			return 1;
+
+		if (lClass.equals(PidType.handle))
+			return -1;
+		if (rClass.equals(PidType.handle))
+			return 1;
+
+		if (lClass.equals(PidType.arXiv))
+			return -1;
+		if (rClass.equals(PidType.arXiv))
+			return 1;
+
+		if (lClass.equals(PidType.nct))
+			return -1;
+		if (rClass.equals(PidType.nct))
+			return 1;
+
+		if (lClass.equals(PidType.pdb))
+			return -1;
+		if (rClass.equals(PidType.pdb))
+			return 1;
+
+		return 0;
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/ResultTypeComparator.java

@@ -0,0 +1,77 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import static eu.dnetlib.dhp.schema.common.ModelConstants.CROSSREF_ID;
+
+import java.util.Comparator;
+import java.util.HashSet;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+import eu.dnetlib.dhp.schema.common.ModelConstants;
+import eu.dnetlib.dhp.schema.oaf.KeyValue;
+import eu.dnetlib.dhp.schema.oaf.Result;
+
+public class ResultTypeComparator implements Comparator<Result> {
+
+	@Override
+	public int compare(Result left, Result right) {
+
+		if (left == null && right == null)
+			return 0;
+		if (left == null)
+			return 1;
+		if (right == null)
+			return -1;
+
+		HashSet<String> lCf = getCollectedFromIds(left);
+		HashSet<String> rCf = getCollectedFromIds(right);
+
+		if (lCf.contains(CROSSREF_ID) && !rCf.contains(CROSSREF_ID)) {
+			return -1;
+		}
+		if (!lCf.contains(CROSSREF_ID) && rCf.contains(CROSSREF_ID)) {
+			return 1;
+		}
+
+		String lClass = left.getResulttype().getClassid();
+		String rClass = right.getResulttype().getClassid();
+
+		if (lClass.equals(rClass))
+			return 0;
+
+		if (lClass.equals(ModelConstants.PUBLICATION_RESULTTYPE_CLASSID))
+			return -1;
+		if (rClass.equals(ModelConstants.PUBLICATION_RESULTTYPE_CLASSID))
+			return 1;
+
+		if (lClass.equals(ModelConstants.DATASET_RESULTTYPE_CLASSID))
+			return -1;
+		if (rClass.equals(ModelConstants.DATASET_RESULTTYPE_CLASSID))
+			return 1;
+
+		if (lClass.equals(ModelConstants.SOFTWARE_RESULTTYPE_CLASSID))
+			return -1;
+		if (rClass.equals(ModelConstants.SOFTWARE_RESULTTYPE_CLASSID))
+			return 1;
+
+		if (lClass.equals(ModelConstants.ORP_RESULTTYPE_CLASSID))
+			return -1;
+		if (rClass.equals(ModelConstants.ORP_RESULTTYPE_CLASSID))
+			return 1;
+
+		// Else (but unlikely), lexicographical ordering will do.
+		return lClass.compareTo(rClass);
+	}
+
+	protected HashSet<String> getCollectedFromIds(Result left) {
+		return Optional
+			.ofNullable(left.getCollectedfrom())
+			.map(
+				cf -> cf
+					.stream()
+					.map(KeyValue::getKey)
+					.collect(Collectors.toCollection(HashSet::new)))
+			.orElse(new HashSet<>());
+	}
+}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/RorCleaningRule.java

@@ -1,27 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import java.util.regex.Matcher;
-import java.util.regex.Pattern;
-
-// https://ror.readme.io/docs/ror-identifier-pattern
-public class RorCleaningRule {
-
-	public static final String ROR_PREFIX = "https://ror.org/";
-
-	private static final Pattern PATTERN = Pattern.compile("(?<ror>0[a-hj-km-np-tv-z|0-9]{6}[0-9]{2})");
-
-	public static String clean(String ror) {
-		String s = ror
-			.replaceAll("\\s", "")
-			.toLowerCase();
-
-		Matcher m = PATTERN.matcher(s);
-
-		if (m.find()) {
-			return ROR_PREFIX + m.group("ror");
-		}
-		return "";
-	}
-
-}

dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/SubjectProvenanceComparator.java

@@ -1,46 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import static eu.dnetlib.dhp.schema.oaf.utils.OafMapperUtils.getProvenance;
-import static org.apache.commons.lang3.StringUtils.isBlank;
-
-import java.util.Comparator;
-
-import eu.dnetlib.dhp.schema.oaf.Subject;
-
-public class SubjectProvenanceComparator implements Comparator<Subject> {
-
-	@Override
-	public int compare(Subject left, Subject right) {
-
-		String lProv = getProvenance(left.getDataInfo());
-		String rProv = getProvenance(right.getDataInfo());
-
-		if (isBlank(lProv) && isBlank(rProv))
-			return 0;
-		if (isBlank(lProv))
-			return 1;
-		if (isBlank(rProv))
-			return -1;
-		if (lProv.equals(rProv))
-			return 0;
-		if (lProv.toLowerCase().contains("crosswalk"))
-			return -1;
-		if (rProv.toLowerCase().contains("crosswalk"))
-			return 1;
-		if (lProv.toLowerCase().contains("user"))
-			return -1;
-		if (rProv.toLowerCase().contains("user"))
-			return 1;
-		if (lProv.toLowerCase().contains("propagation"))
-			return -1;
-		if (rProv.toLowerCase().contains("propagation"))
-			return 1;
-		if (lProv.toLowerCase().contains("iis"))
-			return -1;
-		if (rProv.toLowerCase().contains("iis"))
-			return 1;
-
-		return 0;
-	}
-}

dhp-common/src/main/java/eu/dnetlib/dhp/utils/DHPUtils.java

@@ -7,9 +7,14 @@ import java.security.MessageDigest;
 import java.util.*;
 import java.util.stream.Collectors;
 
+import eu.dnetlib.dhp.common.vocabulary.VocabularyGroup;
+import eu.dnetlib.dhp.schema.common.ModelConstants;
+import eu.dnetlib.dhp.schema.oaf.Qualifier;
 import org.apache.commons.codec.binary.Hex;
 import org.apache.commons.io.IOUtils;
 import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.tuple.ImmutablePair;
+import org.apache.commons.lang3.tuple.Pair;
 import org.apache.hadoop.conf.Configuration;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
@@ -32,6 +37,9 @@ import net.minidev.json.JSONArray;
 import scala.collection.JavaConverters;
 import scala.collection.Seq;
 
+/**
+ * The type Dhp utils.
+ */
 public class DHPUtils {
 
 	private static final Logger log = LoggerFactory.getLogger(DHPUtils.class);
@@ -39,10 +47,22 @@ public class DHPUtils {
 	private DHPUtils() {
 	}
 
+	/**
+	 * To seq seq.
+	 *
+	 * @param list the list
+	 * @return the seq
+	 */
 	public static Seq<String> toSeq(List<String> list) {
 		return JavaConverters.asScalaIteratorConverter(list.iterator()).asScala().toSeq();
 	}
 
+	/**
+	 * Md 5 string.
+	 *
+	 * @param s the s
+	 * @return the string
+	 */
 	public static String md5(final String s) {
 		try {
 			final MessageDigest md = MessageDigest.getInstance("MD5");
@@ -54,14 +74,71 @@ public class DHPUtils {
 		}
 	}
 
+
+
+	private static Pair<Qualifier, Qualifier> searchTypeInVocabularies(final String aType,  final VocabularyGroup vocabularies) {
+
+		if (StringUtils.isNotBlank(aType)) {
+			final Qualifier typeQualifier = vocabularies.getSynonymAsQualifier(ModelConstants.DNET_PUBLICATION_RESOURCE, aType);
+			if (typeQualifier != null)
+				return new ImmutablePair<>(typeQualifier, vocabularies.getSynonymAsQualifier(
+						ModelConstants.DNET_RESULT_TYPOLOGIES,
+						typeQualifier.getClassid()
+				));
+
+
+		}
+		return null;
+	}
+
+	/**
+	 * Retrieve oaf type from vocabulary pair.
+	 *
+	 * This method tries to find the correct oaf type general and instance type from
+	 * vocabularies giving this order:
+	 * 	1 - search a vocabulary synonym from subResourceType
+	 * 	2 - search a vocabulary synonym from otherResourceType
+	 *
+	 *
+	 *
+	 * @param resourceTypeGeneral the resource type general
+	 * @param subResourceType     the sub resource type
+	 * @param otherResourceType   the other resource type
+	 * @param vocabularies        the vocabularies
+	 * @return the pair
+	 */
+	public static Pair<Qualifier, Qualifier> retrieveOAFTypeFromVocabulary(final String resourceTypeGeneral , final String subResourceType, final String otherResourceType, final VocabularyGroup vocabularies ) {
+
+		if (StringUtils.isNotBlank(subResourceType)) {
+			Pair<Qualifier, Qualifier> result = searchTypeInVocabularies(subResourceType, vocabularies);
+			if (result!= null)
+				return result;
+		}
+
+		if (StringUtils.isNotBlank(otherResourceType)) {
+			Pair<Qualifier, Qualifier> result = searchTypeInVocabularies(otherResourceType, vocabularies);
+			if (result!= null)
+				return result;
+		}
+
+		if (StringUtils.isNotBlank(resourceTypeGeneral)) {
+			Pair<Qualifier, Qualifier> result = searchTypeInVocabularies(resourceTypeGeneral, vocabularies);
+			return result;
+		}
+
+		return null;
+	}
+
+
 	/**
 	 * Retrieves from the metadata store manager application the list of paths associated with mdstores characterized
 	 * by he given format, layout, interpretation
+	 *
 	 * @param mdstoreManagerUrl the URL of the mdstore manager service
-	 * @param format the mdstore format
-	 * @param layout the mdstore layout
-	 * @param interpretation the mdstore interpretation
-	 * @param includeEmpty include Empty mdstores
+	 * @param format            the mdstore format
+	 * @param layout            the mdstore layout
+	 * @param interpretation    the mdstore interpretation
+	 * @param includeEmpty      include Empty mdstores
 	 * @return the set of hdfs paths
 	 * @throws IOException in case of HTTP communication issues
 	 */
@@ -75,14 +152,9 @@ public class DHPUtils {
 
 		final HttpGet req = new HttpGet(url);
 
-		log.info("MDStoreManager request: {}", req);
-
 		try (final CloseableHttpClient client = HttpClients.createDefault()) {
 			try (final CloseableHttpResponse response = client.execute(req)) {
 				final String json = IOUtils.toString(response.getEntity().getContent());
-
-				log.info("MDStoreManager response: {}", json);
-
 				final MDStoreWithInfo[] mdstores = objectMapper.readValue(json, MDStoreWithInfo[].class);
 				return Arrays
 					.stream(mdstores)
@@ -98,10 +170,24 @@ public class DHPUtils {
 		}
 	}
 
+	/**
+	 * Generate identifier string.
+	 *
+	 * @param originalId the original id
+	 * @param nsPrefix   the ns prefix
+	 * @return the string
+	 */
 	public static String generateIdentifier(final String originalId, final String nsPrefix) {
 		return String.format("%s::%s", nsPrefix, DHPUtils.md5(originalId));
 	}
 
+	/**
+	 * Generate unresolved identifier string.
+	 *
+	 * @param pid     the pid
+	 * @param pidType the pid type
+	 * @return the string
+	 */
 	public static String generateUnresolvedIdentifier(final String pid, final String pidType) {
 
 		final String cleanedPid = CleaningFunctions.normalizePidValue(pidType, pid);
@@ -109,6 +195,13 @@ public class DHPUtils {
 		return String.format("unresolved::%s::%s", cleanedPid, pidType.toLowerCase().trim());
 	}
 
+	/**
+	 * Gets j path string.
+	 *
+	 * @param jsonPath the json path
+	 * @param json     the json
+	 * @return the j path string
+	 */
 	public static String getJPathString(final String jsonPath, final String json) {
 		try {
 			Object o = JsonPath.read(json, jsonPath);
@@ -122,8 +215,19 @@ public class DHPUtils {
 		}
 	}
 
+	/**
+	 * The constant MAPPER.
+	 */
 	public static final ObjectMapper MAPPER = new ObjectMapper();
 
+	/**
+	 * Write hdfs file.
+	 *
+	 * @param conf    the conf
+	 * @param content the content
+	 * @param path    the path
+	 * @throws IOException the io exception
+	 */
 	public static void writeHdfsFile(final Configuration conf, final String content, final String path)
 		throws IOException {
 
@@ -135,6 +239,14 @@ public class DHPUtils {
 		}
 	}
 
+	/**
+	 * Read hdfs file string.
+	 *
+	 * @param conf the conf
+	 * @param path the path
+	 * @return the string
+	 * @throws IOException the io exception
+	 */
 	public static String readHdfsFile(Configuration conf, String path) throws IOException {
 		log.info("reading file {}", path);
 
@@ -147,10 +259,27 @@ public class DHPUtils {
 		}
 	}
 
+	/**
+	 * Read hdfs file as t.
+	 *
+	 * @param <T>   the type parameter
+	 * @param conf  the conf
+	 * @param path  the path
+	 * @param clazz the clazz
+	 * @return the t
+	 * @throws IOException the io exception
+	 */
 	public static <T> T readHdfsFileAs(Configuration conf, String path, Class<T> clazz) throws IOException {
 		return MAPPER.readValue(readHdfsFile(conf, path), clazz);
 	}
 
+	/**
+	 * Save dataset.
+	 *
+	 * @param <T>        the type parameter
+	 * @param mdstore    the mdstore
+	 * @param targetPath the target path
+	 */
 	public static <T> void saveDataset(final Dataset<T> mdstore, final String targetPath) {
 		log.info("saving dataset in: {}", targetPath);
 		mdstore
@@ -160,6 +289,12 @@ public class DHPUtils {
 			.save(targetPath);
 	}
 
+	/**
+	 * Gets hadoop configuration.
+	 *
+	 * @param nameNode the name node
+	 * @return the hadoop configuration
+	 */
 	public static Configuration getHadoopConfiguration(String nameNode) {
 		// ====== Init HDFS File System Object
 		Configuration conf = new Configuration();
@@ -173,6 +308,12 @@ public class DHPUtils {
 		return conf;
 	}
 
+	/**
+	 * Populate oozie env.
+	 *
+	 * @param report the report
+	 * @throws IOException the io exception
+	 */
 	public static void populateOOZIEEnv(final Map<String, String> report) throws IOException {
 		File file = new File(System.getProperty("oozie.action.output.properties"));
 		Properties props = new Properties();
@@ -183,6 +324,13 @@ public class DHPUtils {
 		}
 	}
 
+	/**
+	 * Populate oozie env.
+	 *
+	 * @param paramName the param name
+	 * @param value     the value
+	 * @throws IOException the io exception
+	 */
 	public static void populateOOZIEEnv(final String paramName, String value) throws IOException {
 		Map<String, String> report = Maps.newHashMap();
 		report.put(paramName, value);

dhp-common/src/main/resources/eu/dnetlib/dhp/oa/merge/dispatch_entities_parameters.json

@@ -6,21 +6,21 @@
     "paramRequired": false
   },
   {
-    "paramName": "in",
+    "paramName": "i",
     "paramLongName": "inputPath",
-    "paramDescription": "the path to the graph data dump to read",
+    "paramDescription": "the source path",
     "paramRequired": true
   },
   {
-    "paramName": "wd",
-    "paramLongName": "workingDir",
-    "paramDescription": "the path to store the output graph",
+    "paramName": "o",
+    "paramLongName": "outputPath",
+    "paramDescription": "path of the output graph",
     "paramRequired": true
   },
   {
     "paramName": "c",
-    "paramLongName": "country",
-    "paramDescription": "the id of the context to be removed",
+    "paramLongName": "graphTableClassName",
+    "paramDescription": "the graph entity class name",
     "paramRequired": true
   }
-]
+]

dhp-common/src/main/resources/eu/dnetlib/dhp/oa/merge/group_graph_entities_parameters.json

@@ -8,31 +8,13 @@
   {
     "paramName": "gin",
     "paramLongName": "graphInputPath",
-    "paramDescription": "the input graph root path",
-    "paramRequired": true
-  },
-  {
-    "paramName": "cp",
-    "paramLongName": "checkpointPath",
-    "paramDescription": "checkpoint directory",
+    "paramDescription": "the graph root path",
     "paramRequired": true
   },
   {
     "paramName": "out",
     "paramLongName": "outputPath",
-    "paramDescription": "the output graph root path",
-    "paramRequired": true
-  },
-  {
-    "paramName": "fi",
-    "paramLongName": "filterInvisible",
-    "paramDescription": "if true filters out invisible entities",
-    "paramRequired": true
-  },
-  {
-    "paramName": "isu",
-    "paramLongName": "isLookupUrl",
-    "paramDescription": "url to the ISLookup Service",
+    "paramDescription": "the output merged graph root path",
     "paramRequired": true
   }
 ]

dhp-common/src/main/resources/eu/dnetlib/dhp/oozie/run_sql_parameters.json

@@ -1,20 +0,0 @@
-[
-  {
-    "paramName": "issm",
-    "paramLongName": "isSparkSessionManaged",
-    "paramDescription": "when true will stop SparkSession after job execution",
-    "paramRequired": false
-  },
-  {
-    "paramName": "hmu",
-    "paramLongName": "hiveMetastoreUris",
-    "paramDescription": "the hive metastore uris",
-    "paramRequired": true
-  },
-  {
-    "paramName": "sql",
-    "paramLongName": "sql",
-    "paramDescription": "sql script to execute",
-    "paramRequired": true
-  }
-]

dhp-common/src/main/scala/eu/dnetlib/dhp/application/dedup/log/DedupLogModel.scala

@@ -1,10 +0,0 @@
-package eu.dnetlib.dhp.application.dedup.log
-
-case class DedupLogModel(
-  tag: String,
-  configuration: String,
-  entity: String,
-  startTS: Long,
-  endTS: Long,
-  totalMs: Long
-) {}

dhp-common/src/main/scala/eu/dnetlib/dhp/application/dedup/log/DedupLogWriter.scala

@@ -1,14 +0,0 @@
-package eu.dnetlib.dhp.application.dedup.log
-
-import org.apache.spark.sql.{SaveMode, SparkSession}
-
-class DedupLogWriter(path: String) {
-
-  def appendLog(dedupLogModel: DedupLogModel, spark: SparkSession): Unit = {
-    import spark.implicits._
-    val df = spark.createDataset[DedupLogModel](data = List(dedupLogModel))
-    df.write.mode(SaveMode.Append).save(path)
-
-  }
-
-}

dhp-common/src/main/scala/eu/dnetlib/dhp/client/AbstractRestClient.scala

@@ -1,4 +1,4 @@
-package eu.dnetlib.dhp.datacite
+package eu.dnetlib.dhp.client
 
 import org.apache.commons.io.IOUtils
 import org.apache.http.client.config.RequestConfig

dhp-common/src/test/java/eu/dnetlib/dhp/common/MdStoreClientTest.java

@@ -1,36 +0,0 @@
-
-package eu.dnetlib.dhp.common;
-
-import java.io.IOException;
-import java.nio.charset.StandardCharsets;
-import java.nio.file.Files;
-import java.nio.file.Path;
-import java.nio.file.Paths;
-import java.util.List;
-
-import org.junit.jupiter.api.Test;
-
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
-
-public class MdStoreClientTest {
-
-	// @Test
-	public void testMongoCollection() throws IOException {
-		final MdstoreClient client = new MdstoreClient("mongodb://localhost:27017", "mdstore");
-
-		final ObjectMapper mapper = new ObjectMapper();
-
-		final List<MDStoreInfo> infos = client.mdStoreWithTimestamp("ODF", "store", "cleaned");
-
-		infos.forEach(System.out::println);
-
-		final String s = mapper.writeValueAsString(infos);
-
-		Path fileName = Paths.get("/Users/sandro/mdstore_info.json");
-
-		// Writing into the file
-		Files.write(fileName, s.getBytes(StandardCharsets.UTF_8));
-
-	}
-}

dhp-common/src/test/java/eu/dnetlib/dhp/common/api/ZenodoAPIClientTest.java

@@ -0,0 +1,109 @@
+
+package eu.dnetlib.dhp.common.api;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+
+import org.apache.commons.io.IOUtils;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+@Disabled
+class ZenodoAPIClientTest {
+
+	private final String URL_STRING = "https://sandbox.zenodo.org/api/deposit/depositions";
+	private final String ACCESS_TOKEN = "";
+
+	private final String CONCEPT_REC_ID = "657113";
+
+	private final String depositionId = "674915";
+
+	@Test
+	void testUploadOldDeposition() throws IOException, MissingConceptDoiException {
+		ZenodoAPIClient client = new ZenodoAPIClient(URL_STRING,
+			ACCESS_TOKEN);
+		Assertions.assertEquals(200, client.uploadOpenDeposition(depositionId));
+
+		File file = new File(getClass()
+			.getResource("/eu/dnetlib/dhp/common/api/COVID-19.json.gz")
+			.getPath());
+
+		InputStream is = new FileInputStream(file);
+
+		Assertions.assertEquals(200, client.uploadIS(is, "COVID-19.json.gz", file.length()));
+
+		String metadata = IOUtils.toString(getClass().getResourceAsStream("/eu/dnetlib/dhp/common/api/metadata.json"));
+
+		Assertions.assertEquals(200, client.sendMretadata(metadata));
+
+		Assertions.assertEquals(202, client.publish());
+
+	}
+
+	@Test
+	void testNewDeposition() throws IOException {
+
+		ZenodoAPIClient client = new ZenodoAPIClient(URL_STRING,
+			ACCESS_TOKEN);
+		Assertions.assertEquals(201, client.newDeposition());
+
+		File file = new File(getClass()
+			.getResource("/eu/dnetlib/dhp/common/api/COVID-19.json.gz")
+			.getPath());
+
+		InputStream is = new FileInputStream(file);
+
+		Assertions.assertEquals(200, client.uploadIS(is, "COVID-19.json.gz", file.length()));
+
+		String metadata = IOUtils.toString(getClass().getResourceAsStream("/eu/dnetlib/dhp/common/api/metadata.json"));
+
+		Assertions.assertEquals(200, client.sendMretadata(metadata));
+
+		Assertions.assertEquals(202, client.publish());
+
+	}
+
+	@Test
+	void testNewVersionNewName() throws IOException, MissingConceptDoiException {
+
+		ZenodoAPIClient client = new ZenodoAPIClient(URL_STRING,
+			ACCESS_TOKEN);
+
+		Assertions.assertEquals(201, client.newVersion(CONCEPT_REC_ID));
+
+		File file = new File(getClass()
+			.getResource("/eu/dnetlib/dhp/common/api/newVersion")
+			.getPath());
+
+		InputStream is = new FileInputStream(file);
+
+		Assertions.assertEquals(200, client.uploadIS(is, "newVersion_deposition", file.length()));
+
+		Assertions.assertEquals(202, client.publish());
+
+	}
+
+	@Test
+	void testNewVersionOldName() throws IOException, MissingConceptDoiException {
+
+		ZenodoAPIClient client = new ZenodoAPIClient(URL_STRING,
+			ACCESS_TOKEN);
+
+		Assertions.assertEquals(201, client.newVersion(CONCEPT_REC_ID));
+
+		File file = new File(getClass()
+			.getResource("/eu/dnetlib/dhp/common/api/newVersion2")
+			.getPath());
+
+		InputStream is = new FileInputStream(file);
+
+		Assertions.assertEquals(200, client.uploadIS(is, "newVersion_deposition", file.length()));
+
+		Assertions.assertEquals(202, client.publish());
+
+	}
+
+}

dhp-common/src/test/java/eu/dnetlib/dhp/oa/merge/AuthorMergerTest.java

@@ -0,0 +1,100 @@
+
+package eu.dnetlib.dhp.oa.merge;
+
+import java.io.BufferedReader;
+import java.io.FileReader;
+import java.io.IOException;
+import java.nio.file.Paths;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import eu.dnetlib.dhp.schema.oaf.Author;
+import eu.dnetlib.dhp.schema.oaf.Publication;
+import eu.dnetlib.dhp.schema.oaf.StructuredProperty;
+import eu.dnetlib.pace.util.MapDocumentUtil;
+import scala.Tuple2;
+
+class AuthorMergerTest {
+
+	private String publicationsBasePath;
+
+	private List<List<Author>> authors;
+
+	@BeforeEach
+	public void setUp() throws Exception {
+
+		publicationsBasePath = Paths
+			.get(AuthorMergerTest.class.getResource("/eu/dnetlib/dhp/oa/merge").toURI())
+			.toFile()
+			.getAbsolutePath();
+
+		authors = readSample(publicationsBasePath + "/publications_with_authors.json", Publication.class)
+			.stream()
+			.map(p -> p._2().getAuthor())
+			.collect(Collectors.toList());
+
+	}
+
+	@Test
+	void mergeTest() { // used in the dedup: threshold set to 0.95
+
+		for (List<Author> authors1 : authors) {
+			System.out.println("List " + (authors.indexOf(authors1) + 1));
+			for (Author author : authors1) {
+				System.out.println(authorToString(author));
+			}
+		}
+
+		List<Author> merge = AuthorMerger.merge(authors);
+
+		System.out.println("Merge ");
+		for (Author author : merge) {
+			System.out.println(authorToString(author));
+		}
+
+		Assertions.assertEquals(7, merge.size());
+
+	}
+
+	public <T> List<Tuple2<String, T>> readSample(String path, Class<T> clazz) {
+		List<Tuple2<String, T>> res = new ArrayList<>();
+		BufferedReader reader;
+		try {
+			reader = new BufferedReader(new FileReader(path));
+			String line = reader.readLine();
+			while (line != null) {
+				res
+					.add(
+						new Tuple2<>(
+							MapDocumentUtil.getJPathString("$.id", line),
+							new ObjectMapper().readValue(line, clazz)));
+				// read next line
+				line = reader.readLine();
+			}
+			reader.close();
+		} catch (IOException e) {
+			e.printStackTrace();
+		}
+
+		return res;
+	}
+
+	public String authorToString(Author a) {
+
+		String print = "Fullname = ";
+		print += a.getFullname() + " pid = [";
+		if (a.getPid() != null)
+			for (StructuredProperty sp : a.getPid()) {
+				print += sp.toComparableString() + " ";
+			}
+		print += "]";
+		return print;
+	}
+}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/BlackListProviderTest.java

@@ -0,0 +1,21 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.util.Set;
+
+class BlackListProviderTest {
+
+	@Test
+	void blackListTest() {
+
+		Assertions.assertNotNull(PidBlacklistProvider.getBlacklist());
+		Assertions.assertNotNull(PidBlacklistProvider.getBlacklist().get("doi"));
+		Assertions.assertTrue(PidBlacklistProvider.getBlacklist().get("doi").size() > 0);
+		final Set<String> xxx = PidBlacklistProvider.getBlacklist("xxx");
+		Assertions.assertNotNull(xxx);
+		Assertions.assertEquals(0, xxx.size());
+	}
+}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/GridCleaningRuleTest.java

@@ -1,18 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-import org.junit.jupiter.api.Test;
-
-class GridCleaningRuleTest {
-
-	@Test
-	void testCleaning() {
-		assertEquals("grid.493784.5", GridCleaningRule.clean("grid.493784.5"));
-		assertEquals("grid.493784.5x", GridCleaningRule.clean("grid.493784.5x"));
-		assertEquals("grid.493784.5x", GridCleaningRule.clean("493784.5x"));
-		assertEquals("", GridCleaningRule.clean("493x784.5x"));
-	}
-
-}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/ISNICleaningRuleTest.java

@@ -1,19 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-import org.junit.jupiter.api.Test;
-
-class ISNICleaningRuleTest {
-
-	@Test
-	void testCleaning() {
-		assertEquals("0000000463436020", ISNICleaningRule.clean("0000 0004 6343 6020"));
-		assertEquals("0000000463436020", ISNICleaningRule.clean("0000000463436020"));
-		assertEquals("", ISNICleaningRule.clean("Q30256598"));
-		assertEquals("0000000493403529", ISNICleaningRule.clean("ISNI:0000000493403529"));
-		assertEquals("000000008614884X", ISNICleaningRule.clean("0000 0000 8614 884X"));
-	}
-
-}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/IdentifierFactoryTest.java

@@ -0,0 +1,80 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import static org.junit.jupiter.api.Assertions.*;
+import java.io.IOException;
+
+
+import org.apache.commons.io.IOUtils;
+import org.junit.jupiter.api.Test;
+
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import eu.dnetlib.dhp.schema.oaf.Publication;
+
+class IdentifierFactoryTest {
+
+	private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper()
+		.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+
+	@Test
+	void testCreateIdentifierForPublication() throws IOException {
+
+		verifyIdentifier(
+			"publication_doi1.json", "50|doi_________::79dbc7a2a56dc1532659f9038843256e", true);
+
+		verifyIdentifier(
+			"publication_doi2.json", "50|doi_________::79dbc7a2a56dc1532659f9038843256e", true);
+
+		verifyIdentifier(
+			"publication_doi3.json", "50|pmc_________::94e4cb08c93f8733b48e2445d04002ac", true);
+
+		verifyIdentifier(
+			"publication_doi4.json", "50|od______2852::38861c44e6052a8d49f59a4c39ba5e66", true);
+
+		verifyIdentifier(
+			"publication_doi5.json", "50|doi_________::3bef95c0ca26dd55451fc8839ea69d27", true);
+
+		verifyIdentifier(
+			"publication_pmc1.json", "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f", true);
+
+		verifyIdentifier(
+			"publication_pmc2.json", "50|pmc_________::94e4cb08c93f8733b48e2445d04002ac", true);
+
+		verifyIdentifier(
+				"publication_openapc.json", "50|doi_________::79dbc7a2a56dc1532659f9038843256e", true);
+
+		final String defaultID = "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f";
+		verifyIdentifier("publication_3.json", defaultID, true);
+		verifyIdentifier("publication_4.json", defaultID, true);
+		verifyIdentifier("publication_5.json", defaultID, true);
+
+	}
+
+	@Test
+	void testCreateIdentifierForPublicationNoHash() throws IOException {
+
+		verifyIdentifier("publication_doi1.json", "50|doi_________::10.1016/j.cmet.2010.03.013", false);
+		verifyIdentifier("publication_doi2.json", "50|doi_________::10.1016/j.cmet.2010.03.013", false);
+		verifyIdentifier("publication_pmc1.json", "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f", false);
+		verifyIdentifier(
+			"publication_urn1.json", "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f", false);
+
+		final String defaultID = "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f";
+		verifyIdentifier("publication_3.json", defaultID, false);
+		verifyIdentifier("publication_4.json", defaultID, false);
+		verifyIdentifier("publication_5.json", defaultID, false);
+	}
+
+	protected void verifyIdentifier(String filename, String expectedID, boolean md5) throws IOException {
+		final String json = IOUtils.toString(getClass().getResourceAsStream(filename));
+		final Publication pub = OBJECT_MAPPER.readValue(json, Publication.class);
+
+		String id = IdentifierFactory.createIdentifier(pub, md5);
+
+		assertNotNull(id);
+		assertEquals(expectedID, id);
+	}
+
+}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/MergeTest.java

@@ -0,0 +1,617 @@
+
+package eu.dnetlib.dhp.schema.oaf.utils;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import eu.dnetlib.dhp.schema.oaf.*;
+import org.apache.commons.io.IOUtils;
+import org.apache.commons.lang3.StringUtils;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.time.format.DateTimeParseException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.stream.Collectors;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+/**
+ * The type Merge test.
+ */
+class MergeTest {
+
+	/**
+	 * The Oaf.
+	 */
+	OafEntity oaf;
+
+	/**
+	 * Sets up.
+	 */
+	@BeforeEach
+	public void setUp() {
+		oaf = new Publication();
+	}
+
+	/**
+	 * Merge lists test.
+	 */
+	@Test
+	@SuppressWarnings("unchecked")
+	void mergeListsTest() {
+
+		// string list merge test
+		List<String> a = Arrays.asList("a", "b", "c", "e");
+		List<String> b = Arrays.asList("a", "b", "c", "d");
+		List<String> c = null;
+
+		System.out.println("merge result 1 = " + OafUtils.mergeLists(a, b));
+
+		System.out.println("merge result 2 = " + OafUtils.mergeLists(a, c));
+
+		System.out.println("merge result 3 = " + OafUtils.mergeLists(c, c));
+	}
+
+	/**
+	 * Merge publication collected from test.
+	 */
+	@Test
+	void mergePublicationCollectedFromTest() {
+
+		Publication a = publication();
+		Publication b = publication();
+
+		a.setCollectedfrom(Arrays.asList(setKV("a", "open"), setKV("b", "closed")));
+		b.setCollectedfrom(Arrays.asList(setKV("A", "open"), setKV("b", "Open")));
+
+		a = OafUtils.mergeOAF(a, b);
+
+
+		assertNotNull(a.getCollectedfrom());
+		assertEquals(3, a.getCollectedfrom().size());
+	}
+
+	/**
+	 * Load resource result list.
+	 *
+	 * @param <T>   the type parameter
+	 * @param path  the path
+	 * @param clazz the clazz
+	 * @return the list
+	 * @throws Exception the exception
+	 */
+	private <T extends Result> List<T> loadResourceResult(final String path, final Class<T> clazz ) throws Exception {
+		final ObjectMapper mapper = new ObjectMapper();
+		final InputStream str = Objects.requireNonNull(getClass().getResourceAsStream(path));
+		// LOAD test publications
+		return IOUtils.readLines(str).stream().map(s -> {
+			try {
+				return mapper.readValue(s, clazz);
+			} catch (IOException e) {
+				return null;
+			}
+		}).filter(Objects::nonNull).collect(Collectors.toList());
+	}
+
+
+	/**
+	 * Apply to any test list result the same pid of the enrichment instance
+	 *
+	 * @param source                      the source
+	 * @param enrichment                  the enrichment
+	 * @param overrideAlternateIdentifier the override alternate identifier
+	 */
+	private  <T extends Result> void updatePidIntoPublicationInstance(final List<T> source, final List<T>enrichment, final boolean overrideAlternateIdentifier) {
+		for(int i = 0 ; i< source.size(); i++) {
+			final Result currentPub = source.get(i);
+			final Result currentEnrichment = enrichment.get(i);
+			final Instance currentInstance = Objects.requireNonNull(currentPub.getInstance()).get(0);
+			if (overrideAlternateIdentifier)
+				currentInstance.setAlternateIdentifier(Objects.requireNonNull(currentEnrichment.getInstance()).get(0).getPid());
+			else
+				currentInstance.setPid(Objects.requireNonNull(currentEnrichment.getInstance()).get(0).getPid());
+		}
+	}
+
+
+	private <T extends  Result> void applyAndVerifyEnrichment(final List<T> l1, final List<T> l2) {
+		// Apply Merge and verify that enrichments works
+		for(int i = 0 ; i< l1.size(); i++) {
+			final Result currentPub = l2.get(i);
+			final Result currentEnrichment = l1.get(i);
+			final Result result = OafUtils.mergeOAF(currentPub, currentEnrichment);
+			assertEquals(1, result.getInstance().size());
+			final Instance currentInstance = Objects.requireNonNull(result.getInstance()).get(0);
+			assertNotNull(currentInstance.getMeasures());
+			assertNotNull(result.getTitle());
+			assertFalse(OafUtils.isAnEnrichment(result));
+		}
+
+	}
+
+	/**
+	 * Test the merge of the APC at the level of the result and the instance.
+	 *
+	 * @throws Exception the exception
+	 */
+
+	@Test
+	void testAPCMerge() throws Exception {
+		List<Publication> publications = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/publication_apc.json", Publication.class);
+		System.out.println(publications.size());
+		publications.forEach(p -> assertEquals(1, p.getInstance().size()));
+		publications.forEach(p -> assertTrue(p.getProcessingchargeamount() != null ));
+		publications.forEach(p -> assertTrue(p.getProcessingchargecurrency() != null ));
+		publications.forEach(p -> assertTrue(StringUtils.isNotBlank(p.getProcessingchargeamount().getValue() )));
+		publications.forEach(p -> assertTrue(StringUtils.isNotBlank(p.getProcessingchargecurrency().getValue() )));
+
+		publications.forEach(p -> p.getInstance().stream()
+				.forEach(i -> assertTrue(i.getProcessingchargeamount() != null)));
+		publications.forEach(p -> p.getInstance().stream()
+				.forEach(i -> assertTrue(i.getProcessingchargecurrency() != null)));
+
+		publications.forEach(p -> p.getInstance().stream()
+				.forEach(i -> assertTrue(StringUtils.isNotBlank(i.getProcessingchargeamount().getValue()))));
+		publications.forEach(p -> p.getInstance().stream()
+				.forEach(i -> assertTrue(StringUtils.isNotBlank(i.getProcessingchargecurrency().getValue()))));
+
+		Result p1 = publications.get(0);
+		Result p2 = publications.get(1);
+
+		p1 = OafUtils.mergeOAF(p1, p2);
+
+		assertEquals("1721.47", p1.getProcessingchargeamount().getValue());
+		assertEquals("EUR", p1.getProcessingchargecurrency().getValue());
+
+		assertEquals(2 , p1.getInstance().size());
+
+		p1.getInstance().stream().forEach(i -> assertTrue(i.getProcessingchargeamount() != null));
+		p1.getInstance().stream().forEach(i -> assertTrue(i.getProcessingchargecurrency() != null));
+
+		p1.getInstance().stream().anyMatch(i -> i.getProcessingchargeamount().getValue().equals("2000.47"));
+		p1.getInstance().stream().anyMatch(i -> i.getProcessingchargeamount().getValue().equals("1721.47"));
+
+		p1.getInstance().stream().anyMatch(i -> i.getProcessingchargecurrency().getValue().equals("EUR"));
+		p1.getInstance().stream().anyMatch(i -> i.getProcessingchargecurrency().getValue().equals("USD"));
+		System.out.println(new ObjectMapper().writeValueAsString(p1));
+	}
+	@Test
+	void testAPCMerge2() throws Exception {
+		List<Publication> publications = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/publication_apc2.json", Publication.class);
+		System.out.println(publications.size());
+		publications.forEach(p -> assertEquals(1, p.getInstance().size()));
+		assertTrue(publications.get(0).getProcessingchargeamount() != null );
+		assertTrue(publications.get(0).getProcessingchargecurrency() != null );
+		assertTrue(publications.get(1).getProcessingchargeamount() == null );
+
+		Result p1 = publications.get(1);
+		Result p2 = publications.get(0);
+
+		//merge visible record with OpenAPC
+		p1 = (Result) OafUtils.mergeOAF(p1, p2);
+
+		assertFalse(p1.getDataInfo().getInvisible());
+		assertEquals("1721.47", p1.getProcessingchargeamount().getValue());
+		assertEquals("EUR", p1.getProcessingchargecurrency().getValue());
+
+		assertEquals(2 , p1.getInstance().size());
+		p1.getInstance().stream().anyMatch(i -> i.getProcessingchargeamount() != null);
+
+		p1.getInstance().stream().anyMatch(i -> i.getProcessingchargecurrency() != null);
+
+		assertEquals("1721.47", p1.getInstance().stream().filter(i -> i.getProcessingchargeamount() != null)
+						.collect(Collectors.toList()).get(0).getProcessingchargeamount().getValue());
+
+		assertEquals("EUR", p1.getInstance().stream().filter(i -> i.getProcessingchargeamount() != null)
+				.collect(Collectors.toList()).get(0).getProcessingchargecurrency().getValue());
+		assertFalse(p1.getDataInfo().getInvisible());
+		System.out.println(new ObjectMapper().writeValueAsString(p1));
+
+		//merge OpenAPC with visible record
+
+		p2 = (Result) OafUtils.mergeOAF(p2, p1);
+
+		assertFalse(p2.getDataInfo().getInvisible());
+		assertEquals("1721.47", p2.getProcessingchargeamount().getValue());
+		assertEquals("EUR", p2.getProcessingchargecurrency().getValue());
+
+		assertEquals(2 , p2.getInstance().size());
+		p2.getInstance().stream().anyMatch(i -> i.getProcessingchargeamount() != null);
+
+		p2.getInstance().stream().anyMatch(i -> i.getProcessingchargecurrency() != null);
+
+		assertEquals("1721.47", p2.getInstance().stream().filter(i -> i.getProcessingchargeamount() != null)
+				.collect(Collectors.toList()).get(0).getProcessingchargeamount().getValue());
+
+		assertEquals("EUR", p2.getInstance().stream().filter(i -> i.getProcessingchargeamount() != null)
+				.collect(Collectors.toList()).get(0).getProcessingchargecurrency().getValue());
+
+	}
+
+	/**
+	 * Test enrichment function.
+	 *
+	 * @throws Exception the exception
+	 */
+	@Test
+	void testEnrichment() throws Exception {
+
+
+		// 1 TEST UPDATING PID INSTANCE AND MERGE CURRENT PUBLICATION WITH ENRICHMENT
+		// LOAD test publications
+		List<Publication> publications = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/publications.json", Publication.class);
+		// Assert that each publication has only one instance and inside that all the measure field is empty
+		publications.forEach(p -> {
+			assertEquals(1, p.getInstance().size());
+			final Instance currentInstance = Objects.requireNonNull(p.getInstance()).get(0);
+			assertNull(currentInstance.getMeasures());
+		});
+
+		// LOAD test enrichments
+		List<Publication> enrichment = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/enrichment.json", Publication.class);
+
+		updatePidIntoPublicationInstance(publications, enrichment, false);
+		applyAndVerifyEnrichment(publications, enrichment);
+
+
+		// 2 TEST UPDATING ALTERNATE ID INSTANCE AND MERGE CURRENT PUBLICATION WITH ENRICHMENT
+		publications = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/publications.json", Publication.class);
+		enrichment = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/enrichment.json", Publication.class);
+		updatePidIntoPublicationInstance(publications, enrichment, true);
+		applyAndVerifyEnrichment(publications, enrichment);
+
+
+		// 3 TEST UPDATING PID INSTANCE AND MERGE ENRICHMENT WITH CURRENT PUBLICATION
+		publications = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/publications.json", Publication.class);
+		enrichment = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/enrichment.json", Publication.class);
+		updatePidIntoPublicationInstance(publications, enrichment, false);
+		applyAndVerifyEnrichment( enrichment, publications);
+
+		// 4 TEST UPDATING ALTERNATE ID INSTANCE AND MERGE ENRICHMENT WITH CURRENT PUBLICATION
+		publications = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/publications.json", Publication.class);
+		enrichment = loadResourceResult("/eu/dnetlib/dhp/schema/oaf/utils/enrichment.json", Publication.class);
+		updatePidIntoPublicationInstance(publications, enrichment, true);
+		applyAndVerifyEnrichment( enrichment, publications);
+
+
+	}
+
+
+	/**
+	 * Merge publication date of acceptance test both present.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_bothPresent() {
+
+		Publication a = publication();
+		Publication b = publication();
+
+		a.setDateofacceptance(field("2021-06-18"));
+		b.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-18", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test both present 1.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_bothPresent_1() {
+
+		Publication a = publication("0.8");
+		Publication b = publication("0.9");
+
+		a.setDateofacceptance(field("2021-06-18"));
+		b.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-19", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test both present 2.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_bothPresent_2() {
+
+		Publication a = publication("0.9");
+		Publication b = publication("0.8");
+
+		a.setDateofacceptance(field("2021-06-18"));
+		b.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-18", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test left missing.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_leftMissing() {
+
+		Publication a = publication();
+		Publication b = publication();
+
+		b.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-19", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test left missing 1.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_leftMissing_1() {
+
+		Publication a = publication("0.9");
+		Publication b = publication("0.8");
+
+		b.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-19", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test left missing 2.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_leftMissing_2() {
+
+		Publication a = publication("0.8");
+		Publication b = publication("0.9");
+
+		b.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-19", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test right missing.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_rightMissing() {
+
+		Publication a = publication();
+		Publication b = publication();
+
+		a.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-19", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test right missing 1.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_rightMissing_1() {
+
+		Publication a = publication("0.8");
+		Publication b = publication("0.9");
+
+		a.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-19", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication date of acceptance test right missing 2.
+	 */
+	@Test
+	void mergePublicationDateOfAcceptanceTest_rightMissing_2() {
+
+		Publication a = publication("0.9");
+		Publication b = publication("0.8");
+
+		a.setDateofacceptance(field("2021-06-19"));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getDateofacceptance());
+		assertEquals("2021-06-19", a.getDateofacceptance().getValue());
+	}
+
+	/**
+	 * Merge publication subject test.
+	 */
+	@Test
+	void mergePublicationSubjectTest() {
+
+		Publication a = publication();
+		Publication b = publication();
+
+		a.setSubject(Arrays.asList(setSP("a", "open", "classe"), setSP("b", "open", "classe")));
+		b.setSubject(Arrays.asList(setSP("A", "open", "classe"), setSP("c", "open", "classe")));
+
+		a = OafUtils.mergeOAF(a,b);
+
+		assertNotNull(a.getSubject());
+		assertEquals(3, a.getSubject().size());
+	}
+
+	/**
+	 * Merge relation test.
+	 */
+	@Test
+	void mergeRelationTest() {
+
+		Relation a = createRel(null, null);
+		Relation b = createRel(null, null);
+		a = OafUtils.mergeOAF(a,b);
+		assertEquals(a, b);
+
+		a = createRel(true, null);
+		b = createRel(null, null);
+		a = OafUtils.mergeOAF(a,b);
+		assertEquals(true, a.getValidated());
+
+		a = createRel(true, null);
+		b = createRel(false, null);
+		a = OafUtils.mergeOAF(a,b);
+		assertEquals(true, a.getValidated());
+
+		a = createRel(true, null);
+		b = createRel(true, "2016-04-05T12:41:19.202Z");
+		a = OafUtils.mergeOAF(a,b);
+		assertEquals("2016-04-05T12:41:19.202Z", a.getValidationDate());
+
+		a = createRel(true, "2016-05-07T12:41:19.202Z");
+		b = createRel(true, "2016-04-05T12:41:19.202Z");
+		a = OafUtils.mergeOAF(a,b);
+		assertEquals("2016-04-05T12:41:19.202Z", a.getValidationDate());
+
+		a = createRel(true, "2020-09-10 11:08:52");
+		b = createRel(true, "2021-09-10 11:08:52");
+		a = OafUtils.mergeOAF(a,b);
+		assertEquals("2020-09-10 11:08:52", a.getValidationDate());
+
+		a = createRel(true, "2021-03-16T10:32:42Z");
+		b = createRel(true, "2020-03-16T10:32:42Z");
+		a = OafUtils.mergeOAF(a,b);
+		assertEquals("2020-03-16T10:32:42Z", a.getValidationDate());
+
+
+	}
+
+	/**
+	 * Merge relation test parse exception.
+	 */
+	@Test
+	void mergeRelationTestParseException() {
+		assertThrows(DateTimeParseException.class, () -> {
+			Relation a = createRel(true, "Once upon a time ...");
+			Relation b = createRel(true, "... in a far away land");
+			a = OafUtils.mergeOAF(a,b);
+		});
+	}
+
+	/**
+	 * Create rel relation.
+	 *
+	 * @param validated      the validated
+	 * @param validationDate the validation date
+	 * @return the relation
+	 */
+	private Relation createRel(Boolean validated, String validationDate) {
+		Relation rel = new Relation();
+		rel.setSource("1");
+		rel.setTarget("2");
+		rel.setRelType("reltype");
+		rel.setSubRelType("subreltype");
+		rel.setRelClass("relclass");
+		rel.setValidated(validated);
+		rel.setValidationDate(validationDate);
+		return rel;
+	}
+
+	/**
+	 * Sets kv.
+	 *
+	 * @param key   the key
+	 * @param value the value
+	 * @return the kv
+	 */
+	private KeyValue setKV(final String key, final String value) {
+
+		KeyValue k = new KeyValue();
+
+		k.setKey(key);
+		k.setValue(value);
+
+		return k;
+	}
+
+	/**
+	 * Sets sp.
+	 *
+	 * @param value     the value
+	 * @param schema    the schema
+	 * @param classname the classname
+	 * @return the sp
+	 */
+	private StructuredProperty setSP(
+		final String value, final String schema, final String classname) {
+		StructuredProperty s = new StructuredProperty();
+		s.setValue(value);
+		Qualifier q = new Qualifier();
+		q.setClassname(classname);
+		q.setClassid(classname);
+		q.setSchemename(schema);
+		q.setSchemeid(schema);
+		s.setQualifier(q);
+		return s;
+	}
+
+	/**
+	 * Field field.
+	 *
+	 * @param <T>   the type parameter
+	 * @param value the value
+	 * @return the field
+	 */
+	private <T> Field<T> field(T value) {
+		Field<T> f = new Field();
+		f.setValue(value);
+		return f;
+	}
+
+	/**
+	 * Publication publication.
+	 *
+	 * @return the publication
+	 */
+	private Publication publication() {
+		Publication p = new Publication();
+		p.setDataInfo(df("0.9"));
+		return p;
+	}
+
+	/**
+	 * Publication publication.
+	 *
+	 * @param trust the trust
+	 * @return the publication
+	 */
+	private Publication publication(String trust) {
+		Publication p = new Publication();
+		p.setDataInfo(df(trust));
+		return p;
+	}
+
+	/**
+	 * Df data info.
+	 *
+	 * @param trust the trust
+	 * @return the data info
+	 */
+	private DataInfo df(String trust) {
+		DataInfo d = new DataInfo();
+		d.setTrust(trust);
+		return d;
+	}
+}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/PICCleaningRuleTest.java

@@ -1,19 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-import org.junit.jupiter.api.Test;
-
-class PICCleaningRuleTest {
-
-	@Test
-	void testCleaning() {
-		assertEquals("887624982", PICCleaningRule.clean("887624982"));
-		assertEquals("", PICCleaningRule.clean("887 624982"));
-		assertEquals("887624982", PICCleaningRule.clean(" 887624982 "));
-		assertEquals("887624982", PICCleaningRule.clean(" 887624982x "));
-		assertEquals("887624982", PICCleaningRule.clean(" 88762498200 "));
-	}
-
-}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/PmcCleaningRuleTest.java

@@ -1,19 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-import org.junit.jupiter.api.Test;
-
-class PmcCleaningRuleTest {
-
-	@Test
-	void testCleaning() {
-		assertEquals("PMC1234", PmcCleaningRule.clean("PMC1234"));
-		assertEquals("PMC1234", PmcCleaningRule.clean(" PMC1234"));
-		assertEquals("PMC12345678", PmcCleaningRule.clean("PMC12345678"));
-		assertEquals("PMC12345678", PmcCleaningRule.clean("PMC123456789"));
-		assertEquals("PMC12345678", PmcCleaningRule.clean("PMC 12345678"));
-	}
-
-}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/PmidCleaningRuleTest.java

@@ -1,24 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-import org.junit.jupiter.api.Test;
-
-class PmidCleaningRuleTest {
-
-	@Test
-	void testCleaning() {
-		// leading zeros are removed
-		assertEquals("1234", PmidCleaningRule.clean("01234"));
-		// tolerant to spaces in the middle
-		assertEquals("1234567", PmidCleaningRule.clean("0123 4567"));
-		// stop parsing at first not numerical char
-		assertEquals("123", PmidCleaningRule.clean("0123x4567"));
-		// invalid id leading to empty result
-		assertEquals("", PmidCleaningRule.clean("abc"));
-		// valid id with zeroes in the number
-		assertEquals("20794075", PmidCleaningRule.clean("20794075"));
-	}
-
-}

dhp-common/src/test/java/eu/dnetlib/dhp/schema/oaf/utils/RorCleaningRuleTest.java

@@ -1,17 +0,0 @@
-
-package eu.dnetlib.dhp.schema.oaf.utils;
-
-import static org.junit.jupiter.api.Assertions.assertEquals;
-
-import org.junit.jupiter.api.Test;
-
-class RorCleaningRuleTest {
-
-	@Test
-	void testCleaning() {
-		assertEquals("https://ror.org/05rpz9w55", RorCleaningRule.clean("https://ror.org/05rpz9w55"));
-		assertEquals("https://ror.org/05rpz9w55", RorCleaningRule.clean("05rpz9w55"));
-		assertEquals("", RorCleaningRule.clean("05rpz9w_55"));
-	}
-
-}

dhp-common/src/test/java/eu/dnetlib/oa/merge/AuthorMergerTest.java

@@ -1,114 +0,0 @@
-
-package eu.dnetlib.oa.merge;
-
-import static org.junit.jupiter.api.Assertions.*;
-
-import java.io.BufferedReader;
-import java.io.InputStreamReader;
-import java.util.List;
-import java.util.Objects;
-
-import org.junit.jupiter.api.Test;
-import org.junit.platform.commons.util.StringUtils;
-
-import com.fasterxml.jackson.core.type.TypeReference;
-import com.fasterxml.jackson.databind.ObjectMapper;
-
-import eu.dnetlib.dhp.oa.merge.AuthorMerger;
-import eu.dnetlib.dhp.schema.oaf.Author;
-
-public class AuthorMergerTest {
-
-	@Test
-	public void testEnrcichAuthor() throws Exception {
-		final ObjectMapper mapper = new ObjectMapper();
-
-		BufferedReader pr = new BufferedReader(new InputStreamReader(
-			Objects
-				.requireNonNull(
-					AuthorMergerTest.class
-						.getResourceAsStream("/eu/dnetlib/dhp/oa/merge/authors_publication_sample.json"))));
-		BufferedReader or = new BufferedReader(new InputStreamReader(
-			Objects
-				.requireNonNull(
-					AuthorMergerTest.class.getResourceAsStream("/eu/dnetlib/dhp/oa/merge/authors_orcid_sample.json"))));
-
-		TypeReference<List<Author>> aclass = new TypeReference<List<Author>>() {
-		};
-		String pubLine;
-
-		int i = 0;
-		while ((pubLine = pr.readLine()) != null) {
-			final String pubId = pubLine;
-			final String MatchPidOrcid = or.readLine();
-			final String pubOrcid = or.readLine();
-
-			final String data = pr.readLine();
-
-			if (StringUtils.isNotBlank(data)) {
-				List<Author> publicationAuthors = mapper.readValue(data, aclass);
-				List<Author> orcidAuthors = mapper.readValue(or.readLine(), aclass);
-				System.out.printf("OAF ID = %s \n", pubId);
-				System.out.printf("ORCID Intersected ID = %s \n", pubOrcid);
-				System.out.printf("OAF Author Size = %d \n", publicationAuthors.size());
-				System.out.printf("Oricd Author Size = %d \n", orcidAuthors.size());
-				System.out.printf("Oricd Matched PID = %s \n", MatchPidOrcid);
-
-				long originalAuthorWithPiD = publicationAuthors
-					.stream()
-					.filter(
-						a -> a.getPid() != null && a
-							.getPid()
-							.stream()
-							.anyMatch(
-								p -> p.getQualifier() != null
-									&& p.getQualifier().getClassid().toLowerCase().contains("orcid")))
-					.count();
-				long start = System.currentTimeMillis();
-
-//                final List<Author> enrichedList = AuthorMerger.enrichOrcid(publicationAuthors, orcidAuthors);
-				final List<Author> enrichedList = AuthorMerger.enrichOrcid(publicationAuthors, orcidAuthors);
-
-				long enrichedAuthorWithPid = enrichedList
-					.stream()
-					.filter(
-						a -> a.getPid() != null && a
-							.getPid()
-							.stream()
-							.anyMatch(
-								p -> p.getQualifier() != null
-									&& p.getQualifier().getClassid().toLowerCase().contains("orcid")))
-					.count();
-
-				long totalTime = (System.currentTimeMillis() - start) / 1000;
-				System.out
-					.printf(
-						"Enriched authors in %d seconds from %d pid to %d pid \n", totalTime, originalAuthorWithPiD,
-						enrichedAuthorWithPid);
-
-				System.out.println("=================");
-			}
-		}
-	}
-
-	@Test
-	public void checkSimilarityTest() {
-		final Author left = new Author();
-		left.setName("Anand");
-		left.setSurname("Rachna");
-		left.setFullname("Anand, Rachna");
-
-		System.out.println(AuthorMerger.normalizeFullName(left.getFullname()));
-
-		final Author right = new Author();
-		right.setName("Rachna");
-		right.setSurname("Anand");
-		right.setFullname("Rachna, Anand");
-//        System.out.println(AuthorMerger.normalize(right.getFullname()));
-		boolean same = AuthorMerger.checkORCIDSimilarity(left, right);
-
-		assertTrue(same);
-
-	}
-
-}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/dataset_2.json

@@ -1,140 +1 @@
-{
-  "id": "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1g",
-  "resuttype": {"classid": "dataset"},
-  "pid": [
-    {
-      "qualifier": {"classid": "doi"},
-      "value": "10.1016/j.cmet.2011.03.013"
-    },
-    {
-      "qualifier": {"classid": "urn"},
-      "value": "urn:nbn:nl:ui:29-f3ed5f9e-edf6-457e-8848-61b58a4075e2"
-    },
-    {
-      "qualifier": {"classid": "scp-number"},
-      "value": "79953761260"
-    },
-    {
-      "qualifier": {"classid": "pmc"},
-      "value": "21459329"
-    }
-  ],
-  "collectedfrom": [
-    {
-      "key": "10|openaire____::081b82f96300b6a6e3d282bad31cb6e3",
-      "value": "Repository B"
-    }
-  ],
-  "instance": [
-    {
-      "refereed": {
-        "classid": "0000",
-        "classname": "UNKNOWN",
-        "schemeid": "dnet:review_levels",
-        "schemename": "dnet:review_levels"
-      },
-      "hostedby": {
-        "key": "10|opendoar____::358aee4cc897452c00244351e4d91f69",
-        "value": "Zenodo"
-      },
-      "accessright": {
-        "classid": "OPEN",
-        "classname": "Open Access",
-        "schemeid": "dnet:access_modes",
-        "schemename": "dnet:access_modes"
-      },
-      "processingchargecurrency": {
-        "dataInfo": {
-          "provenanceaction": {
-            "classid": "sysimport:crosswalk:datasetarchive",
-            "classname": "Harvested",
-            "schemeid": "dnet:provenanceActions",
-            "schemename": "dnet:provenanceActions"
-          },
-          "deletedbyinference": false,
-          "inferred": false,
-          "inferenceprovenance": "",
-          "invisible": true,
-          "trust": "0.9"
-        },
-        "value": "EUR"
-      },
-      "pid": [
-        {
-          "dataInfo": {
-            "provenanceaction": {
-              "classid": "sysimport:crosswalk:datasetarchive",
-              "classname": "Harvested",
-              "schemeid": "dnet:provenanceActions",
-              "schemename": "dnet:provenanceActions"
-            },
-            "deletedbyinference": false,
-            "inferred": false,
-            "inferenceprovenance": "",
-            "invisible": true,
-            "trust": "0.9"
-          },
-          "qualifier": {
-            "classid": "doi",
-            "classname": "Digital Object Identifier",
-            "schemeid": "dnet:pid_types",
-            "schemename": "dnet:pid_types"
-          },
-          "value": "10.1371/journal.pone.0085605"
-        }
-      ],
-      "distributionlocation": "",
-      "url": ["https://doi.org/10.1371/journal.pone.0085605"],
-      "alternateIdentifier": [
-        {
-          "dataInfo": {
-            "provenanceaction": {
-              "classid": "sysimport:crosswalk:datasetarchive",
-              "classname": "Harvested",
-              "schemeid": "dnet:provenanceActions",
-              "schemename": "dnet:provenanceActions"
-            },
-            "deletedbyinference": false,
-            "inferred": false,
-            "inferenceprovenance": "",
-            "invisible": true,
-            "trust": "0.9"
-          },
-          "qualifier": {
-            "classid": "pmid",
-            "classname": "PubMed ID",
-            "schemeid": "dnet:pid_types",
-            "schemename": "dnet:pid_types"
-          },
-          "value": "24454899.0"
-        }
-      ],
-      "collectedfrom": {
-        "key": "10|openaire____::081b82f96300b6a6e3d282bad31cb6e3",
-        "value": "Repository B"
-      },
-      "processingchargeamount": {
-        "dataInfo": {
-          "provenanceaction": {
-            "classid": "sysimport:crosswalk:datasetarchive",
-            "classname": "Harvested",
-            "schemeid": "dnet:provenanceActions",
-            "schemename": "dnet:provenanceActions"
-          },
-          "deletedbyinference": false,
-          "inferred": false,
-          "inferenceprovenance": "",
-          "invisible": true,
-          "trust": "0.9"
-        },
-        "value": "1022.02"
-      },
-      "instancetype": {
-        "classid": "0004",
-        "classname": "Conference object",
-        "schemeid": "dnet:publication_resource",
-        "schemename": "dnet:publication_resource"
-      }
-    }
-  ]
-}
+{"id":"50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1g", "resuttype" : { "classid" : "dataset" }, "pid":[{"qualifier":{"classid":"doi"},"value":"10.1016/j.cmet.2011.03.013"},{"qualifier":{"classid":"urn"},"value":"urn:nbn:nl:ui:29-f3ed5f9e-edf6-457e-8848-61b58a4075e2"},{"qualifier":{"classid":"scp-number"},"value":"79953761260"},{"qualifier":{"classid":"pmc"},"value":"21459329"}], "collectedfrom" : [ { "key" : "10|openaire____::081b82f96300b6a6e3d282bad31cb6e3", "value" : "Repository B"} ]}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/enrichment.json

@@ -0,0 +1,12 @@
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0000/ra.v2i3.114::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"4.65008652949e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0000/ra.v2i3.114"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0001/(aj).v3i6.458::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"4.01810569717e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0001/(aj).v3i6.458"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0001/1587::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.39172290649e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0001/1587"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0001/462::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"6.33235333753e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.36"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.00285265116e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0001/462"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0001/731::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"4.01810569717e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0001/731"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0001/ijllis.v9i4.2066.g2482::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"8.48190886761e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0001/ijllis.v9i4.2066.g2482"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0118/alfahim.v3i1.140::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"9.88840807598e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0118/alfahim.v3i1.140"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0166/fk2.stagefigshare.6442896.v3::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"7.28336930301e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0166/fk2.stagefigshare.6442896.v3"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0301/jttb.v2i1.64::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"7.28336930301e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0301/jttb.v2i1.64"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0809/seruni.v1i1.567::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"2.62959564033e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0809/seruni.v1i1.567"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0809/seruni.v2i1.765::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"9.40178571921e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0559872"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"3.67659957614e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0809/seruni.v2i1.765"}]}]}
+{"dataInfo":{"deletedbyinference":false,"inferred":true,"invisible":false,"provenanceaction":{"classid":"sysimport:enrich","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"}},"id":"unresolved::10.0901/jkip.v7i3.485::doi","instance":[{"measures":[{"id":"influence","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"5.91019644836e-09"}]},{"id":"popularity_alt","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"0.0"}]},{"id":"popularity","unit":[{"dataInfo":{"deletedbyinference":false,"inferenceprovenance":"update","inferred":true,"invisible":false,"provenanceaction":{"classid":"measure:bip","classname":"Inferred by OpenAIRE","schemeid":"dnet:provenanceActions","schemename":"dnet:provenanceActions"},"trust":""},"key":"score","value":"6.26204125721e-09"}]}],"pid":[{"qualifier":{"classid":"doi","classname":"Digital Object Identifier","schemeid":"dnet:pid_types","schemename":"dnet:pid_types"},"value":"10.0901/jkip.v7i3.485"}]}]}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/publication_3.json

@@ -0,0 +1 @@
+{"id":"50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f","pid":[{"qualifier":{"classid":"scp-number"},"value":"79953761260"}]}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/publication_4.json

@@ -0,0 +1 @@
+{"id":"50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f","pid":[]}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/publication_5.json

@@ -0,0 +1 @@
+{"id":"50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f"}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/publication_doi1.json

@@ -0,0 +1,33 @@
+{
+  "id": "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f",
+  "instance": [
+    {
+      "collectedfrom": {
+        "key": "10|openaire____::081b82f96300b6a6e3d282bad31cb6e2",
+        "value": "Crossref"
+      },
+      "pid": [
+        {
+          "qualifier": {"classid": "doi"},
+          "value": "10.1016/j.cmet.2010.03.013"
+        }
+      ]
+    },
+    {
+      "pid": [
+        {
+          "qualifier": {"classid": "urn"},
+          "value": "urn:nbn:nl:ui:29-f3ed5f9e-edf6-457e-8848-61b58a4075e2"
+        },
+        {
+          "qualifier": {"classid": "scp-number"},
+          "value": "79953761260"
+        },
+        {
+          "qualifier": {"classid": "pmc"},
+          "value": "21459329"
+        }
+      ]
+    }
+  ]
+}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/publication_doi2.json

@@ -0,0 +1,37 @@
+{
+  "id": "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f",
+  "instance": [
+    {
+      "collectedfrom": {
+        "key": "10|openaire____::081b82f96300b6a6e3d282bad31cb6e2",
+        "value": "Crossref"
+      },
+      "pid": [
+        {
+          "qualifier": {"classid": "doi"},
+          "value": "10.1016/j.cmet.2010.03.013"
+        }
+      ]
+    },
+    {
+      "collectedfrom": {
+        "key": "10|opendoar____::8b6dd7db9af49e67306feb59a8bdc52c",
+        "value": "Europe PubMed Central"
+      },
+      "pid": [
+        {
+          "qualifier": {"classid": "urn"},
+          "value": "urn:nbn:nl:ui:29-f3ed5f9e-edf6-457e-8848-61b58a4075e2"
+        },
+        {
+          "qualifier": {"classid": "scp-number"},
+          "value": "79953761260"
+        },
+        {
+          "qualifier": {"classid": "pmc"},
+          "value": "21459329"
+        }
+      ]
+    }
+  ]
+}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/publication_doi3.json

@@ -0,0 +1,37 @@
+{
+  "id": "50|DansKnawCris::0829b5191605bdbea36d6502b8c1ce1f",
+  "instance": [
+    {
+      "collectedfrom": {
+        "key": "10|opendoar____::358aee4cc897452c00244351e4d91f69",
+        "value": "Zenodo"
+      },
+      "pid": [
+        {
+          "qualifier": {"classid": "doi"},
+          "value": "10.1016/j.cmet.2010.03.013"
+        }
+      ]
+    },
+    {
+      "collectedfrom": {
+        "key": "10|opendoar____::8b6dd7db9af49e67306feb59a8bdc52c",
+        "value": "Europe PubMed Central"
+      },
+      "pid": [
+        {
+          "qualifier": {"classid": "urn"},
+          "value": "urn:nbn:nl:ui:29-f3ed5f9e-edf6-457e-8848-61b58a4075e2"
+        },
+        {
+          "qualifier": {"classid": "scp-number"},
+          "value": "79953761260"
+        },
+        {
+          "qualifier": {"classid": "pmc"},
+          "value": "21459329"
+        }
+      ]
+    }
+  ]
+}

dhp-common/src/test/resources/eu/dnetlib/dhp/schema/oaf/utils/publication_doi4.json

@@ -0,0 +1,37 @@
+{
+  "id": "50|od______2852::38861c44e6052a8d49f59a4c39ba5e66",
+  "instance": [
+    {
+      "collectedfrom": {
+        "key": "10|opendoar____::358aee4cc897452c00244351e4d91f69",
+        "value": "Zenodo"
+      },
+      "pid": [
+        {
+          "qualifier": {"classid": "doi"},
+          "value": "10.1016/j.cmet.2010.03.013"
+        },
+        {
+          "qualifier": {"classid": "handle"},
+          "value": "11012/83840"
+        }
+      ]
+    },
+    {
+      "collectedfrom": {
+        "key": "10|opendoar____::2852",
+        "value": "Digital library of Brno University of Technology"
+      },
+      "pid": [
+        {
+          "qualifier": {"classid": "pmc"},
+          "value": "21459329"
+        },
+        {
+          "qualifier": {"classid": "handle"},
+          "value": "11012/83840"
+        }
+      ]
+    }
+  ]
+}