[orcipPropagation]rewritten in scala. generategraph again not abstract

This commit is contained in:
Miriam Baglioni 2024-12-20 12:40:33 +01:00
parent 1853da1e2c
commit 29611b2091
3 changed files with 121 additions and 143 deletions

View File

@ -1,24 +1,27 @@
package eu.dnetlib.dhp.common.author
import eu.dnetlib.dhp.application.AbstractScalaApplication
import eu.dnetlib.dhp.schema.common.{ModelConstants, ModelSupport}
import eu.dnetlib.dhp.schema.common.{EntityType, ModelConstants, ModelSupport}
import eu.dnetlib.dhp.utils.{MatchData, ORCIDAuthorEnricher, ORCIDAuthorEnricherResult}
import org.apache.spark.sql._
import org.apache.spark.sql.functions._
import org.slf4j.{Logger, LoggerFactory}
import eu.dnetlib.dhp.common.enrichment.Constants.PROPAGATION_DATA_INFO_TYPE
import eu.dnetlib.dhp.schema.oaf.Result
import eu.dnetlib.dhp.schema.oaf.{OafEntity, Result}
import eu.dnetlib.dhp.schema.oaf.utils.MergeUtils
import org.apache.spark.api.java.function.{MapFunction, MapGroupsFunction}
import org.apache.spark.sql.expressions.Aggregator
import java.util
import java.util.Iterator
import scala.collection.JavaConverters._
abstract class SparkEnrichWithOrcidAuthors(propertyPath: String, args: Array[String], log: Logger)
extends AbstractScalaApplication(propertyPath, args, log: Logger) {
extends AbstractScalaApplication(propertyPath, args, log: Logger) {
/** Here all the spark applications runs this method
* where the whole logic of the spark node is defined
*/
* where the whole logic of the spark node is defined
*/
override def run(): Unit = {
val graphPath = parser.get("graphPath")
log.info(s"graphPath is '$graphPath'")
@ -41,7 +44,57 @@ abstract class SparkEnrichWithOrcidAuthors(propertyPath: String, args: Array[Str
generateGraph(spark, graphPath, workingDir, targetPath)
}
def generateGraph(spark: SparkSession, graphPath: String, workingDir: String, targetPath: String): Unit
private def processAndMerge(spark: SparkSession, inputPath: String, outputPath: String, clazz: Class[Result], encoder: Encoder[Result]): Unit = {
var tmp = spark.read
.schema(Encoders.bean(clazz).schema)
.json(inputPath).as(encoder)
tmp.groupByKey(r => r.getId)(Encoders.STRING)
.mapGroups((k, it) => {
val p: Result = it.next
it.foldLeft(p.getAuthor)((x,r) => MergeUtils.mergeAuthors(x, r.getAuthor,0))
p
})(encoder).write.mode(SaveMode.Overwrite).option("compression", "gzip").json(outputPath)
}
private def generateGraph(spark: SparkSession, graphPath: String, workingDir: String, targetPath: String): Unit = {
ModelSupport.entityTypes
.keySet().asScala
.filter(ModelSupport.isResult).foreach((e: EntityType) => {
val resultClazz: Class[Result] = ModelSupport.entityTypes.get(e).asInstanceOf[Class[Result]]
val matched: Dataset[Row] = spark.read
.schema(Encoders.bean(classOf[ORCIDAuthorEnricherResult]).schema)
.parquet(workingDir + "/" + e.name + "_matched")
.selectExpr("id", "enriched_author")
val result: Dataset[Row] = spark.read
.schema(Encoders.bean(resultClazz).schema)
.json(graphPath + "/" + e.name)
result.join(matched, Seq("id"), "left")
.withColumn("author", when(size(col("enriched_author")).gt(0), col("enriched_author"))
.otherwise(col("author")))
.drop("enriched_author").as(Encoders.bean(resultClazz))
.groupByKey(r => r.getId)(Encoders.STRING)
.mapGroups((k, it) => {
val p: Result = it.next
it.foldLeft(p.getAuthor)((x,r) => MergeUtils.mergeAuthors(x, r.getAuthor,0))
p
})(Encoders.bean(resultClazz))
.write
.mode(SaveMode.Overwrite)
.option("compression", "gzip")
.json(targetPath + "/" + e.name )
})
}
// def generateGraph(spark: SparkSession, graphPath: String, workingDir: String, targetPath: String): Unit
def createTemporaryData(spark: SparkSession, graphPath: String, orcidPath: String, targetPath: String): Unit

View File

@ -89,112 +89,68 @@ public class SparkPropagateOrcidAuthor extends SparkEnrichWithOrcidAuthors {
}
private <T> void processAndMerge(
SparkSession spark,
String inputPath,
String outputPath,
Class<T> clazz,
Encoder<T> encoder) {
spark.read()
.schema(Encoders.bean(clazz).schema())
.json(inputPath)
.as(encoder)
.groupByKey((MapFunction<T, String>) p -> {
try {
return (String) clazz.getMethod("getId").invoke(p);
} catch (Exception e) {
throw new RuntimeException("Error invoking getId method", e);
}
}, Encoders.STRING())
.mapGroups((MapGroupsFunction<String, T, T>) (k, it) -> {
T p = it.next();
it.forEachRemaining(r -> {
try {
List<Author> currentAuthors = (List<Author>) clazz.getMethod("getAuthor").invoke(p);
List<Author> newAuthors = (List<Author>) clazz.getMethod("getAuthor").invoke(r);
clazz.getMethod("setAuthor", List.class)
.invoke(p, MergeUtils.mergeAuthors(currentAuthors, newAuthors, 0));
} catch (Exception e) {
throw new RuntimeException("Error merging authors", e);
}
});
return p;
}, encoder)
.write()
.mode(SaveMode.Overwrite)
.option("compression", "gzip")
.json(outputPath);
}
@Override
public void generateGraph(SparkSession spark, String graphPath, String workingDir, String targetPath){
ModelSupport.entityTypes.keySet().stream().filter(ModelSupport::isResult)
.forEach(e -> {
Class resultClazz = ModelSupport.entityTypes.get(e);
Dataset<Row> matched = spark
.read()
.schema(Encoders.bean(ORCIDAuthorEnricherResult.class).schema())
.parquet(workingDir + "/" + e.name() + "_matched")
.selectExpr("id","enriched_author");
Dataset<Row> result = spark.read().schema(Encoders.bean(resultClazz).schema())
.json(graphPath + "/" + e.name());
result.join(matched, result.col("id").equalTo(matched.col("id")), "left")
.withColumn(
"author",
when(size(col("enriched_author")).gt(0), col("enriched_author"))
.otherwise(col("author"))
)
.drop(matched.col("id"))
.drop("enriched_author")
.write()
.mode(SaveMode.Overwrite)
.option("compression", "gzip")
.json(workingDir + "/" + e.name() + "/_tobemerged")
;
});
processAndMerge(
spark,
workingDir + "/publication/_tobemerged",
targetPath + "/publication",
Publication.class,
Encoders.bean(Publication.class)
);
processAndMerge(
spark,
workingDir + "/dataset/_tobemerged",
targetPath + "/dataset",
eu.dnetlib.dhp.schema.oaf.Dataset.class,
Encoders.bean(eu.dnetlib.dhp.schema.oaf.Dataset.class)
);
processAndMerge(
spark,
workingDir + "/otherresearchproduct/_tobemerged",
targetPath + "/otherresearchproduct",
OtherResearchProduct.class,
Encoders.bean(OtherResearchProduct.class)
);
processAndMerge(
spark,
workingDir + "/software/_tobemerged",
targetPath + "/software",
Software.class,
Encoders.bean(Software.class)
);
}
// private <T extends Result> void processAndMerge(
// SparkSession spark,
// String inputPath,
// String outputPath,
// Class<T> clazz,
// Encoder<T> encoder) {
//
// spark.read()
// .schema(Encoders.bean(clazz).schema())
// .json(inputPath)
// .as(encoder)
// .groupByKey((MapFunction<T, String>) OafEntity::getId, Encoders.STRING())
// .mapGroups((MapGroupsFunction<String, T, T>) (k, it) -> {
// T p = it.next();
// it.forEachRemaining(r -> p.setAuthor(MergeUtils.mergeAuthors(p.getAuthor(),r.getAuthor(),0)));
// return p;
// }, encoder)
// .write()
// .mode(SaveMode.Overwrite)
// .option("compression", "gzip")
// .json(outputPath);
// }
// @Override
//public void generateGraph(SparkSession spark, String graphPath, String workingDir, String targetPath){
//
// ModelSupport.entityTypes.keySet().stream().filter(ModelSupport::isResult)
// .forEach(e -> {
// Class resultClazz = ModelSupport.entityTypes.get(e);
// Dataset<Row> matched = spark
// .read()
// .schema(Encoders.bean(ORCIDAuthorEnricherResult.class).schema())
// .parquet(workingDir + "/" + e.name() + "_matched")
// .selectExpr("id","enriched_author");
// Dataset<Row> result = spark.read().schema(Encoders.bean(resultClazz).schema())
// .json(graphPath + "/" + e.name());
//
//
//
// result.join(matched, result.col("id").equalTo(matched.col("id")), "left")
// .withColumn(
// "author",
// when(size(col("enriched_author")).gt(0), col("enriched_author"))
// .otherwise(col("author"))
// )
// .drop(matched.col("id"))
// .drop("enriched_author")
// .write()
// .mode(SaveMode.Overwrite)
// .option("compression", "gzip")
// .json(workingDir + "/" + e.name() + "/_tobemerged")
// ;
// processAndMerge(
// spark,
// workingDir + "/" + e.name() + "/_tobemerged",
// targetPath + "/" + e.name(),
// resultClazz,
// Encoders.bean(resultClazz)
// );
// });
//
//
// }
@Override
public void createTemporaryData(SparkSession spark, String graphPath, String orcidPath, String targetPath) {

View File

@ -87,37 +87,6 @@ class SparkEnrichGraphWithOrcidAuthors(propertyPath: String, args: Array[String]
orcidWorksWithAuthors.unpersist()
}
override def generateGraph(spark: SparkSession, graphPath: String, workingDir: String, targetPath: String): Unit = {
ModelSupport.entityTypes.asScala
.filter(e => ModelSupport.isResult(e._1))
.foreach(e => {
val resultType = e._1.name()
val enc = Encoders.bean(e._2)
val matched = spark.read
.schema(Encoders.bean(classOf[ORCIDAuthorEnricherResult]).schema)
.parquet(s"${workingDir}/${resultType}_matched")
.selectExpr("id", "enriched_author")
spark.read
.schema(enc.schema)
.json(s"$graphPath/$resultType")
.join(matched, Seq("id"), "left")
.withColumn(
"author",
when(size(col("enriched_author")).gt(0), col("enriched_author"))
.otherwise(col("author"))
)
.drop("enriched_author")
.write
.mode(SaveMode.Overwrite)
.option("compression", "gzip")
.json(s"${targetPath}/${resultType}")
})
}
}
object SparkEnrichGraphWithOrcidAuthors {