ROHub as delegated authority for w3id

src/main/java/eu/dnetlib/dhp/schema/oaf/utils/IdentifierFactory.java

@@ -32,7 +32,8 @@ public class IdentifierFactory implements Serializable {
 	public static final int ID_PREFIX_LEN = 12;
 
 	/**
-	 * Declares the associations PID_TYPE -> [DATASOURCE ID, NAME] considered authoritative for that PID_TYPE
+	 * Declares the associations PID_TYPE -> [DATASOURCE ID, NAME] considered authoritative for that PID_TYPE.
+	 * The id of the record (source_::id) will be rewritten as pidType_::id)
 	 */
 	public static final Map<PidType, HashBiMap<String, String>> PID_AUTHORITY = Maps.newHashMap();
 
@@ -61,6 +62,9 @@ public class IdentifierFactory implements Serializable {
 	/**
 	 * Declares the associations PID_TYPE -> [DATASOURCE ID, PID SUBSTRING] considered as delegated authority for that
 	 * PID_TYPE. Example, Zenodo is delegated to forge DOIs that contain the 'zenodo' word.
+	 *
+	 * If a record with the same id (same pid) comes from 2 data sources, the one coming from a delegated source wins. E.g. Zenodo records win over those from Datacite.
+	 * See also https://code-repo.d4science.org/D-Net/dnet-hadoop/pulls/187 and the class dhp-common/src/main/java/eu/dnetlib/dhp/schema/oaf/utils/OafMapperUtils.java
 	 */
 	public static final Map<PidType, Map<String, String>> DELEGATED_PID_AUTHORITY = Maps.newHashMap();
 
@@ -68,6 +72,8 @@ public class IdentifierFactory implements Serializable {
 		DELEGATED_PID_AUTHORITY.put(PidType.doi, new HashMap<>());
 		DELEGATED_PID_AUTHORITY.get(PidType.doi).put(ZENODO_OD_ID, "zenodo");
 		DELEGATED_PID_AUTHORITY.get(PidType.doi).put(ZENODO_R3_ID, "zenodo");
+		DELEGATED_PID_AUTHORITY.put(PidType.w3id, new HashMap<>());
+		DELEGATED_PID_AUTHORITY.get(PidType.w3id).put(ROHUB_ID, "ro-id");
 	}
 
 	/**

src/test/java/eu/dnetlib/dhp/schema/oaf/utils/IdentifierFactoryTest.java

@@ -68,12 +68,18 @@ class IdentifierFactoryTest {
 		verifyIdentifier("publication_5.json", defaultID, false);
 	}
 
+	@Test
+	void testCreateIdentifierForROHub() throws IOException {
+		verifyIdentifier(
+				"orp-rohub.json", "50|w3id________::afc7592914ae190a50570db90f55f9c2", true);
+	}
+
 	protected void verifyIdentifier(String filename, String expectedID, boolean md5) throws IOException {
 		final String json = IOUtils.toString(getClass().getResourceAsStream(filename));
 		final Publication pub = OBJECT_MAPPER.readValue(json, Publication.class);
 
 		String id = IdentifierFactory.createIdentifier(pub, md5);
-
+		System.out.println(id);
 		assertNotNull(id);
 		assertEquals(expectedID, id);
 	}