From 69ca7eaade82fcd460b53afb82bd6152de382003 Mon Sep 17 00:00:00 2001 From: Alessia Bardi Date: Fri, 7 Aug 2020 12:44:36 +0200 Subject: [PATCH] removed redundand lines of code --- .../dnetlib/ariadneplus/graphdb/GraphDBClient.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/dnet-ariadneplus-graphdb-publisher/src/main/java/eu/dnetlib/ariadneplus/graphdb/GraphDBClient.java b/dnet-ariadneplus-graphdb-publisher/src/main/java/eu/dnetlib/ariadneplus/graphdb/GraphDBClient.java index 40312b4..460317e 100644 --- a/dnet-ariadneplus-graphdb-publisher/src/main/java/eu/dnetlib/ariadneplus/graphdb/GraphDBClient.java +++ b/dnet-ariadneplus-graphdb-publisher/src/main/java/eu/dnetlib/ariadneplus/graphdb/GraphDBClient.java @@ -46,7 +46,6 @@ public class GraphDBClient { private static final Log log = LogFactory.getLog(GraphDBClient.class); public static final String PROVENANCE_NS = "http://www.d-net.research-infrastructures.eu/provenance/"; - public static final int NUM_RECORDS_THRESHOLD = 10; @Autowired private RunSPARQLQueryService runSPQRLQuery; @@ -95,7 +94,6 @@ public class GraphDBClient { con.add(IOUtils.toInputStream(getRDFBlock(record), "UTF-8"), recordURI, RDFFormat.RDFXML, graph); con.commit(); // log.debug("statement added"); - con.close(); } catch (RDF4JException e) { log.error("error adding statement ...", e); @@ -260,12 +258,11 @@ public class GraphDBClient { public String updateSparql(final String queryValue) throws AriadnePlusPublisherException{ try { - String result = new String(""); + String result= ""; RemoteRepositoryManager manager = new RemoteRepositoryManager(this.graphDBServerUrl); manager.init(); manager.setUsernameAndPassword(getWriterUser(), getWriterPwd()); Repository repository = manager.getRepository(getRepository()); - ValueFactory factory = repository.getValueFactory(); try (RepositoryConnection con = repository.getConnection()) { con.begin(); @@ -281,7 +278,6 @@ public class GraphDBClient { log.debug("query result: "+result); con.commit(); log.debug("query executed"); - con.close(); } catch (RDF4JException e) { log.error("error executing query ...", e); @@ -297,7 +293,7 @@ public class GraphDBClient { public String feedFromURL(final String dataUrl, final String context) throws AriadnePlusPublisherException{ try { - String result = new String(""); + String result = ""; RemoteRepositoryManager manager = new RemoteRepositoryManager(this.graphDBServerUrl); manager.init(); manager.setUsernameAndPassword(getWriterUser(), getWriterPwd()); @@ -305,13 +301,11 @@ public class GraphDBClient { ValueFactory factory = repository.getValueFactory(); try (RepositoryConnection con = repository.getConnection()) { con.begin(); - String baseUri = null; IRI contextIRI = factory.createIRI(getGraphDBBaseURI(), context); - con.add(new URL(dataUrl), baseUri, RDFFormat.TURTLE, contextIRI); + con.add(new URL(dataUrl), null, RDFFormat.TURTLE, contextIRI); result.concat("data added from url: "+dataUrl+" into graph "+context); con.commit(); log.debug("add data from Url executed"); - con.close(); } catch (RDF4JException e) { log.error("error executing query ...", e);