From 6edcb9862983ddf15c0f8342582a6675b29a3baa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Arranz?= Date: Mon, 16 Jul 2018 09:02:47 +0200 Subject: [PATCH] Improve code coverage --- ckanext/privatedatasets/tests/test_selenium.py | 4 ++-- ckanext/privatedatasets/tests/test_views.py | 11 ++++++++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/ckanext/privatedatasets/tests/test_selenium.py b/ckanext/privatedatasets/tests/test_selenium.py index 79f2acd..44ae530 100644 --- a/ckanext/privatedatasets/tests/test_selenium.py +++ b/ckanext/privatedatasets/tests/test_selenium.py @@ -83,7 +83,7 @@ class TestSelenium(unittest.TestCase): def tearDown(self): self.driver.get(self.base_url) - try: + try: # pragma: no cover # Accept any "Are you sure to leave?" alert self.driver.switch_to.alert.accept() self.driver.switch_to.default_content() @@ -206,7 +206,7 @@ class TestSelenium(unittest.TestCase): try: # The link button is only clicked if it's present driver.find_element_by_link_text('Link').click() - except Exception: + except Exception: # pragma: no cover pass driver.find_element_by_id('field-image-url').clear() diff --git a/ckanext/privatedatasets/tests/test_views.py b/ckanext/privatedatasets/tests/test_views.py index f090f00..1680d0e 100644 --- a/ckanext/privatedatasets/tests/test_views.py +++ b/ckanext/privatedatasets/tests/test_views.py @@ -37,7 +37,7 @@ class ViewsTest(unittest.TestCase): # Configure the mocks setattr(logic, exception, ValueError) - toolkit.get_action().side_effect=getattr(logic, exception) + toolkit.get_action().side_effect = getattr(logic, exception) base.abort.side_effect = TypeError # Call the function @@ -84,3 +84,12 @@ class ViewsTest(unittest.TestCase): # Check that the render method has been called base.render.assert_called_once_with('user/dashboard_acquired.html', {'user_dict': default_user, 'acquired_datasets': acquisitions_list()}) self.assertEqual(returned, base.render()) + + @patch("ckanext.privatedatasets.views.acquired_datasets") + def test_there_is_a_controller_for_ckan_27(self, acquired_datasets): + controller = views.AcquiredDatasetsControllerUI() + + response = controller.acquired_datasets() + + acquired_datasets.assert_called_once_with() + self.assertEqual(response, acquired_datasets())