Initial Adquired DS UI tests

ckanext/privatedatasets/controllers.py

@@ -107,6 +107,7 @@ class AdquiredDatasetsControllerUI(base.BaseController):
             'user': plugins.toolkit.c.user
         }
 
+        # Get user information
         try:
             c.user_dict = plugins.toolkit.get_action('user_show')(context, {'user_obj': c.userobj})
             c.user_dict['adquired_datasets'] = []
@@ -115,6 +116,7 @@ class AdquiredDatasetsControllerUI(base.BaseController):
         except plugins.toolkit.NotAuthorized:
             plugins.toolkit.abort(401, _('Not authorized to see this page'))
 
+        # Get the datasets adquired by the user
         query = model.Session.query(model.PackageExtra).filter(
             # Select only the allowed_users key
             'package_extra.key=\'%s\' AND package_extra.value!=\'\' ' % 'allowed_users' +
@@ -123,9 +125,9 @@ class AdquiredDatasetsControllerUI(base.BaseController):
             # The user name should be contained in the list
             'AND regexp_split_to_array(package_extra.value,\',\') @> ARRAY[\'%s\']' % context['user'])
 
+        # Get full information about the datasets
         for dataset in query:
             try:
-                print dataset.package_id
                 dataset_dict = plugins.toolkit.get_action('package_show')(context, {'id': dataset.package_id})
                 c.user_dict['adquired_datasets'].append(dataset_dict)
             except Exception:

ckanext/privatedatasets/tests/test_controller_api.py

@@ -11,7 +11,7 @@ CLASS_NAME = 'parser_class'
 ADD_USERS_ERROR = 'Default Message'
 
 
-class ControllerTest(unittest.TestCase):
+class APIControllerTest(unittest.TestCase):
 
     def setUp(self):
 

ckanext/privatedatasets/tests/test_controller_ui.py

@@ -0,0 +1,118 @@
+import ckanext.privatedatasets.controllers as controllers
+import unittest
+
+from mock import MagicMock, ANY
+from nose_parameterized import parameterized
+
+
+class UIControllerTest(unittest.TestCase):
+
+    def setUp(self):
+
+        # Get the instance
+        self.instanceUI = controllers.AdquiredDatasetsControllerUI()
+
+        # Load the mocks
+        self._plugins = controllers.plugins
+        controllers.plugins = MagicMock()
+
+        self._model = controllers.model
+        controllers.model = MagicMock()
+
+        # Set exceptions
+        controllers.plugins.toolkit.ObjectNotFound = self._plugins.toolkit.ObjectNotFound
+        controllers.plugins.toolkit.NotAuthorized = self._plugins.toolkit.NotAuthorized
+
+    def tearDown(self):
+        # Unmock
+        controllers.plugins = self._plugins
+        controllers.model = self._model
+
+    @parameterized.expand([
+        (controllers.plugins.toolkit.ObjectNotFound, 404),
+        (controllers.plugins.toolkit.NotAuthorized,  401)
+    ])
+    def test_exceptions_loading_users(self, exception, expected_status):
+
+        # Configure the mock
+        user_show = MagicMock(side_effect=exception)
+        controllers.plugins.toolkit.get_action = MagicMock(return_value=user_show)
+
+        # Call the function
+        self.instanceUI.user_adquired_datasets()
+
+        # Assertations
+        expected_context = {
+            'model': controllers.model,
+            'session': controllers.model.Session,
+            'user': controllers.plugins.toolkit.c.user
+        }
+
+        user_show.assert_called_once_with(expected_context, {'user_obj': controllers.plugins.toolkit.c.userobj})
+        controllers.plugins.toolkit.abort.assert_called_once_with(expected_status, ANY)
+
+    def test_no_errors(self):
+
+        pkgs_ids = [0, 1, 2, 3]
+        user = 'example_user_test'
+        controllers.plugins.toolkit.c.user = user
+
+        # get_action mock
+        user_dict = {'user_name': 'test', 'another_val': 'example value'}
+        package_show = MagicMock(return_value={'pkg_id': '1', 'test': 'ok', 'res': 'ta'})
+        user_show = MagicMock(return_value=user_dict.copy())
+
+        def _get_action(action):
+            if action == 'package_show':
+                return package_show
+            elif action == 'user_show':
+                return user_show
+
+        controllers.plugins.toolkit.get_action = MagicMock(side_effect=_get_action)
+
+        # query mock
+        query_res = []
+        for i in pkgs_ids:
+            pkg = MagicMock()
+            pkg.package_id = i
+            query_res.append(pkg)
+
+        filter_f = MagicMock()
+        filter_f.filter = MagicMock(return_value=query_res)
+        controllers.model.Session.query = MagicMock(return_value=filter_f)
+
+        # Call the function
+        returned = self.instanceUI.user_adquired_datasets()
+
+        # User_show called correctly
+        expected_context = {
+            'model': controllers.model,
+            'session': controllers.model.Session,
+            'user': controllers.plugins.toolkit.c.user
+        }
+
+        user_show.assert_called_once_with(expected_context, {'user_obj': controllers.plugins.toolkit.c.userobj})
+
+        # Query called correctry
+        controllers.model.Session.query.assert_called_once_with(controllers.model.PackageExtra)
+
+        # Filter called correctly
+        filter_f.filter.assert_called_once_with('package_extra.key=\'allowed_users\' AND package_extra.value!=\'\' ' +
+                                                'AND package_extra.state=\'active\' AND ' +
+                                                'regexp_split_to_array(package_extra.value,\',\') @> ARRAY[\'%s\']' % user)
+
+        # Assert that the package_show has been called properly
+        self.assertEquals(len(pkgs_ids), package_show.call_count)
+        for i in pkgs_ids:
+            package_show.assert_any_call(expected_context, {'id': i})
+
+        # Check that the template has the correct datasets
+        expected_user_dict = user_dict.copy()
+        expected_user_dict['adquired_datasets'] = []
+        for i in pkgs_ids:
+            expected_user_dict['adquired_datasets'].append(package_show.return_value)
+        self.assertEquals(expected_user_dict, controllers.plugins.toolkit.c.user_dict)
+
+        # Check that the render method has been called and that its result has been returned
+        self.assertEquals(controllers.plugins.toolkit.render.return_value, returned)
+        controllers.plugins.toolkit.render.assert_called_once_with('user/dashboard_adquired.html')