From 437c4a8646b85918b903b16e664a8f503cc2826f Mon Sep 17 00:00:00 2001 From: Gleb Date: Mon, 13 Mar 2017 15:46:38 +0200 Subject: [PATCH 1/2] #30 / Extension adds ?_ga=... parameters to all external links --- ckanext/googleanalytics/plugin.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ckanext/googleanalytics/plugin.py b/ckanext/googleanalytics/plugin.py index 14f5db9..74fadb4 100644 --- a/ckanext/googleanalytics/plugin.py +++ b/ckanext/googleanalytics/plugin.py @@ -68,9 +68,13 @@ class GoogleAnalyticsPlugin(p.SingletonPlugin): self.googleanalytics_fields = ast.literal_eval(config.get( 'googleanalytics.fields', '{}')) - self.googleanalytics_linked_domains = [x.strip() for x in config.get( - 'googleanalytics.linked_domains', '' - ).split(',')] + googleanalytics_linked_domains = config.get( + 'googleanalytics.linked_domains', None + ) + self.googleanalytics_linked_domains = [ + x.strip() for x in googleanalytics_linked_domains.split(',') + ] if googleanalytics_linked_domains else None + if self.googleanalytics_linked_domains: self.googleanalytics_fields['allowLinker'] = 'true' From 3a589bf40e2c3e6eaf6a502f8652eb5895ed0a8f Mon Sep 17 00:00:00 2001 From: Gleb Date: Mon, 27 Mar 2017 14:57:12 +0300 Subject: [PATCH 2/2] feedback alt --- ckanext/googleanalytics/plugin.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ckanext/googleanalytics/plugin.py b/ckanext/googleanalytics/plugin.py index 74fadb4..c6c83c8 100644 --- a/ckanext/googleanalytics/plugin.py +++ b/ckanext/googleanalytics/plugin.py @@ -69,11 +69,11 @@ class GoogleAnalyticsPlugin(p.SingletonPlugin): 'googleanalytics.fields', '{}')) googleanalytics_linked_domains = config.get( - 'googleanalytics.linked_domains', None + 'googleanalytics.linked_domains', '' ) self.googleanalytics_linked_domains = [ - x.strip() for x in googleanalytics_linked_domains.split(',') - ] if googleanalytics_linked_domains else None + x.strip() for x in googleanalytics_linked_domains.split(',') if x + ] if self.googleanalytics_linked_domains: self.googleanalytics_fields['allowLinker'] = 'true'